stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8248794: Transition JFR Periodic Task Thread to "_thread_in_native" before invoking performance counters

Browse Source 
Reviewed-by: egahlin
This commit is contained in:
Markus Grönlund 2020-07-07 17:52:55 +02:00
parent c7ecaa4a1d
commit ca91da0e0c
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
View File

@ -54,6 +54,7 @@
#include "runtime/arguments.hpp" #include "runtime/arguments.hpp"
#include "runtime/flags/jvmFlag.hpp" #include "runtime/flags/jvmFlag.hpp"
#include "runtime/globals.hpp" #include "runtime/globals.hpp"
#include "runtime/interfaceSupport.inline.hpp"
#include "runtime/os.hpp" #include "runtime/os.hpp"
#include "runtime/os_perf.hpp" #include "runtime/os_perf.hpp"
#include "runtime/thread.inline.hpp" #include "runtime/thread.inline.hpp"
@ -174,7 +175,13 @@ TRACE_REQUEST_FUNC(CPULoad) {
double u = 0; // user time double u = 0; // user time
double s = 0; // kernel time double s = 0; // kernel time
double t = 0; // total time double t = 0; // total time
int ret_val = JfrOSInterface::cpu_loads_process(&u, &s, &t); int ret_val = OS_ERR;
{
// Can take some time on certain platforms, especially under heavy load.
// Transition to native to avoid unnecessary stalls for pending safepoint synchronizations.
ThreadToNativeFromVM transition((JavaThread*)Thread::current());
ret_val = JfrOSInterface::cpu_loads_process(&u, &s, &t);
}
if (ret_val == OS_ERR) { if (ret_val == OS_ERR) {
log_debug(jfr, system)( "Unable to generate requestable event CPULoad"); log_debug(jfr, system)( "Unable to generate requestable event CPULoad");
return; return;
@ -248,7 +255,13 @@ TRACE_REQUEST_FUNC(SystemProcess) {
TRACE_REQUEST_FUNC(ThreadContextSwitchRate) { TRACE_REQUEST_FUNC(ThreadContextSwitchRate) {
double rate = 0.0; double rate = 0.0;
int ret_val = JfrOSInterface::context_switch_rate(&rate); int ret_val = OS_ERR;
{
// Can take some time on certain platforms, especially under heavy load.
// Transition to native to avoid unnecessary stalls for pending safepoint synchronizations.
ThreadToNativeFromVM transition((JavaThread*)Thread::current());
ret_val = JfrOSInterface::context_switch_rate(&rate);
}
if (ret_val == OS_ERR) { if (ret_val == OS_ERR) {
log_debug(jfr, system)( "Unable to generate requestable event ThreadContextSwitchRate"); log_debug(jfr, system)( "Unable to generate requestable event ThreadContextSwitchRate");
return; return;