stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd

Browse Source 
Reviewed-by: coleenp, sspitsyn
This commit is contained in:
Rickard Bäckman 2013-05-15 11:30:54 +02:00
parent 8218671461
commit cd5cf59bae
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hotspot/src/share/vm/prims/jvmtiExport.cpp
View File

@ -1624,15 +1624,19 @@ void JvmtiExport::post_raw_field_modification(JavaThread *thread, Method* method
}
}
assert(sig_type != '[', "array should have sig_type == 'L'");
bool handle_created = false;
// convert oop to JNI handle.
if (sig_type == 'L' || sig_type == '[') {
if (sig_type == 'L') {
handle_created = true;
value->l = (jobject)JNIHandles::make_local(thread, (oop)value->l);
}
post_field_modification(thread, method, location, field_klass, object, field, sig_type, value);
// Destroy the JNI handle allocated above.
if (sig_type == 'L') {
if (handle_created) {
JNIHandles::destroy_local(value->l);
}
}