stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8285712: LogMessageBuffer doesn't check vsnprintf return value

Browse Source 
Reviewed-by: dholmes, iklam
This commit is contained in:
Johan Sjölén 2022-05-02 10:19:54 +00:00 committed by Thomas Stuefe
parent 9795ef5dd3
commit cf81f6cf5b
1 changed files with 7 additions and 1 deletions

8
src/hotspot/share/logging/logMessageBuffer.cpp

@ -110,8 +110,14 @@ void LogMessageBuffer::vwrite(LogLevelType level, const char* fmt, va_list args)
va_list copy;
va_copy(copy, args);
written += (size_t)os::vsnprintf(current_buffer_position, remaining_buffer_length, fmt, copy) + 1;
int ret = os::vsnprintf(current_buffer_position, remaining_buffer_length, fmt, copy);
va_end(copy);
assert(ret >= 0, "Log message buffer issue");
if (ret < 0) {
this->write(level, "%s", "Log message buffer issue");
return;
}
written += (size_t)ret + 1;
if (written > _message_buffer_capacity - _message_buffer_size) {
assert(attempts == 0, "Second attempt should always have a sufficiently large buffer (resized to fit).");
grow(_message_buffer, _message_buffer_capacity, _message_buffer_size + written);