8292975: javac produces code that crashes with LambdaConversionException

8269983: BootstrapMethodError with method reference and intersection type

Reviewed-by: dlsmith, vromero

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

@@ -2309,7 +2309,8 @@ public class LambdaToMethod extends TreeTranslator {
                 List<Type> tl = tree.getDescriptorType(types).getParameterTypes();
                 for (; tl.nonEmpty(); tl = tl.tail) {
                     Type pt = tl.head;
-                    return isIntersectionOrUnionType(pt);
+                    if (isIntersectionOrUnionType(pt))
+                        return true;
                 }
                 return false;
             }

test/langtools/tools/javac/lambda/methodReference/IntersectionParameterTypeTest.java

@@ -0,0 +1,51 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @bug 8292975
+ * @summary Javac produces code that crashes with LambdaConversionException
+ * @run main IntersectionParameterTypeTest
+ */
+
+import java.util.function.BiFunction;
+
+public class IntersectionParameterTypeTest {
+
+    sealed interface Term {
+        record Lit() implements Term {}
+        record Lam(String x, Term a) implements Term {}
+    }
+
+    public static <U, T> void call(BiFunction<U, T, T> op, U x, T t) {
+      op.apply(x, t);
+    }
+
+    public static void main(String[] args) {
+      // this code works
+      call(Term.Lam::new, "x", (Term) new Term.Lit());
+
+      // this does not
+      call(Term.Lam::new, "x", new Term.Lit());
+  }
+}

test/langtools/tools/javac/lambda/methodReference/IntersectionParameterTypeTest2.java

@@ -0,0 +1,54 @@
+/*
+ * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @bug 8269983
+ * @summary BootstrapMethodError with method reference and intersection type
+ * @run main IntersectionParameterTypeTest2
+ */
+
+public class IntersectionParameterTypeTest2 {
+
+    public static void main(String[] args) {
+        f();
+    }
+
+    static <T extends Comparable<T> & G> C<T> f() {
+        return new C<>(Q::g);
+    }
+
+    public interface G {}
+
+    private interface E<T> {
+        void g(Q g, T value);
+    }
+
+    static class C<T extends Comparable<?>> {
+        C(E<T> g) {}
+    }
+
+    static class Q {
+        void g(G g) {}
+    }
+}