stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8284458: CodeHeapState::aggregate() leaks blob_name

Browse Source 
Reviewed-by: lucy, lmesnik
This commit is contained in:
Zhengyu Gu 2022-04-07 20:36:46 +00:00
parent e98c32d6b6
commit d4a4884385
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/hotspot/share/code/codeHeapState.cpp
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2019 SAP SE. All rights reserved. * Copyright (c) 2018, 2019 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
@ -756,18 +756,17 @@ void CodeHeapState::aggregate(outputStream* out, CodeHeap* heap, size_t granular
CodeBlob* cb = (CodeBlob*)heap->find_start(h); CodeBlob* cb = (CodeBlob*)heap->find_start(h);
cbType = get_cbType(cb); // Will check for cb == NULL and other safety things. cbType = get_cbType(cb); // Will check for cb == NULL and other safety things.
if (cbType != noType) { if (cbType != noType) {
const char* blob_name = os::strdup(cb->name()); const char* blob_name = nullptr;
unsigned int nm_size = 0; unsigned int nm_size = 0;
int temperature = 0; int temperature = 0;
nmethod* nm = cb->as_nmethod_or_null(); nmethod* nm = cb->as_nmethod_or_null();
if (nm != NULL) { // no is_readable check required, nm = (nmethod*)cb. if (nm != NULL) { // no is_readable check required, nm = (nmethod*)cb.
ResourceMark rm; ResourceMark rm;
Method* method = nm->method(); Method* method = nm->method();
if (nm->is_in_use()) { if (nm->is_in_use() || nm->is_not_entrant()) {
blob_name = os::strdup(method->name_and_sig_as_C_string());
}
if (nm->is_not_entrant()) {
blob_name = os::strdup(method->name_and_sig_as_C_string()); blob_name = os::strdup(method->name_and_sig_as_C_string());
} else {
blob_name = os::strdup(cb->name());
} }
nm_size = nm->total_size(); nm_size = nm->total_size();
@ -815,6 +814,8 @@ void CodeHeapState::aggregate(outputStream* out, CodeHeap* heap, size_t granular
default: default:
break; break;
} }
} else {
blob_name = os::strdup(cb->name());
} }
//------------------------------------------ //------------------------------------------