stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8303267: Prefer ArrayList to LinkedList in ConcurrentLocksPrinter

Browse Source 
Reviewed-by: cjplummer, sspitsyn
This commit is contained in:
Andrey Turbanov 2023-03-02 18:40:29 +00:00
parent 2c7d2c0ea9
commit d4dcba0463
1 changed files with 5 additions and 10 deletions

15
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ConcurrentLocksPrinter.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -30,7 +30,7 @@ import sun.jvm.hotspot.memory.*;
import sun.jvm.hotspot.oops.*;
public class ConcurrentLocksPrinter {
private Map<JavaThread, List<Oop>> locksMap = new HashMap<>();
private final Map<JavaThread, List<Oop>> locksMap = new HashMap<>();
public ConcurrentLocksPrinter() {
fillLocks();
@ -42,8 +42,7 @@ public class ConcurrentLocksPrinter {
if (locks == null || locks.isEmpty()) {
tty.println(" - None");
} else {
for (Iterator<Oop> itr = locks.iterator(); itr.hasNext();) {
Oop oop = itr.next();
for (Oop oop : locks) {
tty.println(" - <" + oop.getHandle() + ">, (a " +
oop.getKlass().getName().asString() + ")");
}
@ -71,12 +70,8 @@ public class ConcurrentLocksPrinter {
public boolean doObj(Oop oop) {
JavaThread thread = getOwnerThread(oop);
if (thread != null) {
List<Oop> locks = locksMap.get(thread);
if (locks == null) {
locks = new LinkedList<>();
locksMap.put(thread, locks);
}
locks.add(oop);
locksMap.computeIfAbsent(thread, t -> new ArrayList<>())
.add(oop);
}
return false;
}