stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8223391: Unsynchronized iteration of ClassLoaderDataGraph

Browse Source 
Lock in G1 before clear_claimed_marks

Reviewed-by: hseigel, lfoltan, tschatzl
This commit is contained in:
Coleen Phillimore 2019-05-08 06:40:45 -04:00
parent 40fddae1dc
commit dc2c1d3ba8
2 changed files with 2 additions and 0 deletions

1
src/hotspot/share/classfile/classLoaderDataGraph.cpp

@ -48,6 +48,7 @@ volatile size_t ClassLoaderDataGraph::_num_array_classes = 0;
volatile size_t ClassLoaderDataGraph::_num_instance_classes = 0; volatile size_t ClassLoaderDataGraph::_num_instance_classes = 0;
void ClassLoaderDataGraph::clear_claimed_marks() { void ClassLoaderDataGraph::clear_claimed_marks() {
assert_locked_or_safepoint_weak(ClassLoaderDataGraph_lock);
for (ClassLoaderData* cld = _head; cld != NULL; cld = cld->next()) { for (ClassLoaderData* cld = _head; cld != NULL; cld = cld->next()) {
cld->clear_claim(); cld->clear_claim();
} }

1
src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp

@ -268,6 +268,7 @@ void G1ConcurrentMarkThread::run_service() {
{ {
G1ConcPhase p(G1ConcurrentPhase::CLEAR_CLAIMED_MARKS, this); G1ConcPhase p(G1ConcurrentPhase::CLEAR_CLAIMED_MARKS, this);
MutexLocker ml(ClassLoaderDataGraph_lock);
ClassLoaderDataGraph::clear_claimed_marks(); ClassLoaderDataGraph::clear_claimed_marks();
} }