stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8232003: (fs) Files.write can leak file descriptor in the exception case

Browse Source 
Be sure to close the leaked OutputStream in all cases

Reviewed-by: alanb, bpb, clanger
This commit is contained in:
Severin Gehwolf 2019-10-08 15:30:46 +02:00
parent 6fe51396a2
commit dcc9cc3fdd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/java.base/share/classes/java/nio/file/Files.java
View File

@ -3550,8 +3550,8 @@ public final class Files {
// ensure lines is not null before opening file // ensure lines is not null before opening file
Objects.requireNonNull(lines); Objects.requireNonNull(lines);
CharsetEncoder encoder = cs.newEncoder(); CharsetEncoder encoder = cs.newEncoder();
OutputStream out = newOutputStream(path, options); try (OutputStream out = newOutputStream(path, options);
try (BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(out, encoder))) { BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(out, encoder))) {
for (CharSequence line: lines) { for (CharSequence line: lines) {
writer.append(line); writer.append(line);
writer.newLine(); writer.newLine();