diff --git a/src/java.base/share/classes/java/lang/Module.java b/src/java.base/share/classes/java/lang/Module.java index c1452c098b6..e501094ca93 100644 --- a/src/java.base/share/classes/java/lang/Module.java +++ b/src/java.base/share/classes/java/lang/Module.java @@ -1077,9 +1077,9 @@ public final class Module implements AnnotatedElement { *
For named modules, the returned set contains an element for each * package in the module.
* - *For unnamed modules, this method is the equivalent to invoking the - * {@link ClassLoader#getDefinedPackages() getDefinedPackages} method of - * this module's class loader and returning the set of package names.
+ *For unnamed modules, the returned set contains an element for + * each package that {@link ClassLoader#getDefinedPackages() has been defined} + * in the unnamed module.
* * @return the set of the package names of the packages in this module */ @@ -1094,11 +1094,11 @@ public final class Module implements AnnotatedElement { } else { packages = loader.packages(); } - return packages.map(Package::getName).collect(Collectors.toSet()); + return packages.filter(p -> p.module() == this) + .map(Package::getName).collect(Collectors.toSet()); } } - // -- creating Module objects -- /** diff --git a/test/jdk/java/lang/module/Packages/GetPackagesTest.java b/test/jdk/java/lang/module/Packages/GetPackagesTest.java new file mode 100644 index 00000000000..4d156dcec3c --- /dev/null +++ b/test/jdk/java/lang/module/Packages/GetPackagesTest.java @@ -0,0 +1,58 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @library /test/lib + * @build m/* + * @run main/othervm --add-modules m test.GetPackagesTest + * @summary test the packages returned by Module::getPackages for an unnamed + * module does not include the packages for named modules + */ + +package test; + +import java.util.Set; +import static jdk.test.lib.Asserts.*; + +public class GetPackagesTest { + public static void main(String... args) throws Exception { + // module m contains the package "p" + Class> c = Class.forName("p.Main"); + Module m = c.getModule(); + Module test = GetPackagesTest.class.getModule(); + + // module m and unnamed module are defined by the same class loader + assertTrue(m.isNamed()); + assertFalse(test.isNamed()); + assertTrue(m.getClassLoader() == test.getClassLoader()); + + // verify Module::getPackages on an unnamed module only contains + // the packages defined to the unnamed module + assertEquals(m.getPackages(), Set.of("p")); + + Set