stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8286304: Removal of diagnostic flag GCParallelVerificationEnabled

Browse Source 
Reviewed-by: kbarrett, ayang
This commit is contained in:
Thomas Schatzl 2022-05-25 10:29:31 +00:00
parent e1f140d270
commit e32377e456
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hotspot/share/gc/g1/g1HeapVerifier.cpp
View File

@ -485,14 +485,9 @@ void G1HeapVerifier::verify(VerifyOption vo) {
log_debug(gc, verify)("HeapRegions"); log_debug(gc, verify)("HeapRegions");
uint num_workers = GCParallelVerificationEnabled ? _g1h->workers()->active_workers() : 1u;
G1VerifyTask task(_g1h, vo); G1VerifyTask task(_g1h, vo);
_g1h->workers()->run_task(&task, num_workers); _g1h->workers()->run_task(&task);
if (task.failures()) { if (failures || task.failures()) {
failures = true;
}
if (failures) {
log_error(gc, verify)("Heap after failed verification (kind %u):", log_error(gc, verify)("Heap after failed verification (kind %u):",
static_cast<std::underlying_type_t<VerifyOption>>(vo)); static_cast<std::underlying_type_t<VerifyOption>>(vo));
// It helps to have the per-region information in the output to // It helps to have the per-region information in the output to
@ -502,8 +497,9 @@ void G1HeapVerifier::verify(VerifyOption vo) {
ResourceMark rm; ResourceMark rm;
LogStream ls(log.error()); LogStream ls(log.error());
_g1h->print_extended_on(&ls); _g1h->print_extended_on(&ls);
fatal("there should not have been any failures");
} }
guarantee(!failures, "there should not have been any failures");
} }
// Heap region set verification // Heap region set verification

3
src/hotspot/share/gc/shared/gc_globals.hpp
View File

@ -538,9 +538,6 @@
"dictionary, classloader_data_graph, metaspace, jni_handles, " \ "dictionary, classloader_data_graph, metaspace, jni_handles, " \
"codecache_oops, resolved_method_table, stringdedup") \ "codecache_oops, resolved_method_table, stringdedup") \
\ \
product(bool, GCParallelVerificationEnabled, true, DIAGNOSTIC, \
"Enable parallel memory system verification") \
\
product(bool, DeferInitialCardMark, false, DIAGNOSTIC, \ product(bool, DeferInitialCardMark, false, DIAGNOSTIC, \
"When +ReduceInitialCardMarks, explicitly defer any that " \ "When +ReduceInitialCardMarks, explicitly defer any that " \
"may arise from new_pre_store_barrier") \ "may arise from new_pre_store_barrier") \