stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8311076: RedefineClasses doesn't check for ConstantPool overflow

Browse Source 
Reviewed-by: coleenp, lmesnik
This commit is contained in:
Alex Menkov 2024-02-10 00:56:59 +00:00
parent 6303c0e713
commit e33d8a2198
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/prims/jvmtiRedefineClasses.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -1823,6 +1823,12 @@ jvmtiError VM_RedefineClasses::merge_cp_and_rewrite(
return JVMTI_ERROR_INTERNAL;
}
// ensure merged constant pool size does not overflow u2
if (merge_cp_length > 0xFFFF) {
log_warning(redefine, class, constantpool)("Merged constant pool overflow: %d entries", merge_cp_length);
return JVMTI_ERROR_INTERNAL;
}
// Set dynamic constants attribute from the original CP.
if (old_cp->has_dynamic_constant()) {
scratch_cp->set_has_dynamic_constant();