8220614: (bf) Buffer absolute slice methods should use Objects.checkFromIndexSize()

Reviewed-by: alanb, igerasim, rriggs

src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template

@@ -87,8 +87,7 @@ class ByteBufferAs$Type$Buffer$RW$$BO$                  // package-private
 
     @Override
     public $Type$Buffer slice(int index, int length) {
-        Objects.checkIndex(index, limit() + 1);
+        Objects.checkFromIndexSize(index, length, limit());
-        Objects.checkIndex(length, limit() - index + 1);
         return new ByteBufferAs$Type$Buffer$RW$$BO$(bb,
                                                     -1,
                                                     0,

src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template

@@ -220,8 +220,7 @@ class Direct$Type$Buffer$RW$$BO$
 
     @Override
     public $Type$Buffer slice(int index, int length) {
-        Objects.checkIndex(index, limit() + 1);
+        Objects.checkFromIndexSize(index, length, limit());
-        Objects.checkIndex(length, limit() - index + 1);
         return new Direct$Type$Buffer$RW$$BO$(this,
                                               -1,
                                               0,

src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template

@@ -115,8 +115,7 @@ class Heap$Type$Buffer$RW$
 
     @Override
     public $Type$Buffer slice(int index, int length) {
-        Objects.checkIndex(index, limit() + 1);
+        Objects.checkFromIndexSize(index, length, limit());
-        Objects.checkIndex(length, limit() - index + 1);
         return new Heap$Type$Buffer$RW$(hb,
                                         -1,
                                         0,

src/java.base/share/classes/java/nio/StringCharBuffer.java

@@ -54,8 +54,7 @@ class StringCharBuffer                                  // package-private
 
     @Override
     public CharBuffer slice(int index, int length) {
-        Objects.checkIndex(index, limit() + 1);
+        Objects.checkFromIndexSize(index, length, limit());
-        Objects.checkIndex(length, limit() - index + 1);
         return new StringCharBuffer(str,
                                     -1,
                                     0,