stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8239055: Wrong implementation of VMState.hasListener

Browse Source 
Correct the VMState.hasListener implementation to return WeakReference<VMListener> type

Reviewed-by: sspitsyn, poonam
This commit is contained in:
Fairoz Matte 2020-02-27 19:33:07 -08:00
parent 3ca275fb91
commit ea55699f34
1 changed files with 9 additions and 2 deletions

11
src/jdk.jdi/share/classes/com/sun/tools/jdi/VMState.java

@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -174,7 +174,14 @@ class VMState {
}
synchronized boolean hasListener(VMListener listener) {
return listeners.contains(listener);
Iterator<WeakReference<VMListener>> iter = listeners.iterator();
while (iter.hasNext()) {
WeakReference<VMListener> ref = iter.next();
if (listener.equals(ref.get())) {
return true;
}
}
return false;
}
synchronized void removeListener(VMListener listener) {