stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8317919: pthread_attr_init handle return value and destroy pthread_attr_t object

Browse Source 
Reviewed-by: mdoerr, lucy
This commit is contained in:
Matthias Baesken 2023-10-13 07:01:50 +00:00
parent ff0b397e13
commit ec310fe809
4 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hotspot/os/aix/os_aix.cpp
View File

@ -769,7 +769,8 @@ bool os::create_thread(Thread* thread, ThreadType thr_type,
// Init thread attributes.
pthread_attr_t attr;
pthread_attr_init(&attr);
int rslt = pthread_attr_init(&attr);
guarantee(rslt == 0, "pthread_attr_init has to return 0");
guarantee(pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED) == 0, "???");
// Make sure we run in 1:1 kernel-user-thread mode.
@ -803,6 +804,7 @@ bool os::create_thread(Thread* thread, ThreadType thr_type,
stack_size / K);
thread->set_osthread(nullptr);
delete osthread;
pthread_attr_destroy(&attr);
return false;
}

8
src/hotspot/os/linux/os_linux.cpp
View File

@ -911,7 +911,12 @@ bool os::create_thread(Thread* thread, ThreadType thr_type,
// init thread attributes
pthread_attr_t attr;
pthread_attr_init(&attr);
int rslt = pthread_attr_init(&attr);
if (rslt != 0) {
thread->set_osthread(nullptr);
delete osthread;
return false;
}
pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
// Calculate stack size if it's not specified by caller.
@ -960,6 +965,7 @@ bool os::create_thread(Thread* thread, ThreadType thr_type,
stack_size / K);
thread->set_osthread(nullptr);
delete osthread;
pthread_attr_destroy(&attr);
return false;
}

4
src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m
View File

@ -273,8 +273,10 @@ SplashCreateThread(Splash * splash) {
pthread_attr_t attr;
int rc;
pthread_attr_init(&attr);
int rslt = pthread_attr_init(&attr);
if (rslt != 0) return;
rc = pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);
pthread_attr_destroy(&attr);
}
void

4
src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c
View File

@ -773,8 +773,10 @@ SplashCreateThread(Splash * splash) {
pthread_attr_t attr;
int rc;
pthread_attr_init(&attr);
int rslt = pthread_attr_init(&attr);
if (rslt != 0) return;
rc = pthread_create(&thr, &attr, SplashScreenThread, (void *) splash);
pthread_attr_destroy(&attr);
}
void