stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8191306: Math.abs corner case with optimistic typing

Browse Source 
Reviewed-by: jlaskey, hannesw
This commit is contained in:
Athijegannathan Sundararajan 2017-11-15 19:55:21 +05:30
parent 616491477f
commit f441abcff1
3 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/objects/NativeMath.java
View File

@ -105,8 +105,8 @@ public final class NativeMath extends ScriptObject {
* @return abs of argument
*/
@SpecializedFunction
public static int abs(final Object self, final int x) {
return Math.abs(x);
public static double abs(final Object self, final int x) {
return x == Integer.MIN_VALUE? Math.abs((double)x) : Math.abs(x);
}
/**

32
test/nashorn/script/basic/JDK-8191306.js Normal file
View File

@ -0,0 +1,32 @@
/*
* Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8191306 Math.abs corner case with optimistic typing
*
* @test
* @run
*/
print(Math.abs(-2147483648))
print(Math.abs(java.lang.Integer.MIN_VALUE))

2
test/nashorn/script/basic/JDK-8191306.js.EXPECTED Normal file
View File

@ -0,0 +1,2 @@
2147483648
2147483648