stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8153208: TIFFImageReadParam: should "contains()" check be appropriate for addAllowedTagSet() method?

Browse Source 
Do not add a duplicate TIFFTagSet instance and update the spec accordingly.

Reviewed-by: prr
This commit is contained in:
Brian Burkhalter 2016-11-15 08:58:29 -08:00
parent 7395b4d356
commit f5794aaadb
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
jdk/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFImageReadParam.java
View File

@ -50,7 +50,8 @@ import javax.imageio.ImageReadParam;
*/
public final class TIFFImageReadParam extends ImageReadParam {
private List<TIFFTagSet> allowedTagSets = new ArrayList<TIFFTagSet>(4);
private final List<TIFFTagSet> allowedTagSets =
new ArrayList<TIFFTagSet>(4);
/**
* Constructs a {@code TIFFImageReadParam}. Tags defined by
@ -72,7 +73,8 @@ public final class TIFFImageReadParam extends ImageReadParam {
/**
* Adds a {@code TIFFTagSet} object to the list of allowed
* tag sets.
* tag sets. Attempting to add a duplicate object to the list
* has no effect.
*
* @param tagSet a {@code TIFFTagSet}.
*
@ -83,7 +85,9 @@ public final class TIFFImageReadParam extends ImageReadParam {
if (tagSet == null) {
throw new IllegalArgumentException("tagSet == null!");
}
allowedTagSets.add(tagSet);
if (!allowedTagSets.contains(tagSet)) {
allowedTagSets.add(tagSet);
}
}
/**