stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8209856: Obsolete error reporter

Browse Source 
Reviewed-by: coleenp, stuefe
This commit is contained in:
Mikael Vidstedt 2018-08-29 13:04:50 -07:00
parent 296002fe50
commit f5e624c0b3
19 changed files with 7 additions and 132 deletions

22
make/nb_native/nbproject/configurations.xml

@ -2843,8 +2843,6 @@
<in>elfStringTable.hpp</in>
<in>elfSymbolTable.cpp</in>
<in>elfSymbolTable.hpp</in>
<in>errorReporter.cpp</in>
<in>errorReporter.hpp</in>
<in>events.cpp</in>
<in>events.hpp</in>
<in>exceptions.cpp</in>
@ -15166,16 +15164,6 @@
tool="3"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/errorReporter.cpp"
ex="false"
tool="1"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/errorReporter.hpp"
ex="false"
tool="3"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/events.cpp"
ex="false"
tool="1"
@ -28948,16 +28936,6 @@
tool="3"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/errorReporter.cpp"
ex="false"
tool="1"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/errorReporter.hpp"
ex="false"
tool="3"
flavor2="0">
</item>
<item path="../../src/hotspot/share/utilities/events.cpp"
ex="false"
tool="1"

2
src/hotspot/share/runtime/arguments.cpp

@ -572,6 +572,8 @@ static SpecialFlag const special_jvm_flags[] = {
{ "PrintSafepointStatistics", JDK_Version::jdk(11), JDK_Version::jdk(12), JDK_Version::jdk(13) },
{ "PrintSafepointStatisticsTimeout",JDK_Version::jdk(11), JDK_Version::jdk(12), JDK_Version::jdk(13) },
{ "PrintSafepointStatisticsCount", JDK_Version::jdk(11), JDK_Version::jdk(12), JDK_Version::jdk(13) },
{ "TransmitErrorReport", JDK_Version::undefined(), JDK_Version::jdk(12), JDK_Version::jdk(13) },
{ "ErrorReportServer", JDK_Version::undefined(), JDK_Version::jdk(12), JDK_Version::jdk(13) },
#ifdef TEST_VERIFY_SPECIAL_JVM_FLAGS
{ "dep > obs", JDK_Version::jdk(9), JDK_Version::jdk(8), JDK_Version::undefined() },

6
src/hotspot/share/runtime/globals.hpp

@ -2417,12 +2417,6 @@ define_pd_global(uint64_t,MaxRAM, 1ULL*G);
manageable(bool, PrintConcurrentLocks, false, \
"Print java.util.concurrent locks in thread dump") \
\
product(bool, TransmitErrorReport, false, \
"Enable error report transmission on erroneous termination") \
\
product(ccstr, ErrorReportServer, NULL, \
"Override built-in error report server address") \
\
/* Shared spaces */ \
\
product(bool, UseSharedSpaces, true, \

32
src/hotspot/share/utilities/errorReporter.cpp

@ -1,32 +0,0 @@
/*
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
#include "precompiled.hpp"
#include "utilities/errorReporter.hpp"
ErrorReporter::ErrorReporter() {}
void ErrorReporter::call(FILE* fd, char* buffer, int length) {
}

40
src/hotspot/share/utilities/errorReporter.hpp

@ -1,40 +0,0 @@
/*
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
#ifndef SHARE_VM_UTILITIES_ERRORREPORTER_HPP
#define SHARE_VM_UTILITIES_ERRORREPORTER_HPP
#include "utilities/globalDefinitions.hpp"
#include "memory/allocation.hpp"
class ErrorReporter : public StackObj {
public:
ErrorReporter();
~ErrorReporter(){};
void call(FILE* fd, char *buffer, int length);
};
#endif // ndef SHARE_VM_UTILITIES_ERRORREPORTER_HPP

19
src/hotspot/share/utilities/vmError.cpp

@ -47,7 +47,6 @@
#include "utilities/debug.hpp"
#include "utilities/decoder.hpp"
#include "utilities/defaultStream.hpp"
#include "utilities/errorReporter.hpp"
#include "utilities/events.hpp"
#include "utilities/vmError.hpp"
#include "utilities/macros.hpp"
@ -1287,7 +1286,6 @@ void VMError::report_and_die(int id, const char* message, const char* detail_fmt
// then save detailed information in log file (verbose = true).
static bool out_done = false; // done printing to standard out
static bool log_done = false; // done saving error log
static bool transmit_report_done = false; // done error reporting
if (SuppressFatalErrorMessage) {
os::abort(CreateCoredumpOnCrash);
@ -1433,9 +1431,6 @@ void VMError::report_and_die(int id, const char* message, const char* detail_fmt
} else {
out.print_raw_cr("# Can not save log file, dump to screen..");
log.set_fd(defaultStream::output_fd());
/* Error reporting currently needs dumpfile.
* Maybe implement direct streaming in the future.*/
transmit_report_done = true;
}
}
@ -1444,20 +1439,6 @@ void VMError::report_and_die(int id, const char* message, const char* detail_fmt
_current_step = 0;
_current_step_info = "";
// Run error reporting to determine whether or not to report the crash.
if (!transmit_report_done && should_report_bug(_id)) {
transmit_report_done = true;
const int fd2 = ::dup(log.fd());
if (fd2 != -1) {
FILE* const hs_err = ::fdopen(fd2, "r");
if (NULL != hs_err) {
ErrorReporter er;
er.call(hs_err, buffer, O_BUFLEN);
::fclose(hs_err);
}
}
}
if (log.fd() != defaultStream::output_fd()) {
close(log.fd());
}

2
test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java

@ -65,7 +65,7 @@ public abstract class CiReplayBase {
"-XX:MetaspaceSize=4m", "-XX:MaxMetaspaceSize=16m", "-XX:InitialCodeCacheSize=512k",
"-XX:ReservedCodeCacheSize=4m", "-XX:ThreadStackSize=512", "-XX:VMThreadStackSize=512",
"-XX:CompilerThreadStackSize=512", "-XX:ParallelGCThreads=1", "-XX:CICompilerCount=2",
"-Xcomp", "-XX:CICrashAt=1", "-XX:+DumpReplayDataOnError", "-XX:-TransmitErrorReport",
"-Xcomp", "-XX:CICrashAt=1", "-XX:+DumpReplayDataOnError",
"-XX:+PreferInterpreterNativeStubs", "-XX:+PrintCompilation", REPLAY_FILE_OPTION};
private static final String[] REPLAY_OPTIONS = new String[]{DISABLE_COREDUMP_ON_CRASH,
"-XX:+ReplayCompiles", REPLAY_FILE_OPTION};

2
test/hotspot/jtreg/runtime/ErrorHandling/CreateCoredumpOnCrash.java

@ -57,7 +57,7 @@ public class CreateCoredumpOnCrash {
public static OutputAnalyzer runTest(String option) throws Exception {
return new OutputAnalyzer(
ProcessTools.createJavaProcessBuilder(
"-Xmx128m", "-XX:-TransmitErrorReport", "--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED", option, Crasher.class.getName())
"-Xmx128m", "--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED", option, Crasher.class.getName())
.start());
}
}

2
test/hotspot/jtreg/runtime/ErrorHandling/ErrorHandler.java

@ -43,7 +43,7 @@ public class ErrorHandler {
// The -XX:ErrorHandlerTest=N option requires debug bits.
return new OutputAnalyzer(
ProcessTools.createJavaProcessBuilder(
"-XX:-TransmitErrorReport", "-XX:-CreateCoredumpOnCrash", "-XX:ErrorHandlerTest=" + testcase)
"-XX:-CreateCoredumpOnCrash", "-XX:ErrorHandlerTest=" + testcase)
.start());
}

2
test/hotspot/jtreg/runtime/ErrorHandling/ProblematicFrameTest.java

@ -47,7 +47,7 @@ public class ProblematicFrameTest {
public static void main(String[] args) throws Exception {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
"-Xmx64m", "-XX:-TransmitErrorReport", "--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED", "-XX:-CreateCoredumpOnCrash", Crasher.class.getName());
"-Xmx64m", "--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED", "-XX:-CreateCoredumpOnCrash", Crasher.class.getName());
OutputAnalyzer output = new OutputAnalyzer(pb.start());
output.shouldNotContain("Exception in thread");
output.shouldNotMatch("error occurred during error reporting \\(printing problematic frame\\)");

1
test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java

@ -41,7 +41,6 @@ public class TestOnError {
String msg = "Test Succeeded";
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-XX:ErrorHandlerTest=12", // trigger potential SEGV
"-XX:OnError=echo " + msg,

1
test/hotspot/jtreg/runtime/Safepoint/AssertSafepointCheckConsistency1.java

@ -50,7 +50,6 @@ public class AssertSafepointCheckConsistency1 {
"-Xbootclasspath/a:.",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+WhiteBoxAPI",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-Xmx128m",
"AssertSafepointCheckConsistency1",

1
test/hotspot/jtreg/runtime/Safepoint/AssertSafepointCheckConsistency2.java

@ -50,7 +50,6 @@ public class AssertSafepointCheckConsistency2 {
"-Xbootclasspath/a:.",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+WhiteBoxAPI",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-Xmx128m",
"AssertSafepointCheckConsistency2",

1
test/hotspot/jtreg/runtime/Safepoint/AssertSafepointCheckConsistency3.java

@ -50,7 +50,6 @@ public class AssertSafepointCheckConsistency3 {
"-Xbootclasspath/a:.",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+WhiteBoxAPI",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-Xmx32m",
"AssertSafepointCheckConsistency3",

1
test/hotspot/jtreg/runtime/Safepoint/AssertSafepointCheckConsistency4.java

@ -50,7 +50,6 @@ public class AssertSafepointCheckConsistency4 {
"-Xbootclasspath/a:.",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+WhiteBoxAPI",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-Xmx32m",
"AssertSafepointCheckConsistency4",

1
test/hotspot/jtreg/runtime/Unsafe/RangeCheck.java

@ -48,7 +48,6 @@ public class RangeCheck {
true,
"-Xmx128m",
"--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-XX:-InlineUnsafeOps", // The compiler intrinsics doesn't have the assert
DummyClassWithMainRangeCheck.class.getName());

1
test/hotspot/jtreg/runtime/memory/ReserveMemory.java

@ -55,7 +55,6 @@ public class ReserveMemory {
"-Xbootclasspath/a:.",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+WhiteBoxAPI",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"-Xmx128m",
"ReserveMemory",

2
test/hotspot/jtreg/serviceability/sa/TestJmapCore.java

@ -87,7 +87,7 @@ public class TestJmapCore {
static void test(String type) throws Throwable {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(true, "-XX:+CreateCoredumpOnCrash",
"-XX:MaxMetaspaceSize=64m", "-XX:+CrashOnOutOfMemoryError", "-XX:-TransmitErrorReport",
"-XX:MaxMetaspaceSize=64m", "-XX:+CrashOnOutOfMemoryError",
TestJmapCore.class.getName(), type);
boolean useDefaultUlimit = useDefaultUlimit();

1
test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java

@ -69,7 +69,6 @@ public class TestDumpOnCrash {
ProcessTools.createJavaProcessBuilder(true,
"-Xmx64m",
"-Xint",
"-XX:-TransmitErrorReport",
"-XX:-CreateCoredumpOnCrash",
"--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED",
"-XX:StartFlightRecording=dumponexit=true",