stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8255576: (fs) Files.isHidden() throws ArrayIndexOutOfBoundsException (unix)

Browse Source 
Reviewed-by: alanb
This commit is contained in:
Christian Stein 2020-11-01 12:39:43 +00:00 committed by Alan Bateman
parent fe7672bac6
commit f61ce32770
3 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/java.base/unix/classes/sun/nio/fs/UnixFileSystemProvider.java
View File

@ -352,7 +352,14 @@ public abstract class UnixFileSystemProvider
UnixPath name = file.getFileName(); UnixPath name = file.getFileName();
if (name == null) if (name == null)
return false; return false;
return (name.asByteArray()[0] == '.');
byte[] path;
if (name.isEmpty()) { // corner case for empty paths
path = name.getFileSystem().defaultDirectory();
} else {
path = name.asByteArray();
}
return path[0] == '.';
} }
/** /**

2
src/java.base/unix/classes/sun/nio/fs/UnixPath.java
View File

@ -243,7 +243,7 @@ class UnixPath implements Path {
} }
// returns {@code true} if this path is an empty path // returns {@code true} if this path is an empty path
private boolean isEmpty() { boolean isEmpty() {
return path.length == 0; return path.length == 0;
} }

5
test/jdk/java/nio/file/Files/Misc.java
View File

@ -22,7 +22,7 @@
*/ */
/* @test /* @test
* @bug 4313887 6838333 8005566 8032220 8215467 * @bug 4313887 6838333 8005566 8032220 8215467 8255576
* @summary Unit test for miscellenous methods in java.nio.file.Files * @summary Unit test for miscellenous methods in java.nio.file.Files
* @library .. * @library ..
*/ */
@ -87,6 +87,9 @@ public class Misc {
* Tests isHidden * Tests isHidden
*/ */
static void testIsHidden(Path tmpdir) throws IOException { static void testIsHidden(Path tmpdir) throws IOException {
// passing an empty path must not throw any runtime exception
assertTrue(!isHidden(Path.of("")));
assertTrue(!isHidden(tmpdir)); assertTrue(!isHidden(tmpdir));
Path file = tmpdir.resolve(".foo"); Path file = tmpdir.resolve(".foo");