8234841: Enhance buffering of byte buffers

Reviewed-by: alanb, ahgross, rhalade, psandoz
This commit is contained in:
Brian Burkhalter 2019-12-18 07:21:23 -08:00
parent f476138133
commit f711ce40ba
4 changed files with 10 additions and 7 deletions

@ -80,7 +80,6 @@ class ByteBufferAs$Type$Buffer$RW$$BO$ // package-private
public $Type$Buffer slice() { public $Type$Buffer slice() {
int pos = this.position(); int pos = this.position();
int lim = this.limit(); int lim = this.limit();
assert (pos <= lim);
int rem = (pos <= lim ? lim - pos : 0); int rem = (pos <= lim ? lim - pos : 0);
long addr = byteOffset(pos); long addr = byteOffset(pos);
return new ByteBufferAs$Type$Buffer$RW$$BO$(bb, -1, 0, rem, rem, addr, segment); return new ByteBufferAs$Type$Buffer$RW$$BO$(bb, -1, 0, rem, rem, addr, segment);

@ -213,7 +213,6 @@ class Direct$Type$Buffer$RW$$BO$
public $Type$Buffer slice() { public $Type$Buffer slice() {
int pos = this.position(); int pos = this.position();
int lim = this.limit(); int lim = this.limit();
assert (pos <= lim);
int rem = (pos <= lim ? lim - pos : 0); int rem = (pos <= lim ? lim - pos : 0);
int off = (pos << $LG_BYTES_PER_VALUE$); int off = (pos << $LG_BYTES_PER_VALUE$);
assert (off >= 0); assert (off >= 0);

@ -105,13 +105,15 @@ class Heap$Type$Buffer$RW$
} }
public $Type$Buffer slice() { public $Type$Buffer slice() {
int rem = this.remaining(); int pos = this.position();
int lim = this.limit();
int rem = (pos <= lim ? lim - pos : 0);
return new Heap$Type$Buffer$RW$(hb, return new Heap$Type$Buffer$RW$(hb,
-1, -1,
0, 0,
rem, rem,
rem, rem,
this.position() + offset, segment); pos + offset, segment);
} }
@Override @Override

@ -43,12 +43,15 @@ class StringCharBuffer // package-private
} }
public CharBuffer slice() { public CharBuffer slice() {
int pos = this.position();
int lim = this.limit();
int rem = (pos <= lim ? lim - pos : 0);
return new StringCharBuffer(str, return new StringCharBuffer(str,
-1, -1,
0, 0,
this.remaining(), rem,
this.remaining(), rem,
offset + this.position()); offset + pos);
} }
@Override @Override