8226596: Accessibility errors in jdwp-protocol.html

Fix accessability issues in the JDWP spec

Reviewed-by: amenkov, dholmes
This commit is contained in:
Serguei Spitsyn 2019-07-02 14:02:32 -07:00
parent b1dc14ab94
commit f99eec9c0d
5 changed files with 19 additions and 14 deletions

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -30,8 +30,8 @@ import java.io.*;
class AbstractCommandNode extends AbstractNamedNode { class AbstractCommandNode extends AbstractNamedNode {
void document(PrintWriter writer) { void document(PrintWriter writer) {
writer.println("<h5 id=\"" + context.whereC + "\">" + name + writer.println("<h3 id=\"" + context.whereC + "\">" + name +
" Command (" + nameNode.value() + ")</h5>"); " Command (" + nameNode.value() + ")</h3>");
writer.println(comment()); writer.println(comment());
writer.println("<dl>"); writer.println("<dl>");
for (Node node : components) { for (Node node : components) {

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -62,8 +62,8 @@ abstract class AbstractNamedNode extends Node {
} }
void document(PrintWriter writer) { void document(PrintWriter writer) {
writer.println("<h4 id=\"" + name + "\">" + name + writer.println("<h2 id=\"" + name + "\">" + name +
" Command Set</h4>"); " Command Set</h2>");
for (Node node : components) { for (Node node : components) {
node.document(writer); node.document(writer);
} }

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -38,9 +38,9 @@ class CommandSetNode extends AbstractNamedNode {
} }
void document(PrintWriter writer) { void document(PrintWriter writer) {
writer.println("<h4 id=\"" + context.whereC + "\">" + name + writer.println("<h2 id=\"" + context.whereC + "\">" + name +
" Command Set (" + " Command Set (" +
nameNode.value() + ")</h4>"); nameNode.value() + ")</h2>");
writer.println(comment()); writer.println(comment());
for (Node node : components) { for (Node node : components) {
node.document(writer); node.document(writer);

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -54,8 +54,8 @@ class ConstantSetNode extends AbstractNamedNode {
} }
void document(PrintWriter writer) { void document(PrintWriter writer) {
writer.println("<h4 id=\"" + context.whereC + "\">" + name + writer.println("<h2 id=\"" + context.whereC + "\">" + name +
" Constants</h4>"); " Constants</h2>");
writer.println(comment()); writer.println(comment());
writer.println("<table><tr>"); writer.println("<table><tr>");
writer.println("<th style=\"width: 20%\"><th style=\"width: 5%\"><th style=\"width: 65%\">"); writer.println("<th style=\"width: 20%\"><th style=\"width: 5%\"><th style=\"width: 65%\">");

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -52,11 +52,16 @@ class RootNode extends AbstractNamedNode {
writer.println("</style>"); writer.println("</style>");
writer.println("</head>"); writer.println("</head>");
writer.println("<body>"); writer.println("<body>");
writer.println("<ul role=\"navigation\">"); writer.println("<div class=\"centered\" role=\"banner\">");
writer.println("<h1 id=\"Protocol Details\">Java Debug Wire Protocol Details</h1>");
writer.println("</div>");
writer.println("<nav>");
writer.println("<ul>");
for (Node node : components) { for (Node node : components) {
node.documentIndex(writer); node.documentIndex(writer);
} }
writer.println("</ul>"); writer.println("</ul>");
writer.println("</nav>");
writer.println("<div role=\"main\">"); writer.println("<div role=\"main\">");
for (Node node : components) { for (Node node : components) {
node.document(writer); node.document(writer);