stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

7040068: CMS: Possibly unsafe initialization of BlockOffsetArrayUseUnallocatedBlock

Browse Source 
BlockOffsetArrayUseUnallocatedBlock was intended to be turned off as part of BUG 6948538 but a code line in collectorPolicy.cpp actually kept it turned on.

Reviewed-by: jwilhelm, ysr
This commit is contained in:
Bengt Rutisson 2011-04-29 09:11:03 +02:00
parent c01be49675
commit fbffd24fc5
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hotspot/src/share/vm/memory/collectorPolicy.cpp
View File

@ -265,8 +265,6 @@ void TwoGenerationCollectorPolicy::initialize_flags() {
MaxHeapSize = align_size_up(MaxHeapSize, max_alignment()); MaxHeapSize = align_size_up(MaxHeapSize, max_alignment());
always_do_update_barrier = UseConcMarkSweepGC; always_do_update_barrier = UseConcMarkSweepGC;
BlockOffsetArrayUseUnallocatedBlock =
BlockOffsetArrayUseUnallocatedBlock || ParallelGCThreads > 0;
// Check validity of heap flags // Check validity of heap flags
assert(OldSize % min_alignment() == 0, "old space alignment"); assert(OldSize % min_alignment() == 0, "old space alignment");

2
hotspot/src/share/vm/runtime/globals.hpp
View File

@ -1824,7 +1824,7 @@ class CommandLineFlags {
develop(bool, VerifyBlockOffsetArray, false, \ develop(bool, VerifyBlockOffsetArray, false, \
"Do (expensive!) block offset array verification") \ "Do (expensive!) block offset array verification") \
\ \
product(bool, BlockOffsetArrayUseUnallocatedBlock, false, \ diagnostic(bool, BlockOffsetArrayUseUnallocatedBlock, false, \
"Maintain _unallocated_block in BlockOffsetArray" \ "Maintain _unallocated_block in BlockOffsetArray" \
" (currently applicable only to CMS collector)") \ " (currently applicable only to CMS collector)") \
\ \