Tobias Hartmann
9d60300fee
8344199: Incorrect excluded field value set by getEventWriter intrinsic
...
Co-authored-by: Patricio Chilano Mateo <pchilanomate@openjdk.org>
Reviewed-by: syan, mgronlun
2024-11-19 10:01:49 +00:00
Prasanta Sadhukhan
499186be0f
8343902: javax/swing/plaf/nimbus/8041642/bug8041642.java fails in ubuntu22.04
...
Reviewed-by: azvegint
2024-11-19 06:37:49 +00:00
Eirik Bjørsnøs
d85dd77edf
8344365
: SecurityManager cleanups in java.sql and java.sql.rowset modules
...
Reviewed-by: rriggs, bchristi
2024-11-19 05:43:22 +00:00
Ramkumar Sunderbabu
162d66adac
8318668: java/lang/management/MemoryMXBean/CollectionUsageThreshold.java fails with Xcomp
...
Reviewed-by: kevinw, lmesnik
2024-11-18 16:17:30 +00:00
Roger Riggs
9b0ab92b16
8344034: Remove security manager dependency in Serialization
...
Reviewed-by: mullan, alanb
2024-11-18 16:17:07 +00:00
Prasanta Sadhukhan
b6c2122efb
8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14
...
Reviewed-by: tr
2024-11-18 08:11:52 +00:00
Matthias Baesken
543e355bd9
8344298: Test tools/sincechecker/modules/jdk.hotspot.agent/JdkHotspotAgentCheckSince.java fails on platforms without sa
...
Reviewed-by: lucy
2024-11-18 07:42:58 +00:00
SendaoYan
a47d9ba98a
8344349: Problemlist jdk/jfr/jvm/TestVirtualThreadExclusion.java before JDK-8344199 resolved
...
Reviewed-by: lmesnik
2024-11-18 02:35:18 +00:00
Alexey Semenyuk
41a627b789
8343876: Enhancements to jpackage test lib
...
Reviewed-by: almatvee
2024-11-17 23:46:49 +00:00
Prasanta Sadhukhan
aa10ec7c96
8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window
...
Reviewed-by: tr, dnguyen
2024-11-17 08:52:48 +00:00
Nizar Benalla
fec0d1cf5b
8343777: Add since checker tests to Internationalisation modules
...
Reviewed-by: jlu, naoto
2024-11-16 20:27:26 +00:00
Jaikiran Pai
a91d4c022f
8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration
...
Reviewed-by: dfuchs
2024-11-16 11:39:20 +00:00
Alexey Semenyuk
2c509a158f
8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package
...
Reviewed-by: almatvee
2024-11-15 23:55:45 +00:00
Ioi Lam
41a2d49f0a
8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking
...
Reviewed-by: jrose, kvn, heidinga, asmehra, vlivanov
2024-11-15 22:28:54 +00:00
Volkan Yazıcı
59ffac84d3
8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5
...
Reviewed-by: dfuchs
2024-11-15 19:56:48 +00:00
Brian Burkhalter
0b9b82af03
8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
...
Reviewed-by: liach, alanb
2024-11-15 16:11:34 +00:00
Daniel Fuchs
40a055ebd2
8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
...
Reviewed-by: jpai
2024-11-15 15:05:33 +00:00
Adam Sotona
ba39321902
8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry
...
Reviewed-by: liach
2024-11-15 11:40:15 +00:00
Eirik Bjørsnøs
bfee766f03
8344183: (zipfs) SecurityManager cleanup in the ZipFS area
...
Reviewed-by: mullan, lancea
2024-11-15 07:48:15 +00:00
Phil Race
ec148c1365
8344063: Remove doPrivileged calls from swing classes in the java.desktop module
...
Reviewed-by: honkar, kcr
2024-11-14 18:42:31 +00:00
Leonid Mesnik
2cbce1f0f1
8344071: Mark some jdk/jfr/event/oldobject test flagless until they fixed to support all GC
...
Reviewed-by: stefank
2024-11-14 17:59:14 +00:00
Chen Liang
681a57f960
8343064: ClassFormatError: Illegal class name from InnerClassLambdaMetafactory
...
Reviewed-by: jvernee
2024-11-14 17:55:41 +00:00
Artur Barashev
697f27c5d5
8341964: Add mechanism to disable different parts of TLS cipher suite
...
Reviewed-by: mullan, ascarpino
2024-11-14 17:44:13 +00:00
Jorn Vernee
002b985a46
8342963: TestLargeStub::testUpcall doesn't test upcalls stubs
...
Reviewed-by: mcimadamore
2024-11-14 16:55:25 +00:00
Nizar Benalla
e12f514120
8343781: Add since checker test to the Serviceability area modules
...
Reviewed-by: sspitsyn, cjplummer
2024-11-14 16:35:03 +00:00
Brian Burkhalter
7e9dfa4ae4
8343785: (fs) Remove syscalls that set file times with microsecond precision
...
Reviewed-by: alanb
2024-11-14 16:27:22 +00:00
Leonid Mesnik
68164a4847
8343953: Test jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with Parallel/Serial GC
...
Reviewed-by: mli
2024-11-14 16:03:26 +00:00
Jaikiran Pai
752e162955
8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted
...
Reviewed-by: dfuchs, msheppar, syan, alanb
2024-11-14 14:46:19 +00:00
Raffaello Giulietti
8523880f06
8342693: Use byte[] as parameter in a FDBigInteger constructor and as field
...
Reviewed-by: darcy
2024-11-14 10:50:37 +00:00
Dr Heinz M. Kabutz
2b57f402c4
8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream
...
Co-authored-by: Doug Lea <dl@openjdk.org>
Reviewed-by: vklang
2024-11-14 09:17:02 +00:00
Daniel Fuchs
bd6152f596
8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams
...
Reviewed-by: jpai
2024-11-14 08:54:47 +00:00
Jan Lahoda
c3776db498
8342936: Enhance java.io.IO with parameter-less println() and readln()
...
Reviewed-by: asotona, jpai, naoto
2024-11-14 08:22:51 +00:00
Jan Lahoda
1e97c1c913
8335989: Implement JEP 494: Module Import Declarations (Second Preview)
...
Reviewed-by: vromero, abimpoudis, mcimadamore, alanb
2024-11-14 06:14:33 +00:00
Alexey Semenyuk
95a00f8a18
8343875: Minor improvements of jpackage test library
...
Reviewed-by: almatvee
2024-11-14 04:18:26 +00:00
Harshitha Onkar
1eb38c8eb7
8343219: Manual clientlibs test failures after SM removal
...
Reviewed-by: azvegint, aivanov, prr
2024-11-13 19:44:30 +00:00
Alan Bateman
5e01c40b19
8343981: Remove usage of security manager from Thread and related classes
...
Reviewed-by: rriggs, yzheng
2024-11-13 18:49:31 +00:00
Joe Darcy
dbf23466af
8341260: Add Float16 to jdk.incubator.vector
...
Co-authored-by: Raffaello Giulietti <rgiulietti@openjdk.org>
Co-authored-by: Jatin Bhateja <jbhateja@openjdk.org>
Reviewed-by: rgiulietti
2024-11-13 18:27:41 +00:00
Leonid Mesnik
eb240a7df9
8344051: Problemlist jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java with ZGC until JDK-8343893 is fixed
...
Reviewed-by: rkennke, mli, tschatzl
2024-11-13 16:06:44 +00:00
Sean Mullan
db85090553
8338411: Implement JEP 486: Permanently Disable the Security Manager
...
Co-authored-by: Sean Mullan <mullan@openjdk.org>
Co-authored-by: Alan Bateman <alanb@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Co-authored-by: Aleksei Efimov <aefimov@openjdk.org>
Co-authored-by: Brian Burkhalter <bpb@openjdk.org>
Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org>
Co-authored-by: Harshitha Onkar <honkar@openjdk.org>
Co-authored-by: Joe Wang <joehw@openjdk.org>
Co-authored-by: Jorn Vernee <jvernee@openjdk.org>
Co-authored-by: Justin Lu <jlu@openjdk.org>
Co-authored-by: Kevin Walls <kevinw@openjdk.org>
Co-authored-by: Lance Andersen <lancea@openjdk.org>
Co-authored-by: Naoto Sato <naoto@openjdk.org>
Co-authored-by: Roger Riggs <rriggs@openjdk.org>
Co-authored-by: Brent Christian <bchristi@openjdk.org>
Co-authored-by: Stuart Marks <smarks@openjdk.org>
Co-authored-by: Ian Graves <igraves@openjdk.org>
Co-authored-by: Phil Race <prr@openjdk.org>
Co-authored-by: Erik Gahlin <egahlin@openjdk.org>
Co-authored-by: Jaikiran Pai <jpai@openjdk.org>
Reviewed-by: kevinw, aivanov, rriggs, lancea, coffeys, dfuchs, ihse, erikj, cjplummer, coleenp, naoto, mchung, prr, weijun, joehw, azvegint, psadhukhan, bchristi, sundar, attila
2024-11-12 17:16:15 +00:00
Patricio Chilano Mateo
78b80150e0
8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning
...
Co-authored-by: Patricio Chilano Mateo <pchilanomate@openjdk.org>
Co-authored-by: Alan Bateman <alanb@openjdk.org>
Co-authored-by: Andrew Haley <aph@openjdk.org>
Co-authored-by: Fei Yang <fyang@openjdk.org>
Co-authored-by: Coleen Phillimore <coleenp@openjdk.org>
Co-authored-by: Richard Reingruber <rrich@openjdk.org>
Co-authored-by: Martin Doerr <mdoerr@openjdk.org>
Reviewed-by: aboldtch, dholmes, coleenp, fbredberg, dlong, sspitsyn
2024-11-12 15:23:48 +00:00
Sonia Zaldana Calles
8a2a75e56d
8339892: Several security shell tests don't set TESTJAVAOPTS
...
Reviewed-by: valeriep
2024-11-12 13:19:06 +00:00
Kevin Walls
4fa760a1ed
8343936: Adjust timeout in test javax/management/monitor/DerivedGaugeMonitorTest.java
...
Reviewed-by: dfuchs
2024-11-12 09:13:29 +00:00
Viktor Klang
ef0dc2518e
8342707: Prepare Gatherers for graduation from Preview
...
Reviewed-by: alanb, liach
2024-11-11 19:57:26 +00:00
Johan Sjölen
6088d620b4
8343755: Unproblemlist java/lang/Thread/jni/AttachCurrentThread/AttachTest.java
...
Reviewed-by: alanb, syan
2024-11-11 16:10:57 +00:00
Nizar Benalla
80f4c0c38a
8343442: Add since checker tests to the networking area modules
...
Reviewed-by: jpai, dfuchs
2024-11-11 15:21:56 +00:00
Severin Gehwolf
2ec358082f
8311302: Implement JEP 493: Linking Run-Time Images without JMODs
...
Co-authored-by: Mandy Chung <mchung@openjdk.org>
Reviewed-by: mchung, alanb, erikj, ihse
2024-11-11 13:35:25 +00:00
Kevin Walls
5016132291
8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException
...
Reviewed-by: dholmes
2024-11-11 12:26:38 +00:00
Prasanta Sadhukhan
f12c370d73
8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
...
Reviewed-by: abhiscxk, dnguyen
2024-11-11 09:24:44 +00:00
David Holmes
7b0f273e37
8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java
...
Reviewed-by: jpai
2024-11-11 01:40:10 +00:00
Weijun Wang
f400896822
8342442: Static ACVP sample tests
...
Reviewed-by: mullan, bperez
2024-11-09 23:11:33 +00:00
Goetz Lindenmaier
325a2c3f76
8343848: Fix typo of property name in TestOAEPPadding after 8341927
...
Reviewed-by: lucy, mullan
2024-11-09 18:57:21 +00:00
Quan Anh Mai
2614c991d8
8343793: Test java/foreign/TestMemorySession.java is timing out
...
Reviewed-by: mcimadamore
2024-11-09 09:39:23 +00:00
Phil Race
52c0b09b62
8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
...
Reviewed-by: aivanov
2024-11-08 20:37:08 +00:00
Naoto Sato
0329855831
8343804: Show the default time zone with -XshowSettings option
...
Reviewed-by: iris, jpai
2024-11-08 20:22:24 +00:00
Roman Kennke
44ec501a41
8305895: Implement JEP 450: Compact Object Headers (Experimental)
...
Co-authored-by: Sandhya Viswanathan <sviswanathan@openjdk.org>
Co-authored-by: Martin Doerr <mdoerr@openjdk.org>
Co-authored-by: Hamlin Li <mli@openjdk.org>
Co-authored-by: Thomas Stuefe <stuefe@openjdk.org>
Co-authored-by: Amit Kumar <amitkumar@openjdk.org>
Co-authored-by: Stefan Karlsson <stefank@openjdk.org>
Co-authored-by: Coleen Phillimore <coleenp@openjdk.org>
Co-authored-by: Axel Boldt-Christmas <aboldtch@openjdk.org>
Reviewed-by: coleenp, stefank, stuefe, phh, ihse, lmesnik, tschatzl, matsaave, rcastanedalo, vpaprotski, yzheng, egahlin
2024-11-08 17:21:39 +00:00
Kevin Driver
605396280d
8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150
...
Reviewed-by: weijun, hchao, alanb
2024-11-08 16:59:26 +00:00
Daniel Jeliński
72f67fb16a
8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
...
Reviewed-by: dfuchs, jpai
2024-11-08 15:03:17 +00:00
Aleksey Shipilev
0c281acfb4
8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
...
Reviewed-by: egahlin
2024-11-08 10:04:12 +00:00
Nizar Benalla
2e58ede18c
8341399: Add since checker tests to the langtools modules
...
Reviewed-by: vromero
2024-11-08 09:53:16 +00:00
Alexey Semenyuk
a63f501b92
8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests
...
Reviewed-by: rriggs, almatvee
2024-11-07 22:10:59 +00:00
Daniel Gredler
84c99fb91f
8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
...
Reviewed-by: honkar, aivanov, aturbanov
2024-11-07 20:19:50 +00:00
Kevin Driver
2c7bea1cb2
8343772: Expected IAPE not thrown in KDF.getInstance (TCK)
...
Reviewed-by: valeriep
2024-11-07 19:27:35 +00:00
Kevin Walls
4f5a241ec1
8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
...
Reviewed-by: lmesnik, sspitsyn, cjplummer
2024-11-07 18:13:44 +00:00
Brian Burkhalter
56c588b4e8
8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
...
Reviewed-by: alanb
2024-11-07 17:19:27 +00:00
Quan Anh Mai
1d117f65f0
8343394: Make MemorySessionImpl.state a stable field
...
Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Reviewed-by: mcimadamore, jvernee
2024-11-07 14:32:18 +00:00
Alexey Semenyuk
ac82a8f89c
8343610: InOutPathTest jpackage test produces invalid app image on macOS
...
Reviewed-by: almatvee
2024-11-07 12:32:34 +00:00
SendaoYan
f2316f6829
8343505: Problemlist java/lang/Thread/jni/AttachCurrentThread/AttachTest.java
...
Reviewed-by: dholmes, lmesnik
2024-11-07 03:12:32 +00:00
Fernando Guallini
342fe42555
8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree
...
Reviewed-by: rhalade, erikj
2024-11-06 18:36:05 +00:00
Aleksey Shipilev
0be7118b2f
8279016: JFR Leak Profiler is broken with Shenandoah
...
Reviewed-by: egahlin, rkennke, mgronlun, wkemper
2024-11-06 16:38:55 +00:00
Matthias Baesken
06d8216a4e
8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
...
Reviewed-by: mdoerr, lucy, dfuchs
2024-11-06 08:03:26 +00:00
Kevin Driver
2a1ae0ff89
8331008: Implement JEP 478: Key Derivation Function API (Preview)
...
Co-authored-by: Rajan Halade <rhalade@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Co-authored-by: Valerie Peng <valeriep@openjdk.org>
Reviewed-by: weijun, valeriep
2024-11-05 21:07:52 +00:00
Andrew Haley
3fab8e37bb
8341903: Implementation of Scoped Values (Fourth Preview)
...
Reviewed-by: alanb
2024-11-05 17:12:17 +00:00
Alexey Semenyuk
c33a8f52b6
8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
...
Reviewed-by: almatvee
2024-11-05 13:42:27 +00:00
Prasanta Sadhukhan
dafa2e55ad
8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access
...
Reviewed-by: abhiscxk
2024-11-05 06:27:42 +00:00
Artur Barashev
8b4749713c
8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
...
Reviewed-by: wetmore, djelinski, xuelei
2024-11-04 18:46:38 +00:00
Brian Burkhalter
0668e181c8
8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
...
Reviewed-by: alanb, jpai
2024-11-04 18:18:14 +00:00
Naoto Sato
1c4483473d
8333582: Update CLDR to Version 46.0
...
Reviewed-by: joehw, srl, jlu
2024-11-04 17:00:44 +00:00
Per Minborg
646d64e880
8340307: Add explanation around MemorySegment:reinterpret regarding arenas
...
Reviewed-by: jvernee
2024-11-04 14:12:30 +00:00
Chen Liang
1f7d524fd3
8343437: ClassDesc.of incorrectly permitting empty names
...
Reviewed-by: mchung
2024-11-04 13:24:09 +00:00
Alexey Ivanov
7bca0af481
8343128: PassFailJFrame.java test result: Error. Bad action for script: build}
...
Use HTML character entity in javadoc to prevent jtreg from recognising
PassFailJFrame.java as a test file.
Reviewed-by: azvegint, honkar
2024-11-04 11:37:47 +00:00
Adam Sotona
f9e1c62dcd
8343436: Regression in StackMapGenerator after JDK-8339205
...
Reviewed-by: liach
2024-11-04 07:19:23 +00:00
Alexey Semenyuk
29882bfe7b
8340311: JPackage app-image exe launches multiple exe's in JDK 22+
...
Reviewed-by: almatvee
2024-11-02 12:44:17 +00:00
Fernando Guallini
c82ad845e1
8342183: Update tests to use stronger algorithms and keys
...
Reviewed-by: rhalade, ascarpino
2024-11-01 17:52:20 +00:00
Fernando Guallini
7e87c071b0
8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
...
Reviewed-by: mullan
2024-11-01 13:11:56 +00:00
Kevin Walls
4a70c83bd0
8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure
...
Reviewed-by: amenkov
2024-11-01 08:35:28 +00:00
Alexander Matveev
34655c67a8
8342544: [macos] jpackage test helper should check for both "--app-image" and "--mac-sign" for signing predefined app image case
...
Reviewed-by: asemenyuk
2024-10-31 22:18:26 +00:00
Alexey Semenyuk
568b07a09b
8325089: jpackage utility creates an "infinite", undeleteable directory tree
...
Reviewed-by: almatvee
2024-10-31 20:25:55 +00:00
Fernando Guallini
ae82cc1ba1
8342188: Update tests to use stronger key parameters and certificates
...
Reviewed-by: rhalade, ascarpino
2024-10-31 18:28:52 +00:00
Chen Liang
3ccd2f757d
8342458: More consistent constant instruction handling
...
Reviewed-by: asotona
2024-10-31 14:01:13 +00:00
Alan Bateman
dee0982c60
8343132: Remove temporary transitions from Virtual thread implementation
...
Reviewed-by: dholmes, sspitsyn, pchilanomate
2024-10-31 08:53:19 +00:00
Fernando Guallini
f340ab2d36
8342181: Update tests to use stronger Key and Salt size
...
Reviewed-by: rhalade, ascarpino
2024-10-30 22:14:54 +00:00
Harshitha Onkar
02ea4b548e
8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
...
8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir
Reviewed-by: erikj, serb
2024-10-30 21:53:12 +00:00
Matthew Donovan
9a9ac1d005
8341927: Replace hardcoded security providers with new test.provider.name system property
...
Reviewed-by: mullan, ascarpino, rhalade
2024-10-30 18:51:02 +00:00
Axel Boldt-Christmas
821c514a13
8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode
...
Reviewed-by: ihse, eosterlund, stefank, prr, cjplummer, dholmes
2024-10-30 11:05:07 +00:00
Alexey Semenyuk
ceaa71e731
8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
...
Co-authored-by: Alexander Matveev <almatvee@openjdk.org>
Reviewed-by: almatvee
2024-10-30 02:41:45 +00:00
SendaoYan
df3473e220
8343178: Test BasicTest.java javac compile fails cannot find symbol
...
Reviewed-by: jpai, asemenyuk
2024-10-29 06:05:56 +00:00
Alexey Semenyuk
a95374f588
8343101: Rework BasicTest.testTemp test cases
...
Reviewed-by: almatvee
2024-10-28 17:24:01 +00:00
Alexey Semenyuk
00fe9f7bdf
8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
...
Reviewed-by: almatvee
2024-10-28 17:22:38 +00:00
David M. Lloyd
9f6d5b46ce
8343020: (fs) Add support for SecureDirectoryStream on macOS
...
Reviewed-by: bpb, alanb
2024-10-28 16:58:44 +00:00
Brian Burkhalter
1341b81321
8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices
...
Reviewed-by: alanb
2024-10-28 16:38:36 +00:00