Daniel Jeliński
45e5b31a18
8292244: Remove unnecessary include directories
...
Reviewed-by: erikj, prr
2022-08-12 05:23:54 +00:00
Julian Waters
8a804f653d
8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
...
Reviewed-by: erikj, ihse
2022-08-08 12:17:48 +00:00
Alexey Semenyuk
977e09489d
8283707: Support <major.minor.update.build> version format on Windows
...
Reviewed-by: almatvee
2022-07-19 16:59:28 +00:00
Magnus Ihse Bursie
b4ab5fe1da
8288396: Always create reproducible builds
...
Reviewed-by: amenkov, ehelin
2022-06-28 09:00:45 +00:00
Alexey Pavlyutkin
a9d46f3413
8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible
...
Reviewed-by: erikj, ihse
2022-06-08 11:42:30 +00:00
Yasumasa Suenaga
410a25d59a
8286562: GCC 12 reports some compiler warnings
...
Reviewed-by: ihse, kbarrett, prr
2022-05-28 02:09:05 +00:00
Magnus Ihse Bursie
d889319a86
8287254: Clean up Xcode sysroot logic
...
Reviewed-by: erikj
2022-05-25 08:06:23 +00:00
Alexey Ivanov
9b7e42c0f0
8284209: Replace remaining usages of 'a the' in source code
...
Reviewed-by: lancea, wetmore, dfuchs, iris, jjg, ihse
2022-05-24 20:08:11 +00:00
Maurizio Cimadamore
2c5d136260
8282191: Implementation of Foreign Function & Memory API (Preview)
...
Reviewed-by: erikj, jvernee, psandoz, dholmes, mchung
2022-05-12 16:17:45 +00:00
Jaikiran Pai
50d47de835
8286582: Build fails on macos aarch64 when using --with-zlib=bundled
...
Reviewed-by: ihse, lancea
2022-05-12 08:09:54 +00:00
Alexey Semenyuk
e7adc283c6
8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
...
Reviewed-by: erikj
2022-05-05 20:25:32 +00:00
Alexey Semenyuk
b675c597e3
8236128: Allow jpackage create installers for services
...
Reviewed-by: almatvee
2022-04-27 16:32:29 +00:00
Michael McMahon
67755edd6f
8284890: Support for Do not fragment IP socket options
...
Reviewed-by: erikj, ihse, dfuchs
2022-04-26 13:49:58 +00:00
Magnus Ihse Bursie
160eb2bd39
8284891: Fix typos in build system files
...
Reviewed-by: erikj
2022-04-14 19:33:28 +00:00
Magnus Ihse Bursie
3357d9a168
8284588: Remove GensrcCommonLangtools.gmk
...
Reviewed-by: erikj
2022-04-08 20:33:24 +00:00
Magnus Ihse Bursie
2c43ecb43f
8283323: libharfbuzz optimization level results in extreme build times
...
Reviewed-by: erikj, prr
2022-03-24 09:49:33 +00:00
Phil Race
33eb89dfeb
8283457: [macos] libpng build failures with Xcode13.3
...
Reviewed-by: erikj
2022-03-22 21:48:42 +00:00
Magnus Ihse Bursie
f8878cb0cc
8257733: Move module-specific data from make to respective module
...
Reviewed-by: jjg, weijun, naoto, erikj, prr, alanb, mchung
2022-03-21 21:34:09 +00:00
Magnus Ihse Bursie
b6c35ae44a
8209784: Include hsdis in the JDK
...
Reviewed-by: erikj
2022-03-02 18:17:47 +00:00
Joe Darcy
4dbebb62aa
8280534: Enable compile-time doclint reference checking
...
Reviewed-by: serb, naoto, mchung, lancea, iris
2022-01-31 23:22:38 +00:00
Kevin Walls
cb8a82ee24
8272317: jstatd has dependency on Security Manager which needs to be removed
...
Reviewed-by: cjplummer, rriggs
2022-01-28 12:54:19 +00:00
Stuart Marks
04ee9211fc
8278967: rmiregistry fails to start because SecurityManager is disabled
...
Reviewed-by: alanb, erikj
2021-12-22 18:56:30 +00:00
Kevin Walls
734143918d
8279007: jstatd fails to start because SecurityManager is disabled
...
Reviewed-by: alanb, sspitsyn, mullan
2021-12-22 11:36:53 +00:00
Sergey Bylokhov
6e7b7f352e
8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module
...
Reviewed-by: ihse, prr
2021-12-08 21:15:55 +00:00
Jonathan Gibbons
fb11d8faf2
8272945: Use snippets in java.compiler documentation
...
Reviewed-by: erikj, alanb
2021-12-08 19:48:05 +00:00
Joe Darcy
5045eb538b
8278273: Remove unnecessary exclusion of doclint accessibility checks
...
Reviewed-by: iris, alanb, ihse
2021-12-06 16:56:27 +00:00
Joe Darcy
02ee337ae0
8278175: Enable all doclint warnings for build of java.desktop
...
Reviewed-by: erikj, prr
2021-12-04 02:12:35 +00:00
Joe Darcy
780b8b1072
8278179: Enable all doclint warnings for build of java.naming
...
Reviewed-by: iris, erikj
2021-12-03 18:14:33 +00:00
Andrew Leonard
45da3aea22
8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
...
Reviewed-by: ihse
2021-12-03 08:28:37 +00:00
Andrew Leonard
dc2abc9f05
8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
...
Reviewed-by: erikj
2021-12-02 15:36:43 +00:00
Julia Boes
f505396ccc
8277459: Add jwebserver tool
...
Reviewed-by: michaelm, dfuchs, ihse
2021-12-01 10:37:09 +00:00
Alexey Semenyuk
e3911a8532
8277429: Conflicting jpackage static library name
...
Reviewed-by: almatvee, herrick, erikj
2021-11-22 18:04:46 +00:00
Magnus Ihse Bursie
a0227965bb
8275745: Reproducible copyright headers
...
Reviewed-by: ihse, erikj
2021-11-19 13:55:08 +00:00
Jayathirth D V
9a9a157a7d
8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
...
Reviewed-by: ihse, kcr, erikj, prr
2021-11-16 13:18:56 +00:00
Andrew Leonard
14d66bd438
8276654: element-list order is non deterministic
...
Reviewed-by: ihse
2021-11-08 20:37:24 +00:00
Sandhya Viswanathan
9ad4d3d06b
8276025: Hotspot's libsvml.so may conflict with user dependency
...
Reviewed-by: kvn, erikj, psandoz, ihse
2021-11-05 03:30:09 +00:00
Hannes Wallnöfer
8630f55ed7
8275406: Add copy-to-clipboard feature to snippet UI
...
Reviewed-by: erikj, jjg
2021-11-02 12:10:47 +00:00
Julia Boes
9d191fce55
8245095: Implementation of JEP 408: Simple Web Server
...
Co-authored-by: Julia Boes <jboes@openjdk.org>
Co-authored-by: Chris Hegarty <chegar@openjdk.org>
Co-authored-by: Michael McMahon <michaelm@openjdk.org>
Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Ivan Šipka <isipka@openjdk.org>
Reviewed-by: ihse, jlaskey, michaelm, chegar, dfuchs
2021-10-19 10:19:15 +00:00
Aleksey Shipilev
f242cb5ce0
8273797: Stop impersonating "server" VM in all VM variants
...
Reviewed-by: dholmes, erikj, ihse
2021-09-21 06:00:06 +00:00
Aleksey Shipilev
8fbcc8239a
8273494: Zero: Put libjvm.so into "zero" folder, not "server"
...
Reviewed-by: ihse, sgehwolf
2021-09-15 08:56:53 +00:00
Jonathan Gibbons
ae45592d33
8272374: doclint should report missing "body" comments
...
Reviewed-by: kcr, hannesw
2021-08-16 20:48:25 +00:00
Severin Gehwolf
d38b31438d
8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
...
Reviewed-by: prr
2021-08-12 08:52:24 +00:00
Erik Joelsson
e631addd70
8259848: Interim javadoc build does not support platform links
...
Reviewed-by: hannesw, jjg, ihse
2021-07-13 09:27:27 +00:00
Jie Fu
4a6da99f28
8268643: SVML lib shouldn't be generated when C2 is absent
...
Reviewed-by: erikj
2021-06-14 23:39:41 +00:00
Jorn Vernee
8158b82269
8268327: Upstream: 8268169: The system lookup can not find stdio functions such as printf on Windows 10
...
Reviewed-by: erikj, sundar
2021-06-08 14:20:31 +00:00
Liam Miller-Cushon
e546ae27ff
8268296: ScopedMemoryAccess build error with readonly filesystems
...
Reviewed-by: erikj
2021-06-07 17:58:57 +00:00
Maurizio Cimadamore
59a539fef1
8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries
...
Reviewed-by: jvernee, psandoz
2021-06-04 12:53:17 +00:00
Sandhya Viswanathan
9f05c411e6
8265783: Create a separate library for x86 Intel SVML assembly intrinsics
...
Co-authored-by: Sandhya Viswanathan <sviswanathan@openjdk.org>
Co-authored-by: Rahul Kandu <rkandu@openjdk.org>
Co-authored-by: Razvan Lupusoru <rlupusoru@openjdk.org>
Co-authored-by: Magnus Ihse Bursie <ihse@openjdk.org>
Co-authored-by: Jie Fu <jiefu@openjdk.org>
Co-authored-by: Ahmet Akkas <ahmet.akkas@intel.com>
Co-authored-by: Marius Cornea <marius.cornea@intel.com>
Reviewed-by: erikj, kvn, psandoz
2021-06-03 20:03:36 +00:00
Stuart Marks
7c85f3510c
8267123: Remove RMI Activation
...
Reviewed-by: erikj, rriggs, alanb
2021-05-27 15:19:45 +00:00
Phil Race
005d8a7fca
8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
...
Reviewed-by: erikj, serb
2021-05-20 19:49:03 +00:00
Sergey Bylokhov
4086081306
8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142
...
Reviewed-by: erikj, azvegint
2021-05-13 23:41:56 +00:00
Thomas Stuefe
a86ee9b3f3
8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
...
Reviewed-by: mbaesken, rrich
2021-05-06 09:22:32 +00:00
Yasumasa Suenaga
b1725550a2
8266171: -Warray-bounds happens in imageioJPEG.c
...
Reviewed-by: prr
2021-05-05 00:34:26 +00:00
Phil Race
80323b7f66
8261169: Upgrade HarfBuzz to the latest 2.8.0
...
Reviewed-by: serb
2021-05-04 18:23:09 +00:00
Vladimir Kozlov
4785e112ae
8264806: Remove the experimental JIT compiler
...
Reviewed-by: iignatyev, erikj
2021-04-27 06:23:21 +00:00
Vladimir Kozlov
694acedf18
8264805: Remove the experimental Ahead-of-Time Compiler
...
Reviewed-by: coleenp, erikj, stefank, iignatyev, dholmes, aph, shade, iklam, mchung, iveresov
2021-04-27 01:12:18 +00:00
Anton Kozlov
dbc9e4b50c
8253795: Implementation of JEP 391: macOS/AArch64 Port
...
8253816: Support macOS W^X
8253817: Support macOS Aarch64 ABI in Interpreter
8253818: Support macOS Aarch64 ABI for compiled wrappers
8253819: Implement os/cpu for macOS/AArch64
8253839: Update tests and JDK code for macOS/Aarch64
8254941: Implement Serviceability Agent for macOS/AArch64
8255776: Change build system for macOS/AArch64
8262903: [macos_aarch64] Thread::current() called on detached thread
Co-authored-by: Vladimir Kempik <vkempik@openjdk.org>
Co-authored-by: Bernhard Urban-Forster <burban@openjdk.org>
Co-authored-by: Ludovic Henry <luhenry@openjdk.org>
Co-authored-by: Monica Beckwith <mbeckwit@openjdk.org>
Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry
2021-03-25 18:10:18 +00:00
Phil Race
ed1e25d548
8263833: Stop disabling warnings for sunFont.c with gcc
...
Reviewed-by: erikj
2021-03-18 21:52:33 +00:00
Phil Race
05fe06a6ba
8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
...
Reviewed-by: serb, ihse, azvegint
2021-03-16 19:36:04 +00:00
Ajit Ghaisas
8afec70c28
8260931: Implement JEP 382: New macOS Rendering Pipeline
...
Co-authored-by: Jayathirth D V <jdv@openjdk.org>
Co-authored-by: Alexey Ushakov <avu@openjdk.org>
Co-authored-by: Artem Bochkarev <abochkarev@openjdk.org>
Co-authored-by: Prasanta Sadhukhan <psadhukhan@openjdk.org>
Co-authored-by: Denis Konoplev <dkonoplev@openjdk.org>
Co-authored-by: Phil Race <prr@openjdk.org>
Co-authored-by: Kevin Rushforth <kcr@openjdk.org>
Co-authored-by: Magnus Ihse Bursie <ihse@openjdk.org>
Co-authored-by: Ajit Ghaisas <aghaisas@openjdk.org>
Reviewed-by: ihse, avu, kcr, gziemski, prr, kizune, jdv, psadhukhan, serb
2021-03-15 06:41:44 +00:00
Alexey Semenyuk
ad525bcd38
8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702
...
Reviewed-by: erikj
2021-02-08 22:05:02 +00:00
Alexey Semenyuk
fac3c2d258
8254702: jpackage app launcher crashes on CentOS
...
Reviewed-by: almatvee, erikj, herrick
2021-02-05 20:44:34 +00:00
Phil Race
3bb6a3d2ab
8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4
...
Reviewed-by: serb, ihse, erikj
2021-02-04 21:00:18 +00:00
Phil Race
8760688d21
8260616: Removing remaining JNF dependencies in the java.desktop module
...
Reviewed-by: gziemski, ihse, serb
2021-02-04 01:36:19 +00:00
Phil Race
2be60e37e0
8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
...
Reviewed-by: ihse, cjplummer
2021-02-03 21:58:02 +00:00
Weijun Wang
4a8b5c1602
8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
...
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
Reviewed-by: erikj, prr, ihse, valeriep
2021-02-03 16:20:16 +00:00
Erik Joelsson
53f1b93881
8260518: Change default -mmacosx-version-min to 10.12
...
Reviewed-by: tbell, prr, ihse, serb
2021-01-29 14:20:39 +00:00
Magnus Ihse Bursie
8d2f77fd43
8260406: Do not copy pure java source code to gensrc
...
Reviewed-by: alanb, erikj
2021-01-26 14:08:06 +00:00
Jamil Nimeh
8554fe6ebc
8253866: Security Libs Terminology Refresh
...
Reviewed-by: erikj, weijun, mullan
2021-01-14 16:36:51 +00:00
Phil Race
d6a2105b5c
8259343: [macOS] Update JNI error handling in Cocoa code.
...
Reviewed-by: erikj, serb
2021-01-12 20:19:44 +00:00
Magnus Ihse Bursie
1bd015fb0c
8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
...
Reviewed-by: erikj
2021-01-11 11:28:29 +00:00
Jan Lahoda
235488215b
8250768: javac should be adapted to changes in JEP 12
...
Reviewed-by: mcimadamore, erikj, jjg, ihse
2021-01-11 10:10:47 +00:00
Matthias Baesken
3f9f86f0d3
8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
...
Reviewed-by: clanger, mdoerr
2021-01-07 12:39:44 +00:00
Yasumasa Suenaga
67c2211481
8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
...
Reviewed-by: erikj, cjplummer, iklam
2021-01-06 23:59:52 +00:00
David Holmes
149a02f99a
8257572: Deprecate the archaic signal-chaining interfaces: sigset and signal
...
Reviewed-by: ihse, alanb, dcubed, erikj
2020-12-07 21:56:05 +00:00
Magnus Ihse Bursie
d29c78da19
8257679: Improved unix compatibility layer in Windows build (winenv)
...
Reviewed-by: erikj, jvernee, burban
2020-12-07 15:55:53 +00:00
Magnus Ihse Bursie
a3e1980c08
8256541: Sort out what version of awk is used in the build system
...
Reviewed-by: erikj
2020-11-30 16:35:02 +00:00
Magnus Ihse Bursie
8e7a855ee8
8255526: Enable jcheck whitespace checking of build system files
...
Reviewed-by: shade, erikj
2020-11-20 10:01:34 +00:00
Maurizio Cimadamore
3e70aac5cc
8254162: Implementation of Foreign-Memory Access API (Third Incubator)
...
Reviewed-by: erikj, psandoz, alanb
2020-11-12 16:37:23 +00:00
Phil Race
ed7526a66c
8247872: Upgrade HarfBuzz to the latest 2.7.2
...
Reviewed-by: serb
2020-11-08 17:06:12 +00:00
Andy Herrick
26e7ef78fb
8252870: Finalize (remove "incubator" from) jpackage
...
Reviewed-by: kcr, erikj, almatvee, asemenyuk, prr, ihse
2020-11-04 20:27:11 +00:00
Magnus Ihse Bursie
7dcaba6312
8253892: Disable misleading-indentation on clang as well as gcc
...
Reviewed-by: erikj
2020-11-04 16:17:15 +00:00
Magnus Ihse Bursie
364b0fe82e
8255801: Race when building ct.sym build tools
...
Reviewed-by: erikj
2020-11-03 14:51:14 +00:00
Magnus Ihse Bursie
edd19888df
8255530: Additional cleanup after JDK-8235710 (elliptic curve removal)
...
Reviewed-by: erikj
2020-10-28 22:25:21 +00:00
Michael McMahon
6bb7e45e8e
8245194: Unix domain socket channel implementation
...
Reviewed-by: erikj, dfuchs, alanb, chegar
2020-10-28 17:26:26 +00:00
Kiran Sidhartha Ravikumar
9c9349098a
8254177: (tz) Upgrade time-zone data to tzdata2020b
...
Reviewed-by: erikj, naoto, coffeys
2020-10-13 11:38:03 +00:00
Hannes Wallnöfer
1e8e543b26
8216497: javadoc should auto-link to platform classes
...
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: erikj, jjg
2020-10-07 13:08:34 +00:00
Monica Beckwith
9604ee8269
8248238: Implementation: JEP 388: Windows AArch64 Support
...
Co-authored-by: Monica Beckwith <mbeckwit@openjdk.org>
Co-authored-by: Ludovic Henry <luhenry@openjdk.org>
Co-authored-by: Bernhard Urban-Forster <burban@openjdk.org>
Reviewed-by: dholmes, cjplummer, aph, ihse
2020-10-05 03:21:39 +00:00
Phil Race
3d7b524593
8074844: Resolve disabled warnings for libfontmanager
...
Reviewed-by: serb, ihse, erikj
2020-08-29 10:07:22 -07:00
Prasanta Sadhukhan
9573ef8bda
Merge
2020-08-14 15:49:27 +05:30
Phil Race
63b3498733
8251367: [windows] harfbuzz.dll not found causes failure to load sun.font.SunFontManager
...
Reviewed-by: serb
2020-08-10 21:12:47 -07:00
Magnus Ihse Bursie
9edcdf12a0
8251533: MacOS build of libjimage explicitly adds C++ standard library
...
Reviewed-by: erikj
2020-08-13 17:10:48 +02:00
Phil Race
84e397b4de
8250894: Provide a configure option to build and run against the platform libharfbuzz
...
Reviewed-by: erikj
2020-08-04 12:20:37 -07:00
Aleksey Shipilev
5b99c6ae1f
8250605: Linux x86_32 builds fail after JDK-8249821
...
Reviewed-by: erikj, prr
2020-07-28 09:05:36 +02:00
Prasanta Sadhukhan
091b0c95c3
Merge
2020-07-25 12:48:29 +05:30
Phil Race
b1ff2bd00a
8249821: Separate libharfbuzz from libfontmanager
...
Reviewed-by: erikj
2020-07-22 07:46:50 -07:00
Kim Barrett
2a8f92e7e7
8246032: Implementation of JEP 347: Enable C++14 Language Features
...
Update build configuration to use C++14
Reviewed-by: jlaskey, mdoerr, ihse, erikj
2020-07-22 00:13:53 -04:00
Mikael Vidstedt
1982432db4
Merge
2020-07-14 23:29:45 -07:00
Magnus Ihse Bursie
4b85bd546e
8248610: Clean up handling of Windows RC files
...
Reviewed-by: erikj
2020-07-01 22:39:58 +02:00
Erik Gahlin
3576a88369
8246436: JFR: Avoid parsing metadata.xml during startup
...
Reviewed-by: mgronlun, erikj, redestad
2020-06-22 08:09:23 +02:00
Alex Menkov
f3c463b50a
8244703: "platform encoding not initialized" exceptions with debugger, JNI
...
Reviewed-by: alanb, sspitsyn
2020-05-28 11:39:51 -07:00
Mikael Vidstedt
44a0a08991
8245600: Clean up libjli
...
Reviewed-by: dholmes, alanb
2020-05-26 10:18:32 -07:00
Chris Hegarty
f3eb44a94d
8243491: Implementation of Foreign-Memory Access API (Second Incubator)
...
Upstream latest changes of the Foreign-Memory Access API
Co-authored-by: Jorn Vernee <jorn.vernee@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Peter Levart <peter.levart@gmail.com>
Reviewed-by: chegar, psandoz
2020-05-25 10:54:39 +01:00
Mikael Vidstedt
071bd521bc
8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports
...
Reviewed-by: alanb, bchristi, dcubed, dfuchs, eosterlund, erikj, glaubitz, ihse, iignatyev, jjiang, kbarrett, ksrini, kvn, naoto, prr, rriggs, serb, sspitsyn, stefank, tschatzl, valeriep, weijun, weijun
2020-05-20 17:33:37 -07:00
Magnus Ihse Bursie
1cb7df63e7
8245287: Start using ModuleWrapper for gensrc as well
...
Reviewed-by: erikj
2020-05-19 15:59:51 +02:00
Jan Lahoda
ed9cbe252d
8241616: Timestamps on ct.sym entries lead to non-reproducible builds
...
Generate ct.sym in a reproducible way
Reviewed-by: ihse
2020-04-29 18:35:14 +02:00
Erik Joelsson
c992521995
8244951: Missing entitlements for hardened runtime
...
Reviewed-by: ihse
2020-05-14 06:58:59 -07:00
Naoto Sato
80c75c9fa9
8239383: Support for Unicode 13.0
...
Reviewed-by: rriggs, joehw
2020-05-13 15:46:08 -07:00
Magnus Ihse Bursie
0de9bbd4f3
8244044: Refactor phase makefiles to be structured per module
...
Reviewed-by: erikj
2020-04-29 08:55:01 +02:00
Phil Race
3476724641
8238002: Better matrix operations
...
Reviewed-by: serb, erikj, mschoene, rhalade
2020-02-12 12:18:46 -08:00