Commit Graph

1926 Commits

Author SHA1 Message Date
Chris Hegarty
a0dee349e1 8171380: Remove all exports from jdk.jlink
Reviewed-by: alanb, mchung, sundar
2017-01-18 09:35:23 +00:00
Jan Lahoda
53792b463e 8172262: packages missing from docs build
Do not return packages without members from Elements.getPackageElement(String), to avoid ambiguities among such packages in multiple modules.

Reviewed-by: jjg
2017-01-17 07:41:04 +01:00
Srikanth Adayapalam
f1eb002e95 8171993: AssertionError when compiling method reference with generic code and varargs
Reviewed-by: mcimadamore
2017-01-17 09:17:10 +05:30
Jonathan Gibbons
ee0491d210 8172474: javac should enable doclint checking for HTML 5
Reviewed-by: jlahoda
2017-01-13 15:48:12 -08:00
Vicente Romero
5fc51d4ecd 8171528: Crash in Annotate with duplicate package-info declarations
Reviewed-by: jjg
2017-01-12 15:59:28 -08:00
Jan Lahoda
abddf32a62 8172668: NPE in jdk.compiler/com.sun.tools.javac.comp.TypeEnter$ImportsPhase.importNamed(
Guarding against noType returned from ErrorType.getOriginalType.

Reviewed-by: mcimadamore
2017-01-12 15:37:46 +01:00
Vicente Romero
a9a05f2aff 8171325: NPE in Check.clearLocalClassNameIndexes
Reviewed-by: mcimadamore
2017-01-11 10:29:24 -08:00
Jan Lahoda
c2d9172419 8169197: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2017-01-11 10:59:57 +01:00
Vicente Romero
6c4a689750 8171332: NPE in MembersPhase.finishClass
Reviewed-by: mcimadamore
2017-01-10 11:31:59 -08:00
Jan Lahoda
4ec30a933a 8172158: Annotation processor not run with -source <= 8
Avoiding use of module prefix to map annotations to processors when running without modules.

Reviewed-by: darcy, jjg
2017-01-06 14:16:45 +01:00
Jonathan Gibbons
61175156de 8172311: MostSpecific09.java and PotentiallyAmbiguousWarningTest.java failing across platforms
Reviewed-by: vromero
2017-01-05 15:39:57 -08:00
Vicente Romero
cedf0baa46 8026699: test test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.java has an extra @compile attribute that should be removed
Reviewed-by: mcimadamore
2017-01-05 11:20:56 -08:00
Bernard Blaser
37f7ab915c 8148100: Convert lambda most specific positive tests to check runtime behavior
Reviewed-by: mcimadamore
2017-01-05 11:16:39 -08:00
Liam Miller-Cushon
d3f27dfe9c 8065800: javac, fix diagnostic position for statement-bodied lambdas
Reviewed-by: mcimadamore
2017-01-05 10:04:40 -08:00
Jonathan Gibbons
3cfe5aae72 8171977: Add support for latest messages from 'tidy'
Reviewed-by: darcy
2017-01-04 16:08:27 -08:00
Mandy Chung
920965dad2 8172212: jdeps --require and --check should detect the specified module in the image
Reviewed-by: psandoz, lancea
2017-01-03 17:53:34 -08:00
Dan Smith
342a27ab58 8144066: StackOverflowException when computing glb
Reviewed-by: mcimadamore
2017-01-03 16:27:54 -07:00
Maurizio Cimadamore
4ff56b008f 8169091: Method reference T::methodName for generic type T does not compile any more
MethodReferenceLookupHelper should use original site to perform unbound subtype check

Reviewed-by: vromero
2017-01-03 11:33:18 +00:00
Liam Miller-Cushon
a84bef19f0 8171132: Improve class reading of invalid or out-of-range ConstantValue attributes
Reviewed-by: mcimadamore
2016-12-21 15:40:08 -08:00
Jonathan Gibbons
71b65b06e4 8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
Reviewed-by: mcimadamore
2016-12-20 05:50:39 -08:00
Mandy Chung
cc3b86f64c 8171418: Remove jdeps internal --include-system-modules option
Reviewed-by: dfuchs, lancea
2016-12-19 12:30:39 -08:00
Jonathan Gibbons
bf8ce3692c 8171255: Javac generates Deprecated class file attribute for @deprecated javadoc tag on module declaration
Reviewed-by: mcimadamore, anazarov
2016-12-19 11:15:01 -08:00
Vicente Romero
b29a67ae55 8169005: tools/javac/T8132562/ClassPathWithDoubleQuotesTest.java fails after fix to JDK-8132562
Reviewed-by: jjg
2016-12-17 16:57:14 -05:00
Bhavesh Patel
4a4e893915 8160196: Module summary page should display information based on "api" or "detail" mode
Reviewed-by: jjg, ksrini
2016-12-16 09:07:57 -08:00
Andrey Nazarov
bf8e595590 8170549: Improve testing of annotations on modules
Reviewed-by: jjg, jlahoda
2016-12-16 18:40:23 +03:00
Jan Lahoda
5a0691c4e4 8171355: Implement Elements.getOrigin
Adding implementation for javax.lang.model.util.Elements.getOrigin

Reviewed-by: darcy, jjg
2016-12-16 12:08:46 +01:00
Jan Lahoda
e62a384eb3 8133896: Update javax.lang.model APIs
Reviewed-by: darcy, jjg
2016-12-16 12:02:30 +01:00
Alan Bateman
574ac0add6 Merge 2016-12-16 08:17:55 +00:00
Alan Bateman
2381943e61 8170987: Module system implementation refresh (12/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Srikanth Adayapalam <srikanth.adayapalam@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Reviewed-by: mcimadamore
2016-12-16 05:47:58 +00:00
Jonathan Gibbons
e4748a6d4c 8170708: javap -m <module> cannot read a module-info.class
Reviewed-by: jlahoda
2016-12-14 18:30:56 -08:00
Dan Smith
3999672b7a 8075793: Source incompatibility for inference using -source 7
In pre-8 sources, avoid capture variables as inference bounds, consistent with old javac behavior

Reviewed-by: vromero, mcimadamore
2016-12-14 17:56:11 -07:00
Jan Lahoda
d3892cc3b4 8072988: Update javax.annotation.processing for modules
Support for generating files in multi-module mode.

Co-authored-by: Joe Darcy <joe.darcy@oracle.com>
Reviewed-by: darcy, jjg
2016-12-13 10:49:28 +01:00
Jan Lahoda
5f63bc3ff0 8171005: Fix JavaFileManager.getLocationForModule(Location location, JavaFileObject fo, String pkgName) to work with location == CLASS_OUTPUT
JavaFileManager operations that allow module-oriented locations should also allow output locations.

Reviewed-by: jjg
2016-12-13 10:48:18 +01:00
Bernard Blaser
bc1ae385d3 8147527: Wrong code generated for postfix unary operators
Avoiding use of duplicated tree nodes when these may be changed in place.

Reviewed-by: mcimadamore, jlahoda
2016-12-12 13:27:39 +01:00
Jonathan Gibbons
e9ddc68f70 8170251: Add javax.tools.Tool.name()
Reviewed-by: darcy, mchung
2016-12-09 16:24:50 -08:00
Liam Miller-Cushon
7aff5df624 8170667: ClassReader assigns method parameters from MethodParameters incorrectly when long/double parameters are present
MethodParameters attribute does not skip a slot for long/double.

Reviewed-by: vromero, jlahoda
2016-12-09 18:06:48 +01:00
Jonathan Gibbons
7987d2876a 8170953: CheckResourceKeys tests should declare the resource package to be open
Reviewed-by: mchung
2016-12-08 16:52:38 -08:00
Maurizio Cimadamore
04f289629a 8170410: inference: javac doesn't implement 18.2.5 correctly
Javac does not generate constraints of the kind 'throws alpha' as described in the spec

Reviewed-by: vromero, dlsmith
2016-12-05 19:00:56 +00:00
Jonathan Gibbons
ffcb66f113 8162712: StandardJavaFileManager.getModuleLocation() can't find a module
Reviewed-by: jlahoda
2016-12-02 14:15:43 -08:00
Jan Lahoda
88a7279627 8166628: Compiling with annotation processing, access error in specific situation
Ensure member classes inside anonymous classes have a correct owner.

Reviewed-by: mcimadamore
2016-12-02 14:39:00 +01:00
Alan Bateman
01a366e6dd Merge 2016-12-01 11:16:45 +00:00
Alan Bateman
22e233b2e9 8169069: Module system implementation refresh (11/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: mcimadamore, jjg, mchung, anazarov
2016-12-01 09:02:42 +00:00
Kumar Srinivasan
f4c9d73b3e 8164316: Refine the Doclet APIs
Reviewed-by: jjg
2016-11-24 20:48:52 -08:00
Jonathan Gibbons
f39acf60a5 Merge 2016-11-22 16:31:03 -08:00
Jonathan Gibbons
2d7092c7ac 8155765: javax.tools.ToolProvider::getSystemToolClassLoader returns app class loader even if no tool is available
Reviewed-by: mchung
2016-11-22 16:29:24 -08:00
Jonathan Gibbons
6e31f6440f 8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung
2016-11-22 15:57:32 -08:00
Jonathan Gibbons
c7374cd58f 8163190: Clarify JavaFileManager use of \"module location\"
Reviewed-by: jlahoda
2016-11-16 12:12:02 -08:00
Jonathan Gibbons
f742ef0ed0 8169676: boolean result of Option.process is often ignored
Reviewed-by: ksrini, jlahoda
2016-11-16 11:53:24 -08:00
Srikanth Adayapalam
95d99302d8 8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
Reviewed-by: jlahoda
2016-11-14 19:45:41 +05:30
Mandy Chung
4e5211401e 8169606: jdeps --list-reduced-deps should not show java.base as all modules require it
Reviewed-by: dfuchs
2016-11-12 09:26:08 -08:00
Mandy Chung
40e24f2e56 8168386: Fix jdeps verbose options
Reviewed-by: dfuchs, lancea
2016-11-11 17:32:21 -08:00
Jonathan Gibbons
a1f6786ab9 8169447: javac should detect/reject repeated use of --patch-module on command line
Reviewed-by: jlahoda
2016-11-10 13:29:34 -08:00
Jan Lahoda
b40c63e9fb 8166700: NPE during invoking getEnclosedElements() on javax.lang.model.element.Element instance representing a package
Should not strip first parameter of a local class constructor for local classes in initializers.

Reviewed-by: jjg
2016-11-10 17:27:01 +01:00
Maurizio Cimadamore
57bee7c4b9 8169093: Generics, javac not matching actual and formal arguments
Make diagnostic for type-args arity mismatch consistent with the class case

Reviewed-by: vromero
2016-11-07 16:08:18 +00:00
Maurizio Cimadamore
9b0354380e 8168854: javac erroneously reject a a service interface inner class in a provides clause
Java SE 9 proposed spec changes do not explicitly forbid a service interface to be an inner class - javac should follow

Reviewed-by: jjg
2016-11-07 11:16:23 +00:00
Jonathan Gibbons
e781b9f262 8167975: align javac --add-* modules options with launcher
Reviewed-by: jlahoda
2016-11-03 13:59:15 -07:00
Jan Lahoda
0c7e5fac7e 8166635: getEnclosedElements() on package causes BadClassFile error
Properly reading typevars from enclosing scopes for local classes.

Reviewed-by: mcimadamore
2016-11-03 11:46:20 +01:00
Stuart Marks
5ff1a63a1c 8169078: add bug IDs to jdeprscan tests
Reviewed-by: jjg
2016-11-02 14:22:27 -07:00
Jan Lahoda
7cffceb22f 8169074: Build is failing after JDK-8166538
Reverting d7c9720c4223

Reviewed-by: darcy
2016-11-02 20:21:45 +01:00
Jan Lahoda
5daafbe43b 8166538: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2016-11-02 16:48:57 +01:00
Stuart Marks
2380985895 8165646: (jdeprscan) adjust tool output to improve clarity
Reviewed-by: jjg, psandoz
2016-11-01 11:28:16 -07:00
Vicente Romero
32ca4bf4c7 8132562: javac fails with CLASSPATH with double-quotes as an environment variable
Reviewed-by: jjg
2016-11-01 10:14:42 -04:00
Mandy Chung
97cee45deb 8167057: jdeps option to list modules and internal APIs for @modules for test dev
Reviewed-by: dfuchs
2016-10-31 18:06:03 -07:00
Maurizio Cimadamore
12e8fccd6c 8168774: Polymorhic signature method check crashes javac
Check for polysig method assumes arity is greater than zero

Reviewed-by: vromero
2016-10-26 15:41:25 +01:00
Maurizio Cimadamore
47f7c2e668 8168134: Inference: javac incorrectly propagating inner constraint with primitive target
Check for propagation doesn't take into account primitive type constraints

Reviewed-by: vromero
2016-10-26 12:27:51 +01:00
Srikanth Adayapalam
5bc203a934 8166367: Missing ExceptionTable attribute in anonymous class constructors
Reviewed-by: vromero
2016-10-26 11:22:50 +05:30
Maurizio Cimadamore
d072e7faa4 8168480: Speculative attribution of lambda causes NPE in Flow
Flow attempts to analyze too much of a lambda body during attribution

Reviewed-by: vromero
2016-10-24 14:47:48 +01:00
Joe Darcy
5078ccdb18 8168499: Workaround intermittent failures of IntersectionTargetTypeTest.java
Reviewed-by: rfield, amlu, mcimadamore
2016-10-22 12:27:52 -07:00
Jonathan Gibbons
734e231c93 8168343: 3 javac tests fail when run on an exploded image
Reviewed-by: darcy
2016-10-20 16:31:42 -07:00
Jonathan Gibbons
a60ef42892 8145471: javac changes for enhanced deprecation
Reviewed-by: smarks, tbell, mcimadamore, jlahoda
2016-10-20 13:44:51 -07:00
Kumar Srinivasan
7ef07fcf9a 8167383: Javadoc does not handle packages correctly when used with module option
Reviewed-by: bpatel, jjg
2016-10-19 14:51:20 -07:00
Jonathan Gibbons
c2ee320e61 8138725: Add options for Javadoc generation
Reviewed-by: ksrini, bpatel, ahgross
2016-07-12 14:41:14 -07:00
Vicente Romero
d130403704 8026721: Enhance Lambda serialization
Reviewed-by: jjg, briangoetz
2016-03-02 18:25:01 -05:00
Maurizio Cimadamore
80ce1c8be2 8167000: Refine handling of multiple maximally specific abstract methods
Bring the compiler in sync with spec changes in JDK-7034913

Reviewed-by: vromero, dlsmith
2016-10-17 15:02:46 +01:00
Stuart Marks
1f91f70a58 8167965: (jdeprscan) using --release option with 8 or earlier throws exception
Reviewed-by: mchung
2016-10-13 17:31:01 -07:00
Mandy Chung
b79835c56b 8164689: Retrofit jar, jlink, jmod as a ToolProvider
Reviewed-by: alanb, jjg
2016-10-12 15:37:27 -07:00
Jan Lahoda
5794656914 8167320: Trying to document only java.base causes a NPE in javac
Ensure ModuleSymbol.getDirectives completes the Symbol

Reviewed-by: ksrini, jjg
2016-10-11 10:31:10 +02:00
Jonathan Gibbons
6fef223c3f 8159855: Create an SPI for tools
Reviewed-by: mchung
2016-10-07 16:49:39 -07:00
Jan Lahoda
6a0ceb74e8 8153362: Add javac -Xlint warning to list exposed types which are not accessible
Adding implementation to -Xlint:exports, to warn about exposing inaccessible types in API

Reviewed-by: jjg
2016-10-06 14:03:58 +02:00
Mandy Chung
2db14bace5 8166846: jdeps fails to generate module info if there is any class in unnamed package
Reviewed-by: lancea
2016-10-05 18:41:43 -07:00
Mandy Chung
a3f3f797b5 8166860: Add magic number to jmod file
Reviewed-by: alanb, jjg
2016-10-04 18:56:03 -07:00
Stuart Marks
512c42b9ac 8161338: (jdeprscan) remove JEP 293 non-conforming -cp option
8165927: (jdeprscan) com.sun.tools.jdeprscan.Main.instance should be package protected

Reviewed-by: jjg
2016-10-04 18:43:36 -07:00
Jonathan Gibbons
5bce3820cc 8166472: javac/javadoc expands @files incorrectly
Reviewed-by: henryjen, ksrini
2016-10-04 16:47:09 -07:00
Jan Lahoda
279b6faa56 8073844: fatal annotation processing errors do not stop compilation
JavacProcessingEnvironment lets the should-stop policy decide when the compilation should stop.

Reviewed-by: jjg
2016-10-04 17:40:29 +02:00
Jan Lahoda
c58a8aae3e 8152911: javac assertion error when compiling overlay sources
Avoid creating ModuleSymbols with unspecified name, to avoid conflicts with predefined ModuleSymbol for the java.base module.

Reviewed-by: jjg
2016-10-04 16:25:19 +02:00
Mandy Chung
33b751c3d4 8166238: Update jdeps for GNU-style long form options
Reviewed-by: alanb
2016-09-29 21:31:09 -07:00
Srikanth Adayapalam
517cfed246 8166363: Method with reordered type parameter bounds compiles with @Override annotation but does not actually override superclass method
Reviewed-by: vromero
2016-09-28 09:05:20 +05:30
Srikanth Adayapalam
e179ac0384 8164519: Rendering of supertype_target for annotated extends clause
Eliminate inconsistencies in handling annotated super class.

Reviewed-by: jlahoda
2016-09-27 04:34:09 +05:30
Steve Drach
18b1c7cd8b 8153654: Update jdeps to be multi-release jar aware
Reviewed-by: mchung
2016-09-26 13:39:50 -07:00
Jan Lahoda
35439dec91 8047347: com.sun.source.util.Trees breaks the compiler
Clearing synthetic constructors and super constructor calls between annotation processing rounds.

Reviewed-by: jjg
2016-09-23 15:35:32 +02:00
Srikanth Adayapalam
7ddb0f7c17 8163027: AssertionError while compiling a program that uses try with resources
Reviewed-by: vromero
2016-09-21 05:26:26 +05:30
Srikanth Adayapalam
ed537dc705 8156568: Update javac to support compiling against a modular JAR that is a multi-release JAR
Reviewed-by: jjg
2016-09-20 12:12:18 +05:30
Srikanth Adayapalam
4688e355c5 8166108: VerifyError passing anonymous inner class to supertype constructor
Anonymous classes instantitated in explicit constructor calls cannot have enclosing instance

Reviewed-by: vromero
2016-09-20 05:28:54 +05:30
Srikanth Adayapalam
ac462ed848 8164742: ServiceConfigurationError on invoke of getServiceLoader method of StandardJavaFileManager
Reviewed-by: jlahoda
2016-09-19 05:31:53 +05:30
Dan Smith
eb56700eba 8138822: Source version error missing version number
Reviewed-by: jjg
2016-09-16 11:58:23 -06:00
Srikanth Adayapalam
83dbcb5c1b 8160699: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Ensure out of scope locals are not treated as being alive

Reviewed-by: mcimadamore
2016-09-14 20:00:20 +05:30
Srikanth Adayapalam
e4870c84e3 8138667: java.lang.IllegalAccessError: tried to access method (for a protected method)
Reviewed-by: mcimadamore
2016-09-13 19:32:03 +05:30
Vicente Romero
29aa24a3c1 8162546: change hidden options -Xdebug to --debug, -XshouldStop to --should-stop, and -diags to --diags
Reviewed-by: mcimadamore
2016-09-06 17:04:43 -07:00
Vicente Romero
7e27dd569e 8160454: JSR269 jigsaw update: javax.lang.model.element.ModuleElement.getDirectives() causes NPE on unnamed modules
Reviewed-by: jjg
2016-09-02 05:43:54 -07:00
Srikanth Adayapalam
876bb73271 8164073: Javac should unconditionally warn if deprecated javadoc tag is used without @Deprecated annotation
Reviewed-by: mcimadamore
2016-09-02 07:49:15 +05:30