108 Commits

Author SHA1 Message Date
Werner Dietl
e2d2bb9a25 8028699: Compiler crash during speculative attribution of annotated type
Moving the checkForDeclarationAnnotations check into Attr.TypeAnnotationsValidator

Reviewed-by: jjg
2013-12-03 18:50:26 +01:00
Joel Borggrén-Franck
979151dfa9 8028428: strictfp allowed as annotation element modifier
Reviewed-by: jjg
2013-11-26 13:33:33 +01:00
Joel Borggrén-Franck
f3cb828db7 8027375: javac asserts on nested erroneous annotations
Make sure JCAnnotation trees have type != null before annotation processing

Reviewed-by: jjg
2013-11-11 17:26:09 +01:00
Eric McCorkle
e62fb20a59 8023682: Incorrect attributes emitted for anonymous class declaration
Cause javac to emit type annotations on new instruction as well as anonymous class supertype for annotated anonymous classes.

Reviewed-by: jjg, jfranck
2013-10-24 01:27:10 -04:00
Eric McCorkle
fb5a684124 8006732: support correct bytecode storage of type annotations in multicatch
Fix issue with annotations being added before attribution, which causes multicatch not to work right and several tests to fail.

Reviewed-by: jfranck, jjg
2013-10-23 23:20:32 -04:00
Werner Dietl
29582c0ec0 8026791: wrong type_path encoded for method_return on an inner class constructor
Reviewed-by: jjg
2013-10-20 12:46:12 -07:00
Matherey Nunez
c57660ca19 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest
Reviewed-by: jjg, jfranck
2013-10-17 13:50:00 +02:00
Eric McCorkle
b8aff04aa0 8026286: Improper locking of annotation queues causes assertion failures
8026063: Calls to annotate.flush() cause incorrect type annotations to be generated

Fix locking in ClassReader.java

Reviewed-by: jfranck
2013-10-16 16:33:04 -04:00
Werner Dietl
e5c34a89eb 8026564: import changes from type-annotations forest
Co-authored-by: Steve Sides <steve.sides@oracle.com>
Reviewed-by: jjg
2013-10-15 15:57:13 -07:00
Jan Lahoda
da21af58f4 8014016: javac is too late detecting invalid annotation usage
Adding new queue to Annotate for validation tasks, performing annotation validation during enter

Reviewed-by: jjg, emc, jfranck
2013-10-14 22:11:09 +02:00
Eric McCorkle
a78344ba67 8008762: Type annotation on inner class in anonymous class show up as regular type annotations
8015257: type annotation with TYPE_USE and FIELD attributed differently if repeated
8013409: test failures for type annotations

Fixes to address some problems in type annotations

Reviewed-by: jfranck, jjg
2013-10-10 20:12:08 -04:00
Jan Lahoda
6c9b134b12 8022765: Compiler crashes with exception on wrong usage of an annotation
Error recovery for incorrect annotation attribute values - ensure the values are always attributed appropriately

Reviewed-by: jfranck, jjg
2013-09-27 17:28:31 +02:00
Eric McCorkle
5b76a0d216 8022322: Reject default and static methods in annotation
Causes javac to reject static and default method declarations inside an annotation

Reviewed-by: jjg
2013-09-09 16:26:55 -04:00
Werner Dietl
d99f710f70 8023768: Use the unannotatedType in cyclicity checks
Reviewed-by: jjg
2013-08-26 15:55:46 -07:00
Werner Dietl
1dc32a077e 8023515: import type-annotations updates
Reviewed-by: jjg
2013-08-21 16:13:50 -07:00
Eric McCorkle
be2ea6f949 8016880: 42 tests in annot102* fail with compile-time errors
Fixes error in type equality when bounds of type variables have annotations.

Reviewed-by: jjg, mcimadamore
2013-07-23 20:42:54 -04:00
Lana Steuck
ba0fc64a03 Merge 2013-06-03 16:10:18 -07:00
David Katleman
b08f6026b4 8015525: JDK8 b91 source with GPL header errors
Reviewed-by: dholmes, lancea
2013-05-29 10:16:32 -07:00
Joel Borggrén-Franck
4a4457b237 8013180: Qualified type reference with annotations in throws list crashes compiler
Reviewed-by: jjg
2013-05-21 12:00:29 +02:00
Werner Dietl
54582cab82 8013852: update reference impl for type-annotations
Co-authored-by: Steve Sides <steve.sides@oracle.com>
Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Reviewed-by: jjg
2013-05-14 15:04:06 -07:00
Joel Borggrén-Franck
d5eeeb875b 8013485: javac can't handle annotations with a <clinit> from a previous compilation unit
Reviewed-by: mcimadamore
2013-05-08 14:10:53 +02:00
Jonathan Gibbons
155bd74411 8012728: Normalize @ignore comments on langtools tests
Reviewed-by: vromero, mcimadamore
2013-05-03 09:56:56 -07:00
Maurizio Cimadamore
3044b19d21 8010659: Javac Crashes while building OpenJFX
Reviewed-by: jjg
2013-04-13 12:25:44 +01:00
Matherey Nunez
cd78ad2c8a 8007767: TargetAnnoCombo.java need to be updated to add a new test mode
Reviewed-by: jjg, strarup
2013-03-15 13:39:04 +01:00
Joel Borggrén-Franck
09e3f06ae6 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
Reviewed-by: jjg
2013-03-13 22:03:09 +01:00
Joel Borggrén-Franck
4de6d2c42c 7196531: Duplicate error messages on repeating annotations
Reviewed-by: jjg
2013-03-12 17:39:34 +01:00
Joel Borggrén-Franck
c3e43ab7d5 8005205: tests missing bugid for repeating annotation change
Reviewed-by: jjg, ssides
2013-03-12 11:16:30 +01:00
Jonathan Gibbons
971f247b1b 8008339: Test TargetAnnoCombo.java is broken
Reviewed-by: jjh
2013-02-18 14:29:40 -08:00
Sonali Goel
2fb38081d5 8001457: New tests needed for library-side changes for repeating annotations
Reviewed-by: darcy
2013-02-13 23:05:17 -08:00
Werner Dietl
464abcb4fa 8008077: update reference impl for type-annotations
Reviewed-by: jjg
2013-02-12 17:15:29 -08:00
Sonali Goel
f1442d8261 7195131: Update 2 compiler combo tests for repeating annotations to include package and default use cases
Reviewed-by: darcy
2013-02-07 20:47:06 -08:00
Joe Darcy
71b457cb97 8007351: Malformed copyright statements in typeAnnotations test directory
Reviewed-by: jjg
2013-01-31 18:58:17 -08:00
Joe Darcy
4484857b50 8007313: Remove use of {ContainerFor/ContainedBy} from langtools
Reviewed-by: jjg
2013-01-31 12:16:03 -08:00
Michael Ernst
659a96edf9 8006775: JSR 308: Compiler changes in JDK8
Co-authored-by: Werner Dietl <wmdietl@cs.washington.edu>
Co-authored-by: Matt Papi <mpapi@csail.mit.edu>
Co-authored-by: Mahmood Ali <mahmood@notnoop.com>
Reviewed-by: jjg
2013-01-23 13:27:24 -08:00
Jonathan Gibbons
a2f594bf74 8006119: update javac to follow latest spec for repeatable annotations
Reviewed-by: darcy
2013-01-14 13:50:01 -08:00
Joel Borggrén-Franck
e4c3d2d727 8001114: Container annotation is not checked for semantic correctness
Reviewed-by: jjg
2012-12-03 11:16:32 +01:00
Sonali Goel
eb055bba92 8002157: Write combo compiler tests for repeating annotations for JDK8
Reviewed-by: darcy, jjg
2012-11-07 17:01:19 -08:00
Sonali Goel
3b9822eab7 7169362: JDK8: Write compiler tests for repeating annotations for JDK8
Reviewed-by: darcy, jjg
2012-11-02 14:35:57 -07:00
Jonathan Gibbons
7c509b7652 8001714: add missing tests for 7199925
Reviewed-by: darcy
2012-10-26 17:17:33 -07:00
Joel Borggrén-Franck
9c23b8bad0 7151010: Add compiler support for repeating annotations
Reviewed-by: jjg, mcimadamore
2012-08-31 10:37:46 +01:00
Jonathan Gibbons
a0084596d4 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment
Reviewed-by: darcy
2011-09-09 17:19:26 -07:00
Maurizio Cimadamore
ea2c9e0af0 6550655: com.sun.tools.javac.code.Symbol$CompletionFailure
Accessing a non-existing enum constant from an annotation whose class is available results in an internal error

Reviewed-by: jjg
2011-04-29 16:06:28 +01:00
Jonathan Gibbons
13d31713dc 6993311: annotations on packages are not validated
Reviewed-by: mcimadamore
2011-03-15 11:04:56 -07:00
Kelly O'Hair
84b5875f26 6962318: Update copyright year
Reviewed-by: xdono
2010-12-28 15:54:52 -08:00
Jonathan Gibbons
8e9c506c6c 6999210: javac should be able to warn of anomalous conditions in classfiles
Reviewed-by: mcimadamore, darcy
2010-12-07 14:13:25 -08:00
Jonathan Gibbons
be8a607fef 6900037: javac should warn if earlier -source is used and bootclasspath not set
Reviewed-by: darcy
2010-11-29 14:15:36 -08:00
Jonathan Gibbons
bf00a77f2d 6987760: remove 308 support from JDK7
Reviewed-by: darcy, mcimadamore
2010-10-19 15:02:48 -07:00
Maurizio Cimadamore
91bd86216a 6976649: javac does not enforce required annotation elements in arrays
Type annotation should take advantage of recursive annotation checking

Reviewed-by: jjg
2010-08-16 14:56:23 +01:00
Maurizio Cimadamore
23a89dba04 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
Missing symbols are collected in an HashSet which doesn't preserve ordering

Reviewed-by: jjg
2010-08-10 14:53:19 +01:00
Maurizio Cimadamore
156e82c164 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
Default annotation value is not attributed

Reviewed-by: jjg, darcy
2010-08-05 09:44:54 +01:00