Commit Graph

1820 Commits

Author SHA1 Message Date
Iris Clark
2673fcaf07 Merge 2015-11-29 20:29:56 -08:00
Srikanth Adayapalam
3b399ff099 8078660: Misleading recommendation from diamond finder
Javac should recommend diamond usage if that could lead to a change in program behavior.

Reviewed-by: mcimadamore
2015-11-26 17:38:15 +05:30
Andreas Lundblad
ea92f6bf06 8144009: ToolBox should have a cleanDirectory method
Added cleanDirectory method to ToolBox.

Reviewed-by: jjg
2015-11-26 09:33:41 +01:00
Srikanth Adayapalam
68126c8ee9 8143647: Javac compiles method reference that allows results in an IllegalAccessError
Lambda implementation method synthesized by javac should not mention inaccessible types.

Reviewed-by: mcimadamore
2015-11-26 07:44:23 +05:30
Bhavesh Patel
8bfe3bba2c 8141492: Implement search feature in javadoc
Reviewed-by: jjg, ksrini
2015-11-20 20:55:07 +00:00
Iris Clark
3c9012f9a2 Merge 2015-11-19 14:01:27 -08:00
Sergei Pikalev
b70aa4aee0 8130880: Create sampleapi regression test
Reviewed-by: ksrini, vromero
2015-11-19 13:14:16 -08:00
Jan Lahoda
16f32db97e 8143334: @ignore langtools/test/jdk/jshell/ToolBasicTest.java
Reviewed-by: ksrini
2015-11-19 19:03:03 +01:00
Maurizio Cimadamore
875bccb11e 8067767: type inference performance regression
Overhaul implememntation of inference incorporation

Reviewed-by: vromero
2015-11-19 16:43:11 +00:00
Srikanth Adayapalam
54029caa26 8143217: javac throws NPE when printing diagnostics for Lambda expressions
Fix compiler crash when -XDdumpLambdaToMethodStats option is in effect.

Reviewed-by: mcimadamore
2015-11-19 17:19:06 +05:30
Srikanth Adayapalam
6ce337adaf 8142931: java compiler: type erasure doesn't work since 9-b28
Reinstate pre JDK-8055054 behavior with respect to erasing wildcard types.

Reviewed-by: mcimadamore
2015-11-18 16:37:12 +05:30
Iris Clark
26c71ec728 Merge 2015-11-16 17:10:23 -08:00
Alejandro Murillo
c48d4c4c7d Merge 2015-11-16 10:47:28 -08:00
Maurizio Cimadamore
3acf9da9d1 8142948: langtools/test/tools/javac/lambda/speculative/T8046685.java fails on some platforms
Test uses too much stack on 32-bit platforms

Reviewed-by: jlahoda
2015-11-13 18:45:38 +00:00
Alejandro Murillo
ca65b05bd1 Merge 2015-11-13 10:35:28 -08:00
Srikanth Adayapalam
b79126e437 8073616: Duplicate error message: cannot inherit from final (class) F
Ensure that the compiler does not emit duplicate errors at slightly different source positions.

Reviewed-by: mcimadamore
2015-11-13 18:09:36 +05:30
Maurizio Cimadamore
90a76d40e5 8046685: Uncompilable large expressions involving generics
Improve inference propagation logic so that unnecessary inference variables are not propagated.

Reviewed-by: vromero
2015-11-13 12:29:23 +00:00
Jan Lahoda
31df921493 8141092: JShell: Completion hangs on identifier completion
Avoiding recursive search when computing package completion.

Reviewed-by: mcimadamore, rfield
2015-11-12 15:10:01 +01:00
Shinya Yoshida
fadea54488 8142384: JShell tool: New command: /imports, /i which show the list of imported packages or classes, etc..
Reviewed-by: rfield, jlahoda
2015-11-12 08:48:42 +01:00
Srinivas Dama
9bf5e9c8f4 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
Improve clarity of javac messages by discriminating hiding scenerio from overriding

Reviewed-by: mcimadamore, sadayapalam
2015-11-12 08:39:23 +05:30
Srikanth Adayapalam
431aa657a6 8136419: Type annotations in initializers and lambda bodies not written to class file
Reviewed-by: jlahoda
2015-11-12 06:13:14 +05:30
Srikanth Adayapalam
f7bc90496a 8142476: Call site initialization exception caused by LambdaConversionException: Invalid receiver type
Incorrect handling of intersection typed receiver in method references results in call site initialization exception

Reviewed-by: mcimadamore
2015-11-12 05:59:47 +05:30
Joseph Provino
76f328a4ca Merge 2015-11-11 23:47:42 +00:00
Srikanth Adayapalam
7ea18e2abd 8141508: java.lang.invoke.LambdaConversionException: Invalid receiver type
Incorrect handling of intersection type parameter of functional interface descriptor results in call site initialization exception

Reviewed-by: mcimadamore
2015-11-11 18:46:03 +05:30
Maurizio Cimadamore
e0f654819b 8141613: Compiler fails to infer generic type
Repeated capture of same expression leads to erroneous inference constraints

Reviewed-by: vromero
2015-11-10 11:49:14 +00:00
Iris Clark
f0eef2073e Merge 2015-11-09 10:57:05 -08:00
Srikanth Adayapalam
4d94dba613 8129740: Incorrect class file created when passing lambda in inner class constructor
Lambda implementation method must be static when lambda is an argument to an explicit constructor call.

Reviewed-by: mcimadamore, jlahoda
2015-11-09 05:45:22 +05:30
Srikanth Adayapalam
48e3b3f0df 8138612: Do not retain declaration annotations on lambda formal parameters
Reviewed-by: jlahoda
2015-11-06 14:45:44 +05:30
Chris Plummer
206be75e45 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12
Updated requiredVersion to 4.1 b12

Reviewed-by: dholmes, sla, darcy
2015-11-05 10:30:22 -08:00
Maurizio Cimadamore
a65f240258 8141343: Subtle semantics changes for union types in cast conversion
Cast applied to union types do not behave correctly and sometimes pass erroneously

Reviewed-by: jlahoda
2015-11-05 11:32:01 +00:00
Andreas Lundblad
d2d6dd48d4 8139961: Various sjavac tests result in error on Windows (JPRT)
Test now closes Stream properly.

Reviewed-by: jlahoda
2015-11-04 12:27:00 +01:00
Andreas Lundblad
922ac5ff90 8141355: PackagePathMismatch.java does not use --state-dir option
Added --state-dir to the PackagePathMismatch.java test.

Reviewed-by: jlahoda
2015-11-03 22:55:30 +01:00
Andreas Lundblad
7cf539d35e 8137075: Sjavac tests are leaking file managers
Closing sjavac file managers.

Reviewed-by: jjg
2015-11-03 21:29:46 +01:00
Iris Clark
616e4c704e Merge 2015-11-01 09:49:09 -08:00
Kumar Srinivasan
2711685247 8132096: Augment the Compiler Tree API to support the new Simplified Doclet API
Reviewed-by: jjg, jlahoda
2015-10-28 10:41:30 -07:00
Andreas Eriksson
27b171c977 8134759: jdb: Incorrect stepping inside finally block
Add LineNumberTable attribute for return bytecodes split around finally code

Reviewed-by: mcimadamore
2015-10-27 10:35:14 +01:00
Iris Clark
641e7a407a Merge 2015-10-25 19:16:46 -07:00
Srikanth Adayapalam
2d8d2e83ba 8057685: javac should not crash compiling type annotations
Reviewed-by: jlahoda
2015-10-23 08:21:41 +05:30
Srikanth Adayapalam
b84f19e870 8074803: Name clash
Javac incorrectly reports a name clash.

Reviewed-by: mcimadamore
2015-10-22 16:18:28 +05:30
Andreas Lundblad
200d75bd08 8087349: Test tools/sjavac/IncCompInheritance.java is failing
Refactoring of Dependencies framework.

Reviewed-by: mcimadamore
2015-10-22 09:05:54 +02:00
Srikanth Adayapalam
32cea7c65b 8138729: javac -parameters should not emit parameter names for lambda expressions
Reviewed-by: mcimadamore
2015-10-21 17:52:43 +05:30
Srikanth Adayapalam
08b811e8d6 8139836: Can't use super::x method reference when x is protected
Javac incorrectly diasllows reference to a protected method from a super class in method reference expressions.

Reviewed-by: mcimadamore
2015-10-20 15:25:41 +05:30
Jan Lahoda
a21102b5f4 8134254: JShell API/tool: REPL for Java into JDK9
Adding the implementation of the jshell (read-eval-print-loop) tool.

Co-authored-by: Robert Field <robert.field@oracle.com>
Co-authored-by: Shinya Yoshida <bitterfoxc@gmail.com>
Reviewed-by: briangoetz, mcimadamore, psandoz, forax
2015-10-19 19:15:16 +02:00
Jan Lahoda
9cd68d0633 8139751: Javac crash with -XDallowStringFolding=false
When string folding is disabled, need to keep the original expression.

Reviewed-by: mcimadamore
2015-10-19 12:41:45 +02:00
Chris Hegarty
8a27a7469b 8139371: Three langtools test failures after the removal of sun.misc.Lock
Reviewed-by: jjg, mchung
2015-10-13 09:02:30 +01:00
Dmitry Chuyko
cb20fc2079 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
Speed up Check.localClassName by avoiding generating names known to be in use already

Reviewed-by: mcimadamore, jlahoda, sadayapalam
2015-10-13 09:48:03 +05:30
Srikanth Adayapalam
ac4f8dfdd2 8139245: compiler crashes with exception on int:new method reference and generic method inference
Reviewed-by: mcimadamore
2015-10-12 19:43:44 +05:30
Maurizio Cimadamore
4d32c48daf 8138840: NPE when compiling bitwise operations with illegal operand types
8139243: compiler crashes with exception on sum operation of String var and void method call result
8139249: Compiler crashes on unary bitwise complement with non-integral operand

Certain binary operator checks are accepting more operands than required.

Reviewed-by: jlahoda
2015-10-12 12:24:33 +01:00
Srikanth Adayapalam
9c310602ec 8075799: Extraneous access checks implemented by javac
Allow anonymous class constructors to refer to inaccessible types.

Reviewed-by: mcimadamore
2015-10-07 19:35:43 +05:30
Srikanth Adayapalam
855243b12f 8065219: Deprecated warning in method reference are missing in some cases
Reviewed-by: mcimadamore
2015-10-07 16:02:57 +05:30
Srikanth Adayapalam
1a5c52e6c3 8130506: javac AssertionError when invoking MethodHandle.invoke with lambda paramter
Reviewed-by: mcimadamore
2015-10-07 15:53:38 +05:30
Iris Clark
3e51146504 Merge 2015-10-05 20:56:02 -07:00
Jan Lahoda
c4a3a35b97 8075274: Compilation still depends on the order of imports
8133235: Compilation depends on order of source files

When analyzing type hierarchy, HierarchyPhase should process supertypes before subtypes.

Reviewed-by: mcimadamore
2015-10-05 18:31:38 +02:00
Srikanth Adayapalam
ea13770069 8133135: Compiler internall error (NPE) on anonymous class defined by qualified instance creation expression with diamond
Reviewed-by: mcimadamore
2015-10-05 15:41:29 +05:30
Srikanth Adayapalam
0ea96ddfe4 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
Reviewed-by: mcimadamore
2015-10-01 19:47:06 +05:30
Iris Clark
0cbebd3571 Merge 2015-09-29 11:46:40 -07:00
Andrei Eremeev
b403bd3715 8081472: Add a mode to the tests for class-file attributes which dumps in-memory sources to disk
Reviewed-by: ksrini
2015-09-28 13:23:35 +03:00
Jan Lahoda
1c64d72bb6 8135307: CompletionFailure thrown when calling FieldDoc.type, if the field's type is missing
Handling CompletionFailures inside the Javadoc API implementation.

Reviewed-by: mcimadamore, ksrini, jjg
2015-09-23 08:29:33 +02:00
Iris Clark
58aa7068df Merge 2015-09-21 20:09:01 -07:00
Andreas Lundblad
6238d40db4 8135131: Enable thin server mode in Sjavac
State tracknig and incremental compilation disabled unless --state-dir is provided.

Reviewed-by: jlahoda
2015-09-21 11:19:10 +02:00
Maurizio Cimadamore
981c6dc298 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
Add infrastructure to avoid combinatorial explosion of method argument attributions

Reviewed-by: jlahoda, vromero, dlsmith
2015-09-15 13:43:44 +01:00
Iris Clark
16545b9471 Merge 2015-09-14 09:47:26 -07:00
Maurizio Cimadamore
379f2540aa 8077306: Recursive implementation of List.map leads to stack overflow
Recusrive implementation of List.map uses too much stack; switch to iterative version.

Reviewed-by: jlahoda
2015-09-14 11:26:14 +01:00
Kumar Srinivasan
11da417a28 8078320: Improve DocTrees parsing
Reviewed-by: jjg, jlahoda
2015-09-11 16:34:24 -07:00
Maurizio Cimadamore
9f6a7922f7 8135246: CheckAttributedTree silently generates spurious compiler error
Cyclic inheritance errors should cause shared combo context to be thrown away

Reviewed-by: jlahoda
2015-09-11 16:27:20 +01:00
Jan Lahoda
25d64eb4bc 8132885: langtools/test/tools/javac/sym/ElementStructureTest.java is also searching default classpath
Explicitly setting classpath when inspecting the platform classes; using the java.util.ServiceLoader instead of the javac's copy

Reviewed-by: jjg
2015-09-10 21:10:20 +02:00
Iris Clark
057b421238 Merge 2015-09-08 10:25:18 -07:00
Andreas Lundblad
ab159bb1f7 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
Protocol revised, javac output sent back to client slightly earlier.

Reviewed-by: jlahoda
2015-09-04 13:24:15 +02:00
Maurizio Cimadamore
2f46e61a83 8129962: Investigate performance improvements in langtools combo tests
New combo API that runs all combo instances in a shared javac context (whenever possible).

Reviewed-by: jjg, jlahoda, vromero
2015-08-31 17:33:34 +01:00
Maurizio Cimadamore
5f1384e8b4 8134007: Improve string folding
Generalize string folding algorithm to detect mulitple groups of foldable constants within an concat expression

Reviewed-by: jlahoda
2015-08-31 15:50:20 +01:00
Andreas Lundblad
97577b084f 8134483: A recent update to copyright headers caused two tests to fail
Replaced copyright notice with nodynamiccopyright and adjusted line numbers.

Reviewed-by: jfranck
2015-08-26 11:14:28 +02:00
Andreas Lundblad
8d0ebb66bd 8133671: langtools tests have bad license
Dropped classpath exception from copyright notice in tests.

Reviewed-by: jjg
2015-08-26 09:02:02 +02:00
Iris Clark
7f5ebecc4d Merge 2015-08-25 14:45:30 -07:00
Aleksey Shipilev
d2e6717c87 8134329: TeeOpTest.java fails across platforms after fix for JDK-8129547
Wrong indexes associated to CONSTANT_InvokeDynamic_info entries.

Reviewed-by: sundar
2015-08-25 15:10:25 +01:00
Andreas Lundblad
3672dbcddf 8048318: Refactor sjavac as a thin client
Moved compilation logic from client to server.

Reviewed-by: jlahoda
2015-08-25 15:14:41 +02:00
Aleksey Shipilev
062a960fd6 8129547: Excess entries in BootstrapMethods with the same (bsm, bsmKind, bsmStaticArgs), but different dynamicArgs
Pool.DynamicMethod implementation for hash/equals leads to duplicate BSM entries.

Reviewed-by: jlahoda
2015-08-24 13:15:12 +01:00
Iris Clark
8322ba07af Merge 2015-08-17 13:02:56 -07:00
Iris Clark
b75884a7f7 Merge 2015-08-10 19:59:16 -07:00
Vicente Romero
8a2078e8a3 8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
Reviewed-by: jlahoda
2015-08-10 18:10:18 -07:00
Iris Clark
736be40fcc Merge 2015-08-03 09:26:27 -07:00
Jan Lahoda
16d8f98d09 8131915: CompletionFailure during import listing crashes javac
Handling CompletionFailures during import listing properly.

Reviewed-by: mcimadamore
2015-08-03 13:28:39 +02:00
Ivan Gerasimov
f04bff42c7 8062647: Wrong indentation of arguments of annotated methods
Reviewed-by: jjg, bpatel
2015-07-31 01:36:56 +03:00
Maurizio Cimadamore
7baee75969 8131742: Syntactically meaningless code accepted by javac
Receiver parameter logic for type annotations should be disabled when parsing lambda formals

Reviewed-by: jlahoda
2015-07-30 13:24:35 +01:00
Maurizio Cimadamore
787325090c 8129214: Access error when unboxing a primitive whose target is a type-variable in a different package
Missing erasure when unboxing type in Lower

Reviewed-by: jlahoda
2015-07-30 13:21:01 +01:00
Maurizio Cimadamore
34ea5286e4 8081769: Redundant error message on bad usage of 'class' literal
Javac should skip to next token when an erroneous ident is found in term3rest

Reviewed-by: jlahoda
2015-07-30 13:20:01 +01:00
Jan Lahoda
8d3026508a 8130826: test writes file in test source directory
Setting an explicit output directory for ToolBox.JavacTask in PlatformProviderTest.

Reviewed-by: jjg
2015-07-28 17:01:45 +02:00
Jan Lahoda
c7fd81acde 8086737: Add support for -release to Javadoc
Reviewed-by: jjg, ksrini
2015-07-24 13:08:36 +02:00
Iris Clark
c3545012dc Merge 2015-07-23 13:20:35 -07:00
Iris Clark
45320f3096 Merge 2015-07-20 11:02:12 -07:00
Maurizio Cimadamore
4ae1cb2cd6 8130304: Inference: NodeNotFoundException thrown with deep generic method call chain
Bug in Tarjan implementation is generating node ids which can overflow 32 bits

Reviewed-by: vromero
2015-07-17 12:46:07 +01:00
Alejandro Murillo
0be524debf Merge 2015-07-14 16:29:08 -07:00
Iris Clark
11a87851d7 Merge 2015-07-13 13:24:07 -07:00
Jan Lahoda
85193a1a26 8129909: Add -Xdoclint/package: to javadoc
Adding -Xdoclint/package: command line option, similar to the javac -Xdoclint/package: option, to javadoc.

Reviewed-by: darcy, jjg, ksrini
2015-07-13 16:33:42 +02:00
Andrei Eremeev
a7cf8786ff 8044411: Implement classfile tests for RuntimeAnnotations and RuntimeParameterAnnotations attribute
Reviewed-by: jjg, shurailine, anazarov
2015-07-10 12:42:00 +03:00
Alejandro Murillo
a761654ef9 Merge 2015-07-09 22:46:18 -07:00
Liam Miller-Cushon
7d78c183c4 8130803: add regression test related to fix for JDK-8078024
Reviewed-by: mcimadamore
2015-07-09 11:06:48 -07:00
Srikanth Adayapalam
7b64cba44c 8130745: Revert fix pushed for JDK-8074346
Reviewed-by: jlahoda
2015-07-08 19:01:57 +05:30
Iris Clark
483fd8263a Merge 2015-07-06 11:49:24 -07:00
Daniel D. Daugherty
92febebcac Merge 2015-07-03 06:39:38 -07:00
Daniel D. Daugherty
99552a1c2f Merge 2015-07-02 14:42:12 -07:00