Commit Graph

579 Commits

Author SHA1 Message Date
Ekaterina Pavlova
ebdb70fe9e 8236975: compiler/graalunit tests fails with --illegal-access=deny
Reviewed-by: iignatyev, kvn, alanb
2020-03-26 14:24:53 -07:00
Roland Westrelin
eb003a7382 8240335: C2: assert(found_sfpt) failed: no node in loop that's not input to safepoint
Reviewed-by: kvn, thartmann
2020-03-20 13:56:12 +01:00
Christian Hagedorn
c01e986cc9 8237859: C2: Crash when loads float above range check
Fix control edges of predicates to data nodes when creating pre/main/post loops.

Reviewed-by: neliasso, thartmann, roland
2020-03-25 14:41:52 +01:00
Tobias Hartmann
ca85500615 8240905: assert(mem == (Node*)1 || mem == mem2) failed: multiple Memories being matched at once?
Stop recursion if there are multiple loads with different memory inputs in the tree.

Reviewed-by: kvn, vlivanov
2020-03-24 17:39:52 +01:00
Sandhya Viswanathan
398ce2948c 8240248: Extend superword reduction optimizations for x86
Add support for and, or, xor reduction

Co-authored-by: Shravya Rukmannagari <shravya.rukmannagari@intel.com>
Reviewed-by: vlivanov, thartmann
2020-03-23 10:26:40 -07:00
Roland Westrelin
c9faf88cb7 8240795: [REDO] 8238384 CTW: C2 compilation fails with "assert(store != load->find_exact_control(load->in(0))) failed: dependence cycle found"
Reviewed-by: kvn, thartmann
2020-03-13 16:32:51 +01:00
Jamsheed Mohammed C M
136a1574ec 8237894: CTW: C1 compilation fails with assert(x->type()->tag() == f->type()->tag()) failed: should have same type
Field access instructions hash decalred_type in addition, indexed access instructions hash value type of the instruction in addition.

Reviewed-by: thartmann, shade
2020-03-20 05:19:56 -07:00
Christian Hagedorn
a51dd58f38 8240227: Loop predicates should be copied to unswitched loops
Copy loop range check predicates to unswitched loops and update their control edges.

Reviewed-by: kvn, neliasso, thartmann, roland
2020-03-19 10:15:28 +01:00
Jie Fu
dd63eec6e5 8241232: -XX:+BootstrapJVMCI is not compatible with TieredStopAtLevel < CompLevel_full_optimization
Reviewed-by: kvn, thartmann
2020-03-19 16:34:01 +08:00
Doug Simon
34b9ac2287 8236285: [JVMCI] improve TranslatedException traces
Reviewed-by: never, kvn
2020-03-18 13:11:09 -07:00
Chris Plummer
a147636157 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available
Reviewed-by: sspitsyn, iignatyev
2020-03-17 18:04:59 -07:00
Roland Westrelin
2a35bc5aee 8240854: [REDO] some jaotc failures of fastdebug build with specific flags
Reviewed-by: vlivanov, kvn, thartmann
2020-03-11 10:32:07 +01:00
Richard Reingruber
c5bd0d7934 8234146: compiler/jsr292/ContinuousCallSiteTargetChange.java times out on SPARC
Reviewed-by: vlivanov, thartmann
2020-03-12 11:51:00 +01:00
Vladimir Kozlov
39ab073173 8240830: [BACKOUT] 8240195: some jaotc failures of fastdebug build with specific flags
Reviewed-by: dcubed
2020-03-10 14:39:39 -07:00
Vladimir Ivanov
072cfd2e48 8238681: Make -XX:UseSSE flag x86-specific
Reviewed-by: dholmes, kvn
2020-03-10 20:51:07 +03:00
Roland Westrelin
42ff13ab82 8240195: some jaotc failures of fastdebug build with specific flags
Reviewed-by: kvn, thartmann
2020-03-09 09:42:30 +01:00
Roland Westrelin
43e0165eea 8240794: [BACKOUT] 8238384 CTW: C2 compilation fails with "assert(store != load->find_exact_control(load->in(0))) failed: dependence cycle found"
Reviewed-by: thartmann
2020-03-10 10:45:01 +01:00
Dongbo He
aa2be1141d 8240576: JVM crashes after transformation in C2 IdealLoopTree::merge_many_backedges
Reviewed-by: kvn
2020-03-09 22:31:12 +08:00
Roland Westrelin
b58c8601bb 8239335: C2: assert((Value(phase) == t) || (t != TypeInt::CC_GT && t != TypeInt::CC_EQ)) failed: missing Value() optimization
Reviewed-by: kvn, thartmann
2020-03-05 15:56:49 +01:00
Doug Simon
f456f151cc 8240538: [JVMCI] add test for JVMCI ConstantPool class
Reviewed-by: kvn, iignatyev
2020-03-05 16:32:52 -08:00
Qi Feng
d1818942b0 8240286: [TESTBUG] Test command error in hotspot/jtreg/compiler/loopopts/superword/SumRedAbsNeg_Float.java
Reviewed-by: kvn, thartmann
2020-03-05 14:51:41 +08:00
Roland Westrelin
86ad195099 8238384: CTW: C2 compilation fails with "assert(store != load->find_exact_control(load->in(0))) failed: dependence cycle found"
Reviewed-by: vlivanov, thartmann
2020-02-20 16:41:05 +01:00
Roland Westrelin
1e796eae8f 8239367: RunThese30M.java failed due to "assert(false) failed: graph should be schedulable"
Reviewed-by: thartmann, vlivanov, neliasso
2020-02-21 15:01:22 +01:00
Nils Eliasson
908a933131 8238759: Clones should always keep the base pointer
Reviewed-by: rkennke, thartmann
2020-03-03 10:29:05 +01:00
Christian Hagedorn
d7b122ed69 8238438: SuperWord::co_locate_pack picks memory state of first instead of last load
Fix selection of first and last memory state in SuperWord::co_locate_pack

Reviewed-by: thartmann, kvn
2020-03-02 10:23:08 +01:00
Pengfei Li
934db29ac5 8239549: AArch64: Backend support for MulAddVS2VI node
Reviewed-by: aph
2020-02-26 09:33:29 +08:00
Jie Fu
ca838e68c9 8239885: [TESTBUG] compiler/allocation/TestAllocation.java fails with release VMs
Reviewed-by: thartmann
2020-02-25 16:22:12 +08:00
Nils Eliasson
38a57e8bed 8238723: yank_alloc_node must remove membar
Reviewed-by: vlivanov, thartmann, roland
2020-02-24 11:31:07 +01:00
Ao Qi
305fe226dc 8239424: [TESTBUG] compiler/whitebox/OSRFailureLevel4Test.java failed when TieredCompilation is disabled
Skip test if TieredCompilation is not available.

Reviewed-by: thartmann
2020-02-19 12:10:45 +08:00
Ao Qi
eef02376bd 8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled
Skip test if C1 is not available.

Reviewed-by: thartmann, xliu
2020-02-19 12:09:25 +08:00
Doug Simon
8119f836bf 8238758: [JVMCI] fix JVMCI jtreg events tests to work with GraalVM
Reviewed-by: kvn, dlong, never
2020-02-14 09:25:43 -08:00
Roland Westrelin
3bb62dc0d8 8236759: ShouldNotReachHere in PhaseIdealLoop::verify_strip_mined_scheduling
Reviewed-by: thartmann, neliasso
2020-01-13 10:00:30 +01:00
Christian Hagedorn
2ac2d590c2 8238811: C2: assert(i >= req() || i == 0 || is_Region() || is_Phi()) with -XX:+VerifyGraphEdges
Fix -XX:+VerifyGraphEdges by additionally handling ArrayCopyNodes and UnlockNodes and add some basic flag testing.

Reviewed-by: roland, neliasso
2020-02-13 15:08:08 +01:00
Christian Hagedorn
3ea92e735b 8238756: C2: assert(((n) == __null || !VerifyIterativeGVN || !((n)->is_dead()))) failed: can not use dead node
Fix -XX:+VerifyIterativeGVN due to a dead node and add some basic flag testing.

Reviewed-by: roland, neliasso
2020-02-13 15:07:45 +01:00
Christian Hagedorn
e2829b7b87 8237945: CTW: C2 compilation fails with assert(just_allocated_object(alloc_ctl) == ptr) failed: most recent allo
Removing too strong assertion about array allocation in LibraryCallKit::tightly_coupled_allocation().

Reviewed-by: thartmann, neliasso
2020-02-13 15:07:21 +01:00
Christian Hagedorn
8bdb972192 8238178: CTW: C1 compilation fails with assert(sux->loop_depth() != block->loop_depth() || sux->loop_index() == block->loop_index() || loop_through_xhandler) failed: Loop index has to be same
Fix verification of C1 IR involving xhandlers in one-time executed loops on the non-exceptional path.

Reviewed-by: thartmann, neliasso
2020-02-13 15:06:57 +01:00
Nils Eliasson
b59f630249 8237581: Improve allocation expansion
Reviewed-by: vlivanov, redestad
2020-02-06 11:21:39 +01:00
David Leopoldseder
135f209852 8238190: [JVMCI] Fix single implementor speculation for diamond shapes
Reviewed-by: kvn
2020-02-04 09:33:09 +01:00
Christian Hagedorn
b940e17c9e 8235332: TestInstanceCloneAsLoadsStores.java fails with -XX:+StressGCM
Account for GC barriers when skipping a cloned ArrayCopyNode in ConnectionGraph::find_inst_mem()

Reviewed-by: roland, neliasso
2020-01-31 09:32:00 +01:00
Ekaterina Pavlova
9d5d2a241a 8236211: [Graal] compiler/graalunit/GraphTest.java is skipped in all testing
Reviewed-by: iignatyev
2020-01-29 10:12:59 -08:00
Pengfei Li
6fd7ad87ce 8237524: AArch64: String.compareTo() may return incorrect result
Reviewed-by: aph
2020-01-21 08:15:33 +00:00
Mikael Vidstedt
3318314c7c 8237589: Fix copyright header formatting
Reviewed-by: jjg, serb, iris, jwilhelm
2020-01-21 14:23:01 -08:00
Fairoz Matte
a4b3e781fe 8236701: [TESTBUG] compiler/loopopts/superword/Vec_MulAddS2I.java uses wrong flag -XX:-SuperWord
Reviewed-by: iklam, thartmann
2020-01-16 17:37:09 -08:00
Fei Yang
a86e196559 8235762: JVM crash in SWPointer during C2 compilation
Reviewed-by: thartmann, chagedorn, neliasso
2020-01-09 19:12:16 +08:00
Jesper Wilhelmsson
d34f561de0 Merge 2020-01-15 20:41:46 +01:00
Jie Fu
6d03f918cf 8237055: [TESTBUG] compiler/c2/TestJumpTable.java fails with release VMs
Reviewed-by: thartmann
2020-01-14 18:07:45 +08:00
Tobias Hartmann
ea152dcd9b 8229855: C2 fails with assert(false) failed: bad AD file
Strengthen the check to ensure that both control and data paths die consistently.

Reviewed-by: vlivanov, roland
2020-01-13 13:37:01 +01:00
Christian Hagedorn
863f741611 8236140: assert(!VerifyHashTableKeys || _hash_lock == 0) failed: remove node from hash table before modifying it
Add missing rehashing for modified node in InitializeNode::complete_stores().

Reviewed-by: neliasso, thartmann
2020-01-09 16:14:14 +01:00
Tobias Hartmann
f243173a18 8236721: C2 should better optimize not-equal integer comparisons
Narrow the type if an integer value is found to be unequal to it's lower/upper boundary.

Reviewed-by: roland, neliasso
2020-01-15 08:44:53 +01:00
Jesper Wilhelmsson
913b8702d1 Merge 2020-01-13 15:40:09 +01:00
Jesper Wilhelmsson
943b87ddde Merge 2020-01-09 20:21:53 +01:00
Andrew Haley
984da450f2 Merge 2020-01-09 09:30:49 -05:00
Andrew Haley
21c02a5b18 8235385: AArch64: Crash on aarch64 JDK due to long offset
Reviewed-by: adinn
2020-01-09 09:30:02 -05:00
Jesper Wilhelmsson
257a1bb854 Merge 2020-01-08 16:03:32 +01:00
Christian Hagedorn
3e9a17c53e 8235984: C2: assert(out->in(PhiNode::Region) == head || out->in(PhiNode::Region) == slow_head) failed: phi must be either part of the slow or the fast loop
Bailout from loop unswitching if loop predicates have a control dependency to partially peeled statements.

Reviewed-by: neliasso, thartmann
2020-01-07 17:06:10 +01:00
Igor Veresov
cc99075c79 8236050: Some compiler tests fail when executed with custom TieredLevel
Make sure TieredStopAtLevel is properly supported for different compilation modes

Reviewed-by: redestad, thartmann
2020-01-07 07:31:28 -08:00
Smita Kamath
995da6eb2a 8167065: Add intrinsic support for double precision shifting on x86_64
Reviewed-by: kvn
2019-12-23 14:42:21 -08:00
Tobias Hartmann
34b08ed2a5 8233164: C2 fails with assert(phase->C->get_alias_index(t) == phase->C->get_alias_index(t_adr)) failed: correct memory chain
Use _src_type/_dest_type as address types for the loads and stores.

Reviewed-by: vlivanov, roland
2019-12-23 09:44:35 +01:00
Jatin Bhateja
079db54d51 8230185: assert(is_Loop()) failed: invalid node class
Adding missing check for a counted loop.

Reviewed-by: kvn, thartmann
2019-12-18 10:04:53 +01:00
Ekaterina Pavlova
efdf413a20 8235773: Tier3 fails because graalunit tests started to run with ZGC
Reviewed-by: iignatyev
2019-12-11 17:18:32 -08:00
Tom Rodriguez
bca86d6492 8229961: Assert failure in compiler/graalunit/HotspotTest.java
Reviewed-by: kvn
2019-12-11 09:47:41 -08:00
Christian Hagedorn
ba94936c80 8233033: C2 produces wrong result while unswitching a loop due to lost control dependencies
Adding missing control dependencies when cloning loop predicates at loop unswitching.

Reviewed-by: roland, vlivanov, thartmann
2019-12-11 14:33:32 +01:00
Tobias Hartmann
642d2ddcbc 8235452: Strip mined loop verification fails with assert(is_OuterStripMinedLoop()) failed: invalid node class
Do not try to verify strip mining if the strip mined loop is malformed.

Reviewed-by: roland, vlivanov
2019-12-11 10:42:44 +01:00
Ekaterina Pavlova
2c54f0f643 8215728: [Graal] we should run some Graal tests in tier1
Reviewed-by: iignatyev
2019-12-10 21:49:07 -08:00
Doug Simon
25b5ddc05d 8235539: [JVMCI] -XX:+EnableJVMCIProduct breaks -XX:-EnableJVMCI
Reviewed-by: kvn, thartmann
2019-12-10 09:34:33 -08:00
Patrick Zhang
8c1efbe38b 8229351: AArch64: the const STUB_THRESHOLD in macroAssembler_aarch64.cpp needs to be tuned
Optimize the stub thresholds of string_compare intrinsics

Reviewed-by: adinn, aph, avoitylov
2019-08-12 16:22:24 +08:00
Gustavo Romero
11d4e9f34d 8223968: Add abort type description to RTM statistic counters
Reviewed-by: mdoerr, kvn
2019-05-10 18:20:02 -04:00
Roland Westrelin
9d40ab91db 8234350: assert(mode == ControlAroundStripMined && (use == sfpt || !use->is_reachable_from_root())) failed: missed a node
Reviewed-by: thartmann, mdoerr
2019-12-09 15:37:04 +01:00
Xin Liu
f33087405a 8235383: C1 compilation fails with -XX:+PrintIRDuringConstruction -XX:+Verbose
Added check for printable bci.

Reviewed-by: thartmann
2019-12-10 10:34:31 +01:00
Christian Hagedorn
2ee7b9d3a0 8233032: assert(in_bb(n)) failed: must be
Find first and last memory state of a load pack without relying on bb indices.

Co-authored-by: Roland Westrelin <rwestrel@redhat.com>
Reviewed-by: roland, kvn, thartmann
2019-12-10 09:28:38 +01:00
Christian Hagedorn
fd8832f726 8229994: assert(false) failed: Bad graph detected in get_early_ctrl_for_expensive
Fixes wrong idom information set in loop peeling when a loop strip mined loop is involved.

Reviewed-by: vlivanov, thartmann
2019-12-06 10:00:16 +01:00
Christoph Göttschkes
9c4adc66c7 8234906: [TESTBUG] TestDivZeroCheckControl fails for client VMs due to Unrecognized VM option LoopUnrollLimit
Reviewed-by: kvn
2019-12-04 10:38:54 +01:00
Igor Ignatyev
503a960e7d 8129092: compiler/intrinsics/classcast/NullCheckDroppingsTest.java testVarClassCast() can fail
Reviewed-by: kvn
2019-12-03 20:23:53 -08:00
Tobias Hartmann
aff41433b6 8234617: C1: Incorrect result of field load due to missing narrowing conversion
Emit an explicit conversion to get the correct field value after the write.

Reviewed-by: vlivanov, mdoerr
2019-12-03 08:29:04 +01:00
Andrew Dinn
7b02e24b65 8232828: AArch64: compiler/c2/aarch64/TestVolatilesG1.java fails after JDK-8225776
Reviewed-by: aph
2019-11-29 15:37:13 +00:00
Christoph Göttschkes
620d67763d 8234894: [TESTBUG] TestEliminateLocksOffCrash fails for client VMs due to Unrecognized VM option EliminateLocks
Reviewed-by: thartmann
2019-11-28 16:11:44 +01:00
Christoph Göttschkes
a4a351caad 8234807: [TESTBUG] LoopRotateBadNodeBudget fails for client VMs due to Unrecognized VM option PartialPeelNewPhiDelta
Reviewed-by: kvn
2019-11-27 10:13:41 +01:00
Igor Ignatyev
4e0ac78eed 8234290: compiler/c2/Test6857159.java times out and fail to clean up files
Reviewed-by: thartmann
2019-11-21 14:15:31 -08:00
Jie Fu
e665037932 8234499: [Graal] compiler/compilercontrol/CompilationModeHighOnlyTest.java test fails with timeout
Reviewed-by: iignatyev
2019-11-21 09:55:12 +08:00
Christoph Göttschkes
6a99789fd5 8231954: Test compiler/codegen/TestCharVect2.java only works with server VMs
Reviewed-by: iignatyev, kvn
2019-11-15 11:05:03 +01:00
Igor Ignatyev
733bb68c11 8214904: Test8004741.java failed due to "Too few ThreadDeath hits; expected at least 6 but saw only 5"
Reviewed-by: kvn, epavlova
2019-11-15 14:22:24 -08:00
Tom Rodriguez
ddc8f8e757 8233888: jdk.vm.ci.hotspot.test.VirtualObjectLayoutTest.testFormat(): Unexpected error verifying
Reviewed-by: kvn, iignatyev
2019-11-14 16:34:24 -08:00
Igor Ignatyev
298ac1ef9e 8226795: compiler/tiered/Level2RecompilationTest.java fails when XX:TieredStopAtLevel=1/2/3 is set
Reviewed-by: redestad
2019-11-13 11:34:31 -08:00
Igor Ignatyev
a21dd0b86b 8225756: [testbug] compiler/loopstripmining/CheckLoopStripMining.java sets too short a SafepointTimeoutDelay
Reviewed-by: kvn, epavlova, roland, mdoerr
2019-11-13 10:59:25 -08:00
Leo Korinth
1fc67ab002 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector
Reviewed-by: kbarrett, tschatzl, erikj, coleenp, dholmes
2019-11-13 11:37:29 +01:00
Bernard Blaser
b8b88853a5 8214239: Missing x86_64.ad patterns for clearing and setting long vector bits
Reviewed-by: kvn, vlivanov, jrose, sviswanathan
2019-11-13 11:21:15 +01:00
Jie Fu
b2ce439b85 8233885: Test fails with assert(comp != __null) failed: Ensure we have a compiler
Reviewed-by: thartmann, iveresov
2019-11-11 17:40:28 +08:00
Tobias Hartmann
1833584f92 8233529: loopTransform.cpp:2984: Error: assert(p_f->Opcode() == Op_IfFalse) failed
Strengthened asserts in locate_pre_from_main() and added a check for is_main_no_pre_loop().

Reviewed-by: kvn, vlivanov
2019-11-12 10:16:04 +01:00
Christian Hagedorn
173dae8bc6 8229694: JVM crash in SWPointer during C2 OSR compilation
Handle the case where there is only 1 pack and no operations left when calling SuperWord::find_align_to_ref() to find the best alignment again.

Reviewed-by: kvn, vlivanov, thartmann
2019-11-11 10:41:03 +01:00
Igor Ignatyev
993947e6ce 8233745: [JVMCI] TranslatedException should serialize classloader and module info
Reviewed-by: kvn, dnsimon
2019-11-09 10:27:53 -08:00
Igor Ignatyev
69606205a6 8230364: [JVMCI] a number of JVMCI tests are not jtreg enabled
Reviewed-by: kvn
2019-11-07 13:39:31 -08:00
Igor Ignatyev
ddaa12237e 8233496: AOT tests failures with 'java.lang.RuntimeException: Failed to find sun/hotspot/WhiteBox.class'
Reviewed-by: kvn, thartmann
2019-11-05 08:57:36 -08:00
Thomas Stuefe
13cc1154f0 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit
Reviewed-by: mdoerr, dlong, aph
2019-10-31 07:53:16 +01:00
Igor Veresov
83dda95d7f 8227003: Add high-level JIT compilation mode control mechanism
Add tiered mode to emulate non-tiered with special mode for JVMCI compiler. Add -XX:CompilationMode option.

Reviewed-by: never, redestad
2019-11-01 09:39:13 -07:00
Pengfei Li
ec56d9aaf0 8232591: AArch64: Add missing match rules for smaddl, smsubl and smnegl
Reviewed-by: aph
2019-10-30 09:17:36 +08:00
Vladimir Kozlov
5c506779b2 8233035: Update JVMCI
Reviewed-by: dlong
2019-10-29 15:35:06 -07:00
Patric Hedlin
902858e3ce 8231565: More node budget asserts in fuzzed tests
Reviewed-by: neliasso, thartmann
2019-10-23 12:51:53 +02:00
Vladimir Kozlov
e15849a0f8 8232904: Update JVMCI
Reviewed-by: dnsimon
2019-10-24 16:58:39 -07:00
Claes Redestad
574263a884 8232613: Move Object.registerNatives into HotSpot
Reviewed-by: dholmes, adinn, coleenp, lfoltan, mchung
2019-10-24 09:57:29 +02:00
Tobias Hartmann
7b38a7e87d 8232883: compiler/c2/CmpPNodeSubTest.java fails because test class name is wrong
Renamed test file to match class name.

Reviewed-by: roland
2019-10-23 13:52:33 +02:00
Christian Hagedorn
465f4c1200 8231412: C2: InitializeNode::detect_init_independence() bails out on simple IR shapes
Avoids early bailout of capturing a field store to remove unnecessary zeroing in simple methods containing only non-escaping objects.

Reviewed-by: roland, thartmann
2019-10-23 12:21:32 +02:00
Christian Hagedorn
13b4952f11 8232874: Add missing test for 8230062
Adds a missing test which verifies the bug fix of 8230062.

Reviewed-by: roland, thartmann
2019-10-23 12:17:14 +02:00
Christian Hagedorn
3cc9ed08e7 8232873: Add missing test for 8220416
Adds a missing test which verifies the bug fix of 8220416.

Reviewed-by: roland, thartmann
2019-10-23 12:15:42 +02:00
Jie Fu
750eab1ecc 8232692: [TESTBUG] compiler/aot/fingerprint/SelfChangedCDS.java fails when cds is disabled
Reviewed-by: kvn
2019-10-21 17:27:51 +08:00
Huang Wang
4fb2bb554d 8231988: Unexpected test result caused by C2 IdealLoopTree::do_remove_empty_loop
Duplicate cmp node in empty loop if it has other users

Co-authored-by: Tuo Xie <xietuo@huawei.com>
Reviewed-by: neliasso, thartmann
2019-10-11 16:52:18 +08:00
Ekaterina Pavlova
036a3528ea 8231903: [Graal] Update com.oracle.mxtool.junit classes
Reviewed-by: kvn
2019-10-09 10:59:45 -07:00
Roland Westrelin
703760bbec 8231550: C2: ShouldNotReachHere() in verify_strip_mined_scheduling
Reviewed-by: vlivanov, thartmann
2019-10-02 17:32:08 +02:00
Roland Westrelin
a81dcf4dbf 8231620: assert(bol->is_Bool()) crash during split if due to FastLockNode
Reviewed-by: vlivanov, thartmann
2019-10-01 10:28:12 +02:00
Christian Hagedorn
8200eb4d45 8231626: DeoptimizeRandom should not be a product flag
The DeoptimizeRandom flag is changed to develop since it has no effect in production.

Reviewed-by: neliasso, thartmann
2019-10-02 08:27:17 +02:00
Roland Westrelin
fd3a403512 8231665: 8231055 broke escapeAnalysis/TestSelfArrayCopy.java
Reviewed-by: thartmann
2019-09-30 17:58:05 +02:00
Jatin Bhateja
d3ca3a02ff 8226721: Missing intrinsics for Math.ceil, floor, rint
Reviewed-by: neliasso, vlivanov, ecaspole
2019-10-01 11:43:10 +02:00
Roland Westrelin
2f2ec624a2 8227384: C2 compilation fails with "graph should be schedulable" when running with -XX:-EliminateLocks
Reviewed-by: thartmann, kvn
2019-07-16 08:56:08 +02:00
Patric Hedlin
8275b17b07 8229499: Node budget assert in fuzzed test
Reviewed-by: thartmann, neliasso
2019-09-12 11:44:51 +02:00
Tobias Hartmann
a03e92201d 8231223: C2's conditional move optimization fails with assert(bol->Opcode() == Op_Bool) failed
Bail out if the range check If has an Opaque4Node input instead of a BoolNode.

Reviewed-by: roland, kvn
2019-09-26 09:16:08 +02:00
Arno Zeller
3fab0b8407 8230110: TestLinkageErrorInGenerateOopMap times out
Reviewed-by: stuefe, clanger, thartmann
2019-09-24 14:46:38 +02:00
Roland Westrelin
e2803ed999 8231055: C2: arraycopy with same non escaping src and dest but different positions causes wrong execution
Reviewed-by: thartmann, vlivanov
2019-09-17 15:58:54 +02:00
Roland Westrelin
dfc5c795c7 8229483: Sinking load out of loop may trigger: assert(found_sfpt) failed: no node in loop that's not input to safepoint
Reviewed-by: thartmann, neliasso
2019-09-23 16:49:09 +02:00
Roland Westrelin
a63b541842 8230061: # assert(mode == ControlAroundStripMined && use == sfpt) failed: missed a node
Reviewed-by: thartmann, neliasso
2019-08-28 15:51:03 +02:00
Robbin Ehn
35a9f6864a 8226705: [REDO] Deoptimize with handshakes
Reviewed-by: eosterlund, dcubed, dlong, pchilanomate
2019-09-19 10:52:22 +02:00
Jie Fu
4fb41f2617 8230943: False deadlock detection with -XX:+CIPrintCompileQueue after JDK-8163511
Reviewed-by: dholmes, thartmann
2019-09-17 20:38:23 +08:00
Roland Westrelin
ec5451c117 8229701: aarch64: C2 OSR compilation fails with "shouldn't process one node several times" in final graph reshaping
Reviewed-by: thartmann, kvn
2019-08-23 14:22:29 +02:00
Aleksey Shipilev
7c2fe7025b 8230813: Add JDK-8010500 to compiler/loopopts/superword/TestFuzzPreLoop.java bug list
Reviewed-by: zgu
2019-09-10 19:58:22 +02:00
Tobias Hartmann
a4b46ccc23 8229496: SIGFPE (division by zero) in C2 OSR compiled method
Adding a CastNode to keep the dependency between the div/mod operation and the zero check.

Reviewed-by: roland, mdoerr
2019-09-05 13:56:17 +02:00
Xin Liu
0a92dc786d 8229450: C2 compilation fails with assert(found_sfpt) failed
Reviewed-by: roland, thartmann
2019-09-04 16:39:12 +02:00
Aleksey Shipilev
5110530d5b 8230238: Add another regression test for JDK-8134739
Reviewed-by: kvn
2019-09-02 11:31:12 +02:00
Christian Hagedorn
db359f11b5 8229158: make UseSwitchProfiling non-experimental or false by-default
Changed UseSwitchProfiling from experimental to diagnostic.

Reviewed-by: dholmes, shade, thartmann
2019-08-20 10:46:23 +02:00
Tobias Hartmann
672fa8b97a 8228888: C2 compilation fails with assert "m has strange control"
Weakened too strong assert.

Reviewed-by: kvn, roland
2019-08-20 07:47:13 +02:00
Tobias Hartmann
da43cb5e46 8224957: C2 compilation fails with assert: Bad graph detected in build_loop_late
Disable walking up the dominator chain for regions with more than 2 input paths.

Reviewed-by: roland, kvn
2019-08-13 09:56:13 +02:00
Tobias Hartmann
f1763a5e86 8228772: C2 compilation fails due to unschedulable graph if DominatorSearchLimit is reached
Ignore membar if the load is already control dependent on it.

Reviewed-by: neliasso, kvn
2019-08-13 09:54:40 +02:00
Rahul Raghavan
090734266c 8227439: Turn off AOT by default
Made UseAOT, AOTLibrary experimental and UseAOT false by default

Reviewed-by: iignatyev, kvn
2019-08-08 14:13:16 +05:30
Tobias Hartmann
ac2ea95788 8229016: C2 scalarization crashes with assert(node->Opcode() == Op_CastP2X) failed: ConvP2XNode required
Detect array copy to self to avoid emitting another load to the to-be-removed allocation.

Reviewed-by: kvn
2019-08-07 12:09:55 +02:00
Valerie Peng
c720219beb 8228668: compiler/codegen/aes/TestAESMain.java failed with GCM mode must be used with NoPadding
Updated test to use NoPadding as default if the mode is one of GCM, CTR and CTS

Reviewed-by: xuelei
2019-07-29 20:18:43 +00:00
Christian Hagedorn
b2a9f90a94 8223769: Assert triggers with -XX:+StressReflectiveCode
Fixed too strong assert.

Reviewed-by: kvn, thartmann
2019-07-29 09:34:07 +02:00
Roman Kennke
d4afa4e1c8 8226757: Shenandoah: Make traversal and passive modes explicit
Reviewed-by: shade
2019-07-04 14:28:31 +02:00
Bernard Blaser
0a1d85e5a3 8225644: C1 dumps incorrect class name in ClassCastException message
Co-authored-by: Jie Fu <fujie@loongson.cn>
Reviewed-by: vlivanov, bsrbnd
2019-06-25 21:24:37 +02:00
Jesper Wilhelmsson
a1e6e5f785 Merge 2019-06-25 14:36:31 +02:00
Daniel D. Daugherty
b0933034e0 8226699: [BACKOUT] JDK-8221734 Deoptimize with handshakes
Reviewed-by: dholmes, rehn, dlong
2019-06-24 22:38:17 -04:00
Dean Long
01c739c34a 8225369: [AOT] vm/classfmt/cpl/cplres001/cplres00101m004/cplres00101m004.html fails
Reviewed-by: kvn, never
2019-06-24 18:51:54 -04:00
Vladimir Kozlov
3b0ee5a6d8 8225810: Update JVMCI
Reviewed-by: never, dnsimon
2019-06-21 16:21:13 -07:00
Vladimir Kozlov
2527f768bc 8209590: compiler/compilercontrol/DontInlineCommandTest.java test fails with "Inline message differs" error
Increase InlineSmallCode to 4000 for tests which check inlining decisions.

Reviewed-by: iignatyev
2019-06-13 17:18:06 -07:00
Martin Doerr
fad846280b 8225663: [testbug] Missing JNIEXPORT in XAbortProvoker native function
Reviewed-by: mbaesken, gromero, kvn
2019-06-13 11:12:23 +02:00
Tobias Hartmann
31d261dda2 8224658: Unsafe access C2 compile fails with assert(flat != TypePtr::BOTTOM) failed: cannot alias-analyze an untyped ptr: adr_type = NULL
Handle unsafe off-heap access with constant zero address.

Reviewed-by: vlivanov, roland
2019-06-12 14:06:16 +02:00
Rahul Raghavan
2f25526470 8225567: Wrong file headers with 8202414 fix changeset
Corrected source file headers

Reviewed-by: thartmann
2019-06-11 14:33:34 +05:30
Igor Ignatyev
f2f26ca775 8149040: Cleanup compiler/jsr292/NonInlinedCall tests after JDK-8148994
Reviewed-by: kvn, thartmann
2019-06-07 21:35:26 -07:00
Dean Long
c18ffd6a79 8223050: JVMCI: findUniqueConcreteMethod() should not use Dependencies::find_unique_concrete_method() for non-virtual methods
Reviewed-by: kvn, dnsimon
2019-06-07 18:11:33 -04:00
Vladimir Kozlov
12bb59fb63 8225350: compiler/jvmci/compilerToVM/IsCompilableTest.java timed out
Reviewed-by: iignatyev
2019-06-07 13:57:08 -07:00
Vladimir Kozlov
4bd89c7401 8208379: compiler/jvmci/events/JvmciNotifyInstallEventTest.java failed with "Got unexpected event count after 2nd install attempt: expected 9 to equal 2"
Reviewed-by: iignatyev
2019-06-06 15:12:37 -07:00
Jie Fu
d738e209f3 8224162: assert(profile.count() == 0) failed: sanity in InlineTree::is_not_reached
Reviewed-by: vlivanov, kvn
2019-06-06 13:45:59 +03:00
Peter Januschke
0835c96bda 8222103: [testbug] compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest may exceed VM limit
Reviewed-by: iignatyev, mdoerr
2019-05-31 14:52:01 +02:00
Vladimir Kozlov
7356905a83 8225019: Update JVMCI
Reviewed-by: never, dlong
2019-06-04 12:44:53 -07:00
Ekaterina Pavlova
b8e5aefce8 8225199: [Graal] compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java fails with -XX:CompileThresholdScaling=0.1
Reviewed-by: kvn
2019-06-03 17:14:23 -07:00
Patric Hedlin
d222b01dee 8223363: Bad node estimate assertion failure
8223502: Node estimate for loop unswitching is not correct: assert(delta <= 2 * required) failed: Bad node estimate
8224648: assert(!exceeding_node_budget()) failed: Too many NODES required! failure with ctw

Tighten the node estimates. New est_loop_clone_sz() implementation that will compute a "fan-out" complexity estimate as part of the size estimate (to better estimate complex loop body size after cloning). New est_loop_unroll_sz() function, used to estimate the size of a loop body att full/maximal unrolling. Correction to node budget final tests and asserts.

Reviewed-by: neliasso, kvn
2019-05-28 14:56:58 +02:00
Gustavo Romero
88cef8d961 8223660: jtreg: Decouple Unsafe from RTM tests
Reviewed-by: mdoerr, shade
2019-05-22 12:17:26 -04:00
Wang Xue
2e04779cef 8224723: [TESTBUG] compiler/arraycopy/TestArrayCopyWithBadOffset.java failed
Added missing -XX:+IgnoreUnrecognizedVMOptions

Reviewed-by: thartmann
2019-05-24 09:51:02 +02:00
Robbin Ehn
9baafa55a6 8221734: Deoptimize with handshakes
Reviewed-by: dcubed, dholmes, pchilanomate, dlong, coleenp
2019-05-23 10:13:29 +02:00
Tobias Hartmann
abe90da665 8224539: C2 compilation fails during ArrayCopyNode optimizations with assert(i < _max) failed: oob: i=1, _max=1
Bail out if src_offset or dst_offset is top.

Reviewed-by: roland, vlivanov, kvn
2019-05-23 08:57:37 +02:00
Dmitrij Pochepko
c21fc9448d 8218966: AArch64: String.compareTo() can read memory after string
Reviewed-by: dsamersoff
2019-05-22 20:39:04 +03:00
Dmitrij Pochepko
d83c89b805 8215792: AArch64: String.indexOf generates incorrect result
Reviewed-by: dsamersoff
2019-05-22 20:12:19 +03:00
Ekaterina Pavlova
fddcb90369 8222482: [Graal] Update java-allocation-instrumenter.jar handling in graalunit README.md
Reviewed-by: kvn, shade
2019-05-21 12:29:47 -07:00
Jie Fu
c69b24eb77 8222302: [TESTBUG]test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU
Reviewed-by: kvn, dlong
2019-05-18 12:13:38 -07:00
Ekaterina Pavlova
954169d7d1 8223910: TestFloatJNIArgs and TestTrichotomyExpressions time out with Graal as JIT
Reviewed-by: thartmann
2019-05-16 11:30:32 -07:00
Sandhya Viswanathan
707c30fae6 8222074: Enhance auto vectorization for x86
Reviewed-by: kvn, vlivanov
2019-05-07 13:33:27 -07:00
Xin Liu
63dbcdc874 8222670: pathological case of JIT recompilation and code cache bloat
Prevent downgraded compilation tasks from recompiling.

Reviewed-by: sgehwolf, thartmann
2019-05-07 09:17:03 +02:00
Vladimir Kozlov
72f082e925 8223332: Update JVMCI
Reviewed-by: never, dnsimon
2019-05-06 20:05:19 -07:00
Pengfei Li
58a1f6ac13 8223054: [TESTBUG] Put graalJarsCP before existing classpath in GraalUnitTestLauncher
Reviewed-by: iignatyev, dlong
2019-05-07 00:58:10 +00:00
Vladimir Kozlov
e9c523ae5f 8220623: [JVMCI] Update JVMCI to support JVMCI based Compiler compiled into shared library
Reviewed-by: dnsimon, never, stefank, rehn, neliasso, dholmes, kbarrett, coleenp
2019-05-01 12:31:29 -07:00
Rahul Raghavan
fee481d5a2 8202414: Unsafe write after primitive array creation may result in array length change
Avoided collecting unaligned stores in Initialize node by making can_capture_store return false for same

Reviewed-by: dlong, kvn, vlivanov
2019-05-01 22:02:48 +05:30
Tobias Hartmann
048c3dc026 8219807: C2 crash in IfNode::up_one_dom(Node*, bool)
Guard against regions degraded to copies.

Reviewed-by: kvn
2019-04-30 14:49:19 +02:00
Harold Seigel
ef40115621 8221685: -XX:BytecodeVerificationRemote and -XX:BytecodeVerificationLocal should be diagnostic options
Make the options diagnostic and add -XX:+UnlockDiagnosticVMOptions to tests where needed.

Reviewed-by: lfoltan, acorn, dholmes
2019-04-24 08:27:00 -04:00
Jesper Wilhelmsson
75db2f7df9 8221598: Update Graal
Reviewed-by: kvn
2019-04-23 22:55:09 +02:00
Ekaterina Pavlova
a8550e4589 8222747: [Graal] mx_subprocess files miss testing VM flags
Reviewed-by: kvn
2019-04-19 11:18:06 -07:00
Ekaterina Pavlova
894027aec4 8208066: compiler/graalunit/JttThreadsTest.java failed with org.junit.runners.model.TestTimedOutException: test timed out after 20 seconds
Reviewed-by: iignatyev
2019-04-12 14:13:31 -07:00
Ekaterina Pavlova
93c0734d3a 8216551: GraalUnitTestLauncher should be executed as '@run driver'
Reviewed-by: dlong, kvn
2019-04-08 11:11:22 -07:00
Rahul Raghavan
3f0955154d 8219612: compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
Test rewritten to use top level classes rather then nested ones

Reviewed-by: iignatyev, kvn, thartmann
2019-03-27 18:33:48 +05:30
Volker Simonis
6efb59fad7 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected"
Reviewed-by: kvn, mdoerr
2019-03-26 18:42:10 +01:00
Volker Simonis
f9c08cc6fb 8221083: [ppc64] Wrong oop compare in C1-generated code
Reviewed-by: mdoerr, goetz
2019-03-26 11:51:41 +01:00
Dmitry Cherepanov
f16af8d4d5 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit
Reviewed-by: iveresov, thartmann
2019-03-20 11:51:43 +03:00
Per Lidén
fbf62f0fb8 8220569: ZGC: Rename and rework ZUnmapBadViews to ZVerifyViews
Reviewed-by: stefank, eosterlund
2019-03-18 11:50:38 +01:00
Tobias Hartmann
0b42c0728a 8220611: compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java timeout
Test should not be executed with Graal as JIT.

Reviewed-by: kvn
2019-03-15 08:27:13 +01:00
Igor Ignatyev
8fb834a4bf 8219139: move hotspot tests from test/jdk/vm
Reviewed-by: dholmes, mseledtsov
2019-03-14 19:37:17 -07:00
Roland Westrelin
3ec1137c1f 8220374: C2: LoopStripMining doesn't strip as expected
Reviewed-by: rkennke, thartmann, mdoerr
2019-03-12 15:42:32 +01:00
Ekaterina Pavlova
4df6db5e3f 8219882: [AOT] Develop regression test for 8218859
Reviewed-by: kvn
2019-03-13 12:30:20 -07:00
Jesper Wilhelmsson
c7219faf86 8218074: Update Graal
Reviewed-by: kvn
2019-03-12 19:17:42 +01:00
Bernard Blaser
cf09431450 8220407: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java timedout
Reviewed-by: kvn
2019-03-12 02:13:02 +01:00
Tobias Hartmann
164fcbbec9 8218201: Failures when vmIntrinsics::_getClass is not inlined
Fix BCEscapeAnalyzer to correctly handle _getClass intrinsic.

Reviewed-by: kvn, dlong, redestad, neliasso
2019-03-11 11:42:57 +01:00
Severin Gehwolf
1952af8053 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions
Reviewed-by: thartmann, shade
2019-03-08 13:56:05 +01:00
Jatin Bhateja
c2ec1085e1 8217561: X86: Add floating-point Math.min/max intrinsics
Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions

Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn
2019-03-07 15:27:42 +01:00
Goetz Lindenmaier
3d593b0c1c 8219651: compiler/ciReplay/TestServerVM.java is failing on windows
Reviewed-by: thartmann, kvn
2019-03-06 16:01:01 +01:00
Tobias Hartmann
ac17b61a59 8163511: Allocation of compile task fails with assert: "Leaking compilation tasks?"
Use weak handles for compile tasks to allow unloading of referenced methods.

Reviewed-by: kvn, coleenp, eosterlund
2019-03-07 08:38:16 +01:00
Fairoz Matte
3e71e62ff6 8219513: compiler/codegen/aes/TestCipherBlockChainingEncrypt.java timeout on Solaris-sparc
Reviewed-by: kvn, iignatyev
2019-03-01 04:34:28 -08:00
Roland Westrelin
7fd7a118da 8219335: "failed: unexpected type" assert failure in ConnectionGraph::split_unique_types() with unsafe accesses
Reviewed-by: thartmann, kvn
2019-02-18 17:41:31 +01:00
Harold Seigel
dd7e50dc01 8214719: Deprecate -Xverify:none option
Deprecate -Xverify:none and -noverify and remove them from tests

Reviewed-by: dholmes, mikael
2019-02-20 13:21:36 -05:00
Tobias Hartmann
799c9a66fd 8218721: C1's CEE optimization produces safepoint poll with invalid debug information
Bail out of CEE if one of the gotos is a safepoint but the if is not.

Reviewed-by: vlivanov, mdoerr
2019-02-19 08:58:55 +01:00
Igor Ignatyev
8512c3117d 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp
Reviewed-by: kvn, thartmann
2019-02-14 23:45:03 -08:00
Vladimir Ivanov
992f8f87ad 8218758: [TESTBUG] compiler/cha/StrengthReduceInterfaceCall.java misses recompilation event
Reviewed-by: iignatyev
2019-02-14 15:27:12 -08:00
Igor Ignatyev
328fae7880 8145845: [AOT] NullPointerException in compiler/whitebox/GetCodeHeapEntriesTest.java
Reviewed-by: kvn, thartmann
2019-02-12 11:23:43 -08:00
Aleksey Shipilev
7ce7e1b3d7 8218715: [TESTBUG] TestUseOptoBiasInliningWithoutEliminateLocks needs to unlock WhiteBoxAPI
Reviewed-by: kvn
2019-02-09 19:39:28 +01:00
Roland Westrelin
f88962f2d9 8217990: C2 UseOptoBiasInlining: load of markword optimized to 0 if running with -XX:-EliminateLocks
Reviewed-by: thartmann, mdoerr, rrich, kvn
2019-02-07 09:55:57 +01:00
Pengfei Li
42f34d1076 8218550: Add test omitted from JDK-8212043
Add test case omitted from fix for JDK-8212043

Reviewed-by: shade
2019-02-06 16:25:58 +00:00
Jesper Wilhelmsson
b2d0be746a Merge 2019-02-02 00:11:54 +01:00