Commit Graph

521 Commits

Author SHA1 Message Date
Jonathan Gibbons
f71b78ced3 6980021: javac should document @file command line option
Reviewed-by: mcimadamore
2011-03-07 13:45:06 -08:00
Maurizio Cimadamore
409b9b8d25 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR)

Reviewed-by: jjg
2011-03-07 14:31:50 +00:00
Jan Lahoda
ddaf77107d 7024568: Very long method resolution causing OOM error
Resolve.findMethod scans same receiver type more than once in certain inheritance graphs

Reviewed-by: jjg
2011-03-07 14:11:48 +00:00
Jonathan Gibbons
9365637c4a 6964914: javadoc does not output number of warnings using user written doclet
Reviewed-by: bpatel
2011-03-04 19:59:04 -08:00
Jonathan Gibbons
75c64565c4 6227454: package.html and overview.html may not be read fully
Reviewed-by: bpatel
2011-03-04 19:56:02 -08:00
Maurizio Cimadamore
7b3d32182e 7024212: TestWarnErrorCount fails
TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures

Reviewed-by: jjg
2011-03-03 18:05:52 +00:00
Maurizio Cimadamore
f416cac815 7022054: Invalid compiler error on covariant overriding methods with the same erasure
Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6

Reviewed-by: jjg
2011-03-03 17:34:58 +00:00
Maurizio Cimadamore
291f04e8c0 7023703: Valid code doesn't compile
Leftovers cause problems when analyzing loops in Flow.java

Reviewed-by: jjg
2011-03-03 17:32:35 +00:00
Maurizio Cimadamore
df9296f567 7023233: False positive for -Xlint:try with nested try with resources blocks
Wrong lint warning issued about unused resource when nested try-with-resource blocks are found

Reviewed-by: jjg
2011-03-03 09:43:24 +00:00
Jonathan Gibbons
f78030e4f1 6639645: Modeling type implementing missing interfaces
Reviewed-by: darcy, mcimadamore
2011-03-02 21:13:55 -08:00
Jonathan Gibbons
ed6677cbba 6986892: confusing warning given after errors in annotation processing
Reviewed-by: darcy
2011-03-02 21:06:17 -08:00
Jonathan Gibbons
6c7b14a762 6986895: compiler gives misleading message for no input files
Reviewed-by: darcy
2011-03-02 14:03:38 -08:00
Maurizio Cimadamore
45e06252b7 6541876: "Enclosing Instance" error new in 1.6
Unqualified 'this' should not be selected in a qualified super() call in a default constructor

Reviewed-by: jjg
2011-03-02 10:56:39 +00:00
Jonathan Gibbons
5fd6eeaa54 7021183: 269: assertion failure getting enclosing element of an undefined name
Reviewed-by: mcimadamore
2011-03-01 12:00:06 -08:00
Jonathan Gibbons
36ed816102 7022711: compiler crash in try-with-resources
Reviewed-by: mcimadamore
2011-02-28 13:42:24 -08:00
Jonathan Gibbons
148841e5e1 7022741: warning counts are wrong after anno processing
Reviewed-by: mcimadamore
2011-02-28 13:37:48 -08:00
Jonathan Gibbons
56d963bdf6 7022337: repeated warnings about bootclasspath not set
Reviewed-by: mcimadamore
2011-02-28 12:19:18 -08:00
Maurizio Cimadamore
1683dd4109 7015715: lub gets stuck on type with complex supertype
Lub should not scan supertypes unnecessarily

Reviewed-by: jjg, dlsmith
2011-02-28 11:50:56 +00:00
Maurizio Cimadamore
32216fc797 7015430: Incorrect thrown type determined for unchecked invocations
Thrown types do not get updated after 15.12.2.8, and do not get erased as per 15.12.2.6

Reviewed-by: jjg, dlsmith
2011-02-28 11:48:53 +00:00
Jonathan Gibbons
78ebde094c 7022310: test/tools/javac/diags/Example: args added twice
Reviewed-by: mcimadamore
2011-02-25 12:19:00 -08:00
Jonathan Gibbons
a51962066d 7021650: fix Context issues
Reviewed-by: mcimadamore
2011-02-25 12:09:33 -08:00
Jim Holmlund
6d172a6a63 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines
Use a single file manager for all JavacTasks

Reviewed-by: jjg, mcimadamore
2011-02-24 08:40:49 -08:00
Maurizio Cimadamore
7186448cfe 7019631: issues in test headers in b130
Fix to test headers not containing correct bug ID

Reviewed-by: jjg
2011-02-23 14:17:08 +00:00
Maurizio Cimadamore
1ae687fbd2 7020657: Javac rejects a fairly common idiom with raw override and interfaces
Name clash should not be reported if subinterface/implementing class resolves the clash by defining common overrider

Reviewed-by: jjg
2011-02-23 14:16:12 +00:00
Joe Darcy
dc728d5d5a 7020047: Project Coin: generate null-check around try-with-resources close call
Reviewed-by: jjg
2011-02-18 15:55:20 -08:00
Maurizio Cimadamore
0f41147166 7020626: diamond: add diagnostic test for diamond and non-generic classes
Fix failure in regression test CheckExamples

Reviewed-by: jjg
2011-02-18 16:17:44 +00:00
Kumar Srinivasan
3b676c4925 7018859: javac turn off the Zip optimization by default
Reviewed-by: jjg
2011-02-18 08:12:06 -08:00
Maurizio Cimadamore
7d8c3e9460 7020043: Project Coin: diamond allowed on non-generic type
Diamond oerator should be disallowed on non-generic class types (i.e. String)

Reviewed-by: jjg
2011-02-18 12:28:49 +00:00
Maurizio Cimadamore
dd20e6fdd7 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources
Twr should generate better error message when uncaught exceptions are thrown by implicit call of close() method

Reviewed-by: jjg
2011-02-15 11:51:04 +00:00
Maurizio Cimadamore
77f10a1c5f 7017664: Add listeners infrastracture to javac scopes
Add listeners to javac scopes, added CompoundScope and correct invalidation logic for ImplementationCache

Reviewed-by: jjg
2011-02-15 11:49:46 +00:00
Kelly O'Hair
511e9c3dcb 7008433: Minor copyright changes
Reviewed-by: jjg
2011-02-14 14:27:47 -08:00
Jonathan Gibbons
710ec9f95d 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter
Reviewed-by: darcy
2011-02-11 17:10:26 -08:00
Jonathan Gibbons
caf0257075 6485027: javac incorrectly handles relative paths in manifest classpath
Reviewed-by: mcimadamore
2011-02-10 15:05:33 -08:00
Jonathan Gibbons
1406a86c7d 7018098: CacheFSInfo persists too long
Reviewed-by: mcimadamore
2011-02-10 14:24:26 -08:00
Jonathan Gibbons
a71eecc4f7 7016750: tools/javac/nio/CompileTest failing in nightly test
Reviewed-by: mcimadamore
2011-02-09 14:04:53 -08:00
Maurizio Cimadamore
dfec6e2301 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123
Override clash algorithm is not implemented correctly

Reviewed-by: jjg
2011-02-07 18:10:13 +00:00
Maurizio Cimadamore
f4daf3d7bf 7014715: javac returns different error code for certain failure(s)
Javac silently crashes when emitting certain kinds of resolution diagnostics

Reviewed-by: jjg
2011-02-03 09:38:19 +00:00
Maurizio Cimadamore
536bd08692 6969184: poor error recovery after symbol not found
Generic type-well formedness check should ignore erroneous symbols

Reviewed-by: jjg
2011-02-03 09:37:28 +00:00
Maurizio Cimadamore
6ded62c828 5017953: spurious cascaded diagnostics when name not found
When an operator is applied to one or more erroneous operands, spurious diagnostics are generated

Reviewed-by: jjg
2011-02-03 09:36:28 +00:00
Maurizio Cimadamore
79d1b7b1e1 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
Lint warnings generated during MemberEnter might ignore @SuppressWarnings annotations

Reviewed-by: jjg
2011-02-03 09:35:21 +00:00
Joe Darcy
9be3c0f789 6961571: Update visitors to support ARM's ElementKind.RESOURCE_VARIABLE
Reviewed-by: jjg
2011-02-01 10:11:05 -08:00
Joe Darcy
ba98ee427f 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources
Reviewed-by: jjg
2011-01-31 19:06:32 -08:00
Alan Bateman
434b2147c7 Merge 2011-01-28 12:36:34 +00:00
Maurizio Cimadamore
15959fbf11 6838943: inference: javac is not handling type-variable substitution properly
Free type-variables are being replaced with type-variables bound to forall type leading to unsoundness

Reviewed-by: jjg, dlsmith
2011-01-28 12:06:21 +00:00
Maurizio Cimadamore
1e776bc78a 6313164: javac generates code that fails byte code verification for the varargs feature
Method applicability check should fail if formal varargs element type is not accessible

Reviewed-by: jjg
2011-01-28 12:03:49 +00:00
Maurizio Cimadamore
6647b73cc8 6910550: javac 1.5.0_17 fails with incorrect error message
Multiple clashing members declared in same class should be added to the class' scope in order to avoid downstream spurious diagnostics

Reviewed-by: jjg
2011-01-28 12:01:07 +00:00
Alan Bateman
68c23b7878 7006126: (fs) Updates to file system API (1/2011)
Reviewed-by: jjg
2011-01-28 09:25:20 +00:00
Jim Holmlund
50d526442a 7015482: jtreg test tools/javac/diags/MessageInfo.java fails when test/ dir is not in langtools repo
Don't fail if the needed file isn't present, if running under jtreg.

Reviewed-by: jjg
2011-01-28 00:09:38 -08:00
Jonathan Gibbons
de3bde6688 7013272: Automatically generate info about how compiler resource keys are used
Reviewed-by: mcimadamore
2011-01-26 13:45:25 -08:00
Jonathan Gibbons
a184b53cec 6554097: "final" confuses @SuppressWarnings
Reviewed-by: mcimadamore
2011-01-26 11:20:19 -08:00
Joe Darcy
ec50779b72 7013420: Project Coin: remove general expression support from try-with-resources statement
Reviewed-by: mcimadamore, jjg
2011-01-25 17:02:56 -08:00
Jonathan Gibbons
bcf09ec04f 6988106: javac report 'java.lang.IllegalMonitorStateException'
Reviewed-by: ksrini
2011-01-24 16:38:56 -08:00
Jonathan Gibbons
1ab227adc4 6581775: Fix the white space problem in javac shell tests
Reviewed-by: mcimadamore
2011-01-24 16:34:25 -08:00
Jonathan Gibbons
1d1fd8962d 6963934: JCCompilationUnit.getImports does not report all imports
Reviewed-by: mcimadamore
2011-01-24 16:17:33 -08:00
Maurizio Cimadamore
6bd5b48ca7 7013865: varargs: javac crashes during overload resolution with generic varargs
Fixed regression with varargs overload resolution that leads javac to crash

Reviewed-by: jjg
2011-01-24 15:45:41 +00:00
Maurizio Cimadamore
96d0749bfc 6569633: Varargs: parser error when varargs element type is an array
Explicit error message when old-style array syntax is mixed with varargs

Reviewed-by: jjg
2011-01-24 15:45:24 +00:00
Maurizio Cimadamore
13ecf26ded 6510286: Wording of javac error for inner classes
'inner classes cannot have static declarations' message needs to be reworked

Reviewed-by: jjg
2011-01-24 15:45:06 +00:00
Maurizio Cimadamore
b77effad6c 6968793: issues with diagnostics
Several diagnostic improvements

Reviewed-by: jjg
2011-01-24 15:44:51 +00:00
Maurizio Cimadamore
df54c56a04 6943278: spurious error message for inference and type-variable with erroneous bound
Type-inference should ignore erroneous bounds

Reviewed-by: jjg
2011-01-24 15:44:15 +00:00
Jonathan Gibbons
9a6afb10e4 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris)
Reviewed-by: mcimadamore
2011-01-14 11:45:19 -08:00
Maurizio Cimadamore
0dae258b02 6949040: java.dyn package must be compiled with -target 7 or better
Issue error (rather than warning) when @PolymorphicSignature is found and target < 7

Reviewed-by: jjg
2011-01-14 09:46:44 +00:00
Maurizio Cimadamore
ede9924b4e 7007432: Test generic types well-formedness
Add a new kind of check (well-formedness of generic type w.r.t. declared bounds) in the type-harness

Reviewed-by: jjg
2011-01-14 09:45:52 +00:00
Maurizio Cimadamore
7d90979693 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls
Special syntax to denote indy return type through type parameters should be removed (and cast shall be used instead)

Reviewed-by: jjg, jrose
2011-01-14 09:45:04 +00:00
Jonathan Gibbons
e66871ae10 6430241: Hard to disable symbol file feature through API
Reviewed-by: mcimadamore
2011-01-13 11:48:10 -08:00
Jonathan Gibbons
12f8b2493e 6993305: starting position of a method without modifiers and with type parameters is incorrect
Reviewed-by: mcimadamore
2011-01-11 08:05:28 -08:00
Jonathan Gibbons
43e78a8d44 6992999: fully remove JSR 308 from langtools
Reviewed-by: mcimadamore
2011-01-10 14:57:59 -08:00
Maurizio Cimadamore
21c037bb9b 7010194: several langtools regression failures after JSR 292 changes (b123)
Some regression tests rely on unsupported JSR 292 features

Reviewed-by: jjg
2011-01-05 09:59:01 +00:00
Lana Steuck
34c5f24321 Merge 2011-01-04 17:10:35 -08:00
Kelly O'Hair
84b5875f26 6962318: Update copyright year
Reviewed-by: xdono
2010-12-28 15:54:52 -08:00
Jim Holmlund
4157467833 6982992: Tests CheckAttributedTree.java, JavacTreeScannerTest.java, and SourceTreeeScannerTest.java timeout
Hoist some invariant code out of a loop

Reviewed-by: ksrini
2010-12-23 12:29:21 -08:00
Kumar Srinivasan
5032fcd7b5 6567415: Neverending loop in ClassReader
Reviewed-by: jjg
2010-12-18 09:38:39 -08:00
Jonathan Gibbons
facb1c1b6d 7006564: NPE in javac running test/tools/javac/nio/compileTest/CompileTest.java
Reviewed-by: mcimadamore, alanb
2010-12-15 06:39:51 -08:00
Jonathan Gibbons
cfe2f7eb5d 6999891: DefaultFileManager incorrect
Reviewed-by: darcy
2010-12-14 14:17:20 -08:00
Maurizio Cimadamore
6ef5228632 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
Reviewed-by: jjg, darcy
2010-12-13 15:11:00 -08:00
Bhavesh Patel
87db401cf5 Merge 2010-12-13 14:08:01 -08:00
Bhavesh Patel
8850af593b 7006270: Several javadoc regression tests are failing on windows
Reviewed-by: jjg
2010-12-13 13:44:47 -08:00
Maurizio Cimadamore
ecb30ce139 7006109: Add test library to simplify the task of writing automated type-system tests
Types.java needs to be more stress-tested

Reviewed-by: jjg
2010-12-13 14:56:50 +00:00
Jonathan Gibbons
1ce40f31dd 6504896: TreeMaker.Literal(Object) does not support Booleans
Reviewed-by: mcimadamore
2010-12-10 07:38:28 -08:00
Maurizio Cimadamore
450d85b95a 6199075: Unambiguous varargs method calls flagged as ambiguous
Javac does not implement overload resolution w.r.t. varargs methods as described in the JLS

Reviewed-by: jjg
2010-12-10 15:24:17 +00:00
Maurizio Cimadamore
ba8f15cef1 7005671: Regression: compiler accepts invalid cast from X[] to primitive array
Regression in type conversion after 292 changes

Reviewed-by: jjg
2010-12-10 15:23:42 +00:00
Jonathan Gibbons
cc42fec255 6985202: no access to doc comments from Tree API
Reviewed-by: mcimadamore
2010-12-09 08:48:08 -08:00
Jonathan Gibbons
3244279bb2 4917091: javac rejects array over 128 in length
Reviewed-by: mcimadamore
2010-12-09 08:24:42 -08:00
Maurizio Cimadamore
d2e437cb96 7005371: Multicatch: assertion error while generating LocalVariableTypeTable attribute
Compiler crashes with assertion error if '-g' option is passed and source contains multicatch

Reviewed-by: jjg
2010-12-09 15:50:57 +00:00
Maurizio Cimadamore
929d3fd3f5 6476118: compiler bug causes runtime ClassCastException for generics overloading
Compiler allows bridge methods to override unrelated method

Reviewed-by: jjg
2010-12-09 15:50:34 +00:00
Maurizio Cimadamore
e8d1ae243d 7005095: Cast: compile reject sensible cast from final class to interface
A previous fix to cast conversion has made the compiler too strict w.r.t. final cast

Reviewed-by: jjg
2010-12-09 15:50:10 +00:00
Jonathan Gibbons
b9f90baa59 7004698: javap does not output CharacterRangeTable attributes correctly
Reviewed-by: mcimadamore
2010-12-08 13:42:57 -08:00
Jonathan Gibbons
8e9c506c6c 6999210: javac should be able to warn of anomalous conditions in classfiles
Reviewed-by: mcimadamore, darcy
2010-12-07 14:13:25 -08:00
Maurizio Cimadamore
5cdc149cc1 5088429: varargs overloading problem
Compiler implementation for overload resolution w/ varargs method does not match JLS

Reviewed-by: jjg
2010-12-06 11:51:02 +00:00
Maurizio Cimadamore
47f6d8a95e 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
Attribution should check each component of a disjunctive type separately, rather than checking the corresponding lub()

Reviewed-by: jjg
2010-12-06 11:50:37 +00:00
Maurizio Cimadamore
63f05334a6 7003744: Compiler error concerning final variables
Flow analysis does not cleanup init/uninint bit masks after for-loop

Reviewed-by: jjg
2010-12-06 11:49:00 +00:00
Maurizio Cimadamore
8644a0bc46 7002837: Diamond: javac generates diamond inference errors when in 'finder' mode
Javac should disable error messages when analyzing instance creation expression in 'diamond finder' mode

Reviewed-by: jjg
2010-12-03 16:32:31 +00:00
Maurizio Cimadamore
7613f7a72c 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass
Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Lower

Reviewed-by: jjg
2010-12-03 16:31:23 +00:00
Jonathan Gibbons
d4dee14cff Merge 2010-12-02 16:38:16 -08:00
Per Bothner
e07cc985e8 7004029: intermittent failures compiling pack200
Remove "bogus" entries from star-import scopes

Reviewed-by: mcimadamore
2010-12-02 16:37:23 -08:00
Bhavesh Patel
275e77646d 6851834: Javadoc doclet needs a structured approach to generate the output HTML
Reviewed-by: jjg
2010-12-01 11:02:38 -08:00
Jonathan Gibbons
be8a607fef 6900037: javac should warn if earlier -source is used and bootclasspath not set
Reviewed-by: darcy
2010-11-29 14:15:36 -08:00
Jonathan Gibbons
cba5c7df9f 7002346: javap test relies on location of scratch directory
Reviewed-by: ksrini
2010-11-23 15:28:34 -08:00
Jonathan Gibbons
df07a3e457 6942366: javadoc no longer inherits doc from sourcepath
Reviewed-by: mcimadamore
2010-11-23 13:32:29 -08:00
Maurizio Cimadamore
3e65664acf 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type
15.12.2.8 should use boxing when expected type in assignment context is a primitive type

Reviewed-by: jjg
2010-11-23 11:08:43 +00:00
Jonathan Gibbons
bdc7e81168 6999438: remove support for exotic identifiers from JDK 7
Reviewed-by: mcimadamore
2010-11-18 16:13:11 -08:00