Commit Graph

2216 Commits

Author SHA1 Message Date
Vicente Romero
34a6de55b2 8026963: type annotations code crashes for code with erroneous trees
Reviewed-by: jjg, jlahoda
2013-11-14 19:28:20 +00:00
Eric McCorkle
71adca3d64 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java
Remove @ignore from test

Reviewed-by: jjg
2013-11-14 12:32:57 -05:00
Christine Lu
3ad95dda8e Added tag jdk8-b116 for changeset 1fbd33ac5531 2013-11-14 09:05:25 -08:00
Sonali Goel
b941719f94 8025113: Convert 7 tools TryWithResources tests to jtreg format
Reviewed-by: darcy, jjg
2013-11-13 16:36:08 -08:00
Joel Borggrén-Franck
f3cb828db7 8027375: javac asserts on nested erroneous annotations
Make sure JCAnnotation trees have type != null before annotation processing

Reviewed-by: jjg
2013-11-11 17:26:09 +01:00
Eric McCorkle
44f29ffde7 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
8027253: javac illegally accepts array as bound

Backing out change allowing arrays in intersection types

Reviewed-by: vromero
2013-11-11 09:47:46 -05:00
Jan Lahoda
d3eb4e0816 8027142: Invokedynamic instructions don't get line number table entries
When emitting invokedynamic instruction, write pendingStatPos, if set, into the LineNumberTable. Invokedynamic itself does not set the pendingStatPos.

Reviewed-by: jjg, jrose, ksrini, vromero
2013-11-09 15:24:38 +01:00
Lana Steuck
ab3713bd2f Merge 2013-11-08 17:39:33 -08:00
Joe Darcy
d9cc608057 8027730: Fix release-8 type visitors to support intersection types
Reviewed-by: jjg, jlahoda, sogoel
2013-11-07 20:11:56 -08:00
Christine Lu
ccd53abea1 Added tag jdk8-b115 for changeset 115e1128ce1a 2013-11-07 08:16:38 -08:00
Jan Lahoda
e9f9c31086 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests
When invoking interface default method via a superclass, use the direct superclass in the reference.

Reviewed-by: vromero, dlsmith, jjg
2013-11-06 17:48:25 +01:00
Christine Lu
12da1db3d7 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options
Reviewed-by: jjg
2013-11-04 18:51:56 -08:00
Christine Lu
14c3c8b4fb 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b
Reviewed-by: jjg
2013-11-04 18:04:34 -08:00
Christine Lu
989860b8c3 8025844: Need test to provide coverage for new DocumentationTool.Location enum
Reviewed-by: jjg
2013-11-04 17:38:38 -08:00
Magnus Ihse Bursie
9e72063042 8027566: Remove the old build system
Reviewed-by: erikj, tbell
2013-11-04 11:08:41 +01:00
Jan Lahoda
513a51e9bb 8027310: Annotation Processor crashes with NPE
JCAnnotation.attribute is null when annotation type is unavailable

Reviewed-by: jjg, jfranck
2013-11-01 21:43:27 +01:00
Vicente Romero
96d9e95176 8027660: javac crash while creating LVT entry for a local variable defined in an inner block
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2013-11-01 19:08:56 +00:00
Lana Steuck
0de31c2237 Merge 2013-10-31 16:46:43 -07:00
Christine Lu
47d505c488 Added tag jdk8-b114 for changeset 7e53ada0d2d4 2013-10-31 12:36:36 -07:00
Brian Goetz
6dcdc5b742 8024930: Re-enable disabled bridging tests
Reviewed-by: psandoz, rfield
2013-10-30 14:12:16 -04:00
Vicente Romero
9d30f46219 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo
Reviewed-by: ksrini
2013-10-30 18:09:49 +00:00
Mandy Chung
fa729039be 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.*
Reviewed-by: alanb, dfuchs
2013-10-30 08:35:52 -07:00
Lana Steuck
14d87a0e5a Merge 2013-10-28 12:29:34 -07:00
Robert Field
e49bc26ebc 8027220: DefaultMethodsTest: Change test to match spec
Reviewed-by: ksrini
2013-10-24 16:52:27 -07:00
Bhavesh Patel
3033b82865 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags
Reviewed-by: jjg
2013-10-24 11:22:50 -07:00
Christine Lu
7217e11778 Added tag jdk8-b113 for changeset 220220c28a95 2013-10-24 09:10:52 -07:00
Eric McCorkle
e62fb20a59 8023682: Incorrect attributes emitted for anonymous class declaration
Cause javac to emit type annotations on new instruction as well as anonymous class supertype for annotated anonymous classes.

Reviewed-by: jjg, jfranck
2013-10-24 01:27:10 -04:00
Eric McCorkle
fb5a684124 8006732: support correct bytecode storage of type annotations in multicatch
Fix issue with annotations being added before attribution, which causes multicatch not to work right and several tests to fail.

Reviewed-by: jfranck, jjg
2013-10-23 23:20:32 -04:00
Jan Lahoda
017ea08922 8026936: Initialize LamdbaToMethod lazily and as required
Reviewed-by: jjg, rfield
2013-10-23 15:45:18 -07:00
David Katleman
a9467bf52b Merge 2013-10-23 08:50:36 -07:00
Jan Lahoda
14fe29f845 8026861: Wrong LineNumberTable for variable declarations in lambdas
Setting or correcting positions for many trees produced by LambdaToMethod.

Reviewed-by: vromero, rfield
2013-10-23 07:50:04 +02:00
Jan Lahoda
237d1940c6 8027191: Fix for JDK-8026861 refers to an incorrect bug number
Reverting changeset e7c8a164d7bd, so that it can be applied again with a correct bug number

Reviewed-by: jjg
2013-10-23 23:02:17 +02:00
Bhavesh Patel
80787f47a9 8026770: javadoc creates invalid HTML in profile summary pages
Reviewed-by: jjg
2013-10-23 13:54:13 -07:00
Robert Field
c9ceea7ac7 8022720: Method refeerences - private method should be accessible (nested classes)
Reviewed-by: jjg, ksrini
2013-10-23 10:28:10 -07:00
Jan Lahoda
5ea357c66e 8026508: Invokedynamic instructions don't get line number table entries
Setting or correcting positions for many trees produced by LambdaToMethod.

Reviewed-by: vromero, rfield
2013-10-23 07:50:04 +02:00
Jonathan Gibbons
806a84e4de Merge 2013-10-22 17:44:43 -07:00
Jonathan Gibbons
53d2f8ae31 8027119: Cleanup javadoc comments for taglet API
Reviewed-by: mduigou
2013-10-22 17:42:10 -07:00
Robert Field
69709943c3 8023668: Desugar serializable lambda bodies using more robust naming scheme
Lambda / bridged method-reference naming overhaul

Reviewed-by: ksrini, briangoetz
2013-10-22 16:53:21 -07:00
Tim Bell
4c2ade4cc3 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files
Reviewed-by: mduigou, mchung
2013-10-22 16:30:06 -07:00
Vicente Romero
48b6b38e52 8025290: javac implicit versus explicit lambda compilation error
Reviewed-by: jjg, dlsmith
2013-10-22 13:54:49 +01:00
Joel Borggrén-Franck
d8d3ea2057 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present
An empty container should not stop javac from looking at supertypes for inherited repeating annotations

Reviewed-by: jjg
2013-10-22 10:08:49 +02:00
Kumar Srinivasan
39fb59399a 8026758: Inefficient code in LambdaToMethod
Reviewed-by: jjg, jlahoda, rfield
2013-10-21 20:10:43 -07:00
Joel Borggrén-Franck
4a79e1cec8 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable
In AnnoConstruct.getAnnotationByType() check that the annotation sought after is inherited before looking on supertypes.

Reviewed-by: jjg
2013-10-22 03:36:44 +02:00
Joe Darcy
7b509ee987 8026984: Clarity intended use of jdk.Exported
Reviewed-by: psandoz, mr, alanb
2013-10-21 15:37:11 -07:00
Vicente Romero
43754fccbd 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change
Reviewed-by: jfranck
2013-10-21 15:55:02 +01:00
Kumar Srinivasan
24394acaea 8026931: MethodParameters tests failing on Windows
Reviewed-by: jjg, vromero
2013-10-20 12:54:17 -07:00
Werner Dietl
29582c0ec0 8026791: wrong type_path encoded for method_return on an inner class constructor
Reviewed-by: jjg
2013-10-20 12:46:12 -07:00
Werner Dietl
84cadf2e45 8025109: Better encapsulation for AnnotatedType
Reviewed-by: jjg
2013-10-20 12:01:43 -07:00
Vicente Romero
027b935c1b 8024809: javac, some lambda programs are rejected by flow analysis
Reviewed-by: jjg, dlsmith
2013-10-19 17:43:09 +01:00
Bhavesh Patel
cee70e2272 8026567: Use meaningful style names for strong and italic styles
Reviewed-by: jjg
2013-10-18 16:34:42 -07:00
Jonathan Gibbons
cf30c20337 8026749: Missing LV table in lambda bodies
Reviewed-by: vromero, jlahoda
2013-10-18 15:03:34 -07:00
Joe Darcy
f8e08a9965 8026838: Fix new doclint issues in javax.annotation.processing
Reviewed-by: jjg
2013-10-17 19:10:19 -07:00
Lana Steuck
1761325728 Merge 2013-10-17 16:13:39 -07:00
Mandy Chung
1285dee32b 8015912: jdeps support to output in dot file format
8026255: Switch jdeps to follow traditional Java option style

Reviewed-by: alanb
2013-10-17 13:19:48 -07:00
Christine Lu
28cd7f48ee Added tag jdk8-b112 for changeset 96faa2507e3a 2013-10-17 09:41:12 -07:00
Matherey Nunez
c57660ca19 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest
Reviewed-by: jjg, jfranck
2013-10-17 13:50:00 +02:00
Matherey Nunez
7c6e4696ab 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final
Reviewed-by: jjg, jfranck
2013-10-17 13:27:36 +02:00
Eric McCorkle
b8aff04aa0 8026286: Improper locking of annotation queues causes assertion failures
8026063: Calls to annotate.flush() cause incorrect type annotations to be generated

Fix locking in ClassReader.java

Reviewed-by: jfranck
2013-10-16 16:33:04 -04:00
David Katleman
6c2816e717 Merge 2013-10-16 12:05:07 -07:00
Jonathan Gibbons
ef68cc1fc1 8026704: Build failure with --enable-debug
Reviewed-by: ksrini
2013-10-16 10:47:21 -07:00
Werner Dietl
e5c34a89eb 8026564: import changes from type-annotations forest
Co-authored-by: Steve Sides <steve.sides@oracle.com>
Reviewed-by: jjg
2013-10-15 15:57:13 -07:00
Jan Lahoda
912fc38c65 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
A mostly automated rename Annotate.Annotator->Annotate.Worker and enterAnnotation->run.

Reviewed-by: emc, jjg
2013-10-15 22:15:35 +02:00
Chris Hegarty
f5392a9718 Merge 2013-10-15 21:12:33 +01:00
Vicente Romero
1868655b89 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
Reviewed-by: jjg
2013-10-15 21:02:21 +01:00
Chris Hegarty
0fd34f307d Merge 2013-10-15 20:47:55 +01:00
Vicente Romero
53cc43916a 8025816: javac crash with method reference with a type variable as the site
Reviewed-by: jjg
2013-10-15 19:36:45 +01:00
Bhavesh Patel
99e02c21cd 8026370: javadoc creates empty <span class="italic"></span>
Reviewed-by: jjg
2013-10-15 11:20:27 -07:00
Jan Lahoda
52d83865b8 8026180: com.sun.source.tree.NewArrayTree refers to com.sun.tools.javac.util.List
Correcting import in NewArrayTree, adding test protecting againts improper types in API signatures

Reviewed-by: jjg
2013-10-15 16:23:18 +02:00
Chris Hegarty
95866e7e4f Merge 2013-10-15 14:17:11 +01:00
Jonathan Gibbons
0837163643 8025998: Missing LV table in lambda bodies
Reviewed-by: vromero
2013-10-14 23:07:43 -07:00
Jonathan Gibbons
31b34ce39c 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail
Reviewed-by: darcy
2013-10-14 22:34:37 -07:00
Jonathan Gibbons
fc85ec65d8 8026371: "tidy" issues in langtools/src/**/*.html files
Reviewed-by: darcy
2013-10-14 16:28:44 -07:00
Jan Lahoda
da21af58f4 8014016: javac is too late detecting invalid annotation usage
Adding new queue to Annotate for validation tasks, performing annotation validation during enter

Reviewed-by: jjg, emc, jfranck
2013-10-14 22:11:09 +02:00
Jonathan Gibbons
09523f2583 8026368: doclint does not report empty tags when tag closed implicitly
Reviewed-by: darcy
2013-10-14 12:38:09 -07:00
Chris Hegarty
0eadafa765 Merge 2013-10-11 19:05:18 +01:00
Jan Lahoda
958096d69b 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type
Reviewed-by: darcy, jfranck, jjg
2013-10-11 15:49:15 +02:00
Lana Steuck
7f8a6a5898 Merge 2013-10-11 03:09:42 -07:00
Robert Field
a8e63b82f1 8012557: Implement lambda methods on interfaces as private
8016320: Method reference in subinterface of type I.super::foo produces exception at runtime

Now that the VM supports interface instance private methods, lambda methods and lambda bridges are always private. Access is now through invokespecial.

Reviewed-by: vromero, jlahoda
2013-10-10 23:26:56 -07:00
Lana Steuck
aa4594456d Merge 2013-10-10 20:57:27 -07:00
Jonathan Gibbons
a29d963e53 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java
Reviewed-by: darcy
2013-10-10 17:13:32 -07:00
Eric McCorkle
a78344ba67 8008762: Type annotation on inner class in anonymous class show up as regular type annotations
8015257: type annotation with TYPE_USE and FIELD attributed differently if repeated
8013409: test failures for type annotations

Fixes to address some problems in type annotations

Reviewed-by: jfranck, jjg
2013-10-10 20:12:08 -04:00
Lana Steuck
fb3c32d988 Merge 2013-10-10 13:41:08 -07:00
Eric McCorkle
ad8c918fb1 8019461: Clean up javac diagnostics
7196553: Review error messages for repeating annotations

Changes to the diagnostic messages to improve clarity and JLS coherence

Reviewed-by: jjg
2013-10-10 13:55:41 -04:00
Bhavesh Patel
a7125b5d2e 8025633: Fix javadoc to generate valid anchor names
Reviewed-by: jjg
2013-10-10 10:51:15 -07:00
Christine Lu
67a4e0fd30 Added tag jdk8-b111 for changeset 9c619baa6191 2013-10-10 10:09:28 -07:00
Magnus Ihse Bursie
a706cda2ed 8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
2013-10-10 14:58:04 +02:00
Andreas Lundblad
3e4c0741c4 8021237: clean up JavacAnnotatedConstruct
Refactored the static helper methods in JavacAnnoConstructs into ordinary methods and put them in a common superclass (AnnoConstruct) of Symbol and Type.

Reviewed-by: jjg, vromero, jfranck
2013-10-10 08:51:55 +02:00
Jan Lahoda
5ec0ba7c47 8025087: Annotation processing api returns default modifier for interface static method
ClassReader must not set Flags.DEFAULT for interface static methods

Reviewed-by: vromero, jjg
2013-10-09 13:09:31 +02:00
Jan Lahoda
7de3ec870d 8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Should not generate non-public $assertionsDisabled field into interfaces

Reviewed-by: jjg, vromero
2013-10-09 13:06:49 +02:00
Lana Steuck
33306e57d3 Merge 2013-10-08 14:59:46 -07:00
Andreas Lundblad
f6875dad27 8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Fixed precedence and associativity issues with pretty printing of JCConditional expressions.

Co-authored-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: jfranck
2013-10-08 15:33:28 +02:00
Joe Darcy
640945b6f3 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer
Reviewed-by: jjg
2013-10-07 16:51:56 -07:00
Steve Sides
03c9c56f88 8005542: jtreg test OverrideBridge.java contains @ignore
Reviewed-by: jjg
2013-10-04 16:23:05 -07:00
Kumar Srinivasan
74d2e71e10 8003537: javap use internal class name when printing bound of type variable
Reviewed-by: jjg
2013-10-04 16:08:18 -07:00
Jonathan Gibbons
bb2e47a5f4 8025970: Spurious characters in JavaCompiler
Reviewed-by: ksrini
2013-10-04 15:24:42 -07:00
Jonathan Gibbons
6995b57041 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode
Reviewed-by: darcy
2013-10-04 14:46:46 -07:00
Jonathan Gibbons
be225c4b49 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor
Reviewed-by: darcy
2013-10-04 13:59:13 -07:00
Bhavesh Patel
b10f820519 8024756: method grouping tabs are not selectable
Reviewed-by: jjg
2013-10-04 13:41:13 -07:00
Bhavesh Patel
7ad9444ac1 8008164: Invisible table captions in javadoc-generated html
Reviewed-by: jjg
2013-10-04 13:32:30 -07:00
Joe Darcy
e18872a5a9 8025913: Rename jdk.Supported to jdk.Exported
Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg
2013-10-04 10:00:28 -07:00