782 Commits

Author SHA1 Message Date
Pengfei Li
0bbe064c1b 8263354: Accumulated C2 code cleanups
Reviewed-by: thartmann, redestad
2021-03-12 09:41:11 +00:00
Rahul Raghavan
4b5be40ab9 8238812: assert(false) failed: bad AD file
Reviewed-by: thartmann, chagedorn, roland
2021-03-10 15:59:38 +00:00
Eric Liu
23ee60d1b7 8261008: Optimize Xor
Reviewed-by: thartmann, kvn
2021-03-06 08:52:35 +00:00
Roland Westrelin
2c0507ecd6 8261812: C2 compilation fails with assert(!had_error) failed: bad dominance
Reviewed-by: kvn, thartmann
2021-03-05 15:43:24 +00:00
Jie Fu
d91550efad 8262998: Vector API intrinsincs should not modify IR when bailing out
Reviewed-by: thartmann, vlivanov
2021-03-05 05:57:30 +00:00
Kuai Wei
f56c91860c 8262837: handle split_USE correctly
Reviewed-by: kvn
2021-03-04 18:20:57 +00:00
Roberto Castañeda Lozano
4cfecceb04 8261730: C2 compilation fails with assert(store->find_edge(load) != -1) failed: missing precedence edge
Relax assertion in PhaseCFG::verify() to accept the case where a store is used
to implement an implicit null check and a load is placed in the null block.

Reviewed-by: thartmann, kvn
2021-03-04 07:48:51 +00:00
Lutz Schmidt
268d9b7982 8261447: MethodInvocationCounters frequently run into overflow
Reviewed-by: thartmann, mdoerr, kvn, iveresov
2021-03-03 20:04:31 +00:00
Tobias Hartmann
54dfd79cda 8262256: C2 intrinsincs should not modify IR when bailing out
Reviewed-by: roland, kvn
2021-03-03 11:30:52 +00:00
Roland Westrelin
6baecf39d5 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
Reviewed-by: kvn, jvernee, vlivanov
2021-03-01 15:11:25 +00:00
Roland Westrelin
20c93b3b90 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload
Reviewed-by: kvn, shade
2021-03-01 08:47:59 +00:00
Roland Westrelin
ddd550ae84 8261308: C2: assert(inner->is_valid_counted_loop(T_INT) && inner->is_strip_mined()) failed: OuterStripMinedLoop should have been removed
Reviewed-by: chagedorn, kvn
2021-03-01 08:42:10 +00:00
Xin Liu
7603278164 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
Reviewed-by: thartmann
2021-02-26 10:46:43 +00:00
Tobias Hartmann
a83e802bce 8262299: C2 compilation fails with "modified node was not processed by IGVN.transform_old()"
Reviewed-by: roland, chagedorn
2021-02-25 08:53:27 +00:00
Eric Liu
382e38dd24 8256438: AArch64: Implement match rules with ROR shift register value
Reviewed-by: aph, roland
2021-02-24 09:49:53 +00:00
Roland Westrelin
8a2f58907c 8260637: Shenandoah: assert(_base == Tuple) failure during C2 compilation
Reviewed-by: chagedorn, kvn
2021-02-23 16:35:15 +00:00
Aleksey Shipilev
e9f3aab7f4 8261912: Code IfNode::fold_compares_helper more defensively
Reviewed-by: kvn, thartmann
2021-02-18 15:51:45 +00:00
Nils Eliasson
3a21e1df70 8260653: Unreachable nodes keep speculative types alive
Reviewed-by: vlivanov, thartmann
2021-02-18 10:22:20 +00:00
Roberto Castañeda Lozano
16bd7d381f 8261336: IGV: enhance default filters
Add filters to color and hide parts of the graph based on node categories or
estimated execution frequency, and simplify remaining filters.

Co-authored-by: Christian Hagedorn <chagedorn@openjdk.org>
Reviewed-by: vlivanov, chagedorn, thartmann
2021-02-16 12:47:56 +00:00
Ioi Lam
235da6aa04 8261672: Reduce inclusion of classLoaderData.hpp
Reviewed-by: lfoltan, coleenp
2021-02-13 07:13:22 +00:00
Christian Hagedorn
0a89987a96 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
Reviewed-by: roland, kvn, thartmann
2021-02-11 13:00:10 +00:00
Vladimir Ivanov
3ede231dec 8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements
Reviewed-by: kvn, thartmann
2021-02-11 10:16:09 +00:00
Pengfei Li
7a2db858e0 8261022: Fix incorrect result of Math.abs() with char type
Reviewed-by: thartmann, neliasso
2021-02-07 01:15:24 +00:00
Jesper Wilhelmsson
d7acfae3d2 Merge 2021-02-06 00:29:45 +00:00
Roland Westrelin
4de3a6be9e 8260709: C2: assert(false) failed: unscheduable graph
Reviewed-by: thartmann, chagedorn
2021-02-04 15:11:25 +00:00
Jesper Wilhelmsson
9b7a8f1982 Merge 2021-02-04 02:06:33 +00:00
Ioi Lam
ffbcf1b0a7 8260471: Change SystemDictionary::X_klass calls to vmClasses::X_klass
Reviewed-by: lfoltan, hseigel, dholmes, stuefe
2021-02-02 23:40:29 +00:00
Tobias Hartmann
fe407cf1b6 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
Reviewed-by: kvn, roland, chagedorn
2021-02-02 07:23:55 +00:00
Vladimir Kozlov
02d586e13e 8259398: Super word not applied to a loop with byteArrayViewVarHandle
Reviewed-by: vlivanov, thartmann, chagedorn
2021-02-01 15:48:10 +00:00
Christian Hagedorn
aec037721c 8257498: Remove useless skeleton predicates
Reviewed-by: roland, thartmann
2021-02-01 09:39:31 +00:00
casparcwang
0fdf9cdd3a 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled
Co-authored-by: Stuart Monteith <smonteith@openjdk.org>
Co-authored-by: Wang Chao <casparcwang@tencent.com>
Reviewed-by: vlivanov, neliasso
2021-02-01 01:28:31 +00:00
Vladimir Kozlov
6415d3b82b 8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)
Reviewed-by: shade
2021-01-29 16:16:14 +00:00
Igor Veresov
1519632597 8251462: Simplify compilation policy
Reviewed-by: cjplummer, kvn
2021-01-28 20:51:12 +00:00
Vladimir Kozlov
1926765f5e 8253353: Crash in C2: guarantee(n != NULL) failed: No Node
Co-authored-by: Fei Yang <fyang@openjdk.org>
Reviewed-by: vlivanov, neliasso
2021-01-28 16:16:51 +00:00
Roland Westrelin
11d6467c50 8260407: cmp != __null && cmp->Opcode() == Op_CmpL failure with -XX:StressLongCountedLoop=200000000 in lucene
Reviewed-by: thartmann, kvn
2021-01-28 12:27:40 +00:00
Ioi Lam
396a496f3c 8260467: Move well-known classes from systemDictionary.hpp to vmClasses.hpp
Reviewed-by: dholmes, coleenp
2021-01-28 04:24:04 +00:00
Jesper Wilhelmsson
62ffe75b1f Merge 2021-01-28 03:38:32 +00:00
Jesper Wilhelmsson
c52212b146 Merge 2021-01-27 20:56:26 +00:00
Roberto Castañeda Lozano
f353fcf256 8258894: C2: Forbid GCM to move stores into loops
Prevent GCM from placing memory-writing nodes (such as stores) into loops deeper
than their home loop (determined by their control input). Such placements are
invalid, as they cause memory definitions to interfere, and risk causing
miscompilations. This change complements JDK-8255763, which only addresses
invalid placements in irreducible CFGs.

Add control input to stores in generated stubs to ensure that all memory-writing
nodes have control inputs from which their home block can be derived.

Add a battery of simplified fuzzer test cases where, before this change, GCM
moves stores into deeper loops.

Reviewed-by: thartmann, kvn
2021-01-27 15:08:39 +00:00
Vladimir Ivanov
e28e11119d 8260370: C2: LoopLimit node is not eliminated
Reviewed-by: kvn, thartmann
2021-01-27 10:29:59 +00:00
Thomas Stuefe
1c77046811 8260404: jvm_io.h include missing in a number of files
Reviewed-by: shade, iklam, dholmes
2021-01-27 07:34:46 +00:00
Xin Liu
19b6f61bd2 8260334: Remove deprecated sv_for_node_id() from Compile
Reviewed-by: neliasso, chagedorn, thartmann, phh
2021-01-26 20:52:19 +00:00
Vladimir Ivanov
81e730e5f1 8259276: C2: Empty expression stack when reexecuting tableswitch/lookupswitch instructions after deoptimization
Reviewed-by: dlong, kvn, thartmann
2021-01-25 20:02:56 +00:00
Christian Hagedorn
c5ab7c3214 8260284: C2: assert(_base == Int) failed: Not an Int
Reviewed-by: thartmann, kvn
2021-01-25 17:09:52 +00:00
Thomas Stuefe
ca20c63c04 8259710: Inlining trace leaks memory
Reviewed-by: thartmann, neliasso
2021-01-25 10:50:39 +00:00
Yasumasa Suenaga
09489e28bd 8260338: Some fields in HaltNode is not cloned
Reviewed-by: xliu, neliasso, thartmann
2021-01-25 09:12:49 +00:00
Dan Lemmond
7be9113b1c 8255216: Change _directive->BreakAtCompileOption to env()->break_at_compile()
Reviewed-by: kvn, phh
2021-01-22 20:33:44 +00:00
Jesper Wilhelmsson
a1a851b6db Merge 2021-01-19 05:43:27 +00:00
Xin Liu
533a2d398b 8258961: move some fields of SafePointNode from public to protected
Reviewed-by: thartmann, kvn
2021-01-18 22:34:05 +00:00
Roman Kennke
e60c992699 8259849: Shenandoah: Rename store-val to IU-barrier
Reviewed-by: zgu, shade
2021-01-18 15:29:54 +00:00