Commit Graph

180 Commits

Author SHA1 Message Date
Jan Lahoda
61e44cdb6a 8247932: JShell crashes when typing text block
Setting up Log before running javac's scanner, so that errors reported from the scanner are properly ignored.

Reviewed-by: rfield
2020-06-22 12:03:11 +02:00
Goetz Lindenmaier
bf1e6903a2 8233014: Enable ShowCodeDetailsInExceptionMessages by default
Reviewed-by: coleenp, stuefe, dholmes
2020-06-18 22:03:18 +02:00
Jan Lahoda
358714bcd0 8246353: Sealed types not supported by jshell
Reviewed-by: rfield, vromero
2020-06-08 16:59:43 +02:00
Jan Lahoda
3beee2cd93 8242919: Paste locks up jshell
Not waiting until the full block is available while reading from input.

Reviewed-by: rfield
2020-05-08 09:16:12 +02:00
Jan Lahoda
1a35219f01 8243557: Inconvenient span for multi-catch error diagnostics
Reviewed-by: vromero
2020-05-04 12:28:35 +02:00
Jan Lahoda
f08b5a8006 8241950: JShell could support auto-indent
Reviewed-by: rfield
2020-04-20 12:36:09 +02:00
Athijegannathan Sundararajan
b09a8ee657 8242931: Few more tests that use nashorn have been missed
Reviewed-by: dfuchs, dholmes
2020-04-17 09:50:02 +05:30
Jan Lahoda
e44dcf09c0 8234896: Tab completion does not work for method references in jshell
Reviewed-by: rfield
2020-03-04 13:43:28 +01:00
Jan Lahoda
acd2d32913 8239536: Can't use java.util.List object after importing java.awt.List
Using full qualified names for synthetic types; ensuring the user is warned when a variable becomes undefined due to a dependency change.

Reviewed-by: rfield
2020-02-24 11:43:04 +01:00
Mikael Vidstedt
3318314c7c 8237589: Fix copyright header formatting
Reviewed-by: jjg, serb, iris, jwilhelm
2020-01-21 14:23:01 -08:00
Jan Lahoda
6fc159f17c 8236715: JShell: Records with errors are not properly corraled
Correctly corralling record classes, and providing correct messages to the user.

Reviewed-by: rfield, vromero
2020-01-13 10:49:58 +01:00
Robert Field
dca6e34397 8210527: JShell: NullPointerException in jdk.jshell.Eval.translateExceptionStack
8232855: jshell missing word in /help help

Reviewed-by: jlahoda
2019-12-11 14:39:04 -08:00
Jan Lahoda
308aea3e0b 8235474: JShell does not handle records properly
Reviewed-by: vromero, rfield
2019-12-11 13:08:42 +01:00
Vicente Romero
827e5e3226 8225054: Compiler implementation for records
8225052: javax.lang.model support for records
8225053: Preview APIs support for records
8225055: Javadoc for records
8226314: com.sun.source support for records
8227113: Specification for java.lang.Record
8233526: JVM support for records

Implement records in the compiler and the JVM, including serialization, reflection and APIs support

Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Co-authored-by: Harold Seigel <harold.seigel@oracle.com>
Co-authored-by: Joe Darcy <joe.darcy@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: mcimadamore, briangoetz, alanb, darcy, chegar, jrose, jlahoda, coleenp, dholmes, lfoltan, mchung, sadayapalam, hannesw, sspitsyn
2019-12-04 15:57:39 -05:00
Robert Field
6fe98143bc 8200701: jdk/jshell/ExceptionsTest.java fails on Windows, after JDK-8198801
8159740: JShell: corralled declarations do not have correct source to wrapper mapping
8212167: JShell : Stack trace of exception has wrong line number

Build corralled (recoverable undeclared definitions) declarations from position translating wraps....

Reviewed-by: jlahoda
2019-06-14 20:30:10 -07:00
Toshio Nakamura
0f42d9870e 8224184: jshell got IOException at exiting with AIX
Reviewed-by: rfield, jlahoda
2019-06-13 08:42:47 +02:00
Jan Lahoda
1d050ec2e9 8223782: jshell parser should handle Text Blocks
Completion analysis should detect text blocks properly.

Reviewed-by: jlaskey, rfield
2019-06-07 10:09:41 +02:00
Robert Field
4bc1fdf83c 8199623: JShell: corralling not restored on drop
Reviewed-by: jlahoda
2019-06-03 08:21:04 -07:00
Robert Field
0be741c70b 8223688: JShell: crash on the instantiation of raw anonymous class
Reviewed-by: jlahoda
2019-06-01 14:09:59 -07:00
Robert Field
50971d6ea7 8080353: JShell: Better error message on attempting to add default method
Special handling for errors with "default" modifier

Reviewed-by: jlahoda
2019-06-01 13:41:01 -07:00
Jan Lahoda
55e1da1813 8221759: Crash when completing \"java.io.File.path\"
Do not provide documentation for inaccessible elements.

Reviewed-by: rfield
2019-05-09 11:58:26 +02:00
Jim Laskey
11b29c8de1 8215681: Remove compiler support for Raw String Literals from JDK 12
Reviewed-by: mcimadamore, jlahoda, sundar
2019-01-09 11:13:00 -04:00
Jan Lahoda
c526b4b225 8215438: jshell tool: Ctrl-D causes EOF
Properly handling EndOfFileException so that jshell can be closed with Ctrl-D.

Reviewed-by: rfield
2019-01-08 16:31:27 +01:00
Robert Field
2ebc9f99e5 8215099: jshell tool: /help representation of ctrl/meta characters inconsistent
Reviewed-by: jlahoda
2018-12-15 17:13:39 -08:00
Jan Lahoda
cc116b1259 8214491: Upgrade to JLine 3.9.0
Upgrading JLine to 3.9.0 and updating jshell and jjs to the new JLine.

Reviewed-by: rfield, sundar
2018-12-11 11:29:28 +01:00
Vicente Romero
9846588b31 8210031: implementation for JVM Constants API
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: jrose, mcimadamore, darcy, mchung, rriggs, dholmes, forax
2018-12-09 12:36:24 -05:00
Robert Field
020877da03 8213725: JShell NullPointerException due to class file with unexpected package
Reviewed-by: jlahoda
2018-11-29 17:45:29 -08:00
Robert Field
37ef084d73 8210808: jshell tool: only considers the first snippet of the external editor
Reviewed-by: jlahoda, sundar
2018-10-29 08:34:33 -07:00
Robert Field
0d815c2677 8211694: JShell: Redeclared variable should be reset
Reviewed-by: sundar
2018-10-24 21:17:30 -07:00
Robert Field
dafc483475 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'
Reviewed-by: jlahoda
2018-10-22 09:26:50 -07:00
Robert Field
749916b897 8210923: JShell: support for switch expressions
Reviewed-by: jlahoda
2018-10-22 08:30:39 -07:00
Robert Field
f4e1502e03 8210596: jshell does not support raw string literals
Reviewed-by: jlahoda, jlaskey
2018-09-17 08:37:47 -07:00
Jan Lahoda
b3b644438e 8206986: Compiler support for Switch Expressions (Preview)
8207405: Compiler Tree API support for Switch Expressions (Preview)

Support for switch expression, switch with rules and multiple constants for cases.

Reviewed-by: jjg, mcimadamore, vromero
2018-08-29 09:36:17 +02:00
Joe Darcy
90518f0635 8028563: Remove javac support for 6/1.6 source and target values
Reviewed-by: jjg, erikj, henryjen
2018-07-12 14:13:15 -07:00
Jan Lahoda
152488eeee 8205913: Inconsistent source code model
Ensuring variable declarations have non-null modifiers and names.

Reviewed-by: mcimadamore
2018-06-28 10:05:43 +02:00
David Holmes
95bf19563b 8010319: Implementation of JEP 181: Nest-Based Access Control
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Maurizio Mimadamore <maurizio.mimadamore@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Tobias Hartmann <tobias.hartmann@oracle.com>
Co-authored-by: Vlaidmir Ivanov <vladimir.x.ivanov@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Vladimir Kozlov <vladimir.kozlov@oracle.com>
Co-authored-by: John Rose <john.r.rose@oracle.com>
Co-authored-by: Daniel Smith <daniel.smith@oracle.com>
Co-authored-by: Serguei Spitsyn <serguei.spitsyn@oracle.com>
Co-authored-by: Kumar Srinivasan <kumardotsrinivasan@gmail.com>
Co-authored-by: Boris Ulasevich <boris.ulasevich@bell-sw.com>
Reviewed-by: alanb, psandoz, mchung, coleenp, acorn, mcimadamore, forax, jlahoda, sspitsyn, abuckley
2018-06-23 01:32:41 -04:00
Jan Lahoda
aabea5d599 8203827: Upgrade JLine to 2.14.6
Reviewed-by: alanb, hannesw, rfield
2018-06-01 13:04:30 +02:00
Chris Yin
7166041796 8202690: jdk/jshell/ToolBasicTest.java failed in testOpenFileOverHttp() and testOpenLocalFileUrl()
Reviewed-by: rfield, jlahoda
2018-05-08 09:51:42 +08:00
Joe Darcy
42c3c3b5f7 8202599: Mark intermittently failing jshell tests
Reviewed-by: rfield
2018-05-05 09:34:01 -07:00
Michal Vala
1e0c45b250 8199912: jshell tool: /open from URI
Reviewed-by: rfield
2018-05-04 23:19:10 -07:00
Robert Field
ac44a19694 8199193: jshell tool: Add support for preview features
Reviewed-by: sundar
2018-04-23 09:01:03 -07:00
Robert Field
4ecc488704 8198801: JShell: user exception chained cause not retained
Reviewed-by: jlahoda
2018-04-03 13:27:58 -07:00
Shinya Yoshida
4b6cd06e3d 8199762: JShell API: Failed to detect override when snippet to be overridden has been changed before
Reviewed-by: rfield
2018-03-24 14:43:04 +09:00
Phil Race
d2e6289c0b Merge 2018-02-26 10:36:34 -08:00
Robert Field
4aa85f9489 8196133: JShell crashes when attempting to use bad source file in class path
Reviewed-by: jlahoda
2018-02-16 16:18:55 -08:00
Robert Field
b2ed2bda60 8198573: JShell: class replace loses instances
Reviewed-by: jlahoda
2018-02-23 10:49:56 -08:00
Robert Field
f23f23fc76 8166232: jshell tool: cannot access previous history
Reviewed-by: jlahoda
2018-02-23 10:25:22 -08:00
Robert Field
004b22e401 8176474: test/jdk/jshell/JdiBogusHostListenExecutionControlTest.java fails with java.net.BindException
Reviewed-by: jlahoda
2018-02-22 12:26:01 -08:00
Jan Lahoda
ddf6846500 8197439: Crash with -XDfind=lambda for anonymous class in anonymous class
Ensuring unresolvable anonymous classes are attributed.

Reviewed-by: mcimadamore, sadayapalam
2018-02-21 17:07:12 +01:00
Jan Lahoda
46051a71c6 8195789: Building of test/langtools/jdk/jshell/VariablesTest.java may fail
Adding proper @modules tag.

Reviewed-by: vromero
2018-01-19 21:05:23 +01:00
Jan Lahoda
e332323760 8191842: JShell: Inferred type information is lost when assigning types to a \"var\"
For vars, upgrading all anonymous classes to member classes; stripping intersection types from fields before writing.

Reviewed-by: rfield
2018-01-19 17:11:52 +01:00
Goetz Lindenmaier
22762d1cdc 8189102: All tools should support -?, -h and --help
Reviewed-by: kvn, jjg, weijun, alanb, rfield, ksrini
2018-01-16 08:48:34 +01:00
Robert Field
e1069d367d 8179858: jshell tool: sync nomenclature from reference to online /help
Reviewed-by: dlsmith, jjg
2017-12-19 11:37:00 -08:00
Robert Field
9ecafd93f5 8188894: jdk/jshell/ToolShiftTabTest.java failed with IllegalStateException
Reviewed-by: jlahoda
2017-12-13 14:21:12 -08:00
Phil Race
4b727d4f18 Merge 2017-12-13 10:25:38 -08:00
Robert Field
c1d0d6d51d 8162989: jshell tool: /edit with external editor leaks files in /tmp
Reviewed-by: jlahoda
2017-12-11 21:56:34 -08:00
Phil Race
ee9c644643 Merge 2017-12-11 10:08:51 -08:00
Robert Field
e08ffc05d9 8192863: jshell tool: /<id><tab> gives "No such command"
Reviewed-by: jlahoda
2017-12-07 13:23:18 -08:00
Jan Lahoda
17b766fb1d 8191636: [Windows] jshell tool: Wrong character in /env class-path command crashes jshell
Fixing handling of invalid paths.

Reviewed-by: rfield
2017-12-13 11:27:28 +01:00
Robert Field
5252da0f37 8192979: jshell tool: Online help text for commands is confusing
Reviewed-by: jlahoda
2017-12-05 11:04:42 -08:00
Robert Field
3d3780d2e8 8191455: jdk/jshell/StartOptionTest.java and jdk/jshell/ToolProviderTest.java failed after changeset e0f08a
8191456: jdk/jshell/ExternalEditorTest.java testStatementMush() failure

Reviewed-by: jlahoda
2017-12-04 17:15:38 -08:00
Maurizio Cimadamore
686d74f11e 8189749: Devise strategy for making source level checks more uniform
Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation

Reviewed-by: jjg, jlahoda
2017-12-04 17:54:49 +00:00
Jan Lahoda
9f07305ab6 8189248: Jshell: error with mutually dependent snippets, when one must be replaced
Ensuring proper imports are generated for mutually dependent snippets if one of them is replaced.

Reviewed-by: rfield
2017-12-07 19:24:27 +01:00
Phil Race
625c3fd013 Merge 2017-11-29 09:47:02 -08:00
Maurizio Cimadamore
3534ed0379 8191802: Upward projection result is A<? extends Number> instead of A<? super Integer>
Code in Types.TypeProjection doesn't match the latest spec text

Reviewed-by: vromero
2017-11-29 17:31:23 +00:00
Phil Race
586b13cdb6 Merge 2017-11-29 09:07:01 -08:00
Phil Race
dcaa7f90ba Merge 2017-11-27 10:35:05 -08:00
Jan Lahoda
9bb2c5a0b3 8133616: compiler error messages for dup single type, single static import switched
When reporting clashing imports, use the (non-)staticness of the original import to generate the error message.

Reviewed-by: mcimadamore
2017-11-27 19:29:00 +01:00
Robert Field
c942c5de6b 8190939: JShell: gives a compiler error evaluating an expression of inaccessible type
Reviewed-by: jlahoda
2017-11-24 16:55:18 -08:00
Jan Lahoda
fea6c39ce2 8178109: More useful documentation on /help
For /help <command/subject>, show the help for the command/subject directly.

Reviewed-by: rfield
2017-11-23 19:44:13 +01:00
Robert Field
c0689879a7 8177076: jshell tool: allow non-zero /exit
8190383: JShell API: no way for the jshell tool to report exit status to provider

Reviewed-by: jlahoda
2017-11-14 19:33:37 -08:00
Robert Field
846d6be95c 8172154: jshell tool: make all IMPORTS.jsh generated at build time
Reviewed-by: jlahoda
2017-11-14 10:45:22 -08:00
Phil Race
158e69f6ec Merge 2017-11-03 09:56:02 -07:00
Robert Field
022c618af9 8188072: JShell: NPE in SourceCodeAnalysis.completionSuggestions()
Reviewed-by: jlahoda
2017-11-02 11:09:28 -07:00
Robert Field
7ce7347fd2 8179856: jshell tool: not suitable for pipeline use
8186708: jshell tool: bad load file garbles message and does not abort

Reviewed-by: jlahoda
2017-10-24 20:33:36 -07:00
Robert Field
19fbc4c08c 8187359: JShell: Give comprehensible error when user method name matches Object method
Reviewed-by: jlahoda
2017-10-20 19:08:25 -07:00
Jan Lahoda
a36938e082 8188225: AST could be improved in presence of var types
Adding a better start pos for vars; always adding a synthetic type tree to vars.

Reviewed-by: mcimadamore
2017-10-06 17:18:03 +02:00
Maurizio Cimadamore
c825188cd8 8177466: Add compiler support for local variable type-inference
Add support for 'var' in implicitly typed local variable declarations

Reviewed-by: vromero, jlahoda
2017-09-26 12:52:53 +01:00
Erik Joelsson
3789983e89 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2017-09-12 19:03:39 +02:00
Jan Lahoda
e44c7feff9 8189595: jshell tool: line redrawn on each completion
Reviewed-by: rfield
2017-11-02 10:09:34 +01:00