190 Commits

Author SHA1 Message Date
Priya Lakshmi Muthuswamy
c31576193a 8057647: javac parser needs updates to have better error recovery for error cases of new array creation with dimensions
Reviewed-by: jlahoda
2017-07-19 11:44:08 +05:30
Priya Lakshmi Muthuswamy
9efc4c1a60 8074364: Update error message for incorrect annotation type declaration
Issue a more direct, specific error when an annotation type is declared where it is disallowed

Reviewed-by: sadayapalam
2017-07-12 12:27:57 +05:30
Priya Lakshmi Muthuswamy
9797f94e75 8068836: Error message should be updated when Override is used with static methods
Issue a more direct, specific error when @Override annotation is used with a static method

Reviewed-by: sadayapalam
2017-07-03 12:58:30 +05:30
Vicente Romero
dacae3939b 8182747: javac crashes on bad annotation value
Reviewed-by: mcimadamore
2017-06-29 07:19:44 -07:00
Priya Lakshmi Muthuswamy
965530668b 8058408: Compiler should emit a clearer message for invalid parenthesized expression
Reviewed-by: sadayapalam
2017-06-27 15:30:21 +05:30
Lana Steuck
01d2ec7fcd Merge 2017-06-24 00:32:07 +00:00
Alan Bateman
6dc7b17106 8181087: Module system implementation refresh (6/2017)
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2017-06-16 09:21:38 -07:00
Vicente Romero
bfe58ed881 8181464: Invalid lambda in annotation causes NPE in Lint.augment
Reviewed-by: mcimadamore
2017-06-13 11:21:09 -07:00
Jan Lahoda
f417779f87 8178152: Handling of incubating modules, the jdk.unsupported module and --add-exports with --release <current>
--release 9 should only allow documented modules; --add-exports/--add-reads/--patch-module should not be allowed on system modules when --release 9 is used.

Reviewed-by: jjg, erikj, ihse
2017-05-12 06:42:37 +02:00
Jonathan Gibbons
4a269851c9 8176327: javac produces wrong module-info
8178518: Add method JavaFileManager.contains

Reviewed-by: jlahoda
2017-04-24 14:59:43 -07:00
Jan Lahoda
d38fa28ac9 8178011: Automatic module warnings
Adding lints for automatic modules in requires and requires transitive directives.

Reviewed-by: jjg
2017-04-10 11:08:59 +02:00
Alan Bateman
481f056ca9 8177530: Module system implementation refresh (4/2017)
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2017-04-07 08:08:26 +00:00
Jan Lahoda
d60b98466f 8175057: module-info on patch path should not produce an error
Allowing module-infos on patch paths during compilation.

Reviewed-by: jjg, ksrini
2017-03-14 07:11:45 +01:00
Vicente Romero
48b3288060 8174243: incorrect error message for nested service provider
Reviewed-by: jjg, jlahoda
2017-02-14 15:45:17 -08:00
Jan Lahoda
261ce92be5 8173777: Merge javac -Xmodule into javac--patch-module
Merging -Xmodule: functionality into --patch-module.

Reviewed-by: jjg, mchung, rfield
2017-02-13 09:37:26 +01:00
Jonathan Gibbons
0fcd98980c 8174104: Compiler does not allow non-existent module path entry
Reviewed-by: jlahoda
2017-02-10 15:42:17 -08:00
Jonathan Gibbons
f4c670d9b6 8172901: javac: 'opens' statement cannot specify non observable package
Reviewed-by: jlahoda
2017-02-06 12:35:13 -08:00
Srikanth Adayapalam
d6090047be 8166420: Confusing error message when reading bad module declaration
Reviewed-by: jlahoda
2017-02-06 18:14:51 +05:30
Jonathan Gibbons
02431ac603 8172807: Javac doesn't report errors on duplicate provides with different service implementations
Reviewed-by: jlahoda
2017-02-02 14:34:21 -08:00
Jonathan Gibbons
16d379dad4 8165102: incorrect message from javac
Reviewed-by: vromero
2017-01-19 15:12:59 -08:00
Jan Lahoda
c2d9172419 8169197: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2017-01-11 10:59:57 +01:00
Alan Bateman
2381943e61 8170987: Module system implementation refresh (12/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Srikanth Adayapalam <srikanth.adayapalam@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Reviewed-by: mcimadamore
2016-12-16 05:47:58 +00:00
Alan Bateman
01a366e6dd Merge 2016-12-01 11:16:45 +00:00
Alan Bateman
22e233b2e9 8169069: Module system implementation refresh (11/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: mcimadamore, jjg, mchung, anazarov
2016-12-01 09:02:42 +00:00
Jonathan Gibbons
6e31f6440f 8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung
2016-11-22 15:57:32 -08:00
Maurizio Cimadamore
57bee7c4b9 8169093: Generics, javac not matching actual and formal arguments
Make diagnostic for type-args arity mismatch consistent with the class case

Reviewed-by: vromero
2016-11-07 16:08:18 +00:00
Maurizio Cimadamore
9b0354380e 8168854: javac erroneously reject a a service interface inner class in a provides clause
Java SE 9 proposed spec changes do not explicitly forbid a service interface to be an inner class - javac should follow

Reviewed-by: jjg
2016-11-07 11:16:23 +00:00
Jonathan Gibbons
e781b9f262 8167975: align javac --add-* modules options with launcher
Reviewed-by: jlahoda
2016-11-03 13:59:15 -07:00
Jan Lahoda
7cffceb22f 8169074: Build is failing after JDK-8166538
Reverting d7c9720c4223

Reviewed-by: darcy
2016-11-02 20:21:45 +01:00
Jan Lahoda
5daafbe43b 8166538: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2016-11-02 16:48:57 +01:00
Jonathan Gibbons
a60ef42892 8145471: javac changes for enhanced deprecation
Reviewed-by: smarks, tbell, mcimadamore, jlahoda
2016-10-20 13:44:51 -07:00
Vicente Romero
d130403704 8026721: Enhance Lambda serialization
Reviewed-by: jjg, briangoetz
2016-03-02 18:25:01 -05:00
Jan Lahoda
6a0ceb74e8 8153362: Add javac -Xlint warning to list exposed types which are not accessible
Adding implementation to -Xlint:exports, to warn about exposing inaccessible types in API

Reviewed-by: jjg
2016-10-06 14:03:58 +02:00
Vicente Romero
29aa24a3c1 8162546: change hidden options -Xdebug to --debug, -XshouldStop to --should-stop, and -diags to --diags
Reviewed-by: mcimadamore
2016-09-06 17:04:43 -07:00
Mandy Chung
2a62da3a63 8165109: langtools/test switches to use new CLI options
Reviewed-by: jjg, amlu
2016-08-30 20:49:41 -07:00
Jonathan Gibbons
1386ffb4f2 8164887: update tests to remove use of old-style options
Reviewed-by: mchung
2016-08-26 15:54:36 -07:00
Srikanth Adayapalam
8513d8d26f 8157519: Error messages when compiling a malformed module-info.java confusing
Reviewed-by: jjg
2016-08-16 09:13:33 +05:30
Srikanth Adayapalam
37028f8abc 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
Reviewed-by: mcimadamore, ksrini
2016-08-12 11:49:18 +05:30
Jonathan Gibbons
978417c4c7 8136930: Simplify use of module-system options by custom launchers
8160489: Multiple -Xpatch lines ignored by javac
8156998: javac should support new option -XinheritRuntimeEnvironment

Reviewed-by: jlahoda, ksrini
2016-08-10 15:47:46 -07:00
Vicente Romero
8480651475 8161019: javac, fold formatter options
Reviewed-by: mcimadamore, jjg
2016-07-26 07:45:29 -07:00
Vicente Romero
bec16625dc 8153407: javac, fold debug options
Reviewed-by: mcimadamore, jjg
2016-07-08 16:47:13 -07:00
Vicente Romero
8d93dc2a15 8152062: obscure error message for bad 'provides'
Reviewed-by: jjg
2016-05-31 13:00:17 -04:00
Srikanth Adayapalam
34b3d6385e 8154997: Add examples for jigsaw diagnostics
Reviewed-by: jjg, jlahoda
2016-05-18 11:38:20 +05:30
Maurizio Cimadamore
7fa26cbc1e 8153884: Expression lambda erroneously compatible with void-returning descriptor
Fix lambda compatibility check for void returning expressions

Reviewed-by: vromero
2016-05-16 13:05:42 +01:00
Andreas Lundblad
9691505077 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
Javac no longer issues warnings for missing serialVersionUID in anonymous classes.

Reviewed-by: jlahoda
2016-04-18 22:25:50 +02:00
Andreas Lundblad
e449ba161c 8027999: Poorly worded error message when attempting to assign to this
Changed the error message when trying to assign to this.

Reviewed-by: jjg
2016-03-23 13:39:15 +01:00
Alan Bateman
001ebb3a72 8142968: Module System implementation
Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282

Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Co-authored-by: Andreas Lundblad <andreas.lundblad@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Kumar Srinivasan <kumar.x.srinivasan@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jjg, jlahoda, vromero, mcimadamore, bpatel, ksrini, darcy, anazarov, dfuchs
2016-03-17 19:04:28 +00:00
Srikanth Adayapalam
433d2a7dbb 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
Reviewed-by: mcimadamore
2016-03-03 06:10:58 +05:30
Vicente Romero
0698afcea9 8149600: javac, remove unused options, step 2
Reviewed-by: jjg, mcimadamore
2016-02-22 16:17:25 -08:00
Vicente Romero
286b0caa6c 8148808: javac, remove unused options, step 1
Reviewed-by: mcimadamore, jjg
2016-02-10 15:11:40 -08:00