108 Commits

Author SHA1 Message Date
Jan Lahoda
77897a9a41 8182450: javac aborts when generating ct.sym intermittently
Initialize the module system model even in presence of missing/broken module-infos; BadClassFiles should not immediatelly abort compilation anymore, but should be handled as if the classfile did not exist.

Reviewed-by: jjg
2017-07-13 13:37:44 +02:00
Lana Steuck
01d2ec7fcd Merge 2017-06-24 00:32:07 +00:00
Joe Darcy
cd5a336735 8163989: Clarify ModuleElement spec
Reviewed-by: abuckley, jjg
2017-06-19 15:06:01 -07:00
Jan Lahoda
06cf2f81e7 8182162: Remove -XD-Xmodule
Removing the undocumented -XD-Xmodule: option.

Reviewed-by: jjg
2017-06-19 05:56:49 +02:00
Alan Bateman
6dc7b17106 8181087: Module system implementation refresh (6/2017)
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2017-06-16 09:21:38 -07:00
Vicente Romero
b30409ae05 7170058: Confusing error message from javac when overriding a method from a raw supertype
Reviewed-by: mcimadamore
2017-06-01 12:51:26 -07:00
Magnus Ihse Bursie
10678fd999 8179889: Fix typographic errors in copyright headers
Reviewed-by: erikj, dholmes
2017-05-09 12:55:07 +02:00
Jonathan Gibbons
4a269851c9 8176327: javac produces wrong module-info
8178518: Add method JavaFileManager.contains

Reviewed-by: jlahoda
2017-04-24 14:59:43 -07:00
Jan Lahoda
f92855c682 8178012: Finish removal of -Xmodule:
Changing -Xmodule: option to -XD-Xmodule:, setting jtreg to use --patch-module instead of -Xmodule:.

Reviewed-by: jjg
2017-04-19 13:38:36 +02:00
Jonathan Gibbons
0cd70bbdc1 8161295: javac, cleanup use of ModuleTestBase
Reviewed-by: ksrini
2017-04-17 15:28:37 -07:00
Jonathan Gibbons
4b7795c6d5 8178509: MODULE_SOURCE_PATH: Implement missing methods
8178493: StandardJavaFileManager: Clarify/document the use of IllegalStateException

Reviewed-by: jlahoda
2017-04-17 14:16:07 -07:00
Jan Lahoda
d38fa28ac9 8178011: Automatic module warnings
Adding lints for automatic modules in requires and requires transitive directives.

Reviewed-by: jjg
2017-04-10 11:08:59 +02:00
Alan Bateman
7641a14458 Merge 2017-04-07 10:58:38 +01:00
Alan Bateman
481f056ca9 8177530: Module system implementation refresh (4/2017)
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2017-04-07 08:08:26 +00:00
Srikanth Adayapalam
06143df6a2 8176572: Javac does not enforce module name restrictions
Reviewed-by: jlahoda
2017-04-05 14:34:15 +05:30
Jan Lahoda
dc292b699a 8177311: Denied access when named module accesses unreferences package from the unnamed module
Ensure access to the unnamed module is allowed if the given module reads the unnamed module.

Reviewed-by: jjg
2017-03-29 10:27:23 +02:00
Jan Lahoda
1eaf7f1243 8176743: tools/javac/modules/MOptionTest.java test fails on Mac
Correctly preferring classfiles over source files when timestamps match.

Reviewed-by: jjg
2017-03-15 15:46:43 +01:00
Jan Lahoda
828abbabee 8175119: Need to specify module of types created by Filer.createSourceFile/Filer.createClassFile?
Clarifications and improvements to jx.a.processing.Filer for creating and reading files in and from modules.

Reviewed-by: darcy, jjg
2017-03-14 10:51:19 +01:00
Jan Lahoda
308a2b9f90 8176045: No compile error when a package is not declared
Fixing handling of otherwise empty files with package clauses and empty files without package clauses.

Reviewed-by: jjg
2017-03-14 08:19:41 +01:00
Jan Lahoda
d60b98466f 8175057: module-info on patch path should not produce an error
Allowing module-infos on patch paths during compilation.

Reviewed-by: jjg, ksrini
2017-03-14 07:11:45 +01:00
Jan Lahoda
2d911bad19 8175560: Drop String pkgName from javax.tools.JavaFileManager.getLocationForModule(Location location, JavaFileObject fo, String pkgName)
Reviewed-by: jjg
2017-03-06 13:17:33 +01:00
Jonathan Gibbons
e1d9daf27f 8175118: Revisit modeling of module directives
Reviewed-by: darcy, jlahoda
2017-03-03 15:43:08 -08:00
Kumar Srinivasan
3aa07bbfdf 8175990: Javac fails to find module-info.java if module source path contains symlinks
Reviewed-by: jjg
2017-02-28 13:57:39 -08:00
Kumar Srinivasan
c5656c1c76 8173308: JAVAC_OPTIONS should be updated to align with JAVA_OPTIONS
Reviewed-by: jjg
2017-02-15 18:07:28 -08:00
Jonathan Gibbons
6873ceb82c 8173596: JavaCompiler.CompilationTask should support addModules
Reviewed-by: ksrini, jlahoda
2017-02-15 14:12:29 -08:00
Jan Lahoda
8a2de9b69b 8175007: Incorrect error messages for inaccessible classes in visible packages
Recovery lookup may be triggered for inaccessible classes in visible packages - providing better errors.

Reviewed-by: mcimadamore
2017-02-15 11:27:03 +01:00
Vicente Romero
48b3288060 8174243: incorrect error message for nested service provider
Reviewed-by: jjg, jlahoda
2017-02-14 15:45:17 -08:00
Andrey Nazarov
ffe5040932 8170404: Improve negative testing for module-info
Reviewed-by: jjg
2017-02-14 16:18:38 +03:00
Srikanth Adayapalam
0854bc2a21 8170691: fill in @bug number for test
Reviewed-by: darcy
2017-02-14 14:24:23 +05:30
Jan Lahoda
261ce92be5 8173777: Merge javac -Xmodule into javac--patch-module
Merging -Xmodule: functionality into --patch-module.

Reviewed-by: jjg, mchung, rfield
2017-02-13 09:37:26 +01:00
Jonathan Gibbons
0fcd98980c 8174104: Compiler does not allow non-existent module path entry
Reviewed-by: jlahoda
2017-02-10 15:42:17 -08:00
Vicente Romero
25a8d5cb01 8174027: error message should adapt to the corresponding top level element
Reviewed-by: mcimadamore
2017-02-08 06:43:34 -08:00
Jonathan Gibbons
f4c670d9b6 8172901: javac: 'opens' statement cannot specify non observable package
Reviewed-by: jlahoda
2017-02-06 12:35:13 -08:00
Jan Lahoda
eb5ba01b02 8173636: Results from Processor.getSupportedAnnotationTypes should be intepreted strictly
Co-authored-by: Joe Darcy <joe.darcy@oracle.com>
Reviewed-by: darcy, jjg
2017-02-06 15:57:35 +01:00
Srikanth Adayapalam
d6090047be 8166420: Confusing error message when reading bad module declaration
Reviewed-by: jlahoda
2017-02-06 18:14:51 +05:30
Lance Andersen
1ded7c8c04 8173604: Rename module 8173604 java.annotations.common to java.xml.ws.annoations
Reviewed-by: dfuchs, alanb, psandoz, mchung
2017-02-04 14:05:08 -05:00
Jan Lahoda
40c2afd1eb 8172240: javac should not need the transitive closure to compile a module
Reviewed-by: jjg
2017-02-03 08:16:24 -08:00
Jonathan Gibbons
02431ac603 8172807: Javac doesn't report errors on duplicate provides with different service implementations
Reviewed-by: jlahoda
2017-02-02 14:34:21 -08:00
Jonathan Gibbons
f93bda94f7 8173789: Fix broken test header
Reviewed-by: darcy
2017-02-01 14:38:45 -08:00
Jan Lahoda
210dd83834 8173068: ElementUtils getPackageElement does not allow for an unnamed package
Removing special handling of unnamed packages in Elements.getPackageElement.

Reviewed-by: darcy, jjg, ksrini
2017-01-26 14:14:01 +01:00
Srikanth Adayapalam
4141792982 8171322: AssertionError in TypeSymbol.getAnnotationTypeMetadata
Reviewed-by: vromero
2017-01-23 10:28:52 +05:30
Jan Lahoda
721001933d 8173117: Compilation significantly slower after JDK-8169197
Only using recovery search when an error is inevitable.

Reviewed-by: jjg, mcimadamore
2017-01-20 15:32:07 +01:00
Jan Lahoda
3e7e4c275b 8172809: Error compiling javafx modules after fix for JDK-8169197
Properly stripping broken requires from ModuleSymbols.

Reviewed-by: jjg, mcimadamore
2017-01-20 15:32:03 +01:00
Jan Lahoda
b6e7bcbc6a 8171177: Compiler should issue a warning for incubating modules that are resolved
Javac needs to follow ModuleResolution.DO_NOT_RESOLVE_BY_DEFAULT and ModuleResolution.WARN_INCUBATING

Reviewed-by: jjg
2017-01-20 13:20:42 +01:00
Jan Lahoda
ec3981561d 8171098: NPE when --add-modules java.corba is used
Block annotations queue until enter is done, to avoid flushing annotations during module resolution.

Reviewed-by: jjg
2017-01-20 09:26:49 +01:00
Jonathan Gibbons
16d379dad4 8165102: incorrect message from javac
Reviewed-by: vromero
2017-01-19 15:12:59 -08:00
Jan Lahoda
53792b463e 8172262: packages missing from docs build
Do not return packages without members from Elements.getPackageElement(String), to avoid ambiguities among such packages in multiple modules.

Reviewed-by: jjg
2017-01-17 07:41:04 +01:00
Jan Lahoda
abddf32a62 8172668: NPE in jdk.compiler/com.sun.tools.javac.comp.TypeEnter$ImportsPhase.importNamed(
Guarding against noType returned from ErrorType.getOriginalType.

Reviewed-by: mcimadamore
2017-01-12 15:37:46 +01:00
Jan Lahoda
c2d9172419 8169197: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2017-01-11 10:59:57 +01:00
Jan Lahoda
4ec30a933a 8172158: Annotation processor not run with -source <= 8
Avoiding use of module prefix to map annotations to processors when running without modules.

Reviewed-by: darcy, jjg
2017-01-06 14:16:45 +01:00