Commit Graph

1114 Commits

Author SHA1 Message Date
Eric McCorkle
5b76a0d216 8022322: Reject default and static methods in annotation
Causes javac to reject static and default method declarations inside an annotation

Reviewed-by: jjg
2013-09-09 16:26:55 -04:00
Vicente Romero
1704a9454c 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests
Reviewed-by: jjg, jfranck
2013-09-09 16:32:08 +01:00
Andreas Lundblad
5df75e001d 8022260: Rename javac.code.Annotations to javac.code.SymbolMetadata
Reviewed-by: jfranck, jjg
2013-09-09 09:58:20 +02:00
Vicente Romero
a3b1359af5 8024398: javac, compiler crashes with try with empty body
Reviewed-by: jjg
2013-09-08 11:54:21 +01:00
Jonathan Gibbons
f607953eb8 8024434: problem running javadoc tests in samevm mode on Windows
Reviewed-by: darcy
2013-09-06 15:31:59 -07:00
Vicente Romero
26758f0ffd 8024039: javac, previous solution for JDK-8022186 was incorrect
Reviewed-by: jjg
2013-09-06 09:53:24 +01:00
Bhavesh Patel
9c6d420370 8023608: method grouping tabs folding issue
Reviewed-by: jjg
2013-09-05 16:35:47 -07:00
Jonathan Gibbons
7da0f59aec 8024288: javadoc generated-by comment should always be present
Reviewed-by: bpatel
2013-09-04 14:44:05 -07:00
Maurizio Cimadamore
4cc7a55aab 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
Reviewed-by: jjg, vromero
2013-09-04 00:01:05 +01:00
Vicente Romero
cab6b226ff 8023545: Misleading error message when using diamond operator with private constructor
Reviewed-by: jjg
2013-09-03 23:41:37 +01:00
Maurizio Cimadamore
06caeea3d6 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
Reviewed-by: jjg, vromero
2013-09-03 23:31:33 +01:00
Vicente Romero
46d7a993ad 8022162: Incorrect signature determination for certain inner class generics
Reviewed-by: jjg
2013-09-02 22:44:06 +01:00
Maurizio Cimadamore
0382c78ff1 8016177: structural most specific and stuckness
Reviewed-by: jjg, vromero
2013-09-02 22:38:36 +01:00
Evgeniya Stepanova
4337286502 8015663: Need to supply tests to provide javadoc for profiles support code coverage
Reviewed-by: jjg
2013-08-30 17:36:47 -07:00
Bhavesh Patel
b8f8cab5f4 8022738: doclet should only generate functional interface text if source >= 8
Reviewed-by: jjg
2013-08-30 16:38:54 -07:00
Bhavesh Patel
5793c3a33c 8015882: Javadoc prints NPE when using Taglet
Reviewed-by: jjg
2013-08-30 16:16:28 -07:00
Bhavesh Patel
2b93265564 7198273: RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text
Reviewed-by: jjg
2013-08-30 15:59:33 -07:00
Jonathan Gibbons
3dd18b5d8c 8024093: Two *.rej files checked in to langtools/test directory
Reviewed-by: mchung
2013-08-30 15:14:51 -07:00
Jonathan Gibbons
4449fa0c56 8023700: Use non breaking space in various labels
Reviewed-by: bpatel
2013-08-30 11:48:36 -07:00
Jonathan Gibbons
445a49ecb6 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only
Reviewed-by: darcy
2013-08-29 11:57:52 -07:00
Jonathan Gibbons
c56513ee82 8010310: [javadoc] Error processing sources with -private
Reviewed-by: vromero, mcimadamore
2013-08-28 15:40:33 -07:00
Henry Jen
8873ff4e48 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed
Reviewed-by: briangoetz, jjg
2013-08-28 10:17:23 -07:00
Bhavesh Patel
856570998b 7052170: javadoc -charset option generates wrong meta tag
Reviewed-by: jjg
2013-08-27 11:41:39 -07:00
Werner Dietl
d99f710f70 8023768: Use the unannotatedType in cyclicity checks
Reviewed-by: jjg
2013-08-26 15:55:46 -07:00
Jonathan Gibbons
041cadb78d 8023701: Fix badly named test
Reviewed-by: bpatel
2013-08-26 11:48:37 -07:00
Jonathan Gibbons
32a617d198 8022173: Relax some warnings in doclint
Reviewed-by: darcy
2013-08-22 12:41:20 -07:00
Eric McCorkle
0d3a9fcd89 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables
Corrected an error in a previous patch that caused captured locals to be added to the beginning, not the end of a parameter list.

Reviewed-by: jjg, mcimadamore, ksrini, abuckley
2013-08-22 12:47:46 -04:00
Vicente Romero
c65abc95df 8023112: javac should not use lazy constant evaluation approach for method references
Reviewed-by: jjg, mcimadamore
2013-08-22 13:12:43 +01:00
Vicente Romero
7b989a82fd 8022316: Generic throws, overriding and method reference
Reviewed-by: jjg, mcimadamore
2013-08-22 10:22:44 +01:00
Eric McCorkle
febfa82cfb 8023520: Add missing test for JDK-7118412
The test for JDK-7118412 was dropped from the changeset in a merging accident.

Reviewed-by: jjg
2013-08-21 20:41:42 -04:00
Jonathan Gibbons
64412dad17 8022287: javac.sym.Profiles uses a static Map when it should not
Reviewed-by: ksrini
2013-08-21 17:26:22 -07:00
Werner Dietl
1dc32a077e 8023515: import type-annotations updates
Reviewed-by: jjg
2013-08-21 16:13:50 -07:00
Kumar Srinivasan
c9f3cedbfa 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8
Reviewed-by: jjg
2013-08-20 14:15:45 -07:00
Joe Darcy
557cb9c6b1 8011043: Warn about use of 1.5 and earlier source and target values
Reviewed-by: jjg
2013-08-20 12:15:19 -07:00
Joel Borggrén-Franck
07d44a6520 8019243: AnnotationTypeMismatchException instead of MirroredTypeException
Reviewed-by: jjg
2013-08-20 17:21:47 +02:00
Alexander Zuev
7947e49ae3 7182350: Regression in wording of unchecked warning message
Reviewed-by: mcimadamore, jjg
2013-08-20 17:34:06 +04:00
Kumar Srinivasan
7870f1a6dc 7071377: Exception when javac -processor is given a class name with invalid postfix
Reviewed-by: jjg, vromero
2013-08-19 07:47:10 -07:00
Erik Joelsson
99a38df3ab 8023146: Sjavac test failes in langtools nightly
Reviewed-by: mcimadamore, jfranck
2013-08-16 16:00:12 +02:00
Jan Lahoda
d992a67102 8022508: javac crashes if the generics arity of a base class is wrong
Reviewed-by: mcimadamore, vromero
2013-08-15 22:36:08 +02:00
Jan Lahoda
59e0637339 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
Producing individual errors for uncaught undeclared exceptions inside lambda expressions, rather than one error for the whole lambda

Reviewed-by: mcimadamore
2013-08-15 22:33:43 +02:00
Vicente Romero
746be81338 8022053: javac generates unverifiable initializer for nested subclass of local class
Reviewed-by: jjg, mcimadamore
2013-08-16 10:32:42 +01:00
Erik Joelsson
fd4983b254 8015145: Smartjavac needs more flexibility with linking to sources
Reviewed-by: jjg, ohrstrom
2013-08-15 17:24:35 +02:00
Bhavesh Patel
0c6e63367d 8016921: Change the profiles table on overview-summary.html page to a list
Reviewed-by: jjg
2013-08-14 21:44:51 -07:00
Jonathan Gibbons
43991d588a 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages
Reviewed-by: bpatel
2013-08-14 16:41:01 -07:00
Kumar Srinivasan
ce4eb93249 8007517: DefaultMethodRegressionTests.java fail in TL
Reviewed-by: jjg, vromero
2013-08-14 07:07:55 -07:00
Vicente Romero
d36ef0edd0 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\"
Reviewed-by: mcimadamore
2013-08-14 10:53:37 +01:00
Maurizio Cimadamore
58d92c516a 8021567: Javac doesn't report \"java: reference to method is ambiguous\" any more
Javac incorrectly forgets about constant folding results within lambdas

Reviewed-by: jjg, vromero
2013-08-12 17:28:31 +01:00
Maurizio Cimadamore
4e85a5ae43 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods)
Hiding check does not support interface multiple inheritance

Reviewed-by: jjg
2013-08-12 17:25:07 +01:00
Vicente Romero
190f9337b1 6983297: methods missing from NewArrayTree
Reviewed-by: jjg
2013-08-10 16:29:26 +01:00
Vicente Romero
22652f5354 8022622: javac, two tests are failing with compile time error after class Collector was modified
Reviewed-by: mcimadamore
2013-08-10 16:26:50 +01:00
Vicente Romero
cee3c2853b 8009640: -profile <compact> does not work when -bootclasspath specified
Reviewed-by: jjg
2013-08-10 13:27:38 +01:00
Kumar Srinivasan
35e27fd594 8022161: javac Null Pointer Exception in Enter.visitTopLevel
Reviewed-by: jjg, vromero, jlahoda
2013-08-09 15:01:33 -07:00
Vicente Romero
cecb5cc0ea 8019486: javac, generates erroneous LVT for a test case with lambda code
Reviewed-by: mcimadamore
2013-08-08 11:49:16 +01:00
Bhavesh Patel
a8090b5024 4749567: stddoclet: Add CSS style for setting header/footer to be italic
Reviewed-by: jjg
2013-08-07 16:09:31 -07:00
Bhavesh Patel
69a3c42db7 7198274: RFE : Javadoc Accessibility : Use CSS styles rather than <strong> or <i> tags
Reviewed-by: jjg
2013-08-07 15:00:24 -07:00
Vicente Romero
0fb4cd9d38 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations
Reviewed-by: jjg, jfranck
2013-08-07 10:41:20 +01:00
Joel Borggrén-Franck
70ac5c3a48 8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotations
Reviewed-by: jjg, darcy
2013-08-07 01:32:39 +02:00
Vicente Romero
5f5b303d7e 8022186: javac generates dead code if a try with an empty body has a finalizer
Reviewed-by: jjg
2013-08-06 15:08:49 +01:00
Kumar Srinivasan
da7f38703d 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension markers
Reviewed-by: jjg, vromero
2013-07-31 08:37:34 -07:00
Vicente Romero
5540c7cbe1 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6
Reviewed-by: jjg
2013-07-31 10:52:01 +01:00
Jan Lahoda
0847cbc403 8021338: Diamond finder may mark a required type argument as unnecessary
Reviewed-by: mcimadamore
2013-07-28 10:17:45 +02:00
Jan Lahoda
21ab6d5558 8020689: Missing LineNumberTable entries in compiled class files
Reviewed-by: ksrini, mcimadamore
2013-07-28 10:17:45 +02:00
Lana Steuck
f5da332e66 Merge 2013-07-26 14:08:37 -07:00
Maurizio Cimadamore
da6bbaf42b 8020843: javac crashes on accessibility check with method reference with typevar receiver
Method reference overload check doesn't walk through type-variable receivers

Reviewed-by: jjg
2013-07-25 14:51:40 +01:00
Maurizio Cimadamore
663170c654 8016081: field initialized with lambda in annotation types doesn't compile
Check for annotation attributes should skip over synthetic methods

Reviewed-by: jjg
2013-07-25 14:49:16 +01:00
Maurizio Cimadamore
67362236e8 8020804: javac crashes when speculative attribution infers intersection type with array component
Assertion is causing javac to crash because of lack of support for arrays in intersection types

Reviewed-by: jjg
2013-07-25 14:47:43 +01:00
Joel Borggrén-Franck
2030148ec2 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType
Reviewed-by: jjg
2013-07-25 11:02:27 +02:00
Jonathan Gibbons
0c5c756933 8020556: doclint does not check type variables for @throws
Reviewed-by: mcimadamore
2013-07-24 17:35:42 -07:00
Eric McCorkle
be2ea6f949 8016880: 42 tests in annot102* fail with compile-time errors
Fixes error in type equality when bounds of type variables have annotations.

Reviewed-by: jjg, mcimadamore
2013-07-23 20:42:54 -04:00
Jonathan Gibbons
2a95b6ac74 8021215: javac gives incorrect doclint warnings on normal package statements
Reviewed-by: darcy
2013-07-23 16:06:11 -07:00
Lana Steuck
524a340ac9 Merge 2013-07-22 17:39:45 -07:00
Kumar Srinivasan
c6c6fe7b5e 8017216: javac doesn't fill in end position for some errors of type not found
8019421: Javac doesn't fill in end position for some annotation related errors
8019422: Javac doesn't fill in end position for uninitialized variable errors

Reviewed-by: jjg, mcimadamore
2013-07-19 07:22:53 -07:00
Jonathan Gibbons
c42bcf4526 8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore
2013-07-17 19:16:12 -07:00
Jonathan Gibbons
772640d4e8 8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore
2013-07-17 19:12:03 -07:00
Jonathan Gibbons
89197f0946 8014636: TestLiteralCodeInPre fails on windows
Reviewed-by: ksrini
2013-07-17 18:18:45 -07:00
Maurizio Cimadamore
70e005a7eb 8013638: Few policy tests are failing in Lambda nightly
BridgeHarness test is leaving files open

Reviewed-by: ksrini
2013-07-17 19:28:40 +01:00
Lana Steuck
be00b8110f Merge 2013-07-17 10:40:53 -07:00
Jan Lahoda
35af8eccde 8020586: Warning produced for an incorrect file
Always using DeferredLintHandler.immediateHandler when processing import classes

Reviewed-by: mcimadamore
2013-07-17 15:08:58 +02:00
Maurizio Cimadamore
a2a579a4bd 8019942: Graph inference: avoid redundant computation during bound incorporation
Bound incorporation should not perform same operation multiple times

Reviewed-by: jjg
2013-07-17 14:21:12 +01:00
Maurizio Cimadamore
717a989214 8019340: varargs-related warnings are meaningless on signature-polymorphic methods such as MethodHandle.invokeExact
Disable certain varargs warnings when compiling polymorphic signature calls

Reviewed-by: jjg
2013-07-17 14:19:25 +01:00
Maurizio Cimadamore
73953320cc 8020149: Graph inference: wrong logic for picking best variable to solve
Replace logic for selecting best inference leaf in the graph during an unsticking round

Reviewed-by: jjg
2013-07-17 14:19:02 +01:00
Maurizio Cimadamore
8850329bc1 8016640: compiler hangs if the generics arity of a base class is wrong
Check.checkCompatibleConcretes hang when javac creates synthetic supertypes for 269 model API

Reviewed-by: jjg
2013-07-17 14:16:25 +01:00
Maurizio Cimadamore
defbb67771 7041019: Bogus type-variable substitution with array types with dependencies on accessibility check
Call to upperBound() when performing type-variable substitution on element type leads to unsoundness

Reviewed-by: jjg
2013-07-17 14:14:49 +01:00
Maurizio Cimadamore
732e49f6dc 8020286: Wrong diagnostic after compaction
Compact diagnostic shows the least relevant method in the list

Reviewed-by: jjg
2013-07-17 14:14:32 +01:00
Maurizio Cimadamore
eb4e8153b3 8020147: Spurious errors when compiling nested stuck lambdas
Scope of deferred types is not copied correctly; postAttr analyzer should not run on stuck expressions

Reviewed-by: jjg
2013-07-17 14:13:15 +01:00
Maurizio Cimadamore
e92a56fade 8012238: Nested method capture and inference
8008200: java/lang/Class/asSubclass/BasicUnit.java fails to compile

Inference support should be more flexible w.r.t. nested method calls returning captured types

Reviewed-by: jjg, vromero
2013-07-17 14:11:41 +01:00
Maurizio Cimadamore
99b0413d48 8016175: Add bottom-up type-checking support for unambiguous method references
Type-checking of non-overloaded method references should be independent from target-type

Reviewed-by: jjg, vromero
2013-07-17 14:09:46 +01:00
Maurizio Cimadamore
941752ea25 8012242: Lambda compatibility and checked exceptions
Inference variables in 'throws' clause with no constraints should be inferred as RuntimeException

Reviewed-by: jjg, vromero
2013-07-17 14:04:01 +01:00
Jonathan Gibbons
9dd2fe90d4 8020278: NPE in javadoc
Reviewed-by: mcimadamore, vromero
2013-07-12 13:11:12 -07:00
Maurizio Cimadamore
617386d568 8013404: Unclear spec for target typing with conditional operator (?:)
Fix previously ignored test

Reviewed-by: jjg, vromero
2013-07-11 15:37:02 +01:00
Robert Field
d3d1da337a 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
8020010: Move lambda bridge creation from metafactory and VM to compiler

Langtools/javac component of the bridge support and MethodType vs. MethodHandle changes.

Reviewed-by: jjg, vromero, briangoetz, forax
2013-07-11 14:07:39 +01:00
Kumar Srinivasan
424ac16db0 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken
Reviewed-by: jjg
2013-07-09 14:54:20 -07:00
Maurizio Cimadamore
7229f89614 8019824: very long error messages on inference error
Inference error messages shows several spurious captured variables generated during an inference loop

Reviewed-by: jjg, vromero
2013-07-05 11:05:02 +01:00
Maurizio Cimadamore
4442f43ea3 8016702: use of ternary operator in lambda expression gives incorrect results
Constant types erroneously creep in during inference

Reviewed-by: jjg, vromero
2013-07-05 11:04:22 +01:00
Maurizio Cimadamore
28b5759093 8016059: Cannot compile following lambda
8016060: Lambda isn't compiled with return statement

Spurious error triggered during unnecessary recovery round

Reviewed-by: jjg, vromero
2013-07-05 11:03:04 +01:00
Maurizio Cimadamore
86f630b63e 8019480: Javac crashes when method is called on a type-variable receiver from lambda expression
Logic for shortcircuiting speculative attribution doesn't handle type-variable receivers

Reviewed-by: jjg, vromero
2013-07-05 11:02:17 +01:00
Maurizio Cimadamore
7e6f7dcca5 8017618: NullPointerException in RichDiagnosticFormatter for bad input program
RDF crashes when diagnostic contains type 'void'

Reviewed-by: jjg, vromero
2013-07-05 11:00:19 +01:00
Vicente Romero
684d5ec76d 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
Reviewed-by: mcimadamore
2013-07-04 10:41:08 +01:00
Vicente Romero
8277af52ee 8009924: some langtools tools do not accept -cp as an alias for -classpath
Reviewed-by: jjg
2013-07-04 10:35:33 +01:00
Vicente Romero
ea2c99f5bb 6326693: variable x might already have been assigned, when assignment is in catch block
Reviewed-by: mcimadamore
2013-07-02 22:49:40 +01:00