129 Commits

Author SHA1 Message Date
Srikanth Adayapalam
4141792982 8171322: AssertionError in TypeSymbol.getAnnotationTypeMetadata
Reviewed-by: vromero
2017-01-23 10:28:52 +05:30
Srikanth Adayapalam
e179ac0384 8164519: Rendering of supertype_target for annotated extends clause
Eliminate inconsistencies in handling annotated super class.

Reviewed-by: jlahoda
2016-09-27 04:34:09 +05:30
Dan Smith
eb56700eba 8138822: Source version error missing version number
Reviewed-by: jjg
2016-09-16 11:58:23 -06:00
Vicente Romero
29aa24a3c1 8162546: change hidden options -Xdebug to --debug, -XshouldStop to --should-stop, and -diags to --diags
Reviewed-by: mcimadamore
2016-09-06 17:04:43 -07:00
Srikanth Adayapalam
37028f8abc 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
Reviewed-by: mcimadamore, ksrini
2016-08-12 11:49:18 +05:30
Joe Darcy
498a90cde6 8163113: langtools repeating annotations tests depend rely on annotations toString output
Reviewed-by: jlahoda, vromero
2016-08-03 11:30:27 -07:00
Vicente Romero
a7cc024b53 8161020: javac, fold stop compilation options
Reviewed-by: mcimadamore
2016-07-11 15:27:52 -07:00
Srikanth Adayapalam
0917774834 8160928: javac incorrectly copies over interior type annotations to bridge method
Reviewed-by: mcimadamore
2016-07-11 18:13:42 +05:30
Vicente Romero
3360117337 8160891: javac, remove unused options, step 3
Reviewed-by: mcimadamore
2016-07-06 09:42:27 -07:00
Srikanth Adayapalam
ab5510e51f 8146167: Anonymous type declarations drop supertype type parameter annotations
Reviewed-by: mcimadamore
2016-06-02 15:22:34 +05:30
Maurizio Cimadamore
8fb837a1bf 8145489: NPE while compiling annotations with qualified names in package-info.java
Spurious method reference check in Attr.visitSelect is causing NPE

Reviewed-by: vromero
2016-06-01 12:39:24 +01:00
Srikanth Adayapalam
93714ca994 8047024: 7 ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
Fix incorrect assertion about exception index already being set.

Reviewed-by: mcimadamore
2016-05-25 19:30:55 +05:30
Liam Miller-Cushon
9290ce0c7b 8154270: javac wrongly rejects some class literals as annotation element values
Reviewed-by: mcimadamore
2016-04-29 14:18:09 -07:00
Jan Lahoda
d6521300a0 7020499: Project Coin: improvements to try-with-resources desugaring
Avoid unnecessary check for resource nullness if the resource is known to be non-null; put resource closing code in a method that is shared by multiple try-with-resources.

Reviewed-by: darcy, mcimadamore, vromero
2016-04-19 14:16:39 +02:00
Andreas Lundblad
4b662bba26 8036952: copyright issues in jdk9/dev/langtools files
Updated copyright notices.

Reviewed-by: jjg, jlahoda
2016-04-18 21:07:50 +02:00
Jonathan Gibbons
7812306bc0 8152897: refactor ToolBox to allow reduced documented dependencies
Reviewed-by: vromero
2016-03-31 15:20:50 -07:00
Alan Bateman
001ebb3a72 8142968: Module System implementation
Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282

Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Co-authored-by: Andreas Lundblad <andreas.lundblad@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Kumar Srinivasan <kumar.x.srinivasan@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jjg, jlahoda, vromero, mcimadamore, bpatel, ksrini, darcy, anazarov, dfuchs
2016-03-17 19:04:28 +00:00
Srikanth Adayapalam
3cd2c2d034 8148432: tools/javac/annotations/typeAnnotations/classfile/NestedLambdasCastedTest.java fails on all platforms
Reviewed-by: mcimadamore
2016-01-28 17:41:52 +05:30
Srikanth Adayapalam
a7a324e4cb 8144168: No type annotations generated for nested lambdas
Reviewed-by: jlahoda
2016-01-28 09:09:34 +05:30
Srikanth Adayapalam
78651a213e 8145987: Assertion failure when compiling stream with type annotation
Reviewed-by: jlahoda
2016-01-25 15:49:50 +05:30
Srikanth Adayapalam
570883e4dc 8144580: java.lang.AssertionError: Missing type variable in where clause: T
Type variable comparisons should ignore type annotations.

Reviewed-by: mcimadamore
2016-01-19 15:46:42 +05:30
Vassili Igouchkine
9c33078299 8145342: Some copyright notices are inconsistently and ill formatted
Adjusted formatting of copyright notices.

Reviewed-by: darcy, alundblad
2015-12-14 20:18:19 +01:00
Srikanth Adayapalam
431aa657a6 8136419: Type annotations in initializers and lambda bodies not written to class file
Reviewed-by: jlahoda
2015-11-12 06:13:14 +05:30
Srikanth Adayapalam
2d8d2e83ba 8057685: javac should not crash compiling type annotations
Reviewed-by: jlahoda
2015-10-23 08:21:41 +05:30
Srikanth Adayapalam
7b64cba44c 8130745: Revert fix pushed for JDK-8074346
Reviewed-by: jlahoda
2015-07-08 19:01:57 +05:30
Srikanth Adayapalam
23e3cf3d7f 8074346: Type annotation on a qualified type causes spurious 'cannot find symbol' errors
Issue clear diagostic when package names in a qualified type name are illegally annotated

Reviewed-by: mcimadamore, jlahoda
2015-06-16 09:39:59 +05:30
Mandy Chung
ab120497cf 8074432: Move jdeps and javap to jdk.jdeps module
Reviewed-by: jjg, alanb, erikj
2015-05-27 13:25:18 -07:00
Alexander Kulyakhtin
b6262441ad 8076543: Add @modules as needed to the langtools tests
Reviewed-by: jjg, shurailine
2015-05-21 11:41:04 -07:00
Jan Lahoda
1867d1a236 8080338: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle
8080339: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle
8080340: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle

Fixing incorrect file headers; also reviewed by kevin.l.brown@oracle.com

Reviewed-by: vromero
2015-05-18 09:27:09 +02:00
Andreas Lundblad
bd17f06ead 8044196: Incorrect applying of repeatable annotations with incompatible target to type parameter
Additional applicability checks added.

Reviewed-by: jlahoda
2015-04-30 12:21:50 +02:00
Andreas Lundblad
868bdb35b2 8043984: Confusing (incorrect) error message on repeatable annotations
Adjusted error mesage for repeating annotations

Reviewed-by: jfranck, dlsmith
2015-04-17 12:37:11 +02:00
Andreas Lundblad
e17a42c26a 8073534: Confusing / incorrect error message regarding annotations on non-declarations
Adjusted error message for annotations on non-declarations.

Reviewed-by: jlahoda, dlsmith
2015-04-17 11:52:10 +02:00
Joel Borggren-Franck
7d3885b239 8031744: Annotations on many Language Model elements are not returned
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: jfranck, mcimadamore, emc, jlahoda, jjg
2015-04-07 11:04:29 -07:00
Eric McCorkle
b014a7728f 8066725: javac produces classfiles it cannot read
Revert behavioral changes from 8029012 and 8065132

Reviewed-by: jfranck
2015-02-13 17:00:45 -05:00
Sonali Goel
a67e9f2d36 8068463: Group 10c: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2015-01-27 15:11:57 -08:00
Srikanth Adayapalam
2b3c75aa36 8027888: javac wrongly allows annotations in array-typed class literals
Compiler incorrectly accepts type annotations on array-typed class literals.

Reviewed-by: jlahoda, jfranck
2015-01-13 10:36:41 +01:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in
Reviewed-by: jjg
2015-01-07 17:06:47 -08:00
Chris Hegarty
189df3ac57 Merge 2014-12-03 19:28:40 +00:00
Chris Hegarty
8bc2b3ff3a 8049367: Modular Run-Time Images
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Bradford Wetmore <bradford.wetmore@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: James Laskey <james.laskey@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jlahoda, ksrini
2014-12-03 14:25:46 +00:00
Eric McCorkle
590188542e 8065132: Parameter annotations not updated when synthetic parameters are prepended
Cause javac to add synthetic parameters to Runtime[In]VisibleParameterAnnotations attributes

Reviewed-by: jjg, jfranck
2014-11-21 16:36:39 -05:00
Jonathan Gibbons
56e39629eb 8065054: Some tests have junk before the legal header
Reviewed-by: darcy
2014-11-20 14:23:31 -08:00
Eric McCorkle
ab1b9a9cf1 8029012: parameter_index for type annotation not updated after outer.this added
Fix javac's handling of type annotations when synthetic parameters are added

Reviewed-by: jjg, mcimadamore
2014-11-07 07:54:35 -05:00
Jonathan Gibbons
a75d2dbd39 8062676: Tests which leak lots of file managers should be fixed (group 2)
Reviewed-by: darcy
2014-11-05 19:12:45 -08:00
Jonathan Gibbons
8bd23f1681 8062348: langtools tests should close file manager (group 1)
Reviewed-by: darcy
2014-10-29 17:25:23 -07:00
Joel Borggrén-Franck
0149333fb8 8054448: (ann) Cannot reference field of inner class in an anonymous class
Reviewed-by: jlahoda, mcimadamore
2014-10-24 08:34:51 +02:00
Jan Lahoda
1eb03e49bf 8054956: Javac reports wrong error offset for unknown identifier of annotation element/value pair
When reporting an error about unresolvable annotation attribute, use the position of the explicit left-hand-side of the assignment if available, otherwise use the position of the right-hand-side.

Reviewed-by: jfranck
2014-10-13 17:22:47 +02:00
Joel Borggrén-Franck
053a9d56cd 8056021: checkin for JDK-8027262 breaks Checker Framework
Reviewed-by: jjg, mcimadamore
2014-09-08 13:11:28 +02:00
Sonali Goel
e2312f606b 8049126: golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-28 23:42:16 -07:00
Paul Govereau
7cb1497762 8054556: javac should report the error for default usage as the primary error
Reviewed-by: jjg
2014-08-15 11:02:14 -04:00
Sonali Goel
14e6aa6b9e 8049130: Group 8d - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:48:30 -07:00