Commit Graph

1989 Commits

Author SHA1 Message Date
Maurizio Cimadamore
04f289629a 8170410: inference: javac doesn't implement 18.2.5 correctly
Javac does not generate constraints of the kind 'throws alpha' as described in the spec

Reviewed-by: vromero, dlsmith
2016-12-05 19:00:56 +00:00
Jonathan Gibbons
ffcb66f113 8162712: StandardJavaFileManager.getModuleLocation() can't find a module
Reviewed-by: jlahoda
2016-12-02 14:15:43 -08:00
Jan Lahoda
88a7279627 8166628: Compiling with annotation processing, access error in specific situation
Ensure member classes inside anonymous classes have a correct owner.

Reviewed-by: mcimadamore
2016-12-02 14:39:00 +01:00
Alan Bateman
01a366e6dd Merge 2016-12-01 11:16:45 +00:00
Alan Bateman
22e233b2e9 8169069: Module system implementation refresh (11/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: mcimadamore, jjg, mchung, anazarov
2016-12-01 09:02:42 +00:00
Kumar Srinivasan
f4c9d73b3e 8164316: Refine the Doclet APIs
Reviewed-by: jjg
2016-11-24 20:48:52 -08:00
Jonathan Gibbons
f39acf60a5 Merge 2016-11-22 16:31:03 -08:00
Jonathan Gibbons
2d7092c7ac 8155765: javax.tools.ToolProvider::getSystemToolClassLoader returns app class loader even if no tool is available
Reviewed-by: mchung
2016-11-22 16:29:24 -08:00
Jonathan Gibbons
6e31f6440f 8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung
2016-11-22 15:57:32 -08:00
Jonathan Gibbons
c7374cd58f 8163190: Clarify JavaFileManager use of \"module location\"
Reviewed-by: jlahoda
2016-11-16 12:12:02 -08:00
Jonathan Gibbons
f742ef0ed0 8169676: boolean result of Option.process is often ignored
Reviewed-by: ksrini, jlahoda
2016-11-16 11:53:24 -08:00
Srikanth Adayapalam
95d99302d8 8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
Reviewed-by: jlahoda
2016-11-14 19:45:41 +05:30
Mandy Chung
4e5211401e 8169606: jdeps --list-reduced-deps should not show java.base as all modules require it
Reviewed-by: dfuchs
2016-11-12 09:26:08 -08:00
Mandy Chung
40e24f2e56 8168386: Fix jdeps verbose options
Reviewed-by: dfuchs, lancea
2016-11-11 17:32:21 -08:00
Jonathan Gibbons
a1f6786ab9 8169447: javac should detect/reject repeated use of --patch-module on command line
Reviewed-by: jlahoda
2016-11-10 13:29:34 -08:00
Jan Lahoda
b40c63e9fb 8166700: NPE during invoking getEnclosedElements() on javax.lang.model.element.Element instance representing a package
Should not strip first parameter of a local class constructor for local classes in initializers.

Reviewed-by: jjg
2016-11-10 17:27:01 +01:00
Maurizio Cimadamore
57bee7c4b9 8169093: Generics, javac not matching actual and formal arguments
Make diagnostic for type-args arity mismatch consistent with the class case

Reviewed-by: vromero
2016-11-07 16:08:18 +00:00
Maurizio Cimadamore
9b0354380e 8168854: javac erroneously reject a a service interface inner class in a provides clause
Java SE 9 proposed spec changes do not explicitly forbid a service interface to be an inner class - javac should follow

Reviewed-by: jjg
2016-11-07 11:16:23 +00:00
Jonathan Gibbons
e781b9f262 8167975: align javac --add-* modules options with launcher
Reviewed-by: jlahoda
2016-11-03 13:59:15 -07:00
Jan Lahoda
0c7e5fac7e 8166635: getEnclosedElements() on package causes BadClassFile error
Properly reading typevars from enclosing scopes for local classes.

Reviewed-by: mcimadamore
2016-11-03 11:46:20 +01:00
Stuart Marks
5ff1a63a1c 8169078: add bug IDs to jdeprscan tests
Reviewed-by: jjg
2016-11-02 14:22:27 -07:00
Jan Lahoda
7cffceb22f 8169074: Build is failing after JDK-8166538
Reverting d7c9720c4223

Reviewed-by: darcy
2016-11-02 20:21:45 +01:00
Jan Lahoda
5daafbe43b 8166538: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2016-11-02 16:48:57 +01:00
Stuart Marks
2380985895 8165646: (jdeprscan) adjust tool output to improve clarity
Reviewed-by: jjg, psandoz
2016-11-01 11:28:16 -07:00
Vicente Romero
32ca4bf4c7 8132562: javac fails with CLASSPATH with double-quotes as an environment variable
Reviewed-by: jjg
2016-11-01 10:14:42 -04:00
Mandy Chung
97cee45deb 8167057: jdeps option to list modules and internal APIs for @modules for test dev
Reviewed-by: dfuchs
2016-10-31 18:06:03 -07:00
Maurizio Cimadamore
12e8fccd6c 8168774: Polymorhic signature method check crashes javac
Check for polysig method assumes arity is greater than zero

Reviewed-by: vromero
2016-10-26 15:41:25 +01:00
Maurizio Cimadamore
47f7c2e668 8168134: Inference: javac incorrectly propagating inner constraint with primitive target
Check for propagation doesn't take into account primitive type constraints

Reviewed-by: vromero
2016-10-26 12:27:51 +01:00
Srikanth Adayapalam
5bc203a934 8166367: Missing ExceptionTable attribute in anonymous class constructors
Reviewed-by: vromero
2016-10-26 11:22:50 +05:30
Maurizio Cimadamore
d072e7faa4 8168480: Speculative attribution of lambda causes NPE in Flow
Flow attempts to analyze too much of a lambda body during attribution

Reviewed-by: vromero
2016-10-24 14:47:48 +01:00
Joe Darcy
5078ccdb18 8168499: Workaround intermittent failures of IntersectionTargetTypeTest.java
Reviewed-by: rfield, amlu, mcimadamore
2016-10-22 12:27:52 -07:00
Jonathan Gibbons
734e231c93 8168343: 3 javac tests fail when run on an exploded image
Reviewed-by: darcy
2016-10-20 16:31:42 -07:00
Jonathan Gibbons
a60ef42892 8145471: javac changes for enhanced deprecation
Reviewed-by: smarks, tbell, mcimadamore, jlahoda
2016-10-20 13:44:51 -07:00
Kumar Srinivasan
7ef07fcf9a 8167383: Javadoc does not handle packages correctly when used with module option
Reviewed-by: bpatel, jjg
2016-10-19 14:51:20 -07:00
Jonathan Gibbons
c2ee320e61 8138725: Add options for Javadoc generation
Reviewed-by: ksrini, bpatel, ahgross
2016-07-12 14:41:14 -07:00
Vicente Romero
d130403704 8026721: Enhance Lambda serialization
Reviewed-by: jjg, briangoetz
2016-03-02 18:25:01 -05:00
Maurizio Cimadamore
80ce1c8be2 8167000: Refine handling of multiple maximally specific abstract methods
Bring the compiler in sync with spec changes in JDK-7034913

Reviewed-by: vromero, dlsmith
2016-10-17 15:02:46 +01:00
Stuart Marks
1f91f70a58 8167965: (jdeprscan) using --release option with 8 or earlier throws exception
Reviewed-by: mchung
2016-10-13 17:31:01 -07:00
Mandy Chung
b79835c56b 8164689: Retrofit jar, jlink, jmod as a ToolProvider
Reviewed-by: alanb, jjg
2016-10-12 15:37:27 -07:00
Jan Lahoda
5794656914 8167320: Trying to document only java.base causes a NPE in javac
Ensure ModuleSymbol.getDirectives completes the Symbol

Reviewed-by: ksrini, jjg
2016-10-11 10:31:10 +02:00
Jonathan Gibbons
6fef223c3f 8159855: Create an SPI for tools
Reviewed-by: mchung
2016-10-07 16:49:39 -07:00
Jan Lahoda
6a0ceb74e8 8153362: Add javac -Xlint warning to list exposed types which are not accessible
Adding implementation to -Xlint:exports, to warn about exposing inaccessible types in API

Reviewed-by: jjg
2016-10-06 14:03:58 +02:00
Mandy Chung
2db14bace5 8166846: jdeps fails to generate module info if there is any class in unnamed package
Reviewed-by: lancea
2016-10-05 18:41:43 -07:00
Mandy Chung
a3f3f797b5 8166860: Add magic number to jmod file
Reviewed-by: alanb, jjg
2016-10-04 18:56:03 -07:00
Stuart Marks
512c42b9ac 8161338: (jdeprscan) remove JEP 293 non-conforming -cp option
8165927: (jdeprscan) com.sun.tools.jdeprscan.Main.instance should be package protected

Reviewed-by: jjg
2016-10-04 18:43:36 -07:00
Jonathan Gibbons
5bce3820cc 8166472: javac/javadoc expands @files incorrectly
Reviewed-by: henryjen, ksrini
2016-10-04 16:47:09 -07:00
Jan Lahoda
279b6faa56 8073844: fatal annotation processing errors do not stop compilation
JavacProcessingEnvironment lets the should-stop policy decide when the compilation should stop.

Reviewed-by: jjg
2016-10-04 17:40:29 +02:00
Jan Lahoda
c58a8aae3e 8152911: javac assertion error when compiling overlay sources
Avoid creating ModuleSymbols with unspecified name, to avoid conflicts with predefined ModuleSymbol for the java.base module.

Reviewed-by: jjg
2016-10-04 16:25:19 +02:00
Mandy Chung
33b751c3d4 8166238: Update jdeps for GNU-style long form options
Reviewed-by: alanb
2016-09-29 21:31:09 -07:00
Srikanth Adayapalam
517cfed246 8166363: Method with reordered type parameter bounds compiles with @Override annotation but does not actually override superclass method
Reviewed-by: vromero
2016-09-28 09:05:20 +05:30
Srikanth Adayapalam
e179ac0384 8164519: Rendering of supertype_target for annotated extends clause
Eliminate inconsistencies in handling annotated super class.

Reviewed-by: jlahoda
2016-09-27 04:34:09 +05:30
Steve Drach
18b1c7cd8b 8153654: Update jdeps to be multi-release jar aware
Reviewed-by: mchung
2016-09-26 13:39:50 -07:00
Jan Lahoda
35439dec91 8047347: com.sun.source.util.Trees breaks the compiler
Clearing synthetic constructors and super constructor calls between annotation processing rounds.

Reviewed-by: jjg
2016-09-23 15:35:32 +02:00
Srikanth Adayapalam
7ddb0f7c17 8163027: AssertionError while compiling a program that uses try with resources
Reviewed-by: vromero
2016-09-21 05:26:26 +05:30
Srikanth Adayapalam
ed537dc705 8156568: Update javac to support compiling against a modular JAR that is a multi-release JAR
Reviewed-by: jjg
2016-09-20 12:12:18 +05:30
Srikanth Adayapalam
4688e355c5 8166108: VerifyError passing anonymous inner class to supertype constructor
Anonymous classes instantitated in explicit constructor calls cannot have enclosing instance

Reviewed-by: vromero
2016-09-20 05:28:54 +05:30
Srikanth Adayapalam
ac462ed848 8164742: ServiceConfigurationError on invoke of getServiceLoader method of StandardJavaFileManager
Reviewed-by: jlahoda
2016-09-19 05:31:53 +05:30
Dan Smith
eb56700eba 8138822: Source version error missing version number
Reviewed-by: jjg
2016-09-16 11:58:23 -06:00
Srikanth Adayapalam
83dbcb5c1b 8160699: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Ensure out of scope locals are not treated as being alive

Reviewed-by: mcimadamore
2016-09-14 20:00:20 +05:30
Srikanth Adayapalam
e4870c84e3 8138667: java.lang.IllegalAccessError: tried to access method (for a protected method)
Reviewed-by: mcimadamore
2016-09-13 19:32:03 +05:30
Vicente Romero
29aa24a3c1 8162546: change hidden options -Xdebug to --debug, -XshouldStop to --should-stop, and -diags to --diags
Reviewed-by: mcimadamore
2016-09-06 17:04:43 -07:00
Vicente Romero
7e27dd569e 8160454: JSR269 jigsaw update: javax.lang.model.element.ModuleElement.getDirectives() causes NPE on unnamed modules
Reviewed-by: jjg
2016-09-02 05:43:54 -07:00
Srikanth Adayapalam
876bb73271 8164073: Javac should unconditionally warn if deprecated javadoc tag is used without @Deprecated annotation
Reviewed-by: mcimadamore
2016-09-02 07:49:15 +05:30
Jan Lahoda
161e3c650a 8165008: javac -Xmodule compiles the module in a way that reads the unnamed module
Ensuring proper separation between named modules and the unnamed module when using -Xmodule

Reviewed-by: jjg
2016-08-29 15:53:03 +02:00
Amy Lu
9f1556675e 8165193: Workaround intermittent failures of JavacTreeScannerTest and SourceTreeScannerTest due to C2 memory usage
Reviewed-by: darcy
2016-09-01 13:18:42 +08:00
Mandy Chung
2a62da3a63 8165109: langtools/test switches to use new CLI options
Reviewed-by: jjg, amlu
2016-08-30 20:49:41 -07:00
Jan Lahoda
bbf85261aa 8164951: Build broken after JDK-8164745
Reverting the fix for JDK-8164745 to investigate a build failure.

Reviewed-by: jjg
2016-08-29 18:14:26 +02:00
Jan Lahoda
4404741f80 8164745: javac -Xmodule compiles the module in a way that reads the unnamed module
Ensuring proper separation between named modules the unnamed module when using -Xmodule

Reviewed-by: jjg
2016-08-29 15:53:03 +02:00
Jonathan Gibbons
1386ffb4f2 8164887: update tests to remove use of old-style options
Reviewed-by: mchung
2016-08-26 15:54:36 -07:00
Stuart Marks
1673e17518 8145464: implement deprecation static analysis tool
Reviewed-by: psandoz, darcy
2016-08-25 17:58:39 -07:00
Maurizio Cimadamore
2c2d5c4917 8164399: inference of thrown variable does not work correctly
Logic for inferring thrown variables should exclude non proper bounds as per JLS 18.1

Reviewed-by: vromero, dlsmith
2016-08-25 11:51:19 +01:00
Vicente Romero
7328ed21cb 8161501: JSR269 jigsaw update: javax.lang.model.element.ModuleElement.getEnclosedElements() on unnamed module with unnamed package
Reviewed-by: jjg
2016-08-24 17:41:52 -07:00
Vicente Romero
ddbef393bc 8047338: javac is not correctly filtering non-members methods to obtain the function descriptor
Reviewed-by: mcimadamore
2016-08-24 12:23:10 -07:00
Sandeep Konchady
865b439a69 8163991: Fix license and copyright headers under test/jdk/javadoc/ and test/tools/javac/
Reviewed-by: anazarov, iris, jjg, shurailine
2016-08-23 10:19:49 +01:00
Jan Lahoda
f65c3ae869 8164550: tools/javac/modules/InheritRuntimeEnvironmentTest.java fails on Windows after JDK-8153391
Empty classpath is not working on Windows; using a classpath consisting on a sole empty dir

Reviewed-by: mcimadamore
2016-08-22 15:16:30 +02:00
Jan Lahoda
53cd7b54fa 8153391: an image created for \"jdk.compiler\" fails to run javac
Improving errors produced by javac when the zipfs implementation is missing in the JDK image.

Reviewed-by: jjg
2016-08-22 09:59:43 +02:00
Srikanth Adayapalam
6c2a33a67b 8162576: Missing doclint check missing for modules
Co-authored-by: Lance Andersen <lance.andersen@oracle.com>
Reviewed-by: jjg, ksrini
2016-08-17 10:34:48 +05:30
Jan Lahoda
d103a19b3a 8078561: Error message should be generated once when -source 6 is specified
Code to avoid duplicated errors about features not supported in the current source level moved to Log

Reviewed-by: jjg
2016-08-16 16:43:00 +02:00
Srikanth Adayapalam
c7f35c53af 8157512: AssertionError in javac when module-info < v53.0
Reviewed-by: jjg
2016-08-16 09:45:19 +05:30
Srikanth Adayapalam
8513d8d26f 8157519: Error messages when compiling a malformed module-info.java confusing
Reviewed-by: jjg
2016-08-16 09:13:33 +05:30
Jonathan Gibbons
9208c82732 8162353: javadoc should provide a way to disable use of frames
Reviewed-by: bpatel, ksrini
2016-08-15 18:00:36 -07:00
Joe Darcy
66ff418a4b 8163999: Workaround intermittent failures of TreePosTest.java due to C2 memory usage
Reviewed-by: jjg
2016-08-15 13:42:34 -07:00
Jonathan Gibbons
0ae5880c01 8052398: Uniqify test framework class names
Reviewed-by: darcy
2016-08-12 17:45:31 -07:00
Srikanth Adayapalam
37028f8abc 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
Reviewed-by: mcimadamore, ksrini
2016-08-12 11:49:18 +05:30
Jan Lahoda
ec9ca2997f 8133884: javac moduleName/className and moduleName/packageName options
8162711: javax.lang.model.util.Elements.getModuleElement returns null during annotation processing on class files

Adding a test for annotation processing for <module-name>/<class-name>; ensuring the <module-name> module is in the module graph.

Reviewed-by: jjg
2016-08-11 17:26:12 +02:00
Jonathan Gibbons
978417c4c7 8136930: Simplify use of module-system options by custom launchers
8160489: Multiple -Xpatch lines ignored by javac
8156998: javac should support new option -XinheritRuntimeEnvironment

Reviewed-by: jlahoda, ksrini
2016-08-10 15:47:46 -07:00
Vicente Romero
3b80559162 8160156: javac is generating let expressions unnecessarily
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2016-08-10 13:52:02 -07:00
Jan Lahoda
39de28475b 8143048: Re-examine dependency on property sun.boot.class.path
Removing obsolete references to sun.boot.class.path

Reviewed-by: jjg
2016-08-09 20:27:06 +02:00
Jan Lahoda
d898c2f21c 8144733: Iterating over elements of a Scope can return spurious inner class elements
When a Symbol is removed from a Scope while iterating over it, update the iterator as well to reflect the change.

Reviewed-by: mcimadamore
2016-08-08 17:22:44 +02:00
Jonathan Gibbons
b601617d9c 8162359: javac should use stdout for --help and --version
Reviewed-by: vromero
2016-08-03 16:01:09 -07:00
Joe Darcy
498a90cde6 8163113: langtools repeating annotations tests depend rely on annotations toString output
Reviewed-by: jlahoda, vromero
2016-08-03 11:30:27 -07:00
Steve Drach
e6f3a52942 8143366: Control characters in constant pool strings are not escaped properly
Reviewed-by: jjg
2016-07-29 12:27:08 -07:00
Kumar Srinivasan
281438728d 8154705: invalid use of ALL-MODULE-PATH causes crash
Introducing Modules.initModules as a clear point where the module graphs is initialized in javac

Reviewed-by: jjg, ksrini
2016-07-20 12:49:32 -07:00
Srikanth Adayapalam
90a4b8ab1a 8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
Reviewed-by: jlahoda
2016-07-28 10:13:34 +05:30
Vicente Romero
00275bd95e 8161277: javax.lang.model.util.Types.isSameType(...) returns true on wildcards
Reviewed-by: mcimadamore
2016-07-27 07:07:10 -07:00
Vicente Romero
8480651475 8161019: javac, fold formatter options
Reviewed-by: mcimadamore, jjg
2016-07-26 07:45:29 -07:00
Maurizio Cimadamore
f89b798523 8161985: Spurious override of Object.getClass leads to NPE
Attr.adjustMethodReturnType() tweaks return types w/o checking what method is being patched

Reviewed-by: vromero
2016-07-22 12:38:06 +01:00
Vicente Romero
0bba28db43 8161383: javac is looking for operator symbols at the wrong place
Reviewed-by: mcimadamore
2016-07-19 11:27:56 -07:00
Dan Smith
a78d1e0b44 8161013: Never treat anonymous classes as 'final'
Reviewed-by: vromero
2016-07-14 11:57:15 -06:00
Mandy Chung
de4f424b8c 8160398: (jdeps) Replace a list of JDK 8 internal API for detecting if it's removed in JDK 9 or later
Reviewed-by: dfuchs
2016-07-13 14:41:27 -07:00
Vicente Romero
a7cc024b53 8161020: javac, fold stop compilation options
Reviewed-by: mcimadamore
2016-07-11 15:27:52 -07:00
Srikanth Adayapalam
0917774834 8160928: javac incorrectly copies over interior type annotations to bridge method
Reviewed-by: mcimadamore
2016-07-11 18:13:42 +05:30
Vicente Romero
bec16625dc 8153407: javac, fold debug options
Reviewed-by: mcimadamore, jjg
2016-07-08 16:47:13 -07:00
Vicente Romero
57474ae8fb 8048543: JLS8 18.5.3: inference variable seems to be instantiated unexpectedly
Reviewed-by: mcimadamore
2016-07-06 15:27:36 -07:00
Vicente Romero
3360117337 8160891: javac, remove unused options, step 3
Reviewed-by: mcimadamore
2016-07-06 09:42:27 -07:00
Srikanth Adayapalam
928c417cd8 8132446: AsssertionError in ClassSymbol.setAnnotationType
Reviewed-by: jlahoda, darcy
2016-07-04 14:57:33 +05:30
Jan Lahoda
d3eaa80bdd 8148131: compilation result depends on order of sources
Complete during imports phase should not trigger the hierarchy phase

Reviewed-by: mcimadamore
2016-07-04 08:52:45 +02:00
Jan Lahoda
0cc565280e 8155026: javac grants implied readability to explicit modules
Automatic modules should not 'requires public' ordinary named modules

Reviewed-by: jjg
2016-06-28 13:33:04 +02:00
Vicente Romero
0df5aa8678 8159970: javac, JLS8 18.2.4 is not completely implemented by the compiler
Reviewed-by: mcimadamore
2016-06-28 15:29:20 -07:00
Jan Lahoda
11272cf548 8132857: Historical name of default encoding shown on encoding mismatch
Using Charset.defaultCharset().name() to get the proper name of the default Charset.

Reviewed-by: jjg
2016-06-28 15:46:52 +02:00
Vicente Romero
b69fa0a44d 8159439: javac throws NPE with Module attribute and super_class != 0
Reviewed-by: jjg
2016-06-27 12:29:41 -07:00
Jan Lahoda
6f94a3f4bf 8136453: Parameter name indices array size not updated correctly
Correctly resizing ClassReader.parameterNameIndices array.

Reviewed-by: mcimadamore
2016-06-21 21:06:54 +02:00
Jonathan Gibbons
aba0a631d8 8159537: create build file to generate diags reports for all locales
Reviewed-by: mcimadamore
2016-06-20 13:21:09 -07:00
Kumar Srinivasan
2b450085d5 8159756: javadoc tests needs a tool invoker
Reviewed-by: jjg
2016-06-20 07:02:42 -07:00
Jonathan Gibbons
6f1a819053 8159749: Update toolbox ModuleBuilder for doc comments
Reviewed-by: ksrini
2016-06-17 17:40:01 -07:00
Mandy Chung
b41054bc29 8159524: jdeps -jdkinternals throws NPE when no replacement is known
Reviewed-by: dfuchs
2016-06-17 14:33:54 -07:00
Maurizio Cimadamore
62648293e7 8159680: Inference failure with unchecked subtyping and arrays
Discrepancy in handling of capture conversion between Types.isSubtype and Types.isSubtypeUnchecked

Reviewed-by: vromero
2016-06-17 18:17:16 +01:00
Vicente Romero
3f3cc40ea1 8058244: missing error in qualified default super call
Reviewed-by: mcimadamore
2016-06-14 12:46:35 -07:00
Vicente Romero
d4a743435b 8068460: Pretty printing for loops
Reviewed-by: jjg
2016-06-14 11:13:14 -07:00
Shinya Yoshida
e4edbb4617 8158123: NPE when the annotations is used in export-to of module-info
Reviewed-by: mcimadamore
2016-06-11 09:47:59 +09:00
Dan Smith
5cffc0a3ab 8144767: Fix handling of capture variables in most-specific test
Reviewed-by: vromero
2016-06-10 15:08:00 -06:00
Alexandre Iline
57b82df0b9 8157975: Remove duplicate files in sample API
Reviewed-by: jjg, ksrini
2016-06-02 17:31:38 -07:00
Vicente Romero
32e8e4695d 8037947: functional interface causes ClassCastException when extending raw superinterface
Reviewed-by: mcimadamore
2016-06-02 15:39:10 -04:00
Maurizio Cimadamore
17c048ae32 8158355: Inference graph dot support broken
IllegalStateException when converting an inference graph to dot file

Reviewed-by: vromero
2016-06-02 16:08:24 +01:00
Srikanth Adayapalam
ab5510e51f 8146167: Anonymous type declarations drop supertype type parameter annotations
Reviewed-by: mcimadamore
2016-06-02 15:22:34 +05:30
Maurizio Cimadamore
8fb837a1bf 8145489: NPE while compiling annotations with qualified names in package-info.java
Spurious method reference check in Attr.visitSelect is causing NPE

Reviewed-by: vromero
2016-06-01 12:39:24 +01:00
Vicente Romero
8d93dc2a15 8152062: obscure error message for bad 'provides'
Reviewed-by: jjg
2016-05-31 13:00:17 -04:00
Jonathan Gibbons
a8abf4d482 Merge 2016-05-26 10:46:21 -07:00
Jonathan Gibbons
6cb53fe31c 8156962: javac should support options specified in _JAVAC_OPTIONS
Reviewed-by: vromero
2016-05-26 10:45:13 -07:00
Srikanth Adayapalam
f9526a87fe 8154052: Java compiler error displays line from the wrong file
Compiler should update the diagnostic source properly.

Reviewed-by: mcimadamore
2016-05-26 18:22:05 +05:30
Joe Darcy
fff165ddd1 8032230: Enhance javax.a.p.RoundEnvironment after repeating annotations
Reviewed-by: jjg
2016-05-25 22:32:16 -07:00
Vicente Romero
de6399c1a3 8152360: deprecate javah
Reviewed-by: jjg
2016-05-25 11:33:56 -04:00
Srikanth Adayapalam
93714ca994 8047024: 7 ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
Fix incorrect assertion about exception index already being set.

Reviewed-by: mcimadamore
2016-05-25 19:30:55 +05:30
Maurizio Cimadamore
414c739476 8157149: Inference: weird propagation of thrown inference variables
Overhaul of treatment of thrown inference variables

Reviewed-by: vromero
2016-05-23 15:07:10 +01:00
Paul Sandoz
5b6c0e5152 8149821: Add VarHandle signature-polymorphic invocation byte code tests
Reviewed-by: mcimadamore
2016-05-23 12:48:18 +02:00
Srikanth Adayapalam
4917261f1c 8154824: Compiler should handle java.nio.file.FileSystemNotFoundException gracefully and not abort
Reviewed-by: jjg
2016-05-23 10:08:48 +05:30
Joe Darcy
8c88656e09 6415644: Make javax.lang.model.SourceVersion more informative
Reviewed-by: jjg
2016-05-20 17:00:03 -07:00
Jonathan Gibbons
e568099980 8157474: clean up/simplify/rename ModuleWrappers class
Reviewed-by: mchung
2016-05-20 16:44:35 -07:00
Mandy Chung
0bafc010b2 8153042: jdeps should continue to report JDK internal APIs that are removed/renamed in JDK
Reviewed-by: dfuchs
2016-05-20 12:24:02 -07:00
Mandy Chung
479ecdbdaf 8157391: jdeps left JarFile open
Reviewed-by: alanb
2016-05-20 09:47:00 -07:00
Mandy Chung
6db305ee0d 8152502: tools/jdeps/modules/GenModuleInfo.java and TransitiveDeps fails on windows
Reviewed-by: jjg
2016-05-19 17:34:05 -07:00
Iris Clark
45ede707d8 8144062: Move jdk.Version to java.lang.Runtime.Version
Reviewed-by: abuckley, alanb, forax, jjg, mchung, psandoz
2016-05-19 11:56:38 -07:00
Mandy Chung
cad01946df 8156575: Add jdeps -addmods, -system, -inverse options
Reviewed-by: dfuchs
2016-05-19 11:01:26 -07:00
Mandy Chung
bbc75367c7 8156680: jdeps implementation refresh
Reviewed-by: dfuchs
2016-05-19 10:55:33 -07:00
Srikanth Adayapalam
34b3d6385e 8154997: Add examples for jigsaw diagnostics
Reviewed-by: jjg, jlahoda
2016-05-18 11:38:20 +05:30
Jonathan Gibbons
6fa7a76e64 Merge 2016-05-17 10:13:55 -07:00
Jonathan Gibbons
6b7ce3811f 8149599: Update Minefield test
Reviewed-by: martin
2016-05-17 10:11:58 -07:00
Maurizio Cimadamore
cc3cb0640f 8156954: javac incorrectly complains of incompatible types
Add heuristics to pick best stuck constraint as per JLS 18.5.2

Reviewed-by: vromero
2016-05-17 17:53:18 +01:00
Maurizio Cimadamore
358e25664a 8154180: Regression: stuck expressions do not behave correctly
ArgumentAttr should not cache stuck trees

Reviewed-by: vromero
2016-05-16 14:51:17 +01:00
Jan Lahoda
41258c689d 8078559: Update error message to indicate illegal character when encoding set to ascii
When an input character cannot be decoded, include it in the produced error

Reviewed-by: jjg
2016-05-16 15:41:57 +02:00
Jan Lahoda
ef51223aa3 8054562: document skip results in RunCodingRules.java
Documenting when RunCodingRules gets skipped; adding a short description of AssertCheckAnalyzer and MutableFieldsAnalyzer

Reviewed-by: jjg
2016-05-16 15:41:20 +02:00
Maurizio Cimadamore
f18045ee0b 8156180: javac accepts code that violates JLS chapter 16
DA/DU analysis should skip parenthesis around variable references

Reviewed-by: vromero
2016-05-16 13:07:57 +01:00
Maurizio Cimadamore
7fa26cbc1e 8153884: Expression lambda erroneously compatible with void-returning descriptor
Fix lambda compatibility check for void returning expressions

Reviewed-by: vromero
2016-05-16 13:05:42 +01:00
Jan Lahoda
a00ea0d34f 8156097: docs build fails with StackOverflowError on Solaris
Avoiding deep recursion in TypeEnter.MembersPhase

Reviewed-by: mcimadamore
2016-05-11 17:42:17 +02:00
Jonathan Gibbons
695f11e91c 8150011: Update javac to generate V53.0 class files
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: darcy
2016-05-10 15:36:21 -07:00
Vicente Romero
9f41228dab 8153268: javac accepts enums being referenced by 'uses' statement
Reviewed-by: jjg
2016-05-06 16:06:27 -04:00
Mandy Chung
8c11293294 8154190: Deprivilege java.compiler module
Reviewed-by: alanb, chegar, jjg
2016-05-05 16:36:00 -07:00
Jan Lahoda
37c2a5ad4e 8156000: tools/all/RunCodingRules.java fails if build dir exists, but generated sources do not
RunCodingRules test compiles and runs PropertiesParser to get the generated CompilerProperties.java

Reviewed-by: mcimadamore, jjg
2016-05-04 17:06:55 +02:00
Alan Bateman
d2463eca44 Merge 2016-05-03 11:38:13 +01:00
Jonathan Gibbons
64261477b1 8154956: Module system implementation refresh (4/2016)
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg, mchung, alanb
2016-05-03 09:11:12 +01:00
Jonathan Gibbons
325a065aff 8155774: move code from ModuleTestBase to toolbox
Reviewed-by: ksrini, jlahoda
2016-05-02 16:17:39 -07:00
Jan Lahoda
d7af112d8d 8155816: langtools/tools/javac/classfiles/attributes/LineNumberTable/T8050993.java test broken
Correcting expected line numbers

Reviewed-by: alundblad
2016-05-02 12:57:05 +02:00
Jan Lahoda
8ca267abe3 8050993: There is no record for condition in ternary operator in LineNumberTable
Make sure there is an entry in the LineNumberTable for the condition of the ternary operator

Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: jjg
2016-05-02 06:43:44 +02:00
Srikanth Adayapalam
2f5a588d25 8155028: javac crashes in silly do-while loop
Compiler should short circuit code generation for unreachable code.

Reviewed-by: mcimadamore
2016-05-02 10:11:24 +05:30
Kumar Srinivasan
4be9fb29fa 8154482: javadoc tool must support legacy doclet and taglet
Reviewed-by: jjg
2016-04-29 15:35:51 -07:00
Liam Miller-Cushon
9290ce0c7b 8154270: javac wrongly rejects some class literals as annotation element values
Reviewed-by: mcimadamore
2016-04-29 14:18:09 -07:00
Jan Lahoda
d20efa360f 8154283: Check for clash between package and class not working when package in a different module
Looking for any visible package when checking for package-class clash

Reviewed-by: jjg
2016-04-15 11:39:31 +02:00
Andreas Lundblad
e85033c628 8048146: sjavac uses unexpected exit code of -1
Changed exit codes for sjavac

Reviewed-by: jlahoda
2016-03-22 13:14:12 +01:00
Oleg Barbashov
25c9be01d5 8151777: Add "@index" tag to the sampleapi generator
Reviewed-by: ksrini, bpatel
2016-04-20 17:17:56 -07:00
Jan Lahoda
d6521300a0 7020499: Project Coin: improvements to try-with-resources desugaring
Avoid unnecessary check for resource nullness if the resource is known to be non-null; put resource closing code in a method that is shared by multiple try-with-resources.

Reviewed-by: darcy, mcimadamore, vromero
2016-04-19 14:16:39 +02:00
Jonathan Gibbons
28ed819ae9 8154500: fix handling of jdk.launcher.patch.* in tests
Reviewed-by: ksrini
2016-04-18 19:14:50 -07:00
Jonathan Gibbons
8f62cdc8a0 8154504: javac tests fail after JDK API is deprecated
Reviewed-by: darcy
2016-04-18 18:41:38 -07:00
Andreas Lundblad
9691505077 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
Javac no longer issues warnings for missing serialVersionUID in anonymous classes.

Reviewed-by: jlahoda
2016-04-18 22:25:50 +02:00
Andreas Lundblad
4b662bba26 8036952: copyright issues in jdk9/dev/langtools files
Updated copyright notices.

Reviewed-by: jjg, jlahoda
2016-04-18 21:07:50 +02:00
Steve Drach
e652402ed2 8149757: Implement Multi-Release JAR aware JavacFileManager for javac
Reviewed-by: jjg, jlahoda
2016-04-14 17:51:30 -07:00
Jan Lahoda
5cc78b2a2b 8154149: tools/javac/unit/T6198196.java broken on Windows after JDK-8150641
Avoiding interference among sub-tests due to CacheFSInfo by using a new file manager for each sub-test

Reviewed-by: jjg
2016-04-13 19:44:19 +02:00
Kumar Srinivasan
acf90220b2 8073100: [javadoc] Provide an ability to suppress document generation for specific elements
Reviewed-by: jjg
2016-04-10 08:41:00 -07:00
Chris Hegarty
0adea15d1b 8153737: Unsupported Module
Reviewed-by: alanb, mchung, psandoz
2016-04-09 19:49:59 +01:00
Maurizio Cimadamore
945406686e 8152832: Type inference regression in javac
Stale incoropration actions caused missing inference bounds

Reviewed-by: vromero
2016-04-08 10:52:26 +01:00
Vicente Romero
63eb0ee007 8151191: javac error when running javadoc on some inner classes
Reviewed-by: jjg
2016-04-06 13:49:50 -04:00
Alan Bateman
337d1abca4 8153370: Drop use of old style -XaddExports from tests
Reviewed-by: mchung
2016-04-05 21:17:25 +01:00
Jonathan Gibbons
b892b6e3f0 8153416: unexport javah from jdk.compiler module
Reviewed-by: mchung
2016-04-04 12:34:42 -07:00
Kumar Srinivasan
baf7e598c8 8152771: NPE accessing comments on module declarations
Reviewed-by: jjg
2016-03-29 10:24:30 -07:00
Jonathan Gibbons
7812306bc0 8152897: refactor ToolBox to allow reduced documented dependencies
Reviewed-by: vromero
2016-03-31 15:20:50 -07:00
Vicente Romero
332e2c9a68 8150733: NPE when compiling module-info.java with a class declaration in a non-module mode
Reviewed-by: jjg
2016-03-31 17:25:58 -04:00
Maurizio Cimadamore
fd0031d702 8152411: Regression: inference fails to reject incompatible upper bounds
Wrong undet variable comparison in propagation optimization

Reviewed-by: vromero
2016-03-23 16:59:02 +00:00
Andreas Lundblad
e449ba161c 8027999: Poorly worded error message when attempting to assign to this
Changed the error message when trying to assign to this.

Reviewed-by: jjg
2016-03-23 13:39:15 +01:00
Mandy Chung
90d403e786 8152503: tools/javac/completionDeps/DepsAndAnno.java fails after jigsaw m3
Reviewed-by: darcy
2016-03-22 19:34:47 -07:00
Alan Bateman
001ebb3a72 8142968: Module System implementation
Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282

Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Co-authored-by: Andreas Lundblad <andreas.lundblad@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Kumar Srinivasan <kumar.x.srinivasan@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jjg, jlahoda, vromero, mcimadamore, bpatel, ksrini, darcy, anazarov, dfuchs
2016-03-17 19:04:28 +00:00
Aleksey Shipilev
0a352526f3 8151516: test/tools/javac/TestIndyStringConcat depends on runtime JDK details
Reviewed-by: mcimadamore
2016-03-09 18:31:49 +03:00
Aleksey Shipilev
a0224437fc 8151223: String concatenation fails with implicit toString() on package-private class
Reviewed-by: mcimadamore, forax
2016-03-09 12:52:14 +03:00
Vicente Romero
306361b292 8139474: -release 7 -verbose causes Javac exception
Reviewed-by: jjg
2016-03-07 13:45:38 -05:00
Srikanth Adayapalam
3a3ef10033 8148930: Incorrect erasure of exceptions in override-equivalent dual interface impl
Before computing intersection of thrown types, javac must make sure type variables come from the same set.

Reviewed-by: mcimadamore
2016-03-07 18:49:02 +05:30
Srikanth Adayapalam
460020d183 8151134: Fix bug id in test for JDK-8151018
Reviewed-by: jlahoda
2016-03-03 15:07:29 +05:30
Srikanth Adayapalam
433d2a7dbb 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
Reviewed-by: mcimadamore
2016-03-03 06:10:58 +05:30
Andreas Lundblad
c685f3567f 8061320: Sjavac should prevent using source dir as dest dir
Sjavac now makes sure that src and dst dirs do not overlap.

Reviewed-by: jlahoda
2016-03-02 13:12:24 +01:00
Andreas Lundblad
49850dd82f 8147569: Error messages from sjavac server does not always get relayed back to client
Refactored how logging works in sjavac.

Reviewed-by: jlahoda
2016-02-29 13:24:01 +01:00
Jonathan Gibbons
be76f3e83b 8150475: -sourcepath / crashes javac
Reviewed-by: darcy, vromero
2016-02-23 19:17:54 -08:00
Vicente Romero
0698afcea9 8149600: javac, remove unused options, step 2
Reviewed-by: jjg, mcimadamore
2016-02-22 16:17:25 -08:00
Aleksey Shipilev
512b3becc6 8149835: StringConcatFactory should emit classes with the same package as the host class
Reviewed-by: psandoz, alanb, mchung
2016-02-17 19:29:25 +03:00