64 Commits

Author SHA1 Message Date
Coleen Phillimore
8e63a10779 8148772: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool
8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

ConstantPool::resolve_constant_at_impl() isn't thread safe for MethodHandleInError and MethodTypeInError and Constant pool merging is not thread safe for source_file_name.

Reviewed-by: sspitsyn, dcubed
2016-04-13 12:57:31 -04:00
Max Ockner
ac0824cbad 8152468: PrintMiscellaneous in constantPool should use classresolve logging
Some instances of PrintMiscellaneous have ben replaced by classresolve logging.

Reviewed-by: coleenp, rprotacio
2016-04-11 11:33:52 -04:00
Joseph Provino
5cef85023b 8132524: Missing includes to resourceArea.hpp
Files that use ResourceMark are missing the include of resourceArea.hpp

Reviewed-by: tschatzl, jwilhelm
2016-04-04 12:57:48 -04:00
Max Ockner
155a64deb4 8146551: The output from classresolve tag has been shortened and moved to debug level
The output from classresolve tag has been shortened and moved to debug level.

Reviewed-by: coleenp, rprotacio
2016-03-10 15:52:56 -05:00
Goetz Lindenmaier
b26df6b69f 8146401: Clean up oop.hpp: add inline directives and fix header files
Reviewed-by: coleenp
2016-01-04 15:41:05 +01:00
Max Ockner
de7d9e821c 8144874: Reimplement TraceClassResolution with Unified Logging
TraceClassResolution reimplemented with classresolve tag.

Reviewed-by: coleenp, dholmes, iklam, rprotacio
2015-12-23 15:05:38 -05:00
Markus Grönlund
2ad9d3192f 8140485: Class load and creation cleanup
Reviewed-by: hseigel, coleenp, sspitsyn
2015-12-08 20:04:03 +01:00
Jesper Wilhelmsson
b1e3e8436a Merge 2015-10-30 00:02:37 +01:00
Coleen Phillimore
fc03719078 8139203: Consistent naming for klass type predicates
8138923: Remove oop coupling with InstanceKlass subclasses

Renamed oop_is_instance and friends, removed the functions in oop that dug down into InstanceKlass.

Reviewed-by: jrose, lfoltan, stefank
2015-10-28 09:47:23 -04:00
Mikael Gerdin
d281188a5f 8140452: Internal Error memory/allocation.cpp:179
Use const ref & and avoid copy ctor

Reviewed-by: coleenp
2015-10-26 17:13:40 -04:00
Coleen Phillimore
5179fc3488 8139163: InstanceKlass::cast passes through NULL
Reduce raw (InstanceKlass*) casts and InstanceKlass::cast, which no long allows null

Reviewed-by: twisti, kbarrett
2015-10-26 13:11:36 -04:00
Coleen Phillimore
f1e89ea4cc 8140274: methodHandles and constantPoolHandles should be passed as const references
Modified code to use const reference parameters

Reviewed-by: sspitsyn, twisti
2015-10-23 16:48:38 -04:00
David Lindholm
5770f4eb32 8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
8042894: runtime: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files

Reviewed-by: goetz, brutisso
2015-10-09 09:42:33 +02:00
David Lindholm
1e71f67736 8080775: Better argument formatting for assert() and friends
Reviewed-by: kbarrett, pliden
2015-09-29 11:02:08 +02:00
Bill Pittore
304b59b0c8 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
Need to add a space between macro identifier and string literal

Reviewed-by: stefank, dholmes, kbarrett
2015-06-24 12:12:25 -04:00
Coleen Phillimore
7b384c6958 8061205: MetadataOnStackMark only needs to walk code cache during class redefinition
Only do full metadata walk during class redefinition and only walk handles during class unloading.

Reviewed-by: sspitsyn, stefank
2015-03-13 12:40:39 -04:00
Stefan Karlsson
4913ad5d7d 8072911: Remove includes of oop.inline.hpp from .hpp files
Reviewed-by: brutisso, coleenp, jwilhelm, simonis, dholmes
2015-02-13 14:37:35 +01:00
Serguei Spitsyn
8be0bb5458 8008678: JSR 292: constant pool reconstitution must support pseudo strings
Keep orig idx from pseudo-string to UTF8, use 2nd lsb CPSlot to mark pseudo-string.

Reviewed-by: coleenp, jrose
2015-01-29 03:11:01 -08:00
Stefan Karlsson
95704b233c 8064811: Use THREAD instead of CHECK_NULL in return statements
Reviewed-by: coleenp, simonis, dholmes
2014-11-14 09:47:09 +01:00
Coleen Phillimore
63080521d7 8058093: Test nsk/stress/jck60/jck60014: assert in src/share/vm/oops/constantPool.cpp: should not be resolved otherwise
8044209: nsk/split_verifier/security/coglio06 fails with exit code 97 - missing 'prohibited package name'

Fix resolution error saving.

Reviewed-by: lfoltan, sspitsyn, hseigel, ctornqvi
2014-10-28 17:02:08 -04:00
Stefan Karlsson
d410f19961 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
2014-10-02 10:55:36 +02:00
Coleen Phillimore
06cea98803 8048933: -XX:+TraceExceptions output should include the message
Add the exception detail message to the tracing output

Reviewed-by: minqi, dholmes
2014-07-09 22:37:48 -04:00
Coleen Phillimore
243d697d71 8026977: NPG: Remove ConstantPool::lock
Write klass and resolved_references constant pool fields lock free.

Reviewed-by: jrose, twisti
2014-06-19 11:16:10 -04:00
Coleen Phillimore
388434f387 Merge 2014-05-12 09:47:57 -04:00
David Chase
305ec3bd3f 8037816: Fix for 8036122 breaks build with Xcode5/clang
Repaired or selectively disabled offending formats; future-proofed with additional checking

Reviewed-by: kvn, jrose, stefank
2014-05-09 16:50:54 -04:00
Coleen Phillimore
39f7049fbb Merge 2014-05-07 18:19:31 -04:00
Gerard Ziemski
ed9c096396 8038654: Separate SymbolTable and StringTable code
Refactor stringTable class out of symbolTable, making sure all includes are minimal set and are sorted.

Reviewed-by: coleenp, stefank
2014-05-07 14:16:45 -05:00
Coleen Phillimore
7e2463ea72 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Cache detail message when we cache exception for constant pool resolution.

Reviewed-by: acorn, twisti, jrose
2014-05-05 19:53:00 -04:00
Tobias Hartmann
06c26b6f97 8036956: remove EnableInvokeDynamic flag
The EnableInvokeDynamic flag and all support code is removed because it is not longer used in JDK 9.

Reviewed-by: kvn, twisti
2014-04-29 08:08:44 +02:00
Coleen Phillimore
c8990959f2 8028497: SIGSEGV at ClassLoaderData::oops_do(OopClosure*, KlassClosure*, bool)
Keep class in CLD::_klasses list and mirror created for CDS classes if OOM during restore_shareable_info(). This keeps pointers consistent for CMS.

Reviewed-by: ehelin, stefank, jmasa, iklam
2014-04-08 13:58:38 -04:00
Coleen Phillimore
472622d900 8031820: NPG: Fix remaining references to metadata as oops in comments
8012125: Comments for ConstantPoolCache should reflect the addition of resolved_references in ConstantPool

Updated comments in metadata header files, and renamed this_oop variables to this_cp or this_k when referring to constant pool or classes.

Reviewed-by: stefank, jmasa
2014-03-26 21:47:45 -04:00
Staffan Larsen
e1e850a132 8035150: ShouldNotReachHere() in ConstantPool::copy_entry_to
Reviewed-by: dcubed, mgronlun
2014-02-26 15:47:44 +01:00
Coleen Phillimore
2759eb10ae 8033528: assert(0 <= i && i < length()) failed: index out of bounds
Restoring bytecodes for invokedynamic had wrong index calculation added testing stress option.

Reviewed-by: twisti, hseigel
2014-02-07 18:30:27 -05:00
Coleen Phillimore
305d2f27f1 8028275: Metaspace ShrinkGrowTest causes fatal error if run with JFR
Clean up initialization from Threads::create_vm() so that exceptions cause vm_exit_during_initialzation without an exception mark.

Reviewed-by: dholmes, hseigel
2014-01-27 23:12:13 -05:00
Ioi Lam
0e4eda601c 8014910: deadlock between JVM/TI ClassPrepare event handler and CompilerThread
Revert changes in JDK-8008962

Reviewed-by: coleenp, sspitsyn
2013-10-22 14:29:02 -07:00
Coleen Phillimore
fa72ad21f9 8022592: assert at constantTag.cpp:57: ShouldNotReachHere()
More missing cases for JVM_CONSTANT_Method{Handle,Type}InError

Reviewed-by: hseigel, dcubed
2013-10-11 11:23:49 -04:00
Coleen Phillimore
62fc4be9cb 8025185: MethodHandleInError and MethodTypeInError not handled in ConstantPool::compare_entry_to and copy_entry_to
Add missing cases.

Reviewed-by: sspitsyn, dcubed
2013-10-09 21:45:28 -04:00
Lois Foltan
7bf953d005 7195622: CheckUnhandledOops has limited usefulness now
Enable CHECK_UNHANDLED_OOPS in fastdebug builds across all supported platforms.

Reviewed-by: coleenp, hseigel, dholmes, stefank, twisti, ihse, rdurbin
2013-09-26 10:25:02 -04:00
Ioi Lam
522051490c 8025088: Missing cases for JVM_CONSTANT_MethodHandleInError cause crash if debugger steps into error-tagged method handle
Need to refetch each method from InstanceKlass after all safepoints.  Removed leaky PreviousVersionInfo code.

Reviewed-by: coleenp, sspitsyn
2013-09-23 08:56:19 -07:00
Daniel D. Daugherty
80b2573b1c Merge 2013-09-20 18:19:07 -07:00
Coleen Phillimore
42589e0f11 8014956: nashorn/api/javaaccess/MethodAccessTest.java test fails on sparc-solaris 64
Reference_map[] array had uninitialized junk that was causing a bogus bootstrap method to be found.

Reviewed-by: hseigel, dcubed, sspitsyn
2013-09-20 18:34:00 -04:00
David Chase
222c735458 8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
Enhance method resolution and resulting data structures, plus some refactoring.

Reviewed-by: twisti, acorn, jrose
2013-09-13 22:38:02 -04:00
Coleen Phillimore
39a1c1d6c2 8016325: JVM hangs verifying system dictionary
Minimize redundant verifications of Klasses.

Reviewed-by: hseigel, jmasa
2013-06-24 18:55:46 -04:00
Ioi Lam
9dc36eb923 8014912: Restore PrintSharedSpaces functionality after NPG
Added dumping of object sizes in CDS archive, sorted by MetaspaceObj::Type

Reviewed-by: coleenp, acorn
2013-05-28 16:36:19 -07:00
Calvin Cheung
7cb20773ad 8015265: revise the fix for 8007037
Reviewed-by: sspitsyn, dholmes, dcubed
2013-05-24 17:19:56 -07:00
Ioi Lam
4e19360f89 8008962: NPG: Memory regression: One extra Monitor per ConstantPool
Re-use InstanceKlass::_init_lock locking ConstantPool as well.

Reviewed-by: dholmes, coleenp, acorn
2013-04-25 12:55:49 -07:00
Serguei Spitsyn
333cf9a756 8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands
References from operands to CP entries and back must be correct after CP merge

Reviewed-by: coleenp, twisti
2013-04-25 03:58:53 -07:00
Mikael Vidstedt
eeb83733a6 8003310: Enable -Wunused-function when compiling with gcc
Add the -Wunused-function flag and remove a number of unused functions.

Reviewed-by: dholmes, coleenp, kvn
2013-04-04 10:01:26 -07:00
Morris Meyer
6c55facb77 8009593: [parfait] Null pointer deference in hotspot/src/share/vm/oops/constantPool.cpp
Added guarantee() to print_entry_on()

Reviewed-by: kvn
2013-03-21 10:13:56 -07:00
Coleen Phillimore
b8b9434a9f 8000797: NPG: is_pseudo_string_at() doesn't work
Zero Symbol* for constant pool strings to indicate pseudo_strings (objects that aren't strings).  Clean up JVM_CONSTANT_Object and unused flags.

Reviewed-by: sspitsyn, jrose
2013-02-22 08:36:42 -05:00