Commit Graph

7299 Commits

Author SHA1 Message Date
Roberto Castañeda Lozano
4e8338eb13 8255763: C2: OSR miscompilation caused by invalid memory instruction placement
Disable GCM hoisting of memory-writing nodes for irreducible CFGs. This prevents
GCM from wrongly "hoisting" stores into descendants of their original loop. Such
an "inverted hoisting" can happen due to CFGLoop::compute_freq()'s inaccurate
estimation of frequencies for irreducible CFGs.

Extend CFG verification code by checking that memory-writing nodes are placed in
either their original loop or an ancestor.

Add tests for the reducible and irreducible cases. The former was already
handled correctly before the change (the frequency estimation model prevents
"inverted hoisting" for reducible CFGs), and is just added for coverage.

This change addresses the specific miscompilation issue in a conservative way,
for simplicity and safety. Future work includes investigating if only the
illegal blocks can be discarded as candidates for GCM hoisting, and refining
frequency estimation for irreducible CFGs.

Reviewed-by: kvn, chagedorn
2020-12-21 13:04:24 +00:00
Brent Christian
e680ebeb2f 8258007: Add instrumentation to NativeLibraryTest
Reviewed-by: mchung, naoto
2020-12-19 00:17:02 +00:00
Jonathan Gibbons
c04c7e1f10 8258002: Update "type" terminology in generated docs
Reviewed-by: hannesw
2020-12-18 18:34:25 +00:00
Hannes Wallnöfer
45bd3b9ec0 8223607: --override-methods=summary ignores some signature changes
Reviewed-by: jjg
2020-12-18 15:46:25 +00:00
Joel Borggrén-Franck
1cc98bde67 8256693: getAnnotatedReceiverType parameterizes types too eagerly
Reviewed-by: vromero
2020-12-18 13:34:36 +00:00
Sergey Bylokhov
7afb01dce9 8258373: Update the text handling in the JPasswordField
Reviewed-by: kizune, prr, psadhukhan
2020-12-18 06:26:16 +00:00
Stuart Marks
cbc3feeb89 8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812
Reviewed-by: naoto
2020-12-18 00:36:33 +00:00
Nils Eliasson
7320e051ea 8258647: TestCharVect2 is very slow
Reviewed-by: vlivanov, kvn
2020-12-17 22:43:00 +00:00
Rajan Halade
9fdfc6dfc6 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
8258630: Add expiry exception for QuoVadis root certificate

Backport-of: 666e6c4033
2020-12-17 22:14:25 +00:00
Jonathan Gibbons
30ca0a5d4b 8247994: Localize javadoc search
Reviewed-by: hannesw, ihse
2020-12-17 18:34:27 +00:00
Vicente Romero
47c180da43 8258515: javac should issue an error if an annotation is nested in a local class or interface
Reviewed-by: jjg
2020-12-17 18:08:35 +00:00
Nils Eliasson
cb5a6b1a7d 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
Reviewed-by: vlivanov, thartmann, kvn
2020-12-17 17:50:53 +00:00
Alexey Semenyuk
61cbf0fffe 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
Reviewed-by: almatvee, herrick
2020-12-17 15:33:03 +00:00
Markus Grönlund
7aac4dc175 8257621: JFR StringPool misses cached items across consecutive recordings
Reviewed-by: egahlin
2020-12-17 14:34:44 +00:00
Christian Hagedorn
04a1e5b75b 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
Reviewed-by: thartmann, kvn, dcubed
2020-12-17 08:09:19 +00:00
Guoxiong Li
41f312eb64 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation
Reviewed-by: jfranck, vromero
2020-12-17 08:06:35 +00:00
Jonathan Gibbons
ce0ab2dd84 8258338: Support deprecated records
Reviewed-by: hannesw
2020-12-16 22:26:57 +00:00
Anton Litvinov
87644a2bb7 8255880: UI of Swing components is not redrawn after their internal state changed
Reviewed-by: prr
Backport-of: e8c40bafa5
2020-12-16 19:48:07 +00:00
Calvin Cheung
b5a3a5b621 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
Reviewed-by: redestad, coleenp
2020-12-16 02:37:29 +00:00
Pankaj Bansal
e7aa5fe602 8258427: Problem List some tests related to FileDialog for MacOS
Reviewed-by: prr, serb
2020-12-15 21:28:50 +00:00
Christian Hagedorn
ce36aeaac3 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
Reviewed-by: kvn, thartmann
2020-12-15 15:14:34 +00:00
Maurizio Cimadamore
7ff9c85639 8258242: Type profile pollution occurs when memory segments of different kinds are used
Reviewed-by: vlivanov, redestad
2020-12-15 13:50:40 +00:00
Richard Reingruber
09e8675f56 8255381: com/sun/jdi/EATests.java should not suspend graal threads
Reviewed-by: cjplummer, mdoerr, sspitsyn
2020-12-15 08:38:58 +00:00
Hannes Wallnöfer
164c8a6e18 8258092: Link to early access platform documentation in TestHtmlTableTags.java
Reviewed-by: jjg
2020-12-14 08:08:57 +00:00
Martin Buchholz
43dc3f7992 8254350: CompletableFuture.get may swallow InterruptedException
Reviewed-by: alanb, dl
2020-12-13 19:17:36 +00:00
Aleksey Shipilev
6d79ec87fb 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
Reviewed-by: iignatyev, kvn
2020-12-12 06:09:57 +00:00
Vladimir Ivanov
b1afed7501 8257919: [JVMCI] profiling info didn't change after reprofile
Reviewed-by: kvn, redestad
2020-12-11 21:50:49 +00:00
Vicente Romero
b7ac32d6ee 8257598: Clarify what component values are used in Record::equals
Reviewed-by: darcy, chegar
2020-12-11 19:16:34 +00:00
Markus Grönlund
e90d0d1da4 8258065: ProblemList JfrGTestAdaptiveSampling
Reviewed-by: iignatyev
2020-12-10 22:25:23 +00:00
Maurizio Cimadamore
37043b0557 8257837: Performance regression in heap byte buffer views
Reviewed-by: chegar, roland
2020-12-10 15:32:36 +00:00
Markus Grönlund
502a5241e5 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)
Co-authored-by: Jaroslav Bachorik <jbachorik@openjdk.org>
Reviewed-by: egahlin, jbachorik
2020-12-10 12:33:48 +00:00
Christoph Langer
29ffffa7b9 8257997: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java again reports leaks after JDK-8257884
Reviewed-by: mbaesken
2020-12-10 10:56:36 +00:00
Kim Barrett
db5da9619b 8257876: Avoid Reference.isEnqueued in tests
Reviewed-by: mchung, tschatzl
2020-12-10 10:34:47 +00:00
Daniel Fuchs
4a839e95de 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information
Reviewed-by: chegar
2020-12-10 10:09:29 +00:00
Roland Westrelin
d93293f31b 8256730: Code that uses Object.checkIndex() range checks doesn't optimize well
Reviewed-by: vlivanov, thartmann
2020-12-10 08:09:08 +00:00
Michael Edgar
6847bbbb11 8255918: XMLStreamFilterImpl constructor consumes XMLStreamException
Reviewed-by: joehw
2020-12-10 03:40:01 +00:00
Phil Race
f631a9901f 8256888: Client manual test problem list update
Reviewed-by: serb
2020-12-10 01:36:52 +00:00
Alexander Matveev
eb1c8a15b6 8257924: Use full path when running external executable from jpackage
Reviewed-by: herrick, asemenyuk
2020-12-10 01:01:38 +00:00
Andy Herrick
1ce2a36c7b 8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618
Reviewed-by: almatvee, asemenyuk, prr, kizune
2020-12-10 00:50:28 +00:00
Toshio Nakamura
53e537c738 8255387: Japanese characters were printed upside down on AIX
Reviewed-by: prr, serb
2020-12-10 00:27:44 +00:00
Guoxiong Li
46c9a860b6 8245956: JavaCompiler still uses File API instead of Path API in a specific case
Reviewed-by: jjg
2020-12-09 21:09:23 +00:00
Vladimir Kozlov
fd5f6e2e19 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
Reviewed-by: iignatyev
2020-12-09 19:21:53 +00:00
Harold Seigel
d33a689b96 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
Reviewed-by: lfoltan, mchung, jlahoda, chegar
2020-12-09 19:07:11 +00:00
Marcus G K Williams
b977a7b8a5 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
Reviewed-by: stuefe
2020-12-09 18:59:09 +00:00
Jan Lahoda
bd22aa5e86 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
Co-authored-by: Bernard Blaser <bsrbnd@openjdk.org>
Reviewed-by: vromero
2020-12-09 16:49:50 +00:00
Jan Lahoda
6eff9315e1 8256950: Add record attribute support to symbol generator CreateSymbols
Reviewed-by: jjg, chegar
2020-12-09 15:05:01 +00:00
Martin Doerr
0201a33dd6 8255959: Timeouts in VectorConversion tests
Reviewed-by: psandoz, stuefe
2020-12-09 13:17:50 +00:00
Ivan Šipka
616b1f12bd 8257516: define test group for manual tests
Reviewed-by: iignatyev
2020-12-09 10:28:04 +00:00
Hannes Wallnöfer
b4615c67a3 8256580: Fault in new grid display
Reviewed-by: jjg
2020-12-09 09:21:50 +00:00
Christoph Langer
fae7961a03 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
Reviewed-by: xuelei
2020-12-09 08:12:09 +00:00