Commit Graph

1684 Commits

Author SHA1 Message Date
Sonali Goel
395f1173a9 8075164: Group 14b: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg, vromero
2015-05-15 16:59:34 -07:00
Sonali Goel
f6428eb2bb 8074425: Group 13b: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, darcy, mcimadamore
2015-05-15 16:53:42 -07:00
Sonali Goel
1ebb022e1c 8075163: Group 14a: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg, vromero
2015-05-15 16:18:16 -07:00
Sonali Goel
491703889c 8074417: Group 13a: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, mcimadamore
2015-05-15 09:53:08 -07:00
Sonali Goel
11d7b1e161 8074502: Group 13c: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, mcimadamore
2015-05-15 09:30:55 -07:00
Jan Lahoda
e21c57f2ab 8076104: Key collisions in ZipFileIndexFileObject content cache lead to wrong content
Equals&hashCode of ZipFileObject and ZipFileIndexFileObject need to be based on full entry path, not only the file name.

Reviewed-by: jjg
2015-05-15 11:41:04 +02:00
Sonali Goel
d0acf99cf6 8074408: Group 12: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:56:14 -07:00
Sonali Goel
6b7d074037 8074387: Group 11: golden files for coin tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:36:32 -07:00
Sonali Goel
190ba196a0 8068465: Group 10e: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:28:43 -07:00
Sonali Goel
64622d5d74 8068464: Group 10d: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:09:51 -07:00
Srikanth Adayapalam
e57ef90dd9 8078473: javac diamond finder crashes when used to build java.base module
Reviewed-by: mcimadamore
2015-04-27 17:36:20 +05:30
Srikanth Adayapalam
f2ee4e4240 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables
Reviewed-by: mcimadamore
2015-04-25 15:59:54 +05:30
Jonathan Gibbons
6bed31f1c5 8079191: remove remaining references to "cp -p" from langtools/test
Reviewed-by: vromero
2015-04-30 17:35:03 -07:00
Andreas Lundblad
bd17f06ead 8044196: Incorrect applying of repeatable annotations with incompatible target to type parameter
Additional applicability checks added.

Reviewed-by: jlahoda
2015-04-30 12:21:50 +02:00
Jonathan Gibbons
8c93ae0560 8078054: [TESTBUG] tools/javac/Paths/wcMineField.sh failed with "operation not permitted"
Reviewed-by: darcy
2015-04-29 15:05:33 -07:00
Jonathan Gibbons
74169dee6e 8078861: tools/javac/classfiles/attributes/Synthetic/PackageInfoTest.java fails on Windows
Reviewed-by: vromero
2015-04-28 18:57:51 -07:00
Andreas Lundblad
4c307784ae 8078600: Infinite loop when compiling annotations with -XDcompletionDeps
Added Completer::isTerminal and added NULL_COMPLETER.

Reviewed-by: jlahoda, mcimadamore
2015-04-28 22:25:36 +02:00
Andrei Eremeev
153dc079bb 8044537: Implement classfile tests for Synthetic attribute
Reviewed-by: jjg, shurailine, anazarov
2015-04-28 11:08:25 +03:00
Jan Lahoda
b97b136530 8077605: Initializing static fields causes unbounded recursion in javac
Improving detection of potential constant variable initializers; preventing infinite recursion on exception during Attr.visitLambda.

Reviewed-by: mcimadamore, vromero
2015-04-27 16:31:29 +02:00
Vicente Romero
4693c79e67 8078433: javac, some tests are failing after JDK-8078024 because of golden files mismatch
Reviewed-by: darcy
2015-04-22 11:39:06 -07:00
Vicente Romero
8c8261cbad 8078024: javac, several incorporation steps are silently failing when an error should be reported
Reviewed-by: mcimadamore
2015-04-22 09:44:15 -07:00
Andreas Lundblad
b3ddbe8cf4 8078389: Add test for -Xdoclint + -XDcompletionDeps
Test to make sure doclint and completionDeps do not interfere.

Reviewed-by: jlahoda
2015-04-22 16:11:38 +02:00
Andreas Lundblad
fc379b3042 8068737: ArrayType prints element type post order
Rewrote ArrayType.toString

Reviewed-by: jlahoda, ksrini
2015-04-21 12:10:26 +02:00
Andrei Eremeev
56c8f87b08 8042947: Implement classfile tests for AnnotationDefault attribute
Reviewed-by: jjg, shurailine, anazarov
2015-04-20 12:45:41 +03:00
Andreas Lundblad
868bdb35b2 8043984: Confusing (incorrect) error message on repeatable annotations
Adjusted error mesage for repeating annotations

Reviewed-by: jfranck, dlsmith
2015-04-17 12:37:11 +02:00
Andreas Lundblad
e17a42c26a 8073534: Confusing / incorrect error message regarding annotations on non-declarations
Adjusted error message for annotations on non-declarations.

Reviewed-by: jlahoda, dlsmith
2015-04-17 11:52:10 +02:00
Dan Smith
336a125aa0 8075520: Varargs access check mishandles capture variables
8077786: Check varargs access against inferred signature

Reviewed-by: vromero
2015-04-16 17:20:20 -06:00
Bhavesh Patel
9c427df72e 8072945: Javadoc should generate valid and compliant HTML5 output
Reviewed-by: jjg, ksrini
2015-04-13 18:05:23 -07:00
Joel Borggren-Franck
7d3885b239 8031744: Annotations on many Language Model elements are not returned
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: jfranck, mcimadamore, emc, jlahoda, jjg
2015-04-07 11:04:29 -07:00
Jonathan Gibbons
465e4dca9a 8076420: Consolidate javac file handling in javac.file package
Reviewed-by: jlahoda
2015-04-02 15:56:07 -07:00
Andrey Nazarov
15d5184652 8075752: jdk.compiler dependency can be eliminated in MethodReferenceNullCheckTest.java
Reviewed-by: jjg
2015-03-30 16:38:59 +01:00
Andrey Nazarov
9c48863bb1 8075610: java.desktop module dependency can be eliminated in tools/javac/generics/inference/5073060/GenericsAndPackages.java
Reviewed-by: jjg
2015-03-26 17:39:04 +01:00
Srikanth Adayapalam
68593842f8 7040592: Gen.java: fix code for handling 'null' literal when expected type is array
Eliminate needless checkcast when null is assigned to a multi-dimensional array typedobject

Reviewed-by: mcimadamore
2015-03-23 09:48:37 +05:30
Srikanth Adayapalam
8afd89977c 8062373: Project Coin: diamond and anonymous classes
Allow diamond inference in combination with anonymous class instance creation

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
2015-03-30 17:09:14 +05:30
Bhavesh Patel
8b611ba470 8076026: DocTree should parse hyphenated attributes correctly
Reviewed-by: jjg, ksrini
2015-03-28 10:18:27 -07:00
Vicente Romero
38527cecd5 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
Reviewed-by: mcimadamore
2015-03-27 10:11:21 -07:00
Jan Lahoda
31a45d5c86 8054220: Debugger doesn't show variables *outside* lambda
8058227: Debugger has no access to outer variables inside Lambda

Put local variables captured by lambda into the lambda method's LocalVariableTable.

Reviewed-by: mcimadamore, rfield
2015-03-26 11:34:50 +01:00
Andrei Eremeev
22d4785f1d 8049238: Implement classfile tests for Signature attribute
Reviewed-by: jjg, shurailine, anazarov
2015-03-25 10:29:14 +03:00
Maurizio Cimadamore
24c51e1e1b 8048838: type inference performance regression
Reduce redundant bounds before attempting to do pairwise lub computation during bound incorporation.

Reviewed-by: vromero
2015-03-19 11:40:47 +00:00
Maurizio Cimadamore
c03dd06d9a 8074381: java.lang.AssertionError during compiling
Add extra functional interface check to prevent crash during code generation

Reviewed-by: vromero
2015-03-19 11:39:36 +00:00
Srikanth Adayapalam
f1f1f0f7e1 8074148: Attr.visitBinary flags error at wrong position
Reviewed-by: vromero
2015-03-13 10:25:46 +05:30
Srikanth Adayapalam
c4ebb7f3c0 8071847: java.lang.NullPointerException at com.sun.tools.javac.code.Types.elemtype(Types.java:1870)
Class file reader should recover from malformed class files that contain methods incorrectly flagged as variable arity methods.

Reviewed-by: jlahoda
2015-03-13 13:15:24 +05:30
Srikanth Adayapalam
60841ee270 8050021: Improper "duplicate case label" error
Reviewed-by: jlahoda
2015-03-12 10:24:07 +05:30
Bhavesh Patel
6b21a5a5ff 8074521: Generate iframe instead of frame and frameset for index.html page
Reviewed-by: jjg, ksrini
2015-03-11 23:53:38 -07:00
Bhavesh Patel
7b6148280a 8072461: Table's field width in "Use" page generated by javadoc with '-s' is unbalanced
Reviewed-by: jjg
2015-03-11 21:57:59 -07:00
Jan Lahoda
fad1792bc4 8071851: Provide filtering of doclint checking based on packages
Introducing -Xdoclint/package:<packages> doclint option to enable/disable checking of specified packages.

Reviewed-by: jjg, darcy
2015-03-11 22:24:05 +01:00
Maurizio Cimadamore
a981871194 8074306: NULLCHK is emitted as Object.getClass
8074501: Javac fix for 8073432 is missing right test BugIDs

Correct test bugIds

Reviewed-by: jjg
2015-03-06 10:30:44 +00:00
Aleksey Shipilev
89cc77c8cb 8073432: Object.getClass() throws stackless NPE, due to C2 intrinsic
Javac should generate NPE checks using Objects.requireNonNull if -target >= 7

Reviewed-by: jlahoda
2015-03-05 15:03:07 +00:00
Srikanth Adayapalam
105275fb87 8071453: Allow interface methods to be private
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2015-03-02 10:41:08 +05:30
Maurizio Cimadamore
7b2bf7805a 8073842: Invalid method reference when referencing a method on a wildcard type
Method rteference lookup logic doesn't skip type-variables as required by javac.

Reviewed-by: jlahoda
2015-02-27 18:20:33 +00:00
Jan Lahoda
681758e0fa 8067886: Inaccessible nested classes can be incorrectly imported
Check type accessibility at the point of import when importing the type using type-import-on-demand.

Reviewed-by: mcimadamore, jfranck
2015-02-24 16:11:59 +01:00
Maurizio Cimadamore
110a99f0dd 8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
Compiler tests for .isCompound but then cast to a more specific Type subclass, resulting in CCE

Reviewed-by: vromero, jlahoda
2015-02-23 13:02:37 +00:00
Dan Smith
13490088bf 8039214: Inference should not map capture variables to their upper bounds
Update to Types.containsType; related adjustment to most-specific test

Reviewed-by: mcimadamore, vromero
2015-02-20 17:05:13 -07:00
Jan Lahoda
0a57971dd9 8067445: New modular image-based file manager skips boot classes
Taking "sun.boot.class.path" system property into account when constructing bootclasspath for modular images.

Reviewed-by: jjg, mcimadamore
2015-02-17 15:39:05 +01:00
Srikanth Adayapalam
31b752c691 8073201: Incorrect @bug annotation in checkin for JDK-8069545
Reviewed-by: mcimadamore
2015-02-16 19:14:18 +05:30
Maurizio Cimadamore
b91b333053 8071241: Investigate alternate strategy for type-checking operators
Separat operator lookup logic from overload resolution.

Reviewed-by: jjg, jlahoda, sadayapalam
2015-02-16 12:24:25 +00:00
Eric McCorkle
b014a7728f 8066725: javac produces classfiles it cannot read
Revert behavioral changes from 8029012 and 8065132

Reviewed-by: jfranck
2015-02-13 17:00:45 -05:00
Srikanth Adayapalam
cb2a21c5a5 8069545: javac shouldn't check nested stuck lambdas during overload resolution
Nested lambdas should not be considered while overload resolution is in progress

Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: mcimadamore
2015-02-12 10:16:19 +05:30
Maurizio Cimadamore
dbe88a2ef1 8072445: tools/javac/lambda/MethodReference55.java fails across platforms
Remove copyright from test header

Reviewed-by: jlahoda
2015-02-05 18:51:09 +00:00
Srikanth Adayapalam
74f6de6859 8069265: ClassCastException when compiled with JDK 9b08+, JDK8 compiles OK
Alternate fix for 8015499 to eliminate extra checkcast (by working around a limitation in Types#asSuper) without the side effect that results in 8069265

Reviewed-by: mcimadamore, jjg
2015-02-02 18:52:16 +05:30
Sonali Goel
b523cb6aaa 8071629: Write new test to test -j switch
Reviewed-by: jjg
2015-01-30 14:59:47 -08:00
Mandy Chung
5035f5b1d4 8068937: jdeps shows "not found" if target class has no reference other than its own package
Reviewed-by: alanb
2015-01-27 19:50:41 -08:00
Sonali Goel
a67e9f2d36 8068463: Group 10c: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2015-01-27 15:11:57 -08:00
Jan Lahoda
edc2052f33 8069254: Warning issued despite @SafeVarargs annotation on constructor
The Symbol created for diamond inference does not have annotations attached - need to look for @SafeVarargs on the underlying constructor's Symbol.

Reviewed-by: mcimadamore
2015-01-23 15:14:53 +01:00
Srikanth Adayapalam
25c0dd9958 8071310: Tests missing for checkin for JDK-8046977
Reviewed-by: jlahoda
2015-01-22 09:50:03 +01:00
Joel Borggrén-Franck
4b78cb3eb7 8070507: LambdaLambdaSerialized can fail in -agentvm mode
Reviewed-by: mcimadamore
2015-01-21 19:02:20 +01:00
Jan Lahoda
8944d18416 8069094: SuppressWarnings(\"deprecation\") not respected on default clause on annotation declarations
Properly deferring warnings that are reported during entering of annotation's default value.

Reviewed-by: mcimadamore
2015-01-20 12:00:25 +01:00
Srikanth Adayapalam
671f90ddc7 8052070: javac crashes when there are duplicated type parameters
Avoid eager completion of ClassSymbol while type parameters are being processed.

Reviewed-by: jlahoda, mcimadamore
2015-01-20 09:51:17 +01:00
Robert Field
6c9d4861a9 8068488: Facilitate extension of the javac parser -- missing modifier
Reviewed-by: jjg
2015-01-16 20:03:30 -08:00
Jan Lahoda
56c4de876e 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
Making sure enum's abstractness is resolved before writing InnerClasses entry about it.

Reviewed-by: mcimadamore
2015-01-16 14:47:25 +01:00
Maurizio Cimadamore
82db21e08d 8068995: Cleanup method reference lookup code
Simplify method reference code lookup and generate better/more uniform diagnostics

Reviewed-by: vromero
2015-01-15 13:58:11 +00:00
Jan Lahoda
1b90760ef4 8066843: Messager.printMessage cannot print multiple errors for same source position
Using a DiagnosticFlag to mark diagnostics that should be always printed even if multiple of them have the same source position.

Reviewed-by: darcy, jjg, mcimadamore
2015-01-13 19:13:42 +01:00
Srikanth Adayapalam
2b3c75aa36 8027888: javac wrongly allows annotations in array-typed class literals
Compiler incorrectly accepts type annotations on array-typed class literals.

Reviewed-by: jlahoda, jfranck
2015-01-13 10:36:41 +01:00
Srikanth Adayapalam
5cb253a2e9 8068254: Method reference uses wrong qualifying type
Generated code fails with IllegalAccessError due to compiler's mishandling of packageprivate classes in method reference expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:32:19 +01:00
Srikanth Adayapalam
33a3e1add3 8037546: javac -parameters does not emit parameter names for lambda expressions
MethodParameters attribute is missing for synthetic methods encoding lambda expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:25:24 +01:00
Srikanth Adayapalam
1be81e358c 8062358: ClassCastException in TransTypes.visitApply
Incorrect handling of subtype relations involving lower bounded wildcard causes ClassCastException

Reviewed-by: vromero, dlsmith
2015-01-13 10:17:25 +01:00
Jonathan Gibbons
01520ed2aa 8068759: ConstFoldTest fails on Windows
Reviewed-by: ksrini
2015-01-09 18:03:01 -08:00
Srikanth Adayapalam
4eb573aa81 8067914: Redundant type cast nodes in AST (follow up from JDK-8043741)
Workaround for redundant (but harmless) synthetic cast generated in TransTypes

Reviewed-by: mcimadamore
2015-01-09 15:51:20 +00:00
Srikanth Adayapalam
7e499fd15b 8067429: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Bitset for alive variables contains info about variables out of range

Reviewed-by: mcimadamore
2015-01-09 15:50:22 +00:00
Srikanth Adayapalam
5de84c2836 8043741: VerifyError due to missing checkcast
Proto-type is not set correctly for NULLCHK synthetic trees

Reviewed-by: mcimadamore
2015-01-09 15:49:42 +00:00
Srikanth Adayapalam
0eb55d78b6 8066871: java.lang.VerifyError: Bad local variable type - local final String
BaseType() erroneously called on MethodResultInfo causes lack of constant type info

Reviewed-by: jlahoda, mcimadamore
2015-01-09 15:48:09 +00:00
Sonali Goel
274f997aee 8058373: Group 10a: golden files for tests in tools/javac dir
Reviewed-by: jjg, darcy
2015-01-08 22:01:20 -08:00
Maurizio Cimadamore
56a33e4541 8058542: Devise scheme for better diagnostic creation
Add support for generating (at build-time) an enum-like class containing all javac diagnostics, which allows for safe diagnostic creation.

Reviewed-by: jlahoda, jjg, vromero, erikj, jfranck
2015-01-08 14:43:05 +00:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in
Reviewed-by: jjg
2015-01-07 17:06:47 -08:00
Jonathan Gibbons
e6ea1f0ff8 8059977: StandardJavaFileManager should support java.nio.file.Path
Reviewed-by: jlahoda
2015-01-06 14:51:10 -08:00
Maurizio Cimadamore
75b2a03bf9 8067883: Javac misses some opportunities for diagnostic simplification
Javac always report full inference diagnostic, even when message does not mention inference variables.

Reviewed-by: jlahoda
2015-01-06 15:46:41 +00:00
Vicente Romero
f6ed87ed5a 8064857: javac generates LVT entry with length 0 for local variable
Reviewed-by: mcimadamore, jjg
2015-01-05 17:35:48 -08:00
Sonali Goel
11b1d2cdad 8054689: Split large SJavac.java test source into multiple files
Reviewed-by: jjg, jfranck
2014-12-24 11:17:51 -08:00
Maurizio Cimadamore
c269c9451b 8066974: Compiler doesn't infer method's generic type information in lambda body
Add loghic to avoid post-inference triggers on temporarty AST types

Reviewed-by: jlahoda, vromero
2014-12-18 13:21:44 +00:00
Maurizio Cimadamore
41070244c9 8067792: Javac crashes in finder mode with nested implicit lambdas
Revert tree changes occurred in Attr before running the analyzer

Reviewed-by: jlahoda
2014-12-17 16:47:56 +00:00
Jan Lahoda
627ce960f5 8067422: Lambda method names are unnecessarily unstable
Lambda method numbers are now assigned per class for non-serializable lambdas.

Reviewed-by: mcimadamore, rfield
2014-12-17 12:49:57 +01:00
Maurizio Cimadamore
eb3798a14a 8067663: Add bugId to tests that have been modified as part of JDK-8064365
Add missing bug id to modified tests

Reviewed-by: jlahoda
2014-12-16 13:44:22 +00:00
Maurizio Cimadamore
3076062240 8064365: Better support for finder capabilities in target-typing context
Add new framework to allow for easy creation of finder-like capabilities.

Reviewed-by: jjg, jlahoda
2014-12-12 18:07:24 +00:00
Jonathan Gibbons
0900c1f2e0 8066808: langtools/test/Makefile should not use OS-specific jtreg binary
Reviewed-by: mcimadamore
2014-12-11 18:23:17 -08:00
Jonathan Gibbons
827f52c966 8066807: langtools/test/Makefile should use -agentvm not -samevm
Reviewed-by: mcimadamore
2014-12-11 18:20:00 -08:00
Andrei Eremeev
282c943241 8065360: Implement a test that checks possibilty of class members to be imported
Reviewed-by: jlahoda, anazarov
2014-12-10 21:45:39 +02:00
Maurizio Cimadamore
a800908e25 8067001: DetectMutableStaticFields fails after modular images push
Ignore JRTIndex.sharedInstance

Reviewed-by: jlahoda
2014-12-09 16:09:07 +00:00
Andrei Eremeev
400505a1f2 8066961: NegativeCyclicDependencyTest.java fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jlahoda
2014-12-09 11:45:38 +01:00
Andrei Eremeev
ea81e1bc1f 8064794: Implement negative tests for cyclic dependencies in import statements
Reviewed-by: jlahoda, anazarov
2014-12-09 01:06:11 +02:00
Jan Lahoda
cf476e9302 8066902: JavacParserTest fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jjg, ksrini
2014-12-08 21:26:04 +01:00