Commit Graph

1943 Commits

Author SHA1 Message Date
Maurizio Cimadamore
67362236e8 8020804: javac crashes when speculative attribution infers intersection type with array component
Assertion is causing javac to crash because of lack of support for arrays in intersection types

Reviewed-by: jjg
2013-07-25 14:47:43 +01:00
Christine Lu
a2fc898bfc Added tag jdk8-b100 for changeset 7a1ff44c7732 2013-07-25 03:19:39 -07:00
Joel Borggrén-Franck
2030148ec2 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType
Reviewed-by: jjg
2013-07-25 11:02:27 +02:00
Jonathan Gibbons
0c5c756933 8020556: doclint does not check type variables for @throws
Reviewed-by: mcimadamore
2013-07-24 17:35:42 -07:00
Eric McCorkle
be2ea6f949 8016880: 42 tests in annot102* fail with compile-time errors
Fixes error in type equality when bounds of type variables have annotations.

Reviewed-by: jjg, mcimadamore
2013-07-23 20:42:54 -04:00
Jonathan Gibbons
2a95b6ac74 8021215: javac gives incorrect doclint warnings on normal package statements
Reviewed-by: darcy
2013-07-23 16:06:11 -07:00
Lana Steuck
524a340ac9 Merge 2013-07-22 17:39:45 -07:00
Kumar Srinivasan
c6c6fe7b5e 8017216: javac doesn't fill in end position for some errors of type not found
8019421: Javac doesn't fill in end position for some annotation related errors
8019422: Javac doesn't fill in end position for uninitialized variable errors

Reviewed-by: jjg, mcimadamore
2013-07-19 07:22:53 -07:00
Christine Lu
c1ca4a663a Added tag jdk8-b99 for changeset 38dd7ede2dfb 2013-07-18 03:39:33 -07:00
Jonathan Gibbons
c42bcf4526 8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore
2013-07-17 19:16:12 -07:00
Jonathan Gibbons
772640d4e8 8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore
2013-07-17 19:12:03 -07:00
Jonathan Gibbons
89197f0946 8014636: TestLiteralCodeInPre fails on windows
Reviewed-by: ksrini
2013-07-17 18:18:45 -07:00
Maurizio Cimadamore
70e005a7eb 8013638: Few policy tests are failing in Lambda nightly
BridgeHarness test is leaving files open

Reviewed-by: ksrini
2013-07-17 19:28:40 +01:00
Lana Steuck
be00b8110f Merge 2013-07-17 10:40:53 -07:00
Jan Lahoda
35af8eccde 8020586: Warning produced for an incorrect file
Always using DeferredLintHandler.immediateHandler when processing import classes

Reviewed-by: mcimadamore
2013-07-17 15:08:58 +02:00
Maurizio Cimadamore
a2a579a4bd 8019942: Graph inference: avoid redundant computation during bound incorporation
Bound incorporation should not perform same operation multiple times

Reviewed-by: jjg
2013-07-17 14:21:12 +01:00
Maurizio Cimadamore
717a989214 8019340: varargs-related warnings are meaningless on signature-polymorphic methods such as MethodHandle.invokeExact
Disable certain varargs warnings when compiling polymorphic signature calls

Reviewed-by: jjg
2013-07-17 14:19:25 +01:00
Maurizio Cimadamore
73953320cc 8020149: Graph inference: wrong logic for picking best variable to solve
Replace logic for selecting best inference leaf in the graph during an unsticking round

Reviewed-by: jjg
2013-07-17 14:19:02 +01:00
Maurizio Cimadamore
8850329bc1 8016640: compiler hangs if the generics arity of a base class is wrong
Check.checkCompatibleConcretes hang when javac creates synthetic supertypes for 269 model API

Reviewed-by: jjg
2013-07-17 14:16:25 +01:00
Maurizio Cimadamore
defbb67771 7041019: Bogus type-variable substitution with array types with dependencies on accessibility check
Call to upperBound() when performing type-variable substitution on element type leads to unsoundness

Reviewed-by: jjg
2013-07-17 14:14:49 +01:00
Maurizio Cimadamore
732e49f6dc 8020286: Wrong diagnostic after compaction
Compact diagnostic shows the least relevant method in the list

Reviewed-by: jjg
2013-07-17 14:14:32 +01:00
Maurizio Cimadamore
eb4e8153b3 8020147: Spurious errors when compiling nested stuck lambdas
Scope of deferred types is not copied correctly; postAttr analyzer should not run on stuck expressions

Reviewed-by: jjg
2013-07-17 14:13:15 +01:00
Maurizio Cimadamore
e92a56fade 8012238: Nested method capture and inference
8008200: java/lang/Class/asSubclass/BasicUnit.java fails to compile

Inference support should be more flexible w.r.t. nested method calls returning captured types

Reviewed-by: jjg, vromero
2013-07-17 14:11:41 +01:00
Maurizio Cimadamore
99b0413d48 8016175: Add bottom-up type-checking support for unambiguous method references
Type-checking of non-overloaded method references should be independent from target-type

Reviewed-by: jjg, vromero
2013-07-17 14:09:46 +01:00
Maurizio Cimadamore
941752ea25 8012242: Lambda compatibility and checked exceptions
Inference variables in 'throws' clause with no constraints should be inferred as RuntimeException

Reviewed-by: jjg, vromero
2013-07-17 14:04:01 +01:00
Jonathan Gibbons
9dd2fe90d4 8020278: NPE in javadoc
Reviewed-by: mcimadamore, vromero
2013-07-12 13:11:12 -07:00
Maurizio Cimadamore
617386d568 8013404: Unclear spec for target typing with conditional operator (?:)
Fix previously ignored test

Reviewed-by: jjg, vromero
2013-07-11 15:37:02 +01:00
Robert Field
d3d1da337a 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
8020010: Move lambda bridge creation from metafactory and VM to compiler

Langtools/javac component of the bridge support and MethodType vs. MethodHandle changes.

Reviewed-by: jjg, vromero, briangoetz, forax
2013-07-11 14:07:39 +01:00
David Katleman
94e178de87 Added tag jdk8-b98 for changeset d3db5fb3d72f 2013-07-11 10:13:57 -07:00
Kumar Srinivasan
424ac16db0 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken
Reviewed-by: jjg
2013-07-09 14:54:20 -07:00
Lana Steuck
a7cb4ce7b0 Merge 2013-07-05 13:29:04 -07:00
Lana Steuck
9b5da4e548 Merge 2013-07-05 11:06:24 -07:00
Maurizio Cimadamore
7229f89614 8019824: very long error messages on inference error
Inference error messages shows several spurious captured variables generated during an inference loop

Reviewed-by: jjg, vromero
2013-07-05 11:05:02 +01:00
Maurizio Cimadamore
4442f43ea3 8016702: use of ternary operator in lambda expression gives incorrect results
Constant types erroneously creep in during inference

Reviewed-by: jjg, vromero
2013-07-05 11:04:22 +01:00
Maurizio Cimadamore
28b5759093 8016059: Cannot compile following lambda
8016060: Lambda isn't compiled with return statement

Spurious error triggered during unnecessary recovery round

Reviewed-by: jjg, vromero
2013-07-05 11:03:04 +01:00
Maurizio Cimadamore
86f630b63e 8019480: Javac crashes when method is called on a type-variable receiver from lambda expression
Logic for shortcircuiting speculative attribution doesn't handle type-variable receivers

Reviewed-by: jjg, vromero
2013-07-05 11:02:17 +01:00
Maurizio Cimadamore
7e6f7dcca5 8017618: NullPointerException in RichDiagnosticFormatter for bad input program
RDF crashes when diagnostic contains type 'void'

Reviewed-by: jjg, vromero
2013-07-05 11:00:19 +01:00
Vicente Romero
684d5ec76d 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
Reviewed-by: mcimadamore
2013-07-04 10:41:08 +01:00
Vicente Romero
8277af52ee 8009924: some langtools tools do not accept -cp as an alias for -classpath
Reviewed-by: jjg
2013-07-04 10:35:33 +01:00
Christine Lu
7b58133588 Added tag jdk8-b97 for changeset 6774fe79db80 2013-07-04 01:01:07 -07:00
Vicente Romero
ea2c99f5bb 6326693: variable x might already have been assigned, when assignment is in catch block
Reviewed-by: mcimadamore
2013-07-02 22:49:40 +01:00
Kumar Srinivasan
bab861035d 8019460: tests in changeset do not have @bug tag
Reviewed-by: darcy
2013-07-01 16:36:08 -07:00
Dmytro Sheyko
ba85477f84 8019397: javap does not show SourceDebugExtension properly
Reviewed-by: jjg
2013-07-02 10:21:41 +01:00
Joe Darcy
547a050fe1 7162089: Add support for repeating annotations to javax.annotation.processing
Reviewed-by: abuckley, jjg, jfranck
2013-07-01 11:58:45 -07:00
Maurizio Cimadamore
1c13f5e4cb 7034798: Ambiguity error for abstract method call is too eager
Javac should wait and see if ambiguous methods can be reconciled at the end of an overload resolution round

Reviewed-by: jjg, vromero
2013-07-01 14:57:03 +01:00
Vicente Romero
a33129c6af 6983646: javap should identify why a DefaultAttribute is being used
Reviewed-by: jjg
2013-06-29 20:12:24 +01:00
Lana Steuck
c5e36903f7 Merge 2013-06-28 19:47:54 -07:00
Vicente Romero
39673a6ee9 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string
Reviewed-by: mcimadamore
2013-06-28 14:36:06 +01:00
Vicente Romero
e8952a4764 6473148: TreePath.iterator() should document the iteration order
Reviewed-by: mcimadamore
2013-06-28 13:20:44 +01:00
Eric McCorkle
95e39e6039 8016760: Failure of regression test langtools/tools/javac/T6725036.java
Marking the failing test @ignore; the proposed change for 8015666 addresses the underlying issue

Reviewed-by: jjg
2013-06-28 06:54:58 -04:00
Eric McCorkle
9b1ec513d5 8013357: javac accepts erroneous binary comparison operations
Javac does not report type errors on illegal Object == primitive comparisons

Reviewed-by: abuckley, mcimadamore
2013-06-27 17:45:56 -04:00
David Katleman
8ba7651e27 Added tag jdk8-b96 for changeset 51ef92228b23 2013-06-27 13:40:36 -07:00
Kumar Srinivasan
704f96a0d5 7080001: Need to bump version numbers in build.properties for 8
Reviewed-by: jjg
2013-06-27 12:42:47 -07:00
Joe Darcy
21d2b03764 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion
Reviewed-by: jjg
2013-06-27 11:46:23 -07:00
Jan Valenta
97f7bab3c7 8015720: since tag isn't copied while generating JavaFX documentation
Reviewed-by: jjg
2013-06-27 17:47:18 +02:00
Vicente Romero
a87b5d942d 7008643: inlined finally clauses confuse debuggers
Reviewed-by: jjg
2013-06-27 16:06:56 +01:00
Vicente Romero
4e49cb5fc5 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
Reviewed-by: jjg
2013-06-27 16:04:05 +01:00
Vicente Romero
9e35962ebf 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory)
Reviewed-by: jjg
2013-06-27 09:54:50 +01:00
Vicente Romero
94991de3c3 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5
Reviewed-by: jjg
2013-06-27 09:51:59 +01:00
Erik Joelsson
7cdf8d8a08 8014513: Sjavac doesn't detect 32-bit jvm properly
Reviewed-by: jjg
2013-06-27 10:35:36 +02:00
Eric McCorkle
a2c99b7e5c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters
The compiler does not account fr extra parameters due to inner this parameters

Reviewed-by: jjg
2013-06-27 00:37:13 -04:00
Bhavesh Patel
b2c41f305e 8013738: Two javadoc tests have bug 0000000
Reviewed-by: jjg
2013-06-26 20:45:47 -07:00
Bhavesh Patel
9a773a649c 8014017: extra space in javadoc class heading
Reviewed-by: jjg
2013-06-26 20:42:43 -07:00
Bhavesh Patel
561009c4ac 8007338: Method grouping tab line-folding
Reviewed-by: jjg
2013-06-26 20:38:21 -07:00
Matherey Nunez
eedcd5d290 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values
Reviewed-by: jjg, darcy
2013-06-26 18:03:58 -07:00
David Katleman
ed14278b82 8016684: JDK8 b94 source with GPL header errors
Reviewed-by: tbell, darcy
2013-06-26 11:26:33 -07:00
Kumar Srinivasan
3ab53b61f0 8016908: TEST_BUG: removing non-ascii characters causes tests to fail
Reviewed-by: jjg, vromero
2013-06-26 09:54:46 -07:00
Alexander Zuev
fd80bae5c5 8006973: jtreg test fails: test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java
Reviewed-by: ksrini
2013-06-25 20:08:52 +04:00
Vicente Romero
d7fff903e8 8017104: javac should have a class for primitive types that inherits from Type
Reviewed-by: jjg
2013-06-25 16:12:53 +01:00
Eric McCorkle
17f5808828 8012722: Single comma in array initializer should parse
Annotations of the form @Foo({,}) should parse

Reviewed-by: jjg
2013-06-24 22:03:57 -04:00
Lana Steuck
1159b21b3f Merge 2013-06-24 14:27:32 -07:00
Eric McCorkle
bca53c33de 8007546: ClassCastException on JSR308 tests
8015993: jck-compiler tests are failed with java.lang.ClassCastException

Fix ClassCastExceptions arising from addition of AnnotatedType.

Reviewed-by: jjg, abuckley
2013-06-20 19:01:20 -04:00
David Katleman
fa27360b22 Added tag jdk8-b95 for changeset 41b9fc8961f6 2013-06-20 10:17:55 -07:00
Maurizio Cimadamore
1a284a49c9 8016613: javac should avoid source 8 only analysis when compiling for source 7
Reviewed-by: jjg
2013-06-20 08:45:43 +01:00
Maurizio Cimadamore
53f06da300 8016610: javac, add new internal symbols to make operator resolution faster
Reviewed-by: jjg
2013-06-19 22:07:05 +01:00
Chris Hegarty
01cde5204c Merge 2013-06-19 13:00:00 +01:00
Chris Hegarty
700804c6f2 8017045: anti-delta fix for 8013789
Reviewed-by: alanb
2013-06-19 11:48:05 +01:00
Vicente Romero
88aaaa7878 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits
Reviewed-by: jjg
2013-06-19 11:09:13 +01:00
Michael Fang
a3d1e73878 8015657: jdk8 l10n resource file translation update 3
Reviewed-by: yhuang
2013-06-18 20:56:04 -07:00
Chris Hegarty
85d8fa9b97 Merge 2013-06-18 20:08:49 +01:00
Vicente Romero
a48b1a1a91 8016267: javac, TypeTag refactoring has provoked performance issues
Reviewed-by: jjg
2013-06-18 19:02:48 +01:00
Maurizio Cimadamore
d1a88e0b7a 8016607: javac, avoid analyzing lambdas for source 7 compilation
Reviewed-by: jjg
2013-06-18 18:57:52 +01:00
Chris Hegarty
9c098465a5 Merge 2013-06-18 09:36:46 +01:00
Maurizio Cimadamore
1839512a15 8013789: Compiler should emit bridges in interfaces
Paired with 8015402: Lambda metafactory should not attempt to determine bridge methods

Reviewed-by: vromero
2013-06-17 20:29:31 -07:00
Joe Darcy
55c85107b7 8016779: Fix doclint warnings in javax.lang.model
Reviewed-by: jjg
2013-06-17 14:46:01 -07:00
Chris Hegarty
be5d596030 Merge 2013-06-17 11:27:46 +01:00
Lana Steuck
9edd6e01f1 Merge 2013-06-16 22:38:04 -07:00
Vicente Romero
5d4b6cd0d0 8008023: Get rid of utf8 chars in two tests
Reviewed-by: jjg
2013-06-14 18:01:52 +01:00
Maurizio Cimadamore
44641445d7 8016569: javac, add new flag for polymorphic method signatures
Reviewed-by: jjg
2013-06-14 16:25:09 +01:00
David Katleman
18aa8b4042 Added tag jdk8-b94 for changeset f7887244ecd2 2013-06-13 09:49:19 -07:00
Vicente Romero
3596018eb7 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error
Reviewed-by: jjg
2013-06-11 09:59:34 +01:00
Vicente Romero
4836bfbcf1 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific
Reviewed-by: jjg
2013-06-11 09:35:58 +01:00
Chris Hegarty
d758772ec0 Merge 2013-06-11 09:25:57 +01:00
Lana Steuck
622541203a Merge 2013-06-10 17:04:18 -07:00
Maurizio Cimadamore
80407ef47d 8013576: Add stat support to LambdaToMethod
LambdaToMethod should emit info to help diagnose/test lambda metafactory problems

Reviewed-by: jjg, vromero
2013-06-10 15:57:32 +01:00
Vicente Romero
7258bbbfde 7113519: test/tools/javac/VersionOpt.java passes on windows
Reviewed-by: jjg
2013-06-10 15:18:47 +01:00
Chris Hegarty
8bb77f2674 Merge 2013-06-10 09:52:54 +01:00
Bhavesh Patel
3f6b61d75e 8015997: Additional improvement in Javadoc framing
Reviewed-by: jjg
2013-06-07 16:12:04 -07:00
Jonathan Gibbons
a476a195ac 8016193: Fix OAC issue in langtools docs
Reviewed-by: darcy
2013-06-07 15:35:38 -07:00
David Katleman
e142a2e82d Added tag jdk8-b93 for changeset 1697301ac053 2013-06-06 09:55:26 -07:00