144 Commits

Author SHA1 Message Date
Robert Field
f3e88eb313 8143006: jshell tool: /edit doesn't process each line as same as inputs for jshell
8163816: JShell tests: jdk/jshell/ExternalEditorTest.java -- unexpected results EditorTestBase.testEditClass1() and .testEditMethod1()

Reviewed-by: jlahoda
2016-11-16 10:45:23 -08:00
Jan Lahoda
da7b11ca15 8169561: jshell tool: double shift-tab on variable crashes tool
Avoid crashe for unknown HTML tags; avoid crash for non-existing documentation; fix signature for JShell variables

Reviewed-by: rfield
2016-11-16 17:48:43 +01:00
Robert Field
907f7c2d7e 8161983: JShell API: Clean-up following 8160127 et. al
Reviewed-by: jlahoda
2016-11-06 22:50:46 -08:00
Robert Field
d292468c51 8129559: JShell: compilation fails if class, method or field is annotated and has modifiers
8080354: JShell: Runtime visible annotations cannot be retrieved

Reviewed-by: jlahoda
2016-11-04 14:47:25 -07:00
Robert Field
836024d6f9 8161969: jshell tool: /var value is not truncated per feedback setting
8166637: jshell tool: confusing truncation of long result values
8154513: JShell tool: welcome message should match feedback mode
8167552: jshell tool: Typo in jshell command '/? /reload' description

Reviewed-by: jlahoda
2016-11-03 09:12:02 -07:00
Robert Field
02e5b77101 8167636: jshell tool: Edit Pad should be in its own module
Reviewed-by: jlahoda
2016-11-02 16:29:50 -07:00
Jan Lahoda
5d215e5425 8131019: jshell tool: access javadoc from tool
Adding internal support to resolve {@inheritDoc} and format javadoc to plain text for use by jdk.jshell and jdk.scripting.nashorn.shell, enhancing Shift-<tab> documentation in JShell with ability to show javadoc.

Reviewed-by: jjg, rfield
2016-11-02 07:38:37 +01:00
Robert Field
70d8f3c7b4 8167643: JShell: silently ignore access modifiers (as semantically irrelevant)
Reviewed-by: jlahoda
2016-10-27 17:11:16 -07:00
Robert Field
ac9d25d027 8166649: jshell tool: missing --add-modules and --module-path
8167462: jshell tool: /help /reload is wrong about re-executing commands

Reviewed-by: jlahoda
2016-10-24 19:59:35 -07:00
Robert Field
5be06e9de2 8167637: jshell tool: /edit should use EDITOR setting
8167640: jshell tool: external editor temp file should be *.java

Reviewed-by: jlahoda
2016-10-24 17:06:10 -07:00
Robert Field
f601bcb76e 8163840: jshell tool: provide way to display configuration settings
Reviewed-by: jlahoda
2016-10-20 12:53:11 -07:00
Jan Lahoda
7ac8bf6c75 8167461: jshell tool: Scanner#next() hangs tool
PipeInputStream.read(byte[]...) should only read available bytes; properly resending exceptions for snippet's System.in and properly closing it; more reliable way to cancel user input while waiting in System.in.

Reviewed-by: rfield
2016-10-18 16:00:32 +02:00
Shinya Yoshida
e3b0b0192b 8145263: JShell: Fix the format of SourceCodeAnalysis#documentation
Reviewed-by: rfield, jlahoda
2016-10-17 23:23:11 +09:00
Robert Field
8b2ace697c 8167128: JShell: /drop of statement gives confusing output
Reviewed-by: jlahoda
2016-10-10 18:41:12 -07:00
Shinya Yoshida
a53b8b8a5d 8167343: JShell: Completeness analysis infers an incomplete declaration as COMPLETE_WITH_SEMI, which is a first line of Allman style
Reviewed-by: rfield
2016-10-11 00:28:49 +09:00
Shinya Yoshida
20a821ae7c 8166744: JShell: java.lang.IndexOutOfBoundsException for legal history access
Reviewed-by: rfield, jlahoda
2016-09-29 17:36:22 +09:00
Shinya Yoshida
b9ad123afa 8154714: jshell tool: add exports support
Reviewed-by: jlahoda, rfield
2016-09-28 16:36:10 +09:00
Robert Field
1e18e0dc9f 8166400: JShell: friendlier representation of array values
Reviewed-by: sundar, jlahoda
2016-09-21 23:46:06 -07:00
Jan Lahoda
835354dfa6 8131025: JShell: crash on tab-complete reference to bad class file
Catching CompletionFailure when iterating through Scope.

Reviewed-by: rfield
2016-09-08 15:48:28 +02:00
Robert Field
426f1d9d47 8080352: jshell tool: Error message for using "package" should be more descriptive than "Failed"
Reviewed-by: jlahoda
2016-09-07 12:15:22 -07:00
Robert Field
4017bf5f7a 8165211: JShell: Fix completion analysis problems
Reviewed-by: jlahoda
2016-09-01 13:21:52 -07:00
Jan Lahoda
8302f64ee6 8164952: JShell tests: jdk/jshell/CompletionSuggestionTest.testUncompletedDeclaration(): failure
Avoiding conflict between the CompletionSuggestionTest.testUncompletedDeclaration test and ClassPathTest

Reviewed-by: rfield
2016-09-01 21:25:33 +02:00
Robert Field
7a3d0498d3 8133507: JShell: StackTraceElement#getFileName of EvalException does not use custom id generator
Reviewed-by: jlahoda
2016-09-01 12:13:13 -07:00
Jan Lahoda
74e01787b3 8131023: JShell: System.in does not work
Pass user input to snippets/remote agent

Reviewed-by: rfield
2016-09-01 10:30:50 +02:00
Shinya Yoshida
11de22e133 8164825: jshell tool: Completion for subcommand
Reviewed-by: jlahoda
2016-09-01 11:07:00 +09:00
Robert Field
7dceb3e785 8164518: JShell: Add failover case of explicitly listening to "localhost"
Reviewed-by: jlahoda
2016-08-31 10:35:51 -07:00
Nadeesh TV
7cafba7a11 8153897: jshell tool: "not active" must be pulled from resource file
Not active error msg pulled from resource file

Reviewed-by: rfield
2016-08-29 11:13:48 +00:00
Robert Field
0b92f87233 8158738: jshell tool: Save does not affect jshell if started from another editor
Reviewed-by: jlahoda
2016-08-26 11:36:08 -07:00
Robert Field
f39e912857 8160089: jshell tool: use new double-dash long-form command-line options
Reviewed-by: jlahoda
2016-08-22 19:31:37 -07:00
Robert Field
f03ea9c497 8154374: JShell: setContextClassLoader() for remote Snippet class loader
8080347: jshell tool: /vars when the status is other than Active

Reviewed-by: jlahoda
2016-08-22 09:12:11 -07:00
Robert Field
6a0075c86e 8164277: JShell API: Snippets are immutable and should be available for post-mortem analysis
Reviewed-by: jlahoda
2016-08-22 08:18:18 -07:00
Robert Field
9f44318ef9 8158906: JShell: crashes with extremely long result value
Reviewed-by: jlahoda, shinyafox
2016-08-19 13:55:26 -07:00
Robert Field
67028ff853 8159027: JShell API: SourceCodeAnalysis.Suggestion has constructor, ..
Reviewed-by: jlahoda
2016-08-15 11:39:53 -07:00
Jan Lahoda
f0e1e069ff 8129421: JShell: unacceptable suggestions in 'extends', 'implements' in smart completion
8129422: JShell: methods and fields of uncompleted expressions should be suggested

Fixing several completion bugs

Reviewed-by: rfield
2016-08-15 08:28:26 +02:00
Robert Field
ea4535a524 8163817: JShell tests: disable minor failing editor tool cases: 8161276, 8163816, 8159229
Reviewed-by: jlahoda, psandoz, darcy
2016-08-10 15:52:26 -07:00
Robert Field
81c36d2f40 8143964: JShell API: convert query responses to Stream instead of List
Reviewed-by: psandoz, shinyafox
2016-08-09 23:00:49 -07:00
Robert Field
918c010822 8160127: JShell API: extract abstract JDI and abstract streaming implementations of ExecutionControl
8159935: JShell API: Reorganize execution support code into jdk.jshell.execution (previously sent for review, and combined here)
8160128: JShell API: extract abstract streaming remote agent
8159122: JShell API: Configurable invocation mechanism

ExecutionControl implementation support with simplified ExecutionControl interface

Reviewed-by: jlahoda
2016-07-20 23:19:09 -07:00
Andrey Nazarov
1a9a1d8961 8161132: JShell tests: jdk/jshell/KullaCompletenessStressTest.java should pass if jdk.shell sources are not provided
Reviewed-by: rfield
2016-07-14 11:14:22 -07:00
Robert Field
850b281ff0 8159111: JShell API: Add access to wrappers and dependencies
Reviewed-by: jlahoda
2016-07-01 14:41:07 -07:00
Robert Field
c8f9b12b5c 8159635: JShell API: Add compiler options
Reviewed-by: jlahoda
2016-07-01 14:16:28 -07:00
Jan Lahoda
3d43452d94 8150860: Mach 5 tier1 test started failing - jdk/jshell/ComputeFQNsTest.java (after 8131027/8150814)
Correctly escaping '\' in paths; rethrowing exceptions from evaluation to improve debuggability of the test

Reviewed-by: jjg
2016-06-27 09:43:12 +02:00
Robert Field
8696e295a8 8139829: JShell API: No use of fields to return information from public types
Reviewed-by: vromero
2016-06-08 00:32:31 -07:00
Robert Field
19c685726f 8131029: JShell: recover from VMConnection launch failure
Reviewed-by: vromero
2016-06-02 14:05:13 -07:00
Robert Field
9e48d360f5 8131024: JShell: multi-line comment not detected as incomplete
Reviewed-by: vromero
2016-06-02 12:52:00 -07:00
Robert Field
3bad85523c 8080843: JShell tool: invalid key error occurs when external editor is used
Reviewed-by: vromero
2016-05-31 14:02:52 -07:00
Shinya Yoshida
3ff9cf19e2 8141415: JShell: wrap erroneous with one-liner comment-outed imports
Reviewed-by: rfield
2016-05-29 23:46:49 +09:00
Robert Field
1da9340c23 8139872: JShell tests: EditorPadTest failing on headless
Reviewed-by: vromero
2016-05-27 14:45:20 -07:00
Robert Field
c65d2e5dac 8157261: jshell tool: truncation for expressions is not consistent
Reviewed-by: vromero
2016-05-27 10:37:46 -07:00
Robert Field
8a3eaf7f44 8157953: JShell tests: reenable ToolBasicTest
8080883: JShell tool: tool does not report errors if -startup and -nostartup flags are specified

Reviewed-by: vromero
2016-05-26 12:38:21 -07:00
Robert Field
1fb5067c57 8157917: JShell: shutdown could cause remote JDWP errors to be visible to users
8157918: JShell tests: StartOptionTest displays insufficient information to diagnose failures

Reviewed-by: vromero
2016-05-26 07:58:01 -07:00