6285 Commits

Author SHA1 Message Date
Jesper Wilhelmsson
f2bad3a0be Merge 2020-12-22 21:16:59 +00:00
Lin Zang
0ae78d4cd0 8258593: remove redundant codes in HeapObjectDumper
Reviewed-by: coleenp, lfoltan, cjplummer
2020-12-22 19:19:51 +00:00
Corey Ashford
0849117d5c 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE
Reviewed-by: mdoerr
2020-12-22 14:19:32 +00:00
Daniel D. Daugherty
172af1524d 8258284: clean up issues with nested ThreadsListHandles
Reviewed-by: eosterlund, rehn
2020-12-22 14:07:43 +00:00
Vladimir Ivanov
772addfd24 8258790: C2: Crash on empty macro node list
Reviewed-by: kvn, chagedorn
2020-12-22 12:12:21 +00:00
Xin Liu
30b9ff660f 8258653: CallJavaNode::_bci is not in use
Reviewed-by: kvn, vlivanov
2020-12-21 23:27:33 +00:00
Roberto Castañeda Lozano
4e8338eb13 8255763: C2: OSR miscompilation caused by invalid memory instruction placement
Disable GCM hoisting of memory-writing nodes for irreducible CFGs. This prevents
GCM from wrongly "hoisting" stores into descendants of their original loop. Such
an "inverted hoisting" can happen due to CFGLoop::compute_freq()'s inaccurate
estimation of frequencies for irreducible CFGs.

Extend CFG verification code by checking that memory-writing nodes are placed in
either their original loop or an ancestor.

Add tests for the reducible and irreducible cases. The former was already
handled correctly before the change (the frequency estimation model prevents
"inverted hoisting" for reducible CFGs), and is just added for coverage.

This change addresses the specific miscompilation issue in a conservative way,
for simplicity and safety. Future work includes investigating if only the
illegal blocks can be discarded as candidates for GCM hoisting, and refining
frequency estimation for irreducible CFGs.

Reviewed-by: kvn, chagedorn
2020-12-21 13:04:24 +00:00
Roman Kennke
2525f39d35 8258714: Shenandoah: Process references before evacuation during degen
Reviewed-by: shade
2020-12-21 12:42:34 +00:00
Jaroslav Bachorik
a06cea50a5 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
Reviewed-by: mgronlun
2020-12-21 11:43:13 +00:00
Jesper Wilhelmsson
d234388042 Merge 2020-12-21 09:09:05 +00:00
Christian Hagedorn
8e42efaada 8257513: C2: assert((constant_addr - _masm.code()->consts()->start()) == con.offset())
Reviewed-by: kvn, thartmann
2020-12-21 08:06:48 +00:00
Doug Simon
c50b464a12 8258715: [JVMCI] separate JVMCI code install timers for CompileBroker and hosted compilations
Reviewed-by: kvn
2020-12-19 11:17:16 +00:00
Mikael Vidstedt
64644a1072 8253881: Hotspot/Serviceability Terminology Refresh
Reviewed-by: kbarrett, tschatzl, dholmes, lfoltan, dcubed
2020-12-19 02:47:28 +00:00
Igor Veresov
7f92d187b1 8258553: Limit number of fields in instance to be considered for scalar replacement
Reviewed-by: kvn, vlivanov
2020-12-18 21:08:04 +00:00
Xin Liu
adf0e23aa2 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
Reviewed-by: thartmann, chagedorn, phh
2020-12-18 20:35:38 +00:00
Yumin Qi
06c24e14eb 8256213: Remove os::split_reserved_memory
Reviewed-by: ccheung, iklam
2020-12-18 20:23:43 +00:00
Leonid Mesnik
71ae05d51f 8258061: Improve diagnostic information about errors during class redefinition
Reviewed-by: coleenp, sspitsyn
2020-12-18 16:40:12 +00:00
Kim Barrett
00d80fdd86 8258255: Move PtrQueue active flag to SATBMarkQueue
Reviewed-by: tschatzl, sjohanss
2020-12-18 15:08:46 +00:00
Jie Fu
59ae054873 8258687: Build broken on Windows after fix for JDK-8258134
Reviewed-by: thartmann
2020-12-18 14:13:01 +00:00
Richard Reingruber
1ce2e94f5f 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
Reviewed-by: mdoerr, lucy
2020-12-18 13:16:09 +00:00
Jie Fu
45a150b8dc 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
Reviewed-by: kvn, thartmann
2020-12-18 12:50:19 +00:00
Stefan Johansson
38593a4f2a 8257974: Regression 21% in DaCapo-lusearch-large after JDK-8236926
Reviewed-by: ayang, redestad, tschatzl
2020-12-18 08:14:58 +00:00
Thomas Stuefe
853c04712d 8258469: Cleanup remaining safefetch test coding
Reviewed-by: coleenp, dholmes
2020-12-18 08:13:16 +00:00
Yasumasa Suenaga
1e03ca13cc 8258471: "search codecache" clhsdb command does not work
Reviewed-by: cjplummer, sspitsyn
2020-12-18 04:50:09 +00:00
Jesper Wilhelmsson
f15528eb64 Merge 2020-12-17 20:41:37 +00:00
Coleen Phillimore
6e824b3f51 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions
Reviewed-by: dholmes, lfoltan
2020-12-17 18:49:42 +00:00
Markus Grönlund
7aac4dc175 8257621: JFR StringPool misses cached items across consecutive recordings
Reviewed-by: egahlin
2020-12-17 14:34:44 +00:00
Kim Barrett
61390d8e45 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
Reviewed-by: sjohanss, tschatzl
2020-12-17 14:18:00 +00:00
Xin Liu
83be8a902c 8247732: validate user-input intrinsic_ids in ControlIntrinsic
renew webrev to the latest jdk. fixed a typo and a bug.  Add constraints for both DisableIntrinsic and ControlIntrinsics.  Add tests to cover different use cases of them.

Reviewed-by: neliasso, thartmann
2020-12-17 10:05:09 +00:00
Thomas Stuefe
178c00182c 8258479: Minor cleanups in VMError
Reviewed-by: lfoltan, coleenp
2020-12-17 05:26:11 +00:00
Jatin Bhateja
c11525a45e 8257772: Vectorizing clear memory operation using AVX-512 masked operations
Reviewed-by: thartmann, kvn
2020-12-17 04:42:19 +00:00
Nick Gasson
643ddc1320 8257882: Implement linkToNative intrinsic on AArch64
Reviewed-by: jvernee, mcimadamore, aph
2020-12-17 03:24:40 +00:00
Jesper Wilhelmsson
11bd7a814f Merge 2020-12-17 03:04:19 +00:00
Ioi Lam
59f4c4aad5 8258075: Use auto variable declarations for enum iteration
Reviewed-by: jrose, ccheung
2020-12-16 19:39:24 +00:00
Harold Seigel
330ce86123 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
Reviewed-by: lfoltan, coleenp, dholmes
2020-12-16 19:20:54 +00:00
Coleen Phillimore
c4632647ae 8258048: Placeholder hash code is the same as Dictionary hash code
Reviewed-by: dholmes, hseigel, lfoltan
2020-12-16 19:17:58 +00:00
Gerard Ziemski
70183f4d6e 8251438: Issues with our POSIX set_signal_handler()
Reviewed-by: dholmes, stuefe
2020-12-16 17:09:45 +00:00
Xin Liu
0c8cc2cde4 8258058: improve description of OutOfMemoryError relevant flags
OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries.  We need to make the description more clear to users.

Reviewed-by: dholmes, jiefu
2020-12-16 09:01:27 +00:00
Kim Barrett
cdb53422e8 8258252: Move PtrQueue enqueue to PtrQueueSet subclasses
Reviewed-by: tschatzl, rkennke
2020-12-16 07:53:40 +00:00
Ioi Lam
17ace8339d 8258074: Move some flags related to compiler to compiler_globals.hpp
Reviewed-by: kvn, coleenp
2020-12-16 04:36:43 +00:00
Calvin Cheung
b5a3a5b621 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
Reviewed-by: redestad, coleenp
2020-12-16 02:37:29 +00:00
David Holmes
1e77896838 8236225: Remove expired flags in JDK 17
8256717: Expire the long term obsoleted VM flags

Reviewed-by: coleenp, kvn
2020-12-16 00:00:12 +00:00
Coleen Phillimore
4d6f318153 8257726: Make -XX:+StressLdcRewrite option a diagnostic option
Reviewed-by: lfoltan, stuefe, dcubed
2020-12-15 23:54:50 +00:00
Tom Rodriguez
1f556d22ca 8258380: [JVMCI] don't clear InstalledCode reference when unloading JVMCI nmethods
Reviewed-by: kvn, eosterlund
2020-12-15 21:31:00 +00:00
Coleen Phillimore
c37eabe73b 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest
Reviewed-by: iklam, stuefe
2020-12-15 20:48:18 +00:00
Anton Kozlov
2273f9555a 8234930: Use MAP_JIT when allocating pages for code cache on macOS
Reviewed-by: stuefe, iklam, burban
2020-12-15 18:43:49 +00:00
Yumin Qi
36e2097401 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
Reviewed-by: ccheung, iklam, stuefe
2020-12-15 16:52:26 +00:00
Christian Hagedorn
ce36aeaac3 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
Reviewed-by: kvn, thartmann
2020-12-15 15:14:34 +00:00
Markus Grönlund
fa1cbb47aa 8258404: Restore stacktrace reuse after 8258094
Reviewed-by: egahlin
2020-12-15 14:48:57 +00:00
Maurizio Cimadamore
7ff9c85639 8258242: Type profile pollution occurs when memory segments of different kinds are used
Reviewed-by: vlivanov, redestad
2020-12-15 13:50:40 +00:00