179 Commits

Author	SHA1	Message	Date
Maurizio Cimadamore	ec458693f7	8012003: Method diagnostics resolution need to be simplified in some cases ... Unfold method resolution diagnostics when they mention errors in poly expressions Reviewed-by: jjg, vromero	2013-05-15 14:00:31 +01:00
Robert Field	c51505263f	8012556: Implement lambda methods on interfaces as static ... 8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore. Reviewed-by: mcimadamore	2013-05-14 11:11:09 -07:00
Robert Field	136b4bc9b2	8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails ... Reviewed-by: mcimadamore	2013-05-07 06:39:34 -07:00
Jonathan Gibbons	155bd74411	8012728: Normalize @ignore comments on langtools tests ... Reviewed-by: vromero, mcimadamore	2013-05-03 09:56:56 -07:00
Robert Field	0ab1bb68cc	8011591: BootstrapMethodError when capturing constructor ref to local classes ... Reviewed-by: mcimadamore	2013-05-01 08:46:04 -07:00
Maurizio Cimadamore	8b680bdde2	8011392: Missing checkcast when casting to intersection type ... Javac should emit a checkcast for each additional target type specified in an intersection type cast Reviewed-by: jjg	2013-04-15 14:17:30 +01:00
Maurizio Cimadamore	8f2d47cf79	8011028: lang/INFR/infr001/infr00101md/infr00101md.java fails to compile after switch to JDK8-b82 ... Fix bug in Types.removeWildcards Reviewed-by: jjg	2013-04-15 14:16:05 +01:00
Maurizio Cimadamore	e59fd44a73	8011376: Spurious checked exception errors in nested method call ... Fallback attribution logic doesn't work properly when lambda throws checked exceptions Reviewed-by: jjg	2013-04-15 14:15:07 +01:00
Maurizio Cimadamore	2b94dbb504	8011377: Javac crashes when multiple lambdas are defined in an array ... Wrong attribution environment used by DeferredAttr Reviewed-by: jjg	2013-04-15 14:12:17 +01:00
Maurizio Cimadamore	da9dd76b20	8010822: Intersection type cast for functional expressions does not follow spec EDR ... Remove support for marker interfaces; redefine intersection type casts to be order-independent Reviewed-by: jjg	2013-04-08 15:59:29 +01:00
Maurizio Cimadamore	ea55015155	8009131: Overload: javac should discard methods that lead to errors in lambdas with implicit parameter types ... Lambdas that have errors in their bodies should make enclosing overload resolution fail Reviewed-by: jjg	2013-04-08 15:57:10 +01:00
Maurizio Cimadamore	b4b6e4f82e	8010404: Lambda debugging: redundant LineNumberTable entry for lambda capture ... Ignore indy entries in LineNumberTable Reviewed-by: jjg	2013-04-08 15:53:08 +01:00
Maurizio Cimadamore	2b66afe14d	8010303: Graph inference: missing incorporation step causes spurious inference error ... Multiple equality constraints on inference vars are not used to generate new inference constraints Reviewed-by: jjg	2013-03-22 12:43:09 +00:00
Maurizio Cimadamore	710a687c15	8009820: AssertionError when compiling java code with two identical static imports ... Speculative attribution is carried out twice with same method symbol in case of static imports Reviewed-by: jjg	2013-03-22 12:41:13 +00:00
Maurizio Cimadamore	cec722fe8f	8010101: Intersection type cast issues redundant unchecked warning ... Code for checking intersection type cast is incorrectly swapping operands, leading to spurious warnings Reviewed-by: jjg	2013-03-22 12:39:34 +00:00
Maurizio Cimadamore	2454c8c5ae	8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods ... Private lambda methods should be accessed through invokespecial Reviewed-by: jjg	2013-03-22 12:38:12 +00:00
Robert Field	46e9ef69a7	8010010: NPE generating serializedLambdaName for nested lambda ... Reviewed-by: mcimadamore	2013-03-14 22:54:17 -07:00
Maurizio Cimadamore	22e2c128a2	8009545: Graph inference: dependencies between inference variables should be set during incorporation ... Move all transitivity checks into the incorporation round Reviewed-by: jjg	2013-03-12 16:02:43 +00:00
Maurizio Cimadamore	69ee819808	8008540: Constructor reference to non-reifiable array should be rejected ... 8008539: Spurious error when constructor reference mention an interface type 8008538: Constructor reference accepts wildcard parameterized types Overhaul of Check.checkConstructorRefType Reviewed-by: jjg	2013-03-12 16:02:13 +00:00
Robert Field	41447ec765	8009742: Bad lambda name for lambda in a static initializer or ctor ... Reviewed-by: mcimadamore	2013-03-11 10:02:55 -07:00
Robert Field	867e1720c2	8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization ... Reviewed-by: mcimadamore	2013-03-07 08:26:13 -08:00
Maurizio Cimadamore	c9bae7b335	8009299: Javac crashes when compiling method reference to static interface method ... Assertion in Check.checMethod is too strict Reviewed-by: jjg	2013-03-06 15:29:30 +00:00
Maurizio Cimadamore	e788a0e536	8009129: Illegal access error when calling method reference ... Javac generates method handle referencing non public type Reviewed-by: jjg, rfield	2013-03-05 14:19:49 +00:00
Maurizio Cimadamore	7a28d6291d	8009154: Missing cast in method reference bridge leads to NoSuchMethodError ... Missing cast in generated method reference bridge Reviewed-by: rfield, jjg	2013-03-05 14:16:07 +00:00
Maurizio Cimadamore	3cbe22f256	8009227: Certain diagnostics should not be deferred ... Add new diagnostic flag to mark non deferrable diagnostics Reviewed-by: jjg	2013-03-05 14:12:07 +00:00
Maurizio Cimadamore	d0a0df54ed	8004962: Code generation crash with lambda and local classes ... Translation info should be propagated from LambdaToMethod to Lower Reviewed-by: jjg, rfield	2013-03-05 14:04:57 +00:00
Maurizio Cimadamore	f932d844c1	8008537: Missing method reference lookup error when unbound search finds a static method ... Static-ness check should be applied after member reference resolution Reviewed-by: jjg	2013-02-28 14:05:52 +00:00
Maurizio Cimadamore	85067f7869	8008813: Structural most specific fails when method reference is passed to overloaded method ... Bad logic for checking most specific method reference type Reviewed-by: jjg	2013-02-28 14:05:44 +00:00
Maurizio Cimadamore	9c01455eb6	8008723: Graph Inference: bad graph calculation leads to assertion error ... Dependencies are not propagated correctly through merged nodes during inference graph initialization Reviewed-by: jjg	2013-02-28 14:00:52 +00:00
Maurizio Cimadamore	7776fdebe7	8008708: Regression: separate compilation causes crash in wildcards inference logic ... Invalid use of WildcardType.bound in Types.removeWildcards Reviewed-by: jjg	2013-02-22 18:19:51 +00:00
Sonali Goel	96495bc664	8008337: Write test to check for compiler error when static method in interface is called via super() ... Reviewed-by: mcimadamore	2013-02-22 13:31:35 +00:00
Robert Field	bcaa703a49	8008405: Now that metafactory is in place, add javac lambda serialization tests ... Tests part of original langtools serialization review. Reviewed-by: mcimadamore	2013-02-21 14:43:51 -08:00
Maurizio Cimadamore	73b1aee3f4	8008444: Inherited generic functional descriptors are merged incorrectly ... Missing call to Types.createMethodWithThrownTypes Reviewed-by: jjg	2013-02-21 15:27:05 +00:00
Maurizio Cimadamore	8c1621ee38	8008293: Declared bounds not considered when functional interface containing unbound wildcards is instantiated ... Wildcards inference should re-use some of the bounds info generated during capture conversion Reviewed-by: jjg	2013-02-21 15:25:03 +00:00
Maurizio Cimadamore	5bbf5f39fc	8005183: Missing accessor for constructor reference pointing to private inner class ctor ... Compiler should add bridges when translating private constructor reference Reviewed-by: jjg	2013-02-21 15:23:48 +00:00
Maurizio Cimadamore	937b7d2fba	8008276: assertion error in com.sun.tools.javac.comp.TransTypes.visitApply ... DiagnosticFilter used during speculative attribution is too broad Reviewed-by: jjg	2013-02-21 15:21:38 +00:00
Maurizio Cimadamore	eb68b33185	8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler ... Disentangle cyclic dependency between static-ness of synthetic lambda method and static-ness of classes nested within lambdas Reviewed-by: jjg	2013-02-21 15:19:29 +00:00
Robert Field	b2a3c762ff	8004969: Generate $deserializeLambda$ method ... 8006763: super in method reference used in anonymous class - ClassFormatError is produced 8005632: Inner classes within lambdas cause build failures 8005653: Lambdas containing inner classes referencing external type variables do not correctly parameterize the inner classes Reviewed-by: mcimadamore	2013-02-15 18:40:38 -08:00
Maurizio Cimadamore	fd17a4290b	8008309: TargetType60 fails because of bad golden file ... Bad golden file Reviewed-by: jjg	2013-02-15 18:13:00 +00:00
Sonali Goel	30058417e1	8007427: Annotation element as '_' gives compiler error instead of a warning ... 8007401: Write test to check for generation of warnings when '_' is used as an identifier Extended identifier production not used in annotation values Reviewed-by: jjg	2013-02-15 16:31:19 +00:00
Maurizio Cimadamore	f5df2a2562	8007535: Compiler crashes on @FunctionalInterface used on interface with two inherited methods with same signatures ... Bad check in Types.interfaceCandidates Reviewed-by: jjg	2013-02-15 16:30:31 +00:00
Maurizio Cimadamore	b496912ee1	8007462: Fix provisional applicability for method references ... Add speculative arity-based check to rule out potential candidates when stuck reference is passed to method Reviewed-by: jjg	2013-02-15 16:29:58 +00:00
Maurizio Cimadamore	e88e06a5e0	8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract ... Missing abstractness check on super rmethod references Reviewed-by: jjg	2013-02-15 16:28:57 +00:00
Maurizio Cimadamore	f8f9896cc7	8006749: compiler does not allow Object protected methods to be used in lambda ... Check.checkFunctionalInterface should take into account 'fake' override Reviewed-by: jjg	2013-02-15 16:28:07 +00:00
Maurizio Cimadamore	1ec5dfafe0	8007464: Add graph inference support ... Add support for more aggressive type-inference scheme Reviewed-by: jjg	2013-02-12 19:25:09 +00:00
Jim Holmlund	8985a7c2ac	8007504: Remove @ignore from tests that no longer need it ... Reviewed-by: mcimadamore	2013-02-05 18:55:13 +00:00
Maurizio Cimadamore	5b1a78dc92	8006694: temporarily workaround combo tests are causing time out in several platforms ... Reviewed-by: jjg	2013-01-23 20:57:40 +00:00
Maurizio Cimadamore	1f8b2abf80	8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack ... Lambda desugaring generates spurious references to 'this' in static contexts Reviewed-by: jjg	2013-01-22 16:39:51 +00:00
Maurizio Cimadamore	948888218b	8006673: TargetType52 fails because of bad golden file ... Fix golden file in negative test Reviewed-by: jjg	2013-01-22 16:23:35 +00:00
Maurizio Cimadamore	422c8bd914	8006566: Remove transient lambda-related guards from JavacParser ... Remove transitional internal flag for allowing intersection types in cast Reviewed-by: jjg	2013-01-21 20:14:39 +00:00