Commit Graph

526 Commits

Author SHA1 Message Date
Jonathan Dowland
394ebc8642 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value
Reviewed-by: shade, dfuchs
2021-09-14 17:12:49 +00:00
Evan Whelan
00e059ddb3 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order
Reviewed-by: dfuchs
2021-09-09 10:23:12 +00:00
Daniel Fuchs
db9834ff82 8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException"
Reviewed-by: chegar
2021-08-20 09:05:00 +00:00
Thejasvi Voniadka
4e18ec26dd 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
Reviewed-by: dfuchs, vtewari
2021-07-08 06:01:31 +00:00
Patrick Concannon
1578979df7 8269917: Insert missing commas in copyrights in java.net
Reviewed-by: chegar, dfuchs
2021-07-06 15:10:58 +00:00
Patrick Concannon
326b2e1344 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation
Reviewed-by: alanb, dfuchs, chegar
2021-07-06 13:46:02 +00:00
Jesper Wilhelmsson
b6cfca8a89 Merge 2021-06-23 01:05:44 +00:00
Weijun Wang
ef4ba224c4 8268349: Provide clear run-time warnings about Security Manager deprecation
Reviewed-by: lancea, mullan, alanb
2021-06-22 02:06:59 +00:00
Jesper Wilhelmsson
a051e735cd Merge 2021-06-18 00:53:09 +00:00
Patrick Concannon
7d7bdbe135 8268776: Test ADatagramSocket.java missing /othervm from @run tag
Reviewed-by: dfuchs
2021-06-17 09:35:08 +00:00
Michael McMahon
2d088fa91d 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
Reviewed-by: dfuchs
2021-06-17 07:13:59 +00:00
Daniel Fuchs
8ea0606aba 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
Reviewed-by: chegar, michaelm
2021-06-16 17:24:06 +00:00
Daniel Fuchs
da043e99b8 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
Reviewed-by: chegar
2021-06-11 08:42:14 +00:00
Mahendra Chhipa
338dae4d36 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
Reviewed-by: dfuchs
2021-06-03 12:51:48 +00:00
Daniel Fuchs
178343750f 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently
Reviewed-by: alanb, chegar
2021-06-03 08:58:41 +00:00
Weijun Wang
6765f90250 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
Co-authored-by: Sean Mullan <mullan@openjdk.org>
Co-authored-by: Lance Andersen <lancea@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: erikj, darcy, chegar, naoto, joehw, alanb, mchung, kcr, prr, lancea
2021-06-02 11:57:31 +00:00
Daniel Fuchs
d4b4caecad 8268023: Improve diagnostic for HandshakeFailureTest
Reviewed-by: chegar
2021-06-01 17:55:36 +00:00
Daniel Fuchs
9d8ad2ed62 8267990: Revisit some uses of synchronized in the HttpClient API
Reviewed-by: chegar
2021-06-01 17:10:38 +00:00
Daniel Fuchs
24bf35f862 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"
Reviewed-by: chegar
2021-05-28 14:21:11 +00:00
Mark Sheppard
bb085f684d 8265362: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
Reviewed-by: dfuchs, alanb
2021-05-24 17:59:39 +00:00
Weijun Wang
640a2afda3 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager
Co-authored-by: Lance Andersen <lancea@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: dholmes, alanb, dfuchs, mchung, mullan, prr
2021-05-24 16:55:55 +00:00
Daniel Fuchs
0544a732a4 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
Reviewed-by: chegar
2021-04-30 17:21:55 +00:00
Daniel Fuchs
01415f33e3 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List<byte[]>, List<byte[]>)
Reviewed-by: prappo
2021-04-29 16:15:06 +00:00
Conor Cleary
6293299dd3 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
Reviewed-by: aefimov, dfuchs, michaelm, vtewari
2021-04-15 14:05:55 +00:00
Aleksei Efimov
a611c462f9 8264048: Fix caching in Jar URL connections when an entry is missing
Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org>
Reviewed-by: bchristi, dfuchs
2021-04-06 10:43:59 +00:00
Michael McMahon
e55aa41f57 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head
Reviewed-by: dfuchs, chegar
2021-03-24 11:59:19 +00:00
Michael McMahon
bd7a184b98 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED
Reviewed-by: dfuchs
2021-03-23 13:25:56 +00:00
Jonathan Dowland
ba504fcee8 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll
Reviewed-by: chegar, dfuchs, aph
2021-03-22 15:29:47 +00:00
Craig Andrews
0c718ab2a0 8262277: URLClassLoader.getResource throws undocumented IllegalArgumentException
Reviewed-by: alanb, bchristi, psadhukhan
2021-03-15 18:35:04 +00:00
Conor Cleary
8bc8542e3f 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)
Reviewed-by: michaelm, aefimov, dfuchs, chegar
2021-03-01 10:18:12 +00:00
Daniel Fuchs
0d2dbd2995 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool
Reviewed-by: chegar, michaelm
2021-02-24 10:50:35 +00:00
Clive Verghese
63f8fc87cd 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
Reviewed-by: xuelei
2021-02-22 18:36:30 +00:00
Daniel Fuchs
2c28e36454 8237352: Update DatagramSocket to add support for joining multicast groups
Reviewed-by: alanb
2021-02-08 12:55:00 +00:00
Yasumasa Suenaga
e3b548a68b 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens
Reviewed-by: dfuchs, chegar
2021-01-15 01:58:36 +00:00
Roger Riggs
876c7fb5f7 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys
Reviewed-by: lancea, naoto
2021-01-08 21:31:37 +00:00
Joe Darcy
80544e4d5f 8250564: Remove terminally deprecated constructor in GSSUtil
8250565: Remove terminally deprecated constructor in java.net.URLDecoder

Reviewed-by: bpb, smarks, alanb, mullan
2021-01-06 18:05:33 +00:00
Daniel Fuchs
4a839e95de 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information
Reviewed-by: chegar
2020-12-10 10:09:29 +00:00
Daniel Fuchs
fab6158c19 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
Reviewed-by: aefimov, michaelm
2020-12-08 16:36:04 +00:00
Daniel Fuchs
566d77a2ae 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
Reviewed-by: michaelm
2020-12-07 09:58:16 +00:00
Sean Mullan
3a4b90f086 8202343: Disable TLS 1.0 and 1.1
Reviewed-by: xuelei, dfuchs, coffeys
2020-11-19 14:15:57 +00:00
Patrick Concannon
9fe2d31d6e 8252304: Seed an HttpRequest.Builder from an existing HttpRequest
Co-authored-by: Chris Hegarty <chegar@openjdk.org>
Reviewed-by: chegar, dfuchs, michaelm
2020-11-19 09:35:49 +00:00
Daniel Fuchs
1c47244b01 8255244: HttpClient: Response headers contain incorrectly encoded Unicode characters
Reviewed-by: chegar, michaelm
2020-11-13 15:10:41 +00:00
Patrick Concannon
5973e91cc3 8253005: Add @throws IOException in javadoc for HttpEchange.sendResponseHeaders
Reviewed-by: dfuchs
2020-11-13 11:31:25 +00:00
Conor Cleary
f5d36e6c94 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
Reviewed-by: chegar, dfuchs
2020-11-06 17:35:24 +00:00
Michael McMahon
6bb7e45e8e 8245194: Unix domain socket channel implementation
Reviewed-by: erikj, dfuchs, alanb, chegar
2020-10-28 17:26:26 +00:00
Jamil Nimeh
d6cef99050 8245417: Improve certificate chain handling
Co-authored-by: Hai-may Chao <hai-may.chao@oracle.com>
Reviewed-by: mullan, jnimeh
2020-10-20 14:58:39 -07:00
Daniel Fuchs
4184959d85 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher.
Reviewed-by: chegar
2020-10-12 12:52:55 +00:00
Jaikiran Pai
5dd1eaded7 8252767: URLConnection.setRequestProperty throws IllegalAccessError
Reviewed-by: chegar, michaelm, alanb
2020-09-08 09:10:15 +00:00
Daniel Fuchs
80d889189a 8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request
Allows an HTTP operation to be cancelled by calling CompletableFuture::cancel(true)

Reviewed-by: michaelm, chegar, alanb
2020-08-28 10:48:17 +01:00
Rahul Yadav
b328bc14a0 8251715: Throw UncheckedIOException in place of InternalError when HttpClient fails due to unavailability of underlying resources required by SSLContext
This fix updates jdk.internal.net.http.HttpClientImpl to throw an UncheckedIOException instead of InternalError.

Reviewed-by: chegar, dfuchs
2020-08-18 16:44:42 +01:00
Patrick Concannon
a096c0a83f 8240901: Add a test to check that large datagrams are sent/received on the network correctly
This fix updates `java/net/DatagramSocket/SendReceiveMaxSize.java` and `java/net/DatagramSocket/SendReceiveMaxSize.java` to check (on all platforms) that the sending/receiving of large datagrams across a network are sent, fragmented, and re-assembled correctly

Reviewed-by: alanb, dfuchs
2020-08-13 15:40:13 +01:00
Charlie Gracie
ed5696dd2c 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test
Keep a static reference to the logger to prevent its inadvertent garbage collection while the test is running.

Reviewed-by: dfuchs
2020-08-10 19:21:50 +01:00
Rahul Yadav
8e687450d6 8248006: Revisit exceptions thrown when creating an HttpClient fails due to unavailability of underlying resources
This fix updates jdk.internal.net.http.HttpClientImpl to throw an UncheckedIOException instead of InternalError.

Reviewed-by: chegar, dfuchs
2020-08-10 15:15:10 +01:00
Patrick Concannon
c8c4d8377a 8250886: java/net/DatagramSocket/SendReceiveMaxSize.java fails in timeout
SO_RCVBUF was previously set to match the SO_SNDBUF, however the kernel value for SO_RCVBUF is much larger. This mismatch caused the test to fail, and the fix removes this issue.

Reviewed-by: alanb, dfuchs
2020-08-07 20:39:10 +01:00
Daniel Fuchs
77c46ea911 8229822: ThrowingPushPromises tests sometimes fail due to EOF
SocketTube is fixed to cater for errors caused by pausing/resuming events on an asynchronously closed connection, from within the selector's manager thread. Http2Connection and Stream are fixed to prevent sending a DataFrame on a stream after Reset has been sent.

Reviewed-by: chegar
2020-08-07 16:16:45 +01:00
Daniel Fuchs
45c89daf72 8249786: java/net/httpclient/websocket/PendingPingTextClose.java fails very infrequently
TransportImpl is modified to make sure the CLOSED state is recorded before the channel is closed. The tests are modified to enable their retry mechanism on windows, similar to what was done previously for macOS.

Reviewed-by: prappo, chegar
2020-08-07 15:09:19 +01:00
Patrick Concannon
dc71097c2e 8250889: Disable testing SendReceiveMaxSize with preferIPv4Stack=true on the old impl until JDK-8250886 is fixed
The `test java/net/DatagramSocket/SendReceiveMaxSize` is currently failing when run with `-Djdk.net.usePlainDatagramSocketImpl` and `-Djava.net.preferIPv4Stack=true`. This fix removes these run settings from the test until a more permanent solution can be found.

Reviewed-by: dfuchs
2020-07-31 18:59:27 +01:00
Patrick Concannon
7fd5cb6117 8242885: PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams on macOS with sizes between 65508-65527 bytes
This fix changes the current max size for IPv6 datagrams on macOS from it's current size of 65507, which is the IPv4 limit, to 65527, the actual limit for IPv6 on macOS

Reviewed-by: alanb, dfuchs, vtewari
2020-07-31 12:42:32 +01:00
Patrick Concannon
2dda9965cd 8246164: SendDatagramToBadAddress.java and ChangingAddress.java should be changed to explicitly require the new DatagramSocket implementation
This fix updates these tests to explicitly run with `-Djdk.net.usePlainDatagramSocketImpl=false` to avoid false failures when running all tests with a global jtreg -Djdk.net.usePlainDatagramSocketImpl switch.

Reviewed-by: vtewari
2020-07-31 12:12:49 +01:00
Daniel Fuchs
9f23c2c159 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
Fixed the test to reenable its retry logic

Reviewed-by: alanb
2020-07-23 20:25:41 +01:00
Vyom Tewari
955aee3bfa 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly
PlainSocketImpl.socketAccept() handles EINTR incorrectly

Reviewed-by: alanb, dfuchs, martin
2020-07-17 11:15:00 +05:30
Jesper Wilhelmsson
3dcd1c1ab0 Merge 2020-07-09 04:32:30 +02:00
Ivan Sipka
dda0c6cecd 8211974: move test/jdk/lib/testlibrary/java/util/jar/*.java to top-level library or a local library
Reviewed-by: rriggs, bchristi, lancea, iignatyev
2020-07-08 20:35:36 +01:00
Daniel Fuchs
0f43de9f02 8246114: java/net/MulticastSocket/Promiscuous.java fails after 8241072 (multi-homed systems)
Fixed the test - an IPv4 group cannot be joined from an interface that has no IPv4 address configured

Reviewed-by: alanb, amlu
2020-06-30 18:52:59 +01:00
Patrick Concannon
5b6f050fce 8245828: Remove unnecessary NetworkPermission checks from jdk/net/ExtendedSocketOptions.java
This fix removes NetworkPermission checks that were made redundant in jdk/net/ExtendedSocketOptions after the socket option SO_FLOW_SLA was removed.

Reviewed-by: alanb
2020-06-09 15:39:22 +01:00
Patrick Concannon
ac906168c8 8243999: DatagramSocket and MulticastSocket constructors don't specify how a null InetAddress is handled
This fix clarifies the behaviours of constructors from DatagramSocket and MulticastSocket when no address or a null address is supplied.

Reviewed-by: dfuchs
2020-06-09 15:26:53 +01:00
Julia Boes
3943f9d0b7 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission
Add explicit jtreg build configuration and adjust permissions accordingly

Reviewed-by: chegar, dfuchs
2020-06-08 15:27:31 +01:00
Patrick Concannon
d071ed0294 8244582: Remove terminally deprecated Solaris-specific SO_FLOW_SLA socket option
This patch removes ExtendedSocketOptions.SO_FLOW_SLA, SocketFlow and SocketFlow.Status which were terminally deprecated in JDK 14 in preparation for the removal of the Solaris port.

Reviewed-by: alanb, dfuchs, chegar, vtewari
2020-06-05 09:35:42 +01:00
Jesper Wilhelmsson
7c3d72fd3a Merge 2020-06-30 20:09:03 +02:00
Rahul Yadav
c07ce7eec7 8245245: Websocket can lose the URL encoding of URI query parameters
The fix updates jdk.internal.net.http.websocket.OpeningHandshake to avoid double encoding and decoding of URL

Reviewed-by: dfuchs, chegar, prappo
2020-06-29 14:49:03 +01:00
Conor Cleary
1b75b7de80 8246143: UnreferencedXXX tests fail when run with --illegal-access=deny
This patch updates the @modules tag with +open in the tests UnreferencedDatagramSockets and UnreferncedMulticastSockets in advance of the removal of --illegal-access to allow access to private member fields required by the tests.

Reviewed-by: alanb, dfuchs
2020-06-12 09:48:30 +01:00
Aleksei Efimov
02fbf44cc7 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService
Reviewed-by: dfuchs, alanb, vtewari
2020-05-29 13:39:16 +01:00
Julia Boes
c0a1a4e4fc 8237470: HttpResponse.BodySubscriber::ofFile throws UOE with non-default file systems
Rework non-default file system paths of BodySubscriber::ofFile and BodyHandler::ofFile and fix BodyHandler::ofFileDownload to throw consistently for non-default file system paths

Reviewed-by: dfuchs, chegar
2020-05-29 12:59:13 +01:00
Patrick Concannon
4708c6d343 8243507: DatagramSocket constructors don’t always specify what happens when passed invalid parameters
This fix updates the spec for DatagramSocket's constructors to inform the user of the Exceptions thrown when an invalid argument is passed.

Reviewed-by: dfuchs
2020-05-29 11:08:09 +01:00
Vladimir A Ivanov
4aa057013c 8245517: java/net/SocketOption/AfterClose.java fails with Invalid value 'READ_ONLY'
Reviewed-by: dfuchs, pconcannon
2020-05-22 10:25:40 -07:00
Mikael Vidstedt
071bd521bc 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports
Reviewed-by: alanb, bchristi, dcubed, dfuchs, eosterlund, erikj, glaubitz, ihse, iignatyev, jjiang, kbarrett, ksrini, kvn, naoto, prr, rriggs, serb, sspitsyn, stefank, tschatzl, valeriep, weijun, weijun
2020-05-20 17:33:37 -07:00
Vladimir A Ivanov
93fcbec20a 8243099: SO_INCOMING_NAPI_ID support
Add support for the SO_INCOMING_NAPI_ID socket option to jdk.net.ExtendedSocketOptions

Co-authored-by: Dinesh Kumar <dinesh.kumar@intel.com>
Reviewed-by: alanb, chegar, dfuchs, vtewari, pconcannon
2020-05-20 15:12:28 -07:00
Daniel Fuchs
58adc04d69 8244031: HttpClient should have more tests for HEAD requests
Http2TestExchangeImpl.java updated to support HEAD responses; ForbiddenHeadTest.java added.

Reviewed-by: chegar, michaelm
2020-05-20 18:57:06 +01:00
Patrick Concannon
fad2cf51ba 8241072: Reimplement the Legacy DatagramSocket API
Replace the underlying implementations of the java.net.DatagramSocket and java.net.MulticastSocket APIs with simpler and more modern implementations that are easy to maintain and debug.

Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Co-authored-by: Daniel Fuchs <daniel.fuchs@oracle.com>
Reviewed-by: alanb, chegar, dfuchs
2020-05-12 21:51:53 +01:00
Rahul Yadav
178e69a3b9 8244652: Add test for non utf-8 response handling by websocket
The test java.net.httpclient.websocket.WSHandshakeExceptionTest.java checks that the websocket client handles invalid utf-8 sent by the websocket server

Reviewed-by: dfuchs
2020-05-15 14:46:17 +01:00
Daniel Fuchs
a2c35a6acb 8244205: HTTP/2 tunnel connections through proxy may be reused regardless of which proxy is selected
The key used in the HTTP/2 connection pool is updated to take into account the proxy address in case of tunnel connections

Reviewed-by: chegar
2020-05-06 19:19:38 +01:00
Rahul Yadav
ed24927500 8240666: Websocket client’s OpeningHandshake discards the HTTP response body
The fix updates jdk.internal.net.http.websocket. OpeningHandshake.send() method to process the response body from server

Reviewed-by: chegar, dfuchs, prappo
2020-05-06 17:33:32 +01:00
Patrick Concannon
469c13a86d 8243488: Add tests for set/get SendBufferSize and getReceiveBufferSize in DatagramSocket
Tests added for methods: setSendBufferSize(int), getSendBufferSize(), and getReceieveBufferSize() to increase test coverage in the DatagramSocket class

Reviewed-by: alanb, chegar, dfuchs
2020-05-05 18:34:39 +01:00
Rahul Yadav
184b433630 8242999: HTTP/2 client may not handle CONTINUATION frames correctly
Updated jdk.internal.net.http.Stream.incoming(Http2Frame frame) to handle continuation frame with END_HEADER flag

Reviewed-by: chegar, dfuchs
2020-04-28 10:30:27 +01:00
Daniel Fuchs
94a99ab9e5 8243246: HTTP Client sometimes gets java.io.IOException -> Invalid chunk header byte 32
The HTTP/1 chunked body parser is updated to discard chunk extensions

Reviewed-by: chegar, alanb
2020-04-24 16:54:30 +01:00
Patrick Concannon
42d2a7411b 8243408: Inconsistent Exceptions are thrown by MulticastSocket when sending a DatagramPacket to port 0
This fix adds a check for port == 0 to MulticastSocket's 2-arg send method to ensure a consistent exception is thrown across platforms

Reviewed-by: dfuchs
2020-04-22 20:41:56 +01:00
Patrick Concannon
8e21a2a1e4 8237890: DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set
This fix changes the default port of a DatagramPacket from -1 to 0, which changes the behaviour of calling getSocketAddress with no port set from throwing an IAE to returning an InetSocketAddress representing any local address with port 0.

Reviewed-by: alanb, chegar, dfuchs
2020-04-22 12:34:09 +01:00
Daniel Fuchs
da1abd18db 8238270: java.net HTTP/2 client does not decrease stream count when receives 204 response
The HTTP/2 Stream is updated to register a trivial data subscriber in case of 204 so that the END_STREAM is correctly processed.

Reviewed-by: chegar
2020-04-20 13:15:45 +01:00
Henry Jen
0278846eaa Merge 2020-04-14 23:11:49 +00:00
Rahul Yadav
86722cb038 8239594: jdk.tls.client.protocols is not respected
8239595: ssl context version is not respected

The java.net.HttpClient is updated to no longer override any default selected protocols in the SSLContext, in the absence of  any SSLParameters explicitly supplied to the HttpClient.builder.

Reviewed-by: chegar, dfuchs
2020-04-10 10:05:33 +01:00
Patrick Concannon
378aef32ab 8240533: Inconsistent Exceptions are thrown by DatagramSocket and DatagramChannel when sending a DatagramPacket to port 0
Fix adds checks for port == 0 to the send and connect methods in DatagramSocket and DatagramChannelImpl

Reviewed-by: alanb, chegar, dfuchs, lancea
2020-04-07 16:21:01 +01:00
Jaikiran Pai
59af1c2af4 8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
Reviewed-by: dfuchs, chegar
2020-03-24 15:47:51 +05:30
Daniel Fuchs
f541970b31 8241786: Improve heuristic to determine default network interface on macOS
DefaultInetrface.getDefault is updated to prefer interfaces that have non link-local addresses. NetworkConfiguration is updated to skip interface that have only link-local addresses, whether IPv4 or IPv6, for multicasting.

Reviewed-by: chegar, alanb
2020-04-03 14:27:03 +01:00
Chris Hegarty
9a69bb807b 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server
Reviewed-by: dfuchs, michaelm
2020-04-03 07:27:53 +01:00
Chris Hegarty
61940fe4ce 8241988: DatagramSocket incorrectly caches the first set of socket options
Reviewed-by: msheppar, dfuchs, alanb
2020-04-03 07:16:35 +01:00
Daniel Fuchs
5ddbcb7a51 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration
NetworkConfiguration updated to skip interfaces that have only IPv6 link local addresses.

Reviewed-by: alanb, chegar
2020-03-27 12:42:03 +00:00
Julia Boes
eb7c80a308 8241674: Fix incorrect jtreg option in FilePublisherPermsTest
Replace jtreg option 'policy' with 'java.security.policy' to extend rather than replace policy

Reviewed-by: chegar, dfuchs
2020-03-26 14:58:53 +00:00
Julia Boes
d882d528bb 8235459: HttpRequest.BodyPublishers::ofFile assumes the default file system
Add support for non-default file systems to HttpRequest.BodyPublishers::ofFile

Reviewed-by: chegar, dfuchs, amlu
2020-03-26 11:52:15 +00:00
Rahul Yadav
c5a7490809 8240921: Minor correction to HttpResponse.BodySubscribers example
The fix updates the incorrect example of the usage of the class java.net.http.HttpResponse.BodySubscribers.

Reviewed-by: chegar, dfuchs, jboes, pconcannon
2020-03-20 20:16:34 +00:00
Daniel Fuchs
58337b12f8 8059309: network tests fail with "java.net.SocketException: Couldn't obtain phys addr" when run as "root"
The solaris specific code is changed to use the fallback mechanism if the DLPI interface returns an error indicating that the operation is unsupported. In addition, NetworkInterface::getHardwareAddress is changed to always return null for the loopback interface.

Reviewed-by: alanb
2020-03-12 18:31:49 +00:00
Patrick Concannon
0ed44d0aee 8239355: (dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)
Updates DatagramChannel so that the SO_SNDBUF is set to a minimum value of 65527 for IPv6 sockets and 65507 for IPv4 sockets on macOS.

Reviewed-by: alanb, dfuchs
2020-03-12 17:08:09 +00:00
John Jiang
edaf548beb 8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify a TLS protocol
Reviewed-by: dfuchs
2020-03-10 21:43:46 +08:00
Daniel Fuchs
5c8f935641 8240754: Instrument FlowTest.java to provide more debug traces
Reviewed-by: chegar
2020-03-09 17:48:40 +00:00
Ravi Reddy
b2f1f73e75 8183369: RFC unconformity of HttpURLConnection with proxy
HttpURLConnection retried with proxy if the connection fails on first attempt as per RFC

Reviewed-by: chegar, dfuchs, vtewari
2020-03-05 03:27:17 -05:00
Daniel Fuchs
f7c819a72d 8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java failed with BufferUnderflowException against TLSv1.3
The test assumed that ByteBuffer would be split at long boundaries. This is obviously not always the case. A carry has been added to support reading a long split over several buffers.

Reviewed-by: chegar
2020-02-24 17:19:32 +00:00
Daniel Fuchs
f40220f578 8238990: java/net/httpclient/HandshakeFailureTest.java failed against TLSv1.3 on Windows
The SSLTube and SSLFlowDelegate are improved to wrap any non-SSL exception that occur during the handshake in an SSLHandshakeException.

Reviewed-by: chegar
2020-02-20 20:04:15 +00:00
John Jiang
446f59a26c 8234718: java/net/httpclient tests should cover TLSv1.3
Reviewed-by: dfuchs
2020-02-13 21:42:31 +08:00
John Jiang
fbca3fa710 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version
Reviewed-by: dfuchs
2020-02-11 08:36:02 +08:00
Patrick Concannon
00c40ae1e3 7021373: DatagramPacket exception conditions are not clear
Specification is clarified by adding or clarifying @throws clauses where required

Reviewed-by: alanb, chegar, darcy, dfuchs
2020-02-07 11:10:41 +00:00
Daniel Fuchs
b069da31e0 8238231: Custom DatagramSocketImpl's create method not called when with protected constructor
Allow the socket to be lazily created if not created by the constructor.

Reviewed-by: alanb
2020-02-04 18:35:37 +00:00
Mikael Vidstedt
3318314c7c 8237589: Fix copyright header formatting
Reviewed-by: jjg, serb, iris, jwilhelm
2020-01-21 14:23:01 -08:00
Patrick Concannon
d2cd7a5096 8237571: java/net/DatagramSocket/SendCheck.java is failing on Solaris
Commented out failing testcase as this is being tracked by JDK-8236852

Reviewed-by: dfuchs
2020-01-21 18:38:46 +00:00
Patrick Concannon
2f76772fa9 8236105: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent
DatagramSocket and MulticastSocket changed to throw IllegalArgumentException if not connected and passed a packet containing a port out of range

Reviewed-by: chegar, dfuchs
2020-01-20 16:24:05 +00:00
Daniel Fuchs
c6da6681d4 8236859: WebSocket over authenticating proxy fails with NPE
This change fixes several issues with WebSocket and proxy authentication. The AuthenticationFilter is changed to support an authenticating server accessed through an authenticating proxy. MultiExchange is fixed to close the previous connection if a new connection is necessary to establish the websocket (websocket connections are not cached and must be closed in that case). WebSocket OpeningHandshake is fixed to close the connection (without creating the RawChannel) if the opening handshake doesn't result in 101 upgrade protocol.

Reviewed-by: prappo, chegar
2020-01-17 17:55:06 +00:00
Jesper Wilhelmsson
257a1bb854 Merge 2020-01-08 16:03:32 +01:00
Chris Hegarty
417672bc9d 8236441: Bound MulticastSocket fails when setting outbound interface on Windows
Reviewed-by: alanb
2019-12-23 09:17:00 +00:00
Daniel Fuchs
ad09813035 8233245: More adaptive sockets
Reviewed-by: chegar, igerasim, alanb, skoivu, rhalade
2019-12-09 20:33:15 +00:00
Ivan Gerasimov
6c16f55fde 8231785: Improved socket permissions
Reviewed-by: ahgross, chegar, mullan, rhalade
2019-10-23 17:03:07 -07:00
Kiran Sidhartha Ravikumar
a1b2e1042c 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences
Reviewed-by: chegar, dfuchs
2019-12-17 16:06:27 +00:00
Daniel Fuchs
e16d4a45b0 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts and other small cleanups
HttpProxy test is fixed to take into account the possibility that the host may be configured with IPv4 only

Reviewed-by: chegar
2019-12-17 16:11:16 +01:00
Daniel Fuchs
7135b5dd9c 8235141: Specify the required standard socket options for the socket types in the java.net package
Reviewed-by: alanb, chegar
2019-12-10 13:22:52 +00:00
Patrick Concannon
22e26b2a81 8234148: DatagramSocket.setOption/getOption/supportedOption should support multicast options
Fix adds multicast socket options to DatagramSocket

Reviewed-by: alanb, dfuchs, vtewari
2019-12-09 14:25:37 +00:00
Julia Boes
07fc539a85 8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException
Increase the number of bind retries and test repeats, best effort only

Reviewed-by: msheppar, dfuchs, vtewari
2019-12-09 12:46:12 +00:00
Michael McMahon
a2fad13ce2 8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10
Reviewed-by: alanb
2019-12-03 11:55:47 +00:00
Patrick Concannon
55da7d34c9 8233307: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set
The MulticastSocket method getOption has been changed to conform to the behavior described in StandardSocketOptions.IP_MULTICAST_IF.

Reviewed-by: chegar, dfuchs
2019-11-28 16:49:52 +00:00
Patrick Concannon
b9c7a608d2 8233018: Add a new test to verify that DatagramSocket is not interruptible
Test added to check the interruptability of DatagramSocket, MulticastSocket and DatagramSocketAdaptor.

Reviewed-by: chegar, dfuchs
2019-11-27 16:01:34 +00:00
Daniel Fuchs
8333ea85fa 8233296: MulticastSocket getOption/setOption inverts the value of IP_MULTICAST_LOOP
MulticastSocket.getOption(StandardSocketOption.IP_MULTICAST_LOOP) now returns true if loopback mode is enabled, and MulticastSocket.setOption(StandardSocketOption.IP_MULTICAST_LOOP, true) enables loopback mode. No other behavioral changes.

Reviewed-by: alanb, chegar
2019-11-22 11:52:48 +00:00
Patrick Concannon
6a7f775347 8234083: DatagramSocket should report SO_BROADCAST as a supported option
DatagramSocket had a setBroadcast and getBroadcast setter/getter pair but curiously didn't report SO_BROADCAST as a supported option. Note: the source code changes were accidentally pushed with 8234103 so this changeset only has the test changes. The reviewers listed below had already reviewed the full (source+test) changes.

Reviewed-by: alanb, vtewari, chegar
2019-11-21 16:33:00 +00:00
Chris Hegarty
262d5f1790 8232101: (sctp) Add minimal sanity tests for SCTP
Reviewed-by: alanb
2019-11-21 12:14:26 +00:00
Daniel Fuchs
be18a54cb1 8233141: DatagramSocket.send doesn't specify exception thrown when no target address
DatagramSocket and MulticastSocket send methods are changed to throw IllegalArgumentException if no target address can be determined.

Reviewed-by: alanb
2019-11-18 16:48:05 +00:00
Patrick Concannon
78accb5602 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java
This fix adds an IPv4 version of test SetLoopbackMode.java that calls SetLoopbackMode in IPv4 only mode, and runs only if IPv4 is enabled.

Reviewed-by: dfuchs
2019-11-14 11:04:57 +00:00
Patrick Concannon
11433529aa 8233860: AfterClose.java test incorrectly handles IP_MULTICAST_IF
Correction to invalid value used to ensure test fails as expected.

Reviewed-by: alanb, dfuchs, vtewari
2019-11-14 10:49:20 +00:00
Julia Boes
d948bfd584 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException
Change implementation to use iterator instead of plain LinkedList

Reviewed-by: dfuchs, vtewari
2019-11-08 11:15:16 +00:00
Ivan Gerasimov
43368f8f9f 8233886: TEST_BUG jdk/java/net/CookieHandler/B6791927.java hit hardcoded expiration date
Reviewed-by: chegar, vtewari
2019-11-11 05:09:31 -08:00
Daniel Fuchs
eaba9fe23b 8233403: Improve verbosity of some httpclient tests
Improve the verbosity of some httpclient tests to help diagnosis of intermittent failures. Also fixes ShortRequestBody test.

Reviewed-by: chegar
2019-11-07 16:18:02 +00:00
Chris Hegarty
9f6af13f9d 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3
Reviewed-by: dfuchs
2019-11-04 10:06:59 +00:00
Julia Boes
012dffcd27 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact
Modified method description to disambiguate when false is returned and altered implementation

Reviewed-by: dfuchs, chegar, vtewari
2019-11-01 12:57:01 +00:00
Daniel Fuchs
b3477399d0 8232625: HttpClient redirect policy should be more conservative
When enabled, HttpClient redirect is fixed to drop the body when the request method is changed, and to relay any redirection code it does not understand to the caller.

Reviewed-by: chegar
2019-10-23 15:54:39 +01:00
Julia Boes
f8440c33d2 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses
Enclose IPv6 literal in brackets and adjust string format for unresolved addresses

Reviewed-by: dfuchs, chegar
2019-10-17 08:56:06 +01:00
Ivan Gerasimov
31afddccae 8230407: SocketPermission and FilePermission action list allows leading comma
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Reviewed-by: chegar
2019-10-16 14:32:17 -07:00
Daniel Fuchs
ecde34ee35 8231449: HttpClient’s client ssl certificate authentication seems to be broken
SSLFlowDelegate.Reader and SubscriberWrapper are changed to better cooperate on when more demand should be requested from upstream. The issue encountered in this scenario was triggered by a large certificate which caused the SSLFlowDelegate to stop requesting data from upstream during the handshake although the engine handshake status was NEED_UNWRAP.

Reviewed-by: chegar
2019-10-16 14:50:53 +01:00
Patrick Concannon
dcceed10b6 8222829: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative
Clarifies behaviour of setSoTimeout() method when given negative timeout value.

Reviewed-by: alanb, chegar, dfuchs
2019-10-08 15:03:20 +01:00
Daniel Fuchs
8e98ce54bf 8231506: Fix some instabilities in a few networking tests
Reviewed-by: alanb, chegar, msheppar
2019-10-01 12:10:33 +01:00
Daniel Fuchs
8578ab1c23 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed
The test is updated to verify whether reverse lookup is altogether possible.

Reviewed-by: chegar
2019-09-27 14:43:35 +01:00
Chris Hegarty
0b881387f2 8231504: Update networking tests to avoid implicit dependency on the system proxies
Reviewed-by: dfuchs
2019-09-27 09:55:35 +01:00
Patrick Concannon
11d43732bc 8217825: Verify @AfterTest is used correctly in WebSocket tests
Remove @AfterTest tags; added in explicit closing of resources e.g. httpServer, webSocket, etc

Reviewed-by: dfuchs, prappo
2019-09-23 16:53:16 +01:00
Daniel Fuchs
e9eaba3d53 8230858: Replace wildcard address with loopback or local host in tests - part 23
Add new traces for better diagnosis, refrain binding to the wildcard address when possible.

Reviewed-by: chegar, xuelei
2019-09-12 15:46:11 +01:00
Daniel Fuchs
10e4fd4b95 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient
Fixed the PlainProxyConnection lookup key.

Reviewed-by: chegar
2019-09-09 18:23:39 +01:00
Patrick Concannon
1f87cb017f 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface
The test is updated to skip Teredo pseudo interfaces on windows.

Reviewed-by: michaelm, vtewari, aefimov
2019-09-09 16:13:43 +01:00
Daniel Fuchs
f71db3074c 8230435: Replace wildcard address with loopback or local host in tests - part 22
Fixes tests to use the loopback address whenever possible. It also fixes some safe publishing issues, or add diagnostics in some of the tests.

Reviewed-by: michaelm
2019-09-04 18:10:07 +01:00
Julia Boes
7b49c40ee9 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"
Test cleaned up to improve safe termination

Reviewed-by: michaelm, vtewari, dfuchs
2019-09-04 17:36:53 +01:00
Jaikiran Pai
6b2e444aa1 8223714: HTTPSetAuthenticatorTest could be made more resilient
HTTPTestServer (in the test infrastructure) will no longer stop accepting requests if a previous request processing failed

Reviewed-by: dfuchs
2019-08-30 17:22:55 +05:30
Patrick Concannon
aa5d8f64ee 8193596: java/net/DatagramPacket/ReuseBuf.java failed due to timeout
The test is changed to bind to InetAddress.getLocalHost() instead of binding to the wildcard.

Reviewed-by: alanb, dfuchs, msheppar
2019-08-30 12:44:52 +01:00
Jaikiran Pai
6fa4babbb2 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage
Catch the IAE thrown by ProxySelector.select and wrap it into a IOException

Reviewed-by: dfuchs
2019-08-28 20:05:43 +05:30
Jaikiran Pai
f8e6dcdd09 8230220: java/net/HttpURLConnection/HttpURLProxySelectionTest.java fails intermittently
Fix the test to use volatile on members which are accessed across threads

Reviewed-by: dfuchs
2019-08-27 16:17:40 +05:30
Matthias Baesken
313cb3ce76 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Reviewed-by: chegar, clanger
2019-08-14 15:07:04 +02:00
Julia Boes
fb3b0ab1fb 8230000: some httpclients testng tests run zero test
Two tests needed to declared their test methods public, the last one was a simple abstract framework for subclasses and needed its @test keyword removed.

Reviewed-by: chegar, aefimov, dfuchs
2019-08-26 14:48:12 +01:00
Jaikiran Pai
1d67d474a5 8177648: getResponseCode() throws IllegalArgumentException caused by protocol error while following redirect
Reviewed-by: michaelm, chegar, dfuchs
2019-08-26 12:25:49 +01:00
Patrick Concannon
a9f92bec7f 8078219: Verify lack of @test tag in files in java/net test directory
Reviewed-by: alanb
2019-08-22 18:54:56 +01:00
Nick Gasson
84686488e8 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6
Reviewed-by: alanb, dfuchs
2019-08-22 10:53:48 +08:00
Patrick Concannon
c99c1f8d55 8229916: Delete redundant test java/net/Socket/reset/Test.java
Remove java/net/Socket/reset/Test.java which misses an @test tag and is obsoleted by java/net/Socket/ConnectionReset.java

Reviewed-by: alanb
2019-08-20 15:40:49 +01:00
Patrick Concannon
9f41d4d2f2 8229421: The logic of java/net/ipv6tests/TcpTest.java is flawed
The test is fixed to ignore rogue client connection. However it remains succeptible to intermittent failures due to the use of the wildcad address.

Reviewed-by: dfuchs
2019-08-20 11:15:23 +01:00
Daniel Fuchs
bd1521e1a6 8191169: java/net/Authenticator/B4769350.java failed intermittently
Fixed a race condition in AuthenticationInfo when serializeAuth=true

Reviewed-by: chegar, michaelm
2019-08-19 11:14:50 +01:00
Daniel Fuchs
77d09f0f14 8229486: Replace wildcard address with loopback or local host in tests - part 21
Reviewed-by: chegar
2019-08-15 12:58:27 +01:00
Daniel Fuchs
6d63995ada 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently
The test was observed blocking on receive and is updated to avoid using the wildcard address

Reviewed-by: chegar, msheppar
2019-08-13 16:18:43 +01:00
Aleksei Efimov
b4a7fb856b 8228508: [TESTBUG] java/net/httpclient/SmokeTest.java fails on Windows7
Reviewed-by: dfuchs, chegar
2019-08-13 16:11:28 +01:00
Aleksei Efimov
4312f54e51 8225430: Replace wildcard address with loopback or local host in tests - part 14
Reviewed-by: dfuchs, chegar, vtewari
2019-08-08 21:58:11 +01:00
Patrick Concannon
9f7cbf60e4 8228970: AssertionError in ResponseSubscribers$HttpResponseInputStream
HttpResponseInputStream::read(byte[],int,int) now implements the same check than the InputStream::read(byte[],int,int).

Reviewed-by: prappo, chegar, dfuchs
2019-08-08 18:44:11 +01:00
Patrick Concannon
00395fe0d0 8227721: test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java should open the java.net package
Reviewed-by: chegar, bpb, alanb
2019-07-24 13:08:36 +01:00
Xiaohong Gong
53635b436c 8227574: [TESTBUG] JTReg tests fail with Graal due to access denied
Reviewed-by: kvn
2019-07-15 03:14:28 +00:00
Daniel Fuchs
dc300483a7 8227539: Replace wildcard address with loopback or local host in tests - part 20
Update some tests to stop using the wildcard address.

Reviewed-by: michaelm
2019-07-10 22:33:23 +02:00
Patrick Concannon
76785af549 8226756: Replace wildcard address with loopback or local host in tests - part 18
Reviewed-by: dfuchs
2019-07-10 16:09:20 +01:00
Claes Redestad
7f1f9a50ae 8225239: Refactor NetworkInterface lookups
Reviewed-by: michaelm, dfuchs, chegar
2019-07-05 13:40:29 +02:00
Pavel Rappo
3395bb591b 8226602: Test convenience reactive primitives from java.net.http with RS TCK
Reviewed-by: chegar, dfuchs
2019-07-02 13:25:51 +01:00
Daniel Fuchs
2ad9f11d77 8226514: Replace wildcard address with loopback or local host in tests - part 14
Improve test stabilty by getting rid of the wildcard address whenever possible.

Reviewed-by: chegar, vtewari
2019-06-28 15:58:10 +01:00
Michael McMahon
faea44aec3 8222968: ByteArrayPublisher is not thread-safe resulting in broken re-use of HttpRequests
Reviewed-by: chegar, dfuchs
2019-06-28 11:26:07 +01:00
Julia Boes
c45f932cc5 8226825: Replace wildcard address with loopback or local host in tests - part 19
Replace use of wildcard by the loopback address, or possibly the local host address, wherever possible, to improve test stability.

Reviewed-by: chegar, bpb
2019-06-27 16:12:39 +01:00
Michael McMahon
54dfd47fa8 8226683: Remove review suggestion from fix to 8219804
Reviewed-by: chegar
2019-06-24 15:19:11 +01:00
Michael McMahon
eccfec498d 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException
Reviewed-by: chegar, dfuchs
2019-06-24 15:10:44 +01:00
Pavel Rappo
b870874d22 Merge 2019-06-19 12:17:22 +01:00
Pavel Rappo
d49e648148 8226303: Examine the HttpRequest.BodyPublishers for exception handling
Reviewed-by: chegar
2019-06-18 14:12:06 +01:00
Chris Hegarty
d577d9c678 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java
Reviewed-by: dfuchs, prappo
2019-06-18 18:38:53 +01:00
Daniel Fuchs
5b21004fe0 8225578: Replace wildcard address with loopback or local host in tests - part 16
Fixes java/net/Authenticator and java/net/CookieHandler to stop depending on the wildcard address, wherever possible.

Reviewed-by: chegar
2019-06-17 20:03:34 +01:00
Jaikiran Pai
a92f0016f3 8217705: HttpClient - wrong exception type when bad status line is received
Throw a ProtocolException if the status code in the HTTP response's status line isn't a 3-digit integer

Reviewed-by: dfuchs
2019-06-14 10:19:04 +05:30
Michael McMahon
247a6a2ce4 8216417: cleanup of IPv6 scope-id handling
Reviewed-by: alanb, chegar, dfuchs
2019-06-13 09:10:51 +01:00
Daniel Fuchs
96bb069a2d 8224865: Replace wildcard address with loopback or local host in tests - part 13
Fixes intermittent failures observed in some network tests

Reviewed-by: chegar
2019-06-10 11:17:57 +01:00
Chris Hegarty
2edcc74725 8225424: Add jdk.net.usePlainSocketImpl runs to a couple of tests
Reviewed-by: alanb
2019-06-07 11:47:49 +01:00
Chris Hegarty
cc353da44d 8225037: java.net.JarURLConnection::getJarEntry() throws NullPointerException
Reviewed-by: coffeys, vtewari
2019-06-05 13:59:44 +01:00
Chris Hegarty
9fbdec42c4 8225214: Socket.getOption(SocketOption) not returning the expected type for the StandardSocketOptions.SO_LINGER
Reviewed-by: alanb
2019-06-05 12:02:01 +01:00
Arno Zeller
bb2e4df367 8194231: java/net/DatagramSocket/ReuseAddressTest.java failed with java.net.BindException: Address already in use: Cannot bind
Changed test to no longer use hardcoded ports.

Reviewed-by: chegar, clanger
2019-05-28 20:12:16 +02:00
Chris Hegarty
53b022d9eb 8224973: URLStreamHandler.openConnection(URL,Proxy) - spec and implementation mismatch
Reviewed-by: alanb, dfuchs
2019-05-31 15:02:45 +01:00
Chris Hegarty
3ab3ffd29f 8224730: java.net.ServerSocket::toString not invoking checkConnect
Reviewed-by: alanb
2019-05-30 12:36:04 +01:00
Alan Bateman
7e14aeb133 8221481: Reimplement the Legacy Socket API
Reviewed-by: michaelm, chegar
2019-05-30 07:19:19 +01:00
Arthur Eubanks
acad8d1d68 8224081: SOCKS v4 doesn't work with IPv6
Reviewed-by: chegar, dfuchs, mullan, vtewari
2019-05-16 15:58:15 -07:00
Chris Hegarty
bc24d17e80 8224477: java.net socket types new-style socket option methods - spec and impl mismatch
Reviewed-by: alanb
2019-05-29 13:58:05 +01:00
Daniel Fuchs
5461726dcc 8224761: Replace wildcard address with loopback or local host in tests - part 12
Fixes a batch of intermittent failures.

Reviewed-by: chegar, vtewari
2019-05-27 19:24:42 +01:00
Aleksei Efimov
57d319210a 8224035: Replace wildcard address with loopback or local host in tests - part 9
Reviewed-by: dfuchs
2019-05-27 13:29:11 +01:00
Daniel Fuchs
ee040e4be2 8224603: Replace wildcard address with loopback or local host in tests - part 11
Fixes a batch of tests that were observed failing intermittently.

Reviewed-by: chegar, vtewari
2019-05-24 15:34:14 +01:00
Arthur Eubanks
f65e76fef0 8224248: test/jdk/java/net/InetAddress/CheckJNI.java assumes 127.0.0.1 is available
Reviewed-by: dfuchs, chegar
2019-05-20 14:19:19 -07:00
Arthur Eubanks
905330d4ea 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment
Reviewed-by: chegar, dfuchs
2019-05-15 16:21:51 -07:00
Daniel Fuchs
cd9e3c1b13 8223856: Replace wildcard address with loopback or local host in tests - part 8
Fixes some intermittent test failures by replacing wildcard with loopback - or retrying once.

Reviewed-by: aefimov, chegar
2019-05-20 12:37:40 +01:00
Arthur Eubanks
244bdce994 8224018: test/jdk/java/net/ipv6tests/{Tcp,Udp}Test.java assume IPv4 is available
Reviewed-by: dfuchs, chegar
2019-05-15 17:13:57 -07:00
Aleksei Efimov
c9cdfad6ff 8223798: Replace wildcard address with loopback or local host in tests - part 7
Reviewed-by: dfuchs, vtewari
2019-05-15 19:47:28 +01:00
Arthur Eubanks
23301277c5 8223737: Fix HostsFileNameService for IPv6 literal addresses
Reviewed-by: chegar, msheppar
2019-05-10 17:13:02 -07:00
Aleksei Efimov
64b8734964 8223638: Replace wildcard address with loopback or local host in tests - part 6
Reviewed-by: dfuchs
2019-05-14 13:34:49 +01:00
Daniel Fuchs
3103d346a7 8223632: Replace wildcard address with loopback or local host in tests - part 5
Replaces wildcard usage by loopback, when possible, adds intermittent keyword and a comment, when not.

Reviewed-by: chegar
2019-05-13 17:31:23 +01:00
Arthur Eubanks
eff53ce5e9 8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid() to IPSupport.throwSkippedExceptionIfNonOperational()
Reviewed-by: dfuchs, chegar
2019-05-09 10:28:29 -07:00
Aleksei Efimov
6ecf7ffbb1 8223465: Replace wildcard address with loopback or local host in tests - part 3
Reviewed-by: dfuchs
2019-05-10 15:34:17 +01:00
Daniel Fuchs
205fd87f2d 8223573: Replace wildcard address with loopback or local host in tests - part 4
Makes a few intermittently failing tests more resilient to port reuse issues by ensuring they bind to the loopback address instead of the wildcard.

Reviewed-by: alanb, chegar
2019-05-09 14:23:52 +01:00
Arthur Eubanks
0bb6328356 8220673: Add test library support for determining platform IP support
Reviewed-by: dfuchs, chegar
2019-04-16 13:06:23 -07:00
Daniel Fuchs
1188188ee6 8223463: Replace wildcard address with loopback or local host in tests - part 2
Removes (or documents) some usages of the wildcard address in intermittently failing tests.

Reviewed-by: alanb
2019-05-07 18:10:59 +01:00
Michael McMahon
7e142d54bf 8223457: java.net.ServerSocket protected constructor should throw NPE if impl null
Reviewed-by: dfuchs
2019-05-07 15:39:33 +01:00
Sean Coffey
a712b37bd0 8217364: Custom URLStreamHandler for jrt or file protocol can override default handler
Reviewed-by: redestad
2019-05-02 22:52:51 +01:00
Michael McMahon
70ea5ab6e1 8216978: Drop support for pre JDK 1.4 SocketImpl implementations
Reviewed-by: chegar, alanb, dfuchs
2019-05-02 17:29:10 +01:00
Daniel Fuchs
7d4520c109 8223145: Replace wildcard address with loopback or local host in tests - part 1
Replaces binding to wildacard with alternative less susceptible to intermittent failure in some intermittently failing tests.

Reviewed-by: chegar, msheppar
2019-05-02 11:55:16 +01:00
Daniel Fuchs
72467d916c 8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently
Tests are updated to use the loopback address instead of the wildcard to avoid traffic being routed to a different server than what was intended by the test.

Reviewed-by: chegar
2019-04-26 16:25:43 +01:00
Daniel Fuchs
853da81cfe 8222527: HttpClient doesn't send HOST header when tunelling HTTP/1.1 through http proxy
HttpClient no longer filters out system host header when sending tunelling CONNECT request to proxy

Reviewed-by: michaelm
2019-04-18 17:56:46 +01:00
Daniel Fuchs
47b9d898ab 8221395: HttpClient leaving connections in CLOSE_WAIT state until Java process ends
When a non WebSocket connection is not returned to the pool, it needs to be closed even if HttpConnection::isOpen yields false.

Reviewed-by: chegar, michaelm
2019-03-28 12:16:36 +00:00
Arthur Eubanks
0c2b7c4fc3 8220575: Replace hardcoded 127.0.0.1 in URLs with new URI builder
Reviewed-by: dfuchs, chegar
2019-03-27 09:06:43 -07:00
Chris Hegarty
1933437f12 8219446: Specify behaviour of timeout accepting methods of Socket and ServerSocket if timeout is negative
Reviewed-by: alanb, dfuchs
2019-03-26 17:02:11 +00:00
Alan Bateman
fd14375ae2 8221259: New tests for java.net.Socket to exercise long standing behavior
Reviewed-by: chegar
2019-03-21 17:38:41 +00:00
Chris Hegarty
defc86bd5b 8221098: Run java/net/URL/HandlerLoop.java in othervm mode
Reviewed-by: alanb, martin
2019-03-20 09:17:48 +00:00
Chris Hegarty
5ee0711360 8220663: Incorrect handling of IPv6 addresses in Socket(Proxy.HTTP)
Reviewed-by: alanb, michaelm
2019-03-19 14:27:50 +00:00
Alan Bateman
8743be63c4 8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl
Co-authored-by: Michael McMahon <michael.x.mcmahon@oracle.com>
Reviewed-by: chegar
2019-03-16 19:44:12 +00:00
Arthur Eubanks
ef9ce3be1e 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests
Tests that hardcode "127.0.0.1" fail in an environment where only IPv6 is available and IPv4 is not.

Reviewed-by: chegar, dfuchs, michaelm
2019-02-27 13:34:40 -08:00
Chris Hegarty
ac5daa7a22 Merge 2019-02-08 13:07:44 +00:00
Chris Hegarty
bba5ddd08f Merge 2019-02-08 12:44:16 +00:00
Chris Hegarty
fb05ae21bb 8218662: Allow 204 responses with Content-Length:0
Reviewed-by: michaelm
2019-02-08 12:23:16 +00:00
Chris Hegarty
10a281c485 8218546: Unable to connect to https://google.com using java.net.HttpClient
Reviewed-by: dfuchs
2019-02-08 11:26:21 +00:00
Christoph Langer
f828beb2d0 8217657: Move the test for default value of jdk.includeInExceptions into own test
Reviewed-by: mullan, goetz
2019-01-25 10:59:07 +00:00
Daniel Fuchs
6e04e7659a 8216562: UnknownBodyLength sometimes fails due to "Connection reset by peer"
Uses a longer linger time and avoids closing socket too early.

Reviewed-by: chegar
2019-01-30 18:21:06 +00:00
Chris Hegarty
02924f478b 8217976: test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java fails intermittently
Reviewed-by: dfuchs
2019-01-29 16:12:12 +00:00
Daniel Fuchs
6dcfd0f93a 8217882: java/net/httpclient/MaxStreams.java failed once
Added some more traces to help diagnosis

Reviewed-by: bpb
2019-01-28 18:49:34 +00:00
Daniel Fuchs
6b64f80be4 8217903: java/net/httpclient/Response204.java fails with 404
Fixed test to use loopback address - this looks like a port reuse issue.

Reviewed-by: chegar
2019-01-28 18:45:34 +00:00
Daniel Fuchs
8faf2074b1 8210130: java/net/httpclient/UnknownBodyLengthTest.java failed
The fix improves the test robustness by making it retry once in case of IO/Connect exception.

Reviewed-by: chegar
2019-01-28 15:24:41 +00:00
Chris Hegarty
46f4ab603b 8217429: WebSocket over authenticating proxy fails to send Upgrade headers
Reviewed-by: dfuchs, prappo
2019-01-28 13:51:16 +00:00
Daniel Fuchs
7f10cbedd5 8217627: HttpClient: The API documentation of BodySubscribers::mapping promotes bad behavior
The API documentation is updated to steer away from blocking in the mapper function, and an alternative is suggested.

Reviewed-by: chegar
2019-01-25 18:13:25 +00:00
Jesper Wilhelmsson
fd21613d59 Merge 2019-01-25 18:12:06 +01:00
Roger Riggs
083500194a 8217740: SocksIPv6Test compilation error
Reviewed-by: bpb
2019-01-24 14:39:16 -05:00
Michael McMahon
0fc677a674 8216986: Remove unused code from SocksSocketImpl
Reviewed-by: alanb
2019-01-24 15:48:05 +00:00
Daniel Fuchs
a8ae1c1332 8217264: HttpClient: Blocking operations in mapper function do not work as documented
Ensures that a new task is spawned when calling getBody() on a mapping BodySubscriber.

Reviewed-by: chegar
2019-01-24 12:32:42 +00:00
Jesper Wilhelmsson
bc920bd00d Merge 2019-01-22 19:56:19 +01:00
Christoph Langer
bc651663e3 8207404: MulticastSocket tests failing on AIX
Reviewed-by: chegar, sgroeger
2019-01-21 06:55:59 +00:00
Michael McMahon
d089a4ae51 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers
Reviewed-by: chegar, dfuchs
2019-01-17 15:24:20 +00:00
Daniel Fuchs
3b68bb2960 8217094: HttpClient SSL race if a socket IOException is raised before ALPN is available
The patch makes suer that the SSLFlowDelegate's ALPN CF is always completed

Reviewed-by: chegar
2019-01-16 19:09:16 +00:00
Daniel Fuchs
ca77adf19f 8216974: HttpConnection not returned to the pool after 204 response
MultiExchange now call nullBody() on Exchange after receiving 204

Reviewed-by: chegar
2019-01-15 11:34:20 +00:00
Pavel Rappo
884c808e83 8215292: Back out changes for node- and link- local ipv6 multicast address
Reviewed-by: chegar, alanb
2018-12-14 19:49:03 +00:00
Daniel Fuchs
6627b03332 8216498: Confusing and unneeded wrapping of SSLHandshakeException
[httpclient] Avoid wrapping SSLHandshakeException in plain IOException

Reviewed-by: chegar
2019-01-11 14:48:19 +00:00
Jesper Wilhelmsson
f4f859b446 Merge 2018-12-19 20:53:30 +01:00
Alan Bateman
888057a89f 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny
Reviewed-by: redestad, mchung, jjg
2018-12-18 10:26:15 +00:00