Commit Graph

303 Commits

Author SHA1 Message Date
Jan Lahoda
4969d23b89 8221413: javac does not recognize variable assigned in switch expression as DA
Fixing definite assignment in presence of implicit throws clause in switch expressions over enums.

Reviewed-by: vromero
2019-03-28 10:32:05 +01:00
Liam Miller-Cushon
31f64932c3 8220687: Add StandardJavaFileManager.getJavaFileObjectsFromPaths overload
Reviewed-by: jjg
2019-03-26 15:00:02 -07:00
Christoph Langer
1a48fa0fb7 8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old!
Reviewed-by: stuefe, jjg
2019-03-22 08:56:30 +01:00
Jonathan Gibbons
d3242724c9 8220379: Fix doclint handling of headings
Reviewed-by: erikj, jlahoda
2019-03-14 11:39:00 -07:00
Liam Miller-Cushon
0720686823 8193277: SimpleFileObject inconsistency between getName and getShortName
Reviewed-by: jjg
2019-03-05 12:01:04 -08:00
Liam Miller-Cushon
ab3f5e3e15 8220634: SymLinkArchiveTest should handle not being able to create symlinks
Reviewed-by: jjg
2019-03-13 17:26:21 -07:00
Jan Lahoda
76c916516c 8217868: Crash for overlap between source path and patch module path
When analyzing implicit files, do not look for containing module, but rather use the already known one.

Reviewed-by: jjg
2019-03-04 10:19:35 +01:00
Christoph Langer
8bec32b02f 8219915: [TESTBUG] Fix test langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java in Standalone mode
Reviewed-by: jlahoda
2019-03-01 10:15:04 +00:00
Joe Darcy
bf2d27c5a4 8219254: Update explicit uses of latest source/target in langtools tests to a property
8219256: Update javac diags tests to use properties

Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Reviewed-by: jjg, jlahoda, darcy, iignatyev
2019-02-21 10:29:16 -08:00
Harold Seigel
dd7e50dc01 8214719: Deprecate -Xverify:none option
Deprecate -Xverify:none and -noverify and remove them from tests

Reviewed-by: dholmes, mikael
2019-02-20 13:21:36 -05:00
Jan Lahoda
68d32a9a8a 8217381: Incovenient errors reported when annotation processor generates source file and errors in the same round
When an annotation processor reports and error, defer reporting recoverable errors from the erroneous round to the last round, to avoid reporting errors that were resolved in the erroneous round.

Reviewed-by: jjg
2019-02-15 12:09:53 +01:00
Srinivas Dama
37169f4bbc 8201544: Improve javac command line parsing and error reporting
Modified exception into an error message for invalid filenames on windows

Reviewed-by: vromero, jjg
2019-02-14 21:52:39 +05:30
Bernard Blaser
777ad9080e 8193367: Annotated type variable bounds crash javac
Reviewed-by: mcimadamore, vromero
2019-01-26 15:50:59 +01:00
Jonathan Gibbons
6326bf224e 8217395: Update langtools shell tests to use ${EXE_SUFFIX}
Reviewed-by: darcy
2019-01-18 12:41:11 -08:00
Bernard Blaser
454cbfacaa 8214345: infinite recursion while checking super class
Reviewed-by: vromero
2019-01-18 13:49:45 -05:00
Vicente Romero
ae0cb515d6 8215482: check for cycles in type variables can provoke NPE
Reviewed-by: mcimadamore
2019-01-14 12:24:25 -05:00
Joe Darcy
5ad47c58a3 8208371: Provided supported mechanims to create a ModuleElement for an unnamed module
Reviewed-by: jjg
2019-01-11 09:57:15 -08:00
Joe Darcy
f68fd6a1c2 8216404: Elements.getPackageOf should handle modules
Reviewed-by: jlahoda
2019-01-10 10:34:30 -08:00
Jesper Wilhelmsson
67a5fc2529 Merge 2019-01-09 22:59:49 +01:00
Jim Laskey
11b29c8de1 8215681: Remove compiler support for Raw String Literals from JDK 12
Reviewed-by: mcimadamore, jlahoda, sundar
2019-01-09 11:13:00 -04:00
Srinivas Dama
ead8577920 8208184: IllegalArgumentException while invoking code completion on netbeans IDE
Set Log.useSource and fix the issue in Modules.java when broken module is encountered

Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2018-12-24 12:18:40 +05:30
Vicente Romero
f398c3dcd2 8215625: javax/sql/testng/util/xxxxx.java tests compilation failed after JDK-8207224
Reviewed-by: mcimadamore
2018-12-19 14:02:19 -05:00
Vicente Romero
8b6b63b38b 8207224: Javac compiles source code despite illegal use of unchecked conversions
Reviewed-by: mcimadamore, darcy
2018-12-18 16:22:46 -05:00
Alan Bateman
888057a89f 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny
Reviewed-by: redestad, mchung, jjg
2018-12-18 10:26:15 +00:00
Joe Darcy
b5f0eec3d8 8205626: Start of release updates for JDK 13
8205393: Add SourceVersion.RELEASE_13
8205394: Add source 13 and target 13 to javac
8205645: Bump maximum recognized class file version to 57 for JDK 13
8214825: Update preview language features for start of JDK 13

Reviewed-by: erikj, alanb, mchung, mcimadamore, dholmes, smarks, jjg
2018-12-13 19:06:11 +01:00
Srinivas Dama
2f34c5ac6a 8208184: IllegalArgumentException while invoking code completion on netbeans IDE
Set Log.useSource and fix the issue in Modules.java when broken module is encountered

Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2019-01-03 11:21:11 +05:30
Jan Lahoda
655c5d7f35 8214114: Switch expressions with try-catch statements
When switch expression contains try-catch, move the stack values into locals before the executing the switch expression, and back when it is done.

Reviewed-by: mcimadamore, vromero
2018-12-11 09:10:24 +01:00
Harold Seigel
5a23b59ca0 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
Remove the option from the tests

Reviewed-by: lfoltan, coleenp
2018-12-10 13:24:17 -05:00
Vicente Romero
9846588b31 8210031: implementation for JVM Constants API
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: jrose, mcimadamore, darcy, mchung, rriggs, dholmes, forax
2018-12-09 12:36:24 -05:00
Liam Miller-Cushon
7f365fffbd 8214902: Pretty-printing marker annotations add unnecessary parenthesis
Reviewed-by: jjg
2018-12-05 11:31:20 -08:00
Vicente Romero
a4d8574130 8213703: LambdaConversionException: Invalid receiver type not a subtype of implementation type interface
Reviewed-by: mcimadamore
2018-12-05 09:34:01 -05:00
Jan Lahoda
504dfa5de0 8214529: Exception while using Anonymous class in switch expression
Clearing breakResult when creating methodEnv.

Reviewed-by: mcimadamore
2018-12-03 14:25:00 +01:00
Jan Lahoda
835c863ba8 8214031: Assertion error in value break statement with conditional operator in switch expression
Correcting handling of boolean-valued switch expressions when true/false; generating them directly rather than desugaring in Lower.

Reviewed-by: mcimadamore
2018-12-03 10:37:36 +01:00
Srikanth Adayapalam
10d83827bc 8206325: AssertionError in TypeSymbol.getAnnotationTypeMetadata
Reviewed-by: mcimadamore
2018-11-30 10:37:48 +05:30
Liam Miller-Cushon
bddbbd85f9 8214026: Canonicalized archive paths appearing in diagnostics
Reviewed-by: vromero
2018-11-19 15:01:59 -08:00
Vicente Romero
10da56f017 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body
Reviewed-by: mcimadamore
2018-11-27 11:07:44 -05:00
Jan Lahoda
06b1502892 8214113: Switch expressions may have constant type and may be skipped during write
Switch expressions should not be compile-time constants.

Reviewed-by: mcimadamore
2018-11-26 09:24:08 +01:00
Jan Lahoda
60b32f222f 8212982: Rule cases in switch expression accepted even if complete normally
Ensure an error is reported if switch expression does not correctly produce a value.

Reviewed-by: mcimadamore
2018-11-21 15:22:57 +01:00
Liam Miller-Cushon
4a235517f9 8213908: AssertionError in DeferredAttr at setOverloadKind
Reviewed-by: mcimadamore
2018-11-19 09:57:41 -08:00
Srinivas Dama
e4f60a8489 8210742: compound var declaration type is not uniform for all variables
Make implicit type for all variables in compound declaration as null for which type inference happens at later phase

Reviewed-by: mcimadamore
2018-11-20 21:59:07 +05:30
Liam Miller-Cushon
4cdf0c4c1d 8214071: Broken msg.bug diagnostics when using the compiler API
Reviewed-by: jjg
2018-11-19 10:47:38 -08:00
Jan Lahoda
c963d543d2 8209055: c.s.t.javac.code.DeferredCompletionFailureHandler seems to use WeakHashMap incorrectly
Do not keep speculative Symbols in DeferredCompletionFailureHandler.

Reviewed-by: jjg, vromero
2018-11-12 09:35:23 +00:00
Priya Lakshmi Muthuswamy
50dc5ef396 5076751: System properties documentation needed in javadocs
Reviewed-by: jjg
2018-11-12 13:31:41 +05:30
Vicente Romero
0ec4944be7 8211450: UndetVar::dup is not copying the kind field to the duplicated instance
Reviewed-by: mcimadamore
2018-11-08 18:23:52 -05:00
Vicente Romero
7d4e8d0e26 8210197: javac can't tell during speculative attribution if a diamond expression is creating an anonymous inner class or not
Reviewed-by: mcimadamore
2018-11-08 10:36:06 -05:00
Jan Lahoda
fdb010502b 8213103: RoundEnvironment.getElementsAnnotatedWith(Class) crashes with -source 8
Correct handling of missing annotation with -source 8.

Reviewed-by: darcy, jjg, vromero
2018-11-05 10:31:47 +01:00
Jonathan Gibbons
72bfdd96f1 8213265: fix missing newlines at end of files
Reviewed-by: darcy
2018-11-01 15:11:08 -07:00
Jonathan Gibbons
73fa99ae86 8213263: fix legal headers in test/langtools
Reviewed-by: darcy
2018-11-01 14:32:55 -07:00
Vicente Romero
d0696b538a 8213100: fix test OptionSmokeTest before removing it from the problem list
Reviewed-by: jlahoda
2018-10-29 17:09:44 -04:00
Liam Miller-Cushon
d9095c4a72 8198945: Invalid RuntimeVisibleTypeAnnotations for annotation on anonymous class type parameter
Reviewed-by: wmdietl, abuckley, martin
2018-09-17 11:09:43 -07:00
Joe Darcy
34397c4914 8212718: Refactor some annotation processor tests to better use collections
Reviewed-by: jlaskey, vromero
2018-10-23 10:32:39 -07:00
Vicente Romero
1ed6b88a99 8209407: VerifyError is thrown for inner class with lambda
Reviewed-by: mcimadamore
2018-10-08 06:52:41 -07:00
Vicente Romero
609d90e98a 8210789: langtools/tools/javac/T8152616.java missing @modules
Reviewed-by: jjg
2018-10-04 10:19:01 -07:00
Vicente Romero
2589e9733e 8211148: var in implicit lambdas shouldn't be accepted for source < 11
Reviewed-by: mcimadamore
2018-10-04 08:37:08 -07:00
Jim Laskey
c30dffb388 8211080: RawStringLiteralLangAPI.java test times out by default
Reviewed-by: jjg
2018-09-27 15:47:33 -03:00
Jan Lahoda
17c3d1c333 8211102: Crash with -XDfind=lambda and -source 7
Disabling analyzers that cannot run in the given source level; lambdas in standalone positions should have erroneous type rather than the recovery type; avoiding crash in Flow for broken code.

Reviewed-by: mcimadamore
2018-09-27 10:24:12 +02:00
Jonathan Gibbons
db6295f8a2 8209963: source file mode for JVM should provide a hook to locate the source file
Reviewed-by: darcy
2018-09-26 16:23:31 -07:00
Jonathan Gibbons
065fdac559 8210555: create --source --target synonyms for -source -target
Reviewed-by: hannesw
2018-09-26 15:14:17 -07:00
Jonathan Gibbons
25ca76b4f9 8211180: SourceLauncherTest.java fails in JDK12 CI on Win*
Reviewed-by: mchung, darcy
2018-09-26 14:54:38 -07:00
Jonathan Gibbons
cad60d14a6 8210274: Source Launcher should work with a security manager
Reviewed-by: mchung, alanb
2018-09-26 11:41:08 -07:00
Liam Miller-Cushon
9c60728a28 8211138: Missing Flag enum constants
Reviewed-by: mcimadamore, vromero
2018-09-25 21:33:51 -07:00
Jonathan Gibbons
59fd35292e 8210839: Improve interaction between source launcher and classpath
Reviewed-by: alanb, mchung
2018-09-25 10:30:32 -07:00
Jonathan Gibbons
8edf8e2b03 8210275: Source Launcher should fail if --source is used without a source file
Reviewed-by: mchung, alanb, mcimadamore
2018-09-21 15:38:43 -07:00
Jan Lahoda
3f43390b8b 8209058: Cannot find annotation method 'value()' in type 'Profile+Annotation'
Correct detection of the Profile+Annotation synthetic annotation for classes that are not from the java.base module.

Reviewed-by: jjg
2018-09-21 12:29:46 +02:00
Jan Lahoda
c1033edca8 8209865: Incorrect 'multiple elements' notes with Elements#getTypeElement and --release
Changing ct.sym to be module-path oriented, rather than class-path oriented.

Reviewed-by: jjg
2018-09-21 12:29:31 +02:00
Vicente Romero
29fec64583 8209022: Missing checkcast when casting to type parameter bounded by intersection type
Reviewed-by: mcimadamore
2018-09-20 12:49:58 -07:00
Jan Lahoda
52ba129b0a 8207954: Data for --release 11
Adding support for --release 11

Reviewed-by: erikj, ihse, jjg
2018-09-19 10:50:25 +02:00
Jan Lahoda
ee0ac147a2 8193561: Cyclic hierarchy causes a NullPointerException when setting DEFAULT flag
When marking interface as having default methods, use .owner as it is always defined.

Reviewed-by: mcimadamore
2018-09-17 11:49:20 +02:00
Bernard Blaser
8ef50b1dc3 8183548: Comma-expressions shouldn't use any temporary variable
Uses enhanced let-expressions allowing multiple statements

Reviewed-by: vromero
2018-09-15 22:16:16 +02:00
Liam Miller-Cushon
8b3c1810d2 8193037: package-info annotations are not reported when annotation processing is enabled
Reviewed-by: jjg
2018-09-13 15:29:44 -07:00
Jim Laskey
734a258afb 8210674: Need to add examples for use of javac properties introduced by Raw String Literals
Reviewed-by: vromero, jjg
2018-09-13 14:15:27 -03:00
Liam Miller-Cushon
7afa8e42b6 8210483: AssertionError in DeferredAttr at setOverloadKind caused by JDK-8203679
Reviewed-by: mcimadamore, vromero
2018-09-10 16:59:41 -07:00
Vicente Romero
cf26c4cc5c 8207160: ClassReader::adjustMethodParams can potentially return null if the args list is empty
Reviewed-by: mcimadamore, cushon
2018-09-12 16:28:06 -07:00
Jim Laskey
d2b04cb964 8210671: CheckExamples.java fail after Raw String Literals checkin
Reviewed-by: vromero, darcy
2018-09-12 17:14:08 -03:00
Jim Laskey
2065ebd890 8206981: Compiler support for Raw String Literals
Reviewed-by: mcimadamore, briangoetz, abuckley, jjg, vromero, jlahoda
2018-09-12 14:19:36 -03:00
Maurizio Cimadamore
c0d51dc514 8210495: compiler crashes because of illegal signature in otherwise legal code
Disable strict verification of compiler signatures when they do not affect generated bytecode

Reviewed-by: vromero
2018-09-07 15:56:21 +01:00
Jonathan Gibbons
84cf73f2a5 8210009: Source Launcher classloader should support getResource and getResourceAsStream
Reviewed-by: mchung, plevart
2018-09-06 16:15:32 -07:00
Vicente Romero
d0f7d4e374 8210435: don't add local variable spots if they are DCE'ed by the compiler
Reviewed-by: mcimadamore
2018-09-06 05:44:47 -07:00
Jonathan Gibbons
c8d641d148 8208608: Update --module-source-path to allow explicit source paths for specific modules
Reviewed-by: jlahoda
2018-08-31 14:54:42 -07:00
Jan Lahoda
b3b644438e 8206986: Compiler support for Switch Expressions (Preview)
8207405: Compiler Tree API support for Switch Expressions (Preview)

Support for switch expression, switch with rules and multiple constants for cases.

Reviewed-by: jjg, mcimadamore, vromero
2018-08-29 09:36:17 +02:00
Vicente Romero
b2ebbe6460 8209173: javac fails with completion exception while reporting an error
Reviewed-by: mcimadamore
2018-08-24 13:30:56 -07:00
Vicente Romero
efa05e1c62 8207320: Wrong type order for intersection lambdas with multiple abstract methods
Reviewed-by: mcimadamore
2018-08-15 13:39:32 -07:00
Joe Darcy
ac5685e827 8190886: package-info handling in RoundEnvironment.getElementsAnnotatedWith
Reviewed-by: vromero, jlahoda
2018-07-25 12:32:59 -07:00
Vicente Romero
8e61321b6c 8205493: OptionSmokeTest.java uses hard-coded release values
Reviewed-by: darcy
2018-07-20 14:48:41 -07:00
Joe Darcy
fafd1b7536 8193462: Fix Filer handling of package-info initial elements
Reviewed-by: vromero
2018-07-18 00:23:06 -07:00
Joe Darcy
19c364592c 8193214: Incorrect annotations.without.processors warnings with JDK 9
Reviewed-by: vromero
2018-07-18 00:16:37 -07:00
Vicente Romero
898e0f8607 8206874: Evaluate LoadClassFromJava6CreatedJarTest.java after dropping -source 6
Reviewed-by: darcy
2018-07-19 15:13:10 -07:00
Phil Race
28e828130d Merge 2018-07-19 10:17:22 -07:00
Jan Lahoda
66025558bb 8207229: Trees.getScope crashes for broken lambda
8207230: Trees.getScope runs Analyzers

Reviewed-by: vromero
2018-07-17 14:28:56 +02:00
Joe Darcy
a376d5dab4 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests
Reviewed-by: vromero
2018-07-16 21:53:49 -07:00
Jan Lahoda
fe80e55647 8189747: JDK9 javax.lang.model.util.Elements#getTypeElement regressed 1000x in performance
Caching the results of Elements.getTypeElement/getPackageElement

Reviewed-by: darcy
2018-07-16 12:35:25 +02:00
Joe Darcy
90518f0635 8028563: Remove javac support for 6/1.6 source and target values
Reviewed-by: jjg, erikj, henryjen
2018-07-12 14:13:15 -07:00
Joe Darcy
e18f343141 8207055: Make javac -help output for -source and -target more informative
Reviewed-by: jjg
2018-07-11 16:12:18 -07:00
Jesper Wilhelmsson
dafb3af62d Merge 2018-07-11 21:41:43 +02:00
Joe Darcy
03597d010c 8206439: Remove javac -source/-target 6 from langtools regression tests
Reviewed-by: mcimadamore
2018-07-06 10:28:56 -07:00
Joe Darcy
da22bf8a17 8206114: Refactor langtools/tools/javac/classfiles/ClassVersionChecker.java
Reviewed-by: jjg
2018-07-03 16:14:46 -07:00
Joe Darcy
28e2dea71d 8206085: Refactor langtools/tools/javac/versions/Versions.java
Reviewed-by: jjg, forax, plevart, mcimadamore
2018-07-03 15:59:09 -07:00
Liam Miller-Cushon
1fc1f68c3d 8204630: Generating an anonymous class with Filer#createClassFile causes an NPE in JavacProcessingEnvironment
Reviewed-by: jlahoda
2018-07-06 12:10:43 -07:00
Jan Lahoda
eaf0364068 8205418: Assorted improvements to source code model
Improving tree positions, better error recovery, fixing Trees.getScope for possibly erroneous lambdas.

Reviewed-by: jjg, mcimadamore, vromero
2018-06-29 10:41:10 +02:00
Joe Darcy
69191fc4cc 8206083: Make tools/javac/api/T6265137.java robust to JDK version changes
Reviewed-by: jjg
2018-06-28 17:49:13 -07:00