Commit Graph

1695 Commits

Author SHA1 Message Date
Lana Steuck
2288704f7f Merge 2013-04-01 21:42:15 -07:00
Jonathan Gibbons
18f48ab46b 8010511: Tests are creating files in /tmp
Reviewed-by: darcy
2013-03-28 10:58:45 -07:00
David Katleman
e4d9e1a5e7 Added tag jdk8-b83 for changeset fd242a461861 2013-03-28 10:55:14 -07:00
Jonathan Gibbons
84a50dc114 8006346: doclint should make allowance for headers generated by standard doclet
Reviewed-by: mcimadamore
2013-03-28 10:49:39 -07:00
Maurizio Cimadamore
059c4839bc 8010490: FindBugs: double assignments in LambdaToMethod.visitIdent
Remove dead code from LambdaToMethod

Reviewed-by: jjg
2013-03-28 11:39:04 +00:00
Maurizio Cimadamore
b67623d272 8010469: Bad assertion in LambdaToMethod
Add assertion in LambdaToMethod.serializedLambdaName

Reviewed-by: jjg
2013-03-28 11:38:38 +00:00
Joe Darcy
4d16263250 7059170: Assume availablility of URLClassLoader.close
Reviewed-by: jjg
2013-03-26 18:15:24 -07:00
Joe Darcy
af36b14fdb 7041251: Use j.u.Objects utility methods in langtools
Reviewed-by: jjg
2013-03-26 17:17:14 -07:00
Lana Steuck
86f5cb2773 Merge 2013-03-26 12:07:45 -07:00
Michael Fang
1a25595a25 Merge 2013-03-25 18:08:47 -07:00
Michael Fang
fa35aeb6eb 8010521: jdk8 l10n resource file translation update 2
Reviewed-by: naoto, yhuang
2013-03-25 16:55:14 -07:00
Joe Darcy
d54accaf5c 7080464: langtools regression test failures when assertions are enabled
Reviewed-by: jjg
2013-03-22 10:08:46 -07:00
Maurizio Cimadamore
7ee4846b45 8010387: Javac crashes when diagnostic mentions anonymous inner class' type variables
Rich formatter doesn't preprocess supertypes of an anonymous inner class

Reviewed-by: jjg
2013-03-22 12:44:48 +00:00
Maurizio Cimadamore
2b66afe14d 8010303: Graph inference: missing incorporation step causes spurious inference error
Multiple equality constraints on inference vars are not used to generate new inference constraints

Reviewed-by: jjg
2013-03-22 12:43:09 +00:00
Maurizio Cimadamore
710a687c15 8009820: AssertionError when compiling java code with two identical static imports
Speculative attribution is carried out twice with same method symbol in case of static imports

Reviewed-by: jjg
2013-03-22 12:41:13 +00:00
Maurizio Cimadamore
cec722fe8f 8010101: Intersection type cast issues redundant unchecked warning
Code for checking intersection type cast is incorrectly swapping operands, leading to spurious warnings

Reviewed-by: jjg
2013-03-22 12:39:34 +00:00
Maurizio Cimadamore
2454c8c5ae 8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods
Private lambda methods should be accessed through invokespecial

Reviewed-by: jjg
2013-03-22 12:38:12 +00:00
David Katleman
58859413d3 Added tag jdk8-b82 for changeset db9ac0924815 2013-03-21 10:43:39 -07:00
Joe Darcy
08c578cdcf 8010364: Clarify javax.lang.model API for Type Annotations
Reviewed-by: jjg, abuckley
2013-03-20 17:41:40 -07:00
Jonathan Gibbons
d4e9a74af5 8010317: DocLint incorrectly reports some <pre> tags as empty
Reviewed-by: darcy
2013-03-19 19:16:59 -07:00
Jonathan Gibbons
622349cdb1 8010333: Remove com.sun.tools.javac.Server
Reviewed-by: darcy
2013-03-19 17:05:57 -07:00
Jonathan Gibbons
ab8f7a3762 8010361: fix some langtools findbugs issues
Reviewed-by: darcy
2013-03-19 17:04:03 -07:00
Jonathan Gibbons
a52c1dd51a 8010315: doclint errors in javac public API
Reviewed-by: darcy
2013-03-19 15:13:44 -07:00
Joe Darcy
479d5c83b0 8010179: Remove transitional target values from javac
Reviewed-by: jjg, mcimadamore
2013-03-19 13:10:40 -07:00
Jonathan Gibbons
49d55f9300 8007803: Implement javax.lang.model API for Type Annotations
Reviewed-by: darcy
2013-03-18 18:33:13 -07:00
Jonathan Gibbons
0e8a3df6c7 8008425: Remove interim new javax.lang.model API for type-annotations
Reviewed-by: darcy
2013-03-18 14:40:32 -07:00
Peter Jensen
1e91824535 8005220: RFE to write javap tests for repeating annotations
Reviewed-by: jjg
2013-03-18 08:46:09 -07:00
Lana Steuck
582c062a6d Merge 2013-03-15 23:46:14 -07:00
Matherey Nunez
cd78ad2c8a 8007767: TargetAnnoCombo.java need to be updated to add a new test mode
Reviewed-by: jjg, strarup
2013-03-15 13:39:04 +01:00
Vicente Romero
a7e53ae56d 5053846: javac: MethodRef entries are duplicated in the constant pool
Reviewed-by: mcimadamore
2013-03-15 09:02:26 +00:00
Robert Field
46e9ef69a7 8010010: NPE generating serializedLambdaName for nested lambda
Reviewed-by: mcimadamore
2013-03-14 22:54:17 -07:00
Lana Steuck
e261fe353f Merge 2013-03-14 19:33:29 -07:00
David Katleman
6b708cf6e0 Added tag jdk8-b81 for changeset a7ab085069a9 2013-03-14 15:00:41 -07:00
Mandy Chung
857b7efb96 8005428: Update jdeps to read the same profile information as by javac
Reviewed-by: alanb
2013-03-14 10:33:31 -07:00
Vicente Romero
4ef6ef5d0f 8008582: jtreg failures after conversion of shell tests to Java
Reviewed-by: jjg
2013-03-14 08:30:16 +00:00
David Holmes
52954e063d 8009429: Miscellaneous profiles cleanup
Reviewed-by: jjg, alanb
2013-03-14 01:45:44 -04:00
Bhavesh Patel
82210b98a8 8009684: Default top left frame should be "All Packages" in the generated javadoc documentation
Reviewed-by: jjg
2013-03-13 14:47:15 -07:00
Joel Borggrén-Franck
09e3f06ae6 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
Reviewed-by: jjg
2013-03-13 22:03:09 +01:00
Lana Steuck
407bc5f8c6 Merge 2013-03-12 16:43:53 -07:00
Joel Borggrén-Franck
4de6d2c42c 7196531: Duplicate error messages on repeating annotations
Reviewed-by: jjg
2013-03-12 17:39:34 +01:00
Maurizio Cimadamore
22e2c128a2 8009545: Graph inference: dependencies between inference variables should be set during incorporation
Move all transitivity checks into the incorporation round

Reviewed-by: jjg
2013-03-12 16:02:43 +00:00
Maurizio Cimadamore
69ee819808 8008540: Constructor reference to non-reifiable array should be rejected
8008539: Spurious error when constructor reference mention an interface type
8008538: Constructor reference accepts wildcard parameterized types

Overhaul of Check.checkConstructorRefType

Reviewed-by: jjg
2013-03-12 16:02:13 +00:00
Joel Borggrén-Franck
c3e43ab7d5 8005205: tests missing bugid for repeating annotation change
Reviewed-by: jjg, ssides
2013-03-12 11:16:30 +01:00
Fredrik Öhrström
454b9ff071 8009843: sjavac should accept -cp as synonym for -classpath
Reviewed-by: jjg
2013-03-11 19:03:35 -07:00
Robert Field
41447ec765 8009742: Bad lambda name for lambda in a static initializer or ctor
Reviewed-by: mcimadamore
2013-03-11 10:02:55 -07:00
Vicente Romero
475c6f42ad 6181889: Empty try/finally results in bytecodes being generated
Reviewed-by: mcimadamore
2013-03-11 15:35:13 +00:00
David Katleman
e0a29cc0f1 Added tag jdk8-b80 for changeset dec13271b739 2013-03-07 11:18:06 -08:00
Robert Field
867e1720c2 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization
Reviewed-by: mcimadamore
2013-03-07 08:26:13 -08:00
Vicente Romero
b04bec8156 8009170: Regression: javac generates redundant bytecode in assignop involving arrays
Reviewed-by: mcimadamore
2013-03-07 10:12:13 +00:00
Vicente Romero
7fe4d602a6 8009138: javac, equals-hashCode warning tuning
Reviewed-by: mcimadamore
2013-03-07 10:04:28 +00:00
Maurizio Cimadamore
1823b93919 8009391: Synthetic name of serializable lambda methods should not contain negative numbers
Use hex representation of method signature hashcode to avoid negative numbers

Reviewed-by: jjg
2013-03-06 15:33:39 +00:00
Maurizio Cimadamore
a4e10d2aad 8009459: Wrong behavior of diamond finder with source level 7
Diamond finder doesn't take into account different inference behaviors

Reviewed-by: jjg
2013-03-06 15:33:17 +00:00
Maurizio Cimadamore
c9bae7b335 8009299: Javac crashes when compiling method reference to static interface method
Assertion in Check.checMethod is too strict

Reviewed-by: jjg
2013-03-06 15:29:30 +00:00
Lana Steuck
3c0b52b10b Merge 2013-03-05 11:51:58 -08:00
Maurizio Cimadamore
e788a0e536 8009129: Illegal access error when calling method reference
Javac generates method handle referencing non public type

Reviewed-by: jjg, rfield
2013-03-05 14:19:49 +00:00
Maurizio Cimadamore
7a28d6291d 8009154: Missing cast in method reference bridge leads to NoSuchMethodError
Missing cast in generated method reference bridge

Reviewed-by: rfield, jjg
2013-03-05 14:16:07 +00:00
Maurizio Cimadamore
3cbe22f256 8009227: Certain diagnostics should not be deferred
Add new diagnostic flag to mark non deferrable diagnostics

Reviewed-by: jjg
2013-03-05 14:12:07 +00:00
Maurizio Cimadamore
d0a0df54ed 8004962: Code generation crash with lambda and local classes
Translation info should be propagated from LambdaToMethod to Lower

Reviewed-by: jjg, rfield
2013-03-05 14:04:57 +00:00
Jonathan Gibbons
6c39105c60 8008949: javadoc stopped copying doc-files
Reviewed-by: bpatel
2013-03-01 10:47:39 -08:00
David Katleman
f21ded8eea Added tag jdk8-b79 for changeset eef229ae322b 2013-02-28 10:43:03 -08:00
Maurizio Cimadamore
f932d844c1 8008537: Missing method reference lookup error when unbound search finds a static method
Static-ness check should be applied after member reference resolution

Reviewed-by: jjg
2013-02-28 14:05:52 +00:00
Maurizio Cimadamore
85067f7869 8008813: Structural most specific fails when method reference is passed to overloaded method
Bad logic for checking most specific method reference type

Reviewed-by: jjg
2013-02-28 14:05:44 +00:00
Maurizio Cimadamore
9c01455eb6 8008723: Graph Inference: bad graph calculation leads to assertion error
Dependencies are not propagated correctly through merged nodes during inference graph initialization

Reviewed-by: jjg
2013-02-28 14:00:52 +00:00
Vicente Romero
9f2721bfb1 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
Reviewed-by: jjg, mcimadamore
2013-02-26 09:04:19 +00:00
Jan Valenta
63fe735683 7112427: The doclet needs to be able to generate JavaFX documentation
Reviewed-by: jjg
2013-02-24 11:36:58 -08:00
Maurizio Cimadamore
7776fdebe7 8008708: Regression: separate compilation causes crash in wildcards inference logic
Invalid use of WildcardType.bound in Types.removeWildcards

Reviewed-by: jjg
2013-02-22 18:19:51 +00:00
Sonali Goel
96495bc664 8008337: Write test to check for compiler error when static method in interface is called via super()
Reviewed-by: mcimadamore
2013-02-22 13:31:35 +00:00
Lana Steuck
3c22954800 Merge 2013-02-21 17:49:56 -08:00
Eric Mccorkle
e84b39e459 8008658: Four new method param jtreg tests fail in nightly tests
Reviewed-by: jjg, ksrini, mcimadamore
2013-02-21 12:23:27 -08:00
Robert Field
bcaa703a49 8008405: Now that metafactory is in place, add javac lambda serialization tests
Tests part of original langtools serialization review.

Reviewed-by: mcimadamore
2013-02-21 14:43:51 -08:00
David Katleman
60f0c3f6fc Added tag jdk8-b78 for changeset 27bb87e628ae 2013-02-21 11:13:58 -08:00
Maurizio Cimadamore
73b1aee3f4 8008444: Inherited generic functional descriptors are merged incorrectly
Missing call to Types.createMethodWithThrownTypes

Reviewed-by: jjg
2013-02-21 15:27:05 +00:00
Maurizio Cimadamore
6fd868a306 8007461: Regression: bad overload resolution when inner class and outer class have method with same name
Fix regression in varargs method resolution introduced by bad refactoring

Reviewed-by: jjg
2013-02-21 15:26:46 +00:00
Maurizio Cimadamore
8c1621ee38 8008293: Declared bounds not considered when functional interface containing unbound wildcards is instantiated
Wildcards inference should re-use some of the bounds info generated during capture conversion

Reviewed-by: jjg
2013-02-21 15:25:03 +00:00
Maurizio Cimadamore
5bbf5f39fc 8005183: Missing accessor for constructor reference pointing to private inner class ctor
Compiler should add bridges when translating private constructor reference

Reviewed-by: jjg
2013-02-21 15:23:48 +00:00
Maurizio Cimadamore
937b7d2fba 8008276: assertion error in com.sun.tools.javac.comp.TransTypes.visitApply
DiagnosticFilter used during speculative attribution is too broad

Reviewed-by: jjg
2013-02-21 15:21:38 +00:00
Maurizio Cimadamore
eb68b33185 8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler
Disentangle cyclic dependency between static-ness of synthetic lambda method and static-ness of classes nested within lambdas

Reviewed-by: jjg
2013-02-21 15:19:29 +00:00
Peter Jensen
556f6dfebb 8006582: Test for parameter names feature
Reviewed-by: jjg, darcy, emc
2013-02-20 15:47:14 -08:00
Lana Steuck
898ada48bb Merge 2013-02-19 20:53:35 -08:00
Eric Mccorkle
bfe1255adc 8006948: Update javac for MethodParameters format change
Reviewed-by: ksrini, forax
2013-02-19 17:19:01 -08:00
Vicente Romero
68a3295c8b 8006212: javac, convert jtreg tests from shell script to java
Reviewed-by: jjg
2013-02-19 17:53:16 +00:00
Joe Darcy
6e097b8776 8008267: Add @Supported annotation to com.sun.source types
Reviewed-by: jjg
2013-02-19 00:31:45 -08:00
Jonathan Gibbons
971f247b1b 8008339: Test TargetAnnoCombo.java is broken
Reviewed-by: jjh
2013-02-18 14:29:40 -08:00
Vicente Romero
e6b61ae08a 6563143: javac should issue a warning for overriding equals without hashCode
Reviewed-by: jjg, mcimadamore
2013-02-18 14:33:25 +00:00
David Holmes
e57875e8ab Merge 2013-02-17 16:44:55 -05:00
Robert Field
b2a3c762ff 8004969: Generate $deserializeLambda$ method
8006763: super in method reference used in anonymous class - ClassFormatError is produced
8005632: Inner classes within lambdas cause build failures
8005653: Lambdas containing inner classes referencing external type variables do not correctly parameterize the inner classes

Reviewed-by: mcimadamore
2013-02-15 18:40:38 -08:00
Jonathan Gibbons
ff25ecbcbb 8008313: 8007052 breaks test/tools/javap/MethodParameters.java
Reviewed-by: darcy
2013-02-15 11:26:11 -08:00
Maurizio Cimadamore
fd17a4290b 8008309: TargetType60 fails because of bad golden file
Bad golden file

Reviewed-by: jjg
2013-02-15 18:13:00 +00:00
Maurizio Cimadamore
b9a88adb02 Merge 2013-02-15 16:37:19 +00:00
Sonali Goel
30058417e1 8007427: Annotation element as '_' gives compiler error instead of a warning
8007401: Write test to check for generation of warnings when '_' is used as an identifier

Extended identifier production not used in annotation values

Reviewed-by: jjg
2013-02-15 16:31:19 +00:00
Maurizio Cimadamore
f5df2a2562 8007535: Compiler crashes on @FunctionalInterface used on interface with two inherited methods with same signatures
Bad check in Types.interfaceCandidates

Reviewed-by: jjg
2013-02-15 16:30:31 +00:00
Maurizio Cimadamore
b496912ee1 8007462: Fix provisional applicability for method references
Add speculative arity-based check to rule out potential candidates when stuck reference is passed to method

Reviewed-by: jjg
2013-02-15 16:29:58 +00:00
Maurizio Cimadamore
e88e06a5e0 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
Missing abstractness check on super rmethod references

Reviewed-by: jjg
2013-02-15 16:28:57 +00:00
Jonathan Gibbons
a695bef890 8007052: javap should include the descriptor for a method in verbose mode
Reviewed-by: mcimadamore
2013-02-15 08:28:42 -08:00
Maurizio Cimadamore
f8f9896cc7 8006749: compiler does not allow Object protected methods to be used in lambda
Check.checkFunctionalInterface should take into account 'fake' override

Reviewed-by: jjg
2013-02-15 16:28:07 +00:00
Lana Steuck
e2244526fa Merge 2013-02-14 22:11:58 -08:00
David Katleman
32bced14f5 Added tag jdk8-b77 for changeset d97b73add494 2013-02-14 11:44:21 -08:00
Mandy Chung
ee65d32c20 8006225: tools/jdeps/Basic.java failes with AssertionError
Reviewed-by: alanb
2013-02-14 09:43:00 -08:00
Sonali Goel
2fb38081d5 8001457: New tests needed for library-side changes for repeating annotations
Reviewed-by: darcy
2013-02-13 23:05:17 -08:00
Lana Steuck
3bfd774a99 Merge 2013-02-13 11:25:58 -08:00