86 Commits

Author SHA1 Message Date
Maurizio Cimadamore
b77effad6c 6968793: issues with diagnostics
Several diagnostic improvements

Reviewed-by: jjg
2011-01-24 15:44:51 +00:00
Maurizio Cimadamore
df54c56a04 6943278: spurious error message for inference and type-variable with erroneous bound
Type-inference should ignore erroneous bounds

Reviewed-by: jjg
2011-01-24 15:44:15 +00:00
Kelly O'Hair
84b5875f26 6962318: Update copyright year
Reviewed-by: xdono
2010-12-28 15:54:52 -08:00
Maurizio Cimadamore
929d3fd3f5 6476118: compiler bug causes runtime ClassCastException for generics overloading
Compiler allows bridge methods to override unrelated method

Reviewed-by: jjg
2010-12-09 15:50:34 +00:00
Maurizio Cimadamore
8644a0bc46 7002837: Diamond: javac generates diamond inference errors when in 'finder' mode
Javac should disable error messages when analyzing instance creation expression in 'diamond finder' mode

Reviewed-by: jjg
2010-12-03 16:32:31 +00:00
Maurizio Cimadamore
7613f7a72c 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass
Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Lower

Reviewed-by: jjg
2010-12-03 16:31:23 +00:00
Maurizio Cimadamore
3e65664acf 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type
15.12.2.8 should use boxing when expected type in assignment context is a primitive type

Reviewed-by: jjg
2010-11-23 11:08:43 +00:00
Maurizio Cimadamore
3a681162e4 6985719: Alike methods in interfaces (Inheritance and Overriding)
Javac should report error when interface inherits unrelated method with same erasure

Reviewed-by: jjg
2010-11-15 13:50:53 +00:00
Maurizio Cimadamore
83fb083bfa 6996914: Diamond inference: problem when accessing protected constructor
Special resolution scheme for diamond inference needs to open up protected constructors in anon inner class creation

Reviewed-by: jjg
2010-11-10 12:37:25 +00:00
Maurizio Cimadamore
9b7bc21bb0 6939780: add a warning to detect diamond sites
Added hidden compiler flag '-XDfindDiamond' to detect 'diamondifiable' sites

Reviewed-by: jjg
2010-11-02 12:01:35 +00:00
Maurizio Cimadamore
ac9f97939f 6996415: Override bridges causes compiler-generated code to end up with synthetic infinite loop
Temporarily disable fix for override bridges (6337171)

Reviewed-by: jjg
2010-11-02 12:00:54 +00:00
Lana Steuck
78db31beb6 Merge 2010-09-25 12:02:32 -07:00
Maurizio Cimadamore
cd3371e702 5088624: cannot find symbol message should be more intelligent
Resolve.java should keep track of all candidates found during a method resolution sweep to generate more meaningful diagnostics

Reviewed-by: jjg
2010-09-18 09:56:23 -07:00
Lana Steuck
dc37688eb9 Merge 2010-09-16 11:20:36 -07:00
Kelly O'Hair
fd65dbfc50 6982137: Rebranding pass 2 - missed copyright changes
Reviewed-by: mbykov
2010-09-09 16:29:40 -07:00
Maurizio Cimadamore
73825fc885 6337171: javac should create bridge methods when type variable bounds restricted
Javac should add synthetic overrides for inherited abstract methods in order to preserve binary compatibility

Reviewed-by: jjg
2010-09-07 17:31:54 +01:00
Maurizio Cimadamore
634d001c64 6977800: Regression: invalid resolution of supertype for local class
Resolution of superclass/superinterfaces in extends/implements clause skips local classes

Reviewed-by: jjg
2010-08-19 11:54:25 +01:00
Maurizio Cimadamore
71962ebfb0 6886247: regression: javac crashes with an assertion error in Attr.java
Capture conversion does not work on nested types

Reviewed-by: jjg
2010-08-19 11:50:50 +01:00
Maurizio Cimadamore
2801325742 6369605: Unconstrained type variables fails to include bounds
Unconstrained type-variables with recursive bounds are not inferred properly

Reviewed-by: jjg
2010-08-16 14:58:10 +01:00
Maurizio Cimadamore
541f7a7a41 6938454: Unable to determine generic type in program that compiles under Java 6
A redundant dubtyping check causes spurious inference failure

Reviewed-by: jjg
2010-07-29 15:56:25 +01:00
Jonathan Gibbons
ccd014ed3f 6971882: Remove -XDstdout from javac test
Reviewed-by: darcy
2010-07-26 14:18:45 -07:00
Jonathan Gibbons
29ceaebc37 6968497: localized text appears in raw diagnostic
Reviewed-by: darcy
2010-07-12 16:37:46 -07:00
Jonathan Gibbons
0dd9ef9b43 6944312: Potential rebranding issues in openjdk/langtools repository sources
Reviewed-by: darcy
2010-06-10 16:08:01 -07:00
Lana Steuck
2592bab72c Merge 2010-05-28 12:41:48 -07:00
Kelly O'Hair
bd4f4be9d7 6943119: Rebrand source copyright notices
Reviewed-by: darcy
2010-05-25 15:54:51 -07:00
Maurizio Cimadamore
836fb6fe52 6951833: latest diamond implementation generates spurious raw type warnings
Raw warning checks should be disabled in the presence of a diamond AST node

Reviewed-by: jjg
2010-05-19 16:43:30 +01:00
Maurizio Cimadamore
cd66a7b462 6946618: sqe test fails: javac/generics/NewOnTypeParm in pit jdk7 b91 in all platforms
Bad cast to ClassType in the new diamond implementation fails if the target type of the instance creation expression is a type-variable

Reviewed-by: jjg
2010-05-19 16:42:37 +01:00
Maurizio Cimadamore
1bc9b6324e 6880344: Recursive type parameters do not compile
Issue in type-variable substitution causes valid code to be rejected

Reviewed-by: jjg
2010-05-19 16:41:57 +01:00
Maurizio Cimadamore
d3fa7f79ad 6939620: Switch to 'complex' diamond inference scheme
Implement new inference scheme for diamond operator that takes into account type of actual arguments supplied to constructor

Reviewed-by: jjg, darcy
2010-04-14 12:31:55 +01:00
Maurizio Cimadamore
965595d38b 6939618: Revert 'simple' diamond implementation
Backout changeset for 6840638

Reviewed-by: jjg
2010-04-14 12:23:29 +01:00
Jonathan Gibbons
2ed0d63583 6933914: fix missing newlines
Reviewed-by: ohair
2010-03-10 16:23:18 -08:00
Jonathan Gibbons
953e026858 6931126: jtreg tests not Windows friendly
Reviewed-by: darcy
2010-03-03 19:34:34 -08:00
Jonathan Gibbons
87efbd8787 6931127: strange test class files
Reviewed-by: darcy
2010-03-02 16:43:29 -08:00
Jonathan Gibbons
305d4bc5fc 6919889: assorted position errors in compiler syntax trees
Reviewed-by: darcy
2010-01-29 16:06:51 -08:00
Xiomara Jayasena
dbe66b7524 6884624: Update copyright year
Update copyright for files that have been modified in 2009 through Septermber

Reviewed-by: tbell, ohair
2009-09-22 14:06:29 -07:00
Maurizio Cimadamore
1de40db76d 6650759: Inference of formal type parameter (unused in formal parameters) is not performed
Propagate inference constraints from 15.12.2.7 to 15.12.2.8

Reviewed-by: jjg
2009-09-01 14:53:39 +01:00
Jonathan Gibbons
af2f2e8d36 6875336: some tests should use /nodynamiccopyright/
Reviewed-by: darcy
2009-08-27 11:08:27 -07:00
Maurizio Cimadamore
e5ce4a752b 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
Diamond operator implementation (simple approach)

Reviewed-by: jjg
2009-08-27 13:40:48 +01:00
Maurizio Cimadamore
d8292cad05 6569404: Cannot instantiate an inner class of a type variable
Javac is too strict in rejecting member selction from a type-var

Reviewed-by: jjg
2009-08-11 01:14:06 +01:00
Maurizio Cimadamore
b097f12a5d 6869075: regression: javac crashes when compiling compound string assignment with generics
Javac should not add syntehtic cast to the LHS of an assignment expression

Reviewed-by: jjg
2009-08-11 01:13:42 +01:00
Maurizio Cimadamore
dd76763423 6846972: cannot access member of raw type when erasure change overriding into overloading
Fix of 6400189 caused a nasty problem in method resolution

Reviewed-by: jjg
2009-07-15 10:25:01 +01:00
Maurizio Cimadamore
3b51e6ae0d 6638712: Inference with wildcard types causes selection of inapplicable method
Added global sanity check in order to make sure that return type inference does not violate bounds constraints

Reviewed-by: jjg
2009-06-16 10:46:37 +01:00
Maurizio Cimadamore
fda3d758e3 6835428: regression: return-type inference rejects valid code
Redundant subtyping test during type-inference ends up in rejecting legal code

Reviewed-by: jjg
2009-06-16 10:46:16 +01:00
Jonathan Gibbons
6fb18b568c 6802102: unignore @ignored tests where possible
Reviewed-by: mcimadamore
2009-05-28 09:49:56 -07:00
Joe Darcy
05ea258bbb 6843761: Update langtools tests to remove unncessary -source and -target options
Reviewed-by: jjg
2009-05-27 22:34:43 -07:00
Maurizio Cimadamore
8321605121 6182950: methods clash algorithm should not depend on return type
Fixed code that checks for duplicate method declarations

Reviewed-by: jjg
2009-03-25 10:28:36 +00:00
Tim Bell
e005d5df51 Merge 2009-03-09 23:53:41 -07:00
Xiomara Jayasena
56fcf6c052 6814575: Update copyright year
Update copyright for files that have been modified in 2009, up to 03/09

Reviewed-by: katleman, tbell, ohair
2009-03-09 13:29:06 -07:00
Maurizio Cimadamore
5ff31e060f 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
Fixed algorithm for checking cycles in typevar declarations

Reviewed-by: jjg
2009-03-05 17:24:40 +00:00
Maurizio Cimadamore
198f2427b4 6769027: Source line should be displayed immediately after the first diagnostic line
Added support for customizing diagnostic output via API/command line flags

Reviewed-by: jjg
2009-02-13 11:57:33 +00:00