Commit Graph

317 Commits

Author SHA1 Message Date
Coleen Phillimore
d6de951947 8062870: src/share/vm/services/mallocTracker.hpp:64 assert(_count > 0) failed: Negative counter
Signed bitfield size y can only have (1 << y)-1 values.

Reviewed-by: shade, dholmes, jrose, ctornqvi, gtriantafill
2014-11-11 09:59:50 -05:00
Aleksey Shipilev
21527b2ff2 8015272: Make @Contended within the same group to use the same oop map
Reviewed-by: coleenp, dholmes
2014-11-11 15:07:09 +03:00
George Triantafillou
b4138cce10 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms
Reviewed-by: ctornqvi, coleenp
2014-11-05 08:22:17 -08:00
Christian Tornqvist
76971f377b 8058251: assert(_count > 0) failed: Negative counter when running runtime/NMT/MallocTrackingVerify.java
Fixed an issue when overflowing the MallocSite hash table bucket

Reviewed-by: coleenp, gtriantafill
2014-11-05 13:20:09 -08:00
Christian Tornqvist
d934df8a84 8061733: [TESTBUG] Exclude tests that have issues with Jigsaw M2 changes
[TESTBUG] Exclude tests that have issues with Jigsaw M2 changes

Reviewed-by: lfoltan, gtriantafill
2014-11-05 13:18:51 -08:00
Daniel D. Daugherty
ee1de3ce2f Merge 2014-10-27 15:09:23 -07:00
Alejandro Murillo
ea60f1eddd Merge 2014-10-27 07:49:54 -07:00
Boris Molodenkov
f55d90353f 8057135: [TESTBUG] Need a test to cover JDK-8050167
Reviewed-by: ctornqvi, coleenp
2014-10-24 12:32:53 +04:00
Chris Plummer
5306f2430a 6191224: (reflect) Misleading detail string in IllegalArgumentException thrown by Array.get<Type>
The test case shows that an exception is thrown with the message "Argument is not an array", when in fact the argument is an array, but an array of a primitive type is actually what was expected. Fixed by differentiating between failing because an array was expected and failing because an array of a primitive type was expected.

Reviewed-by: dholmes, ctornqvi, lfoltan
2014-10-23 14:43:08 -07:00
Calvin Cheung
1aa3da1067 8038268: VM Crashes in MetaspaceShared::generate_vtable_methods while creating CDS archive with limiting SharedMiscCodeSize
Estimate the minimum required size for the misc code region and check if the specified misc code region size meets the minimum size requirement

Reviewed-by: jiangli, dholmes
2014-10-23 10:08:02 -07:00
Karen Kinnear
397e42b775 Merge 2014-10-22 22:37:06 +00:00
Karen Kinnear
0e1283a811 8043275: Fix interface initialization for default methods
Initialize interfaces that declare concrete instance methods.

Reviewed-by: kamg, coleenp, psandoz
2014-10-22 15:24:37 -07:00
Andreas Eriksson
ea48bceb5e 8057043: Type annotations not retained during class redefine / retransform
Reviewed-by: coleenp, sspitsyn, jfranck
2014-10-22 13:59:56 +02:00
Jiangli Zhou
cc264643ac 8060256: The loop in Arguments::parse() can be enhanced
Add continue statement for matching cases.

Reviewed-by: dholmes, bdelsart
2014-10-16 14:11:53 -04:00
George Triantafillou
b79e1193cd 8058606: [TESTBUG] Detailed Native Memory Tracking (NMT) data is not verified as output at VM exit
Reviewed-by: coleenp, hseigel
2014-10-15 05:55:44 -07:00
Coleen Phillimore
3a86f9cd27 8059100: SIGSEGV VirtualMemoryTracker::remove_released_region
Disallow increasing native memory tracking level

Reviewed-by: hseigel, ctornqvi, gtriantafill
2014-10-10 19:36:12 +00:00
Coleen Phillimore
ae9681a5cf 8058927: ATG throws ClassNotFoundException
ClassLoader for array klass set to null and not the class loader of the component type.

Reviewed-by: dcubed, ctornqvi
2014-09-26 12:50:30 -04:00
Coleen Phillimore
31b9cf6251 8058818: Allocation of more then 1G of memory using Unsafe.allocateMemory is still causing a fatal error on 32bit platforms
The assert was firing for NMT_Off and minimal too even though the size isn't used.

Reviewed-by: gtriantafill, dholmes
2014-09-25 07:52:32 -04:00
Ioi Lam
a2e41921c1 Merge 2014-09-19 13:47:19 -07:00
Jesper Wilhelmsson
e97944b0b1 Merge 2014-09-18 19:41:50 +02:00
Christian Tornqvist
4d8eb788f4 8058369: [TESTBUG] runtime/CompressedOops/UseCompressedOops.java Exception java.lang.RuntimeException: 'Zero based' missing from stdout/stderr
Solaris and OSX places the heap in unpredictable places, some of the test must be excluded on these platforms

Reviewed-by: hseigel, coleenp
2014-09-17 06:55:12 -07:00
George Triantafillou
d7f661e576 8058504: [TESTBUG] Temporarily disable failing test runtime/NMT/MallocTrackingVerify.java
Reviewed-by: ctornqvi, hseigel
2014-09-15 14:28:15 -07:00
Christian Tornqvist
9e6d432562 8022865: [TESTBUG] Compressed Oops testing needs to be revised
Rewrote compressed oops tests

Reviewed-by: kvn, coleenp, mseledtsov
2014-09-11 17:54:22 -07:00
Coleen Phillimore
310192415e 8055145: [TESTBUG] runtime/7158988/FieldMonitor.java fails with VMDisconnectedException
Exclude this test on JPRT and make it trivially pass if it gets a disconnected exception (which seems rare)

Reviewed-by: gtriantafill, sspitsyn, ctornqvi
2014-09-11 10:46:32 -04:00
George Triantafillou
287db624e4 8054836: [TESTBUG] Test is needed to verify correctness of malloc tracking
Reviewed-by: ctornqvi, lfoltan
2014-09-09 09:48:42 -07:00
Ivan Gerasimov
b5c0f09885 8057745: TEST_BUG: runtime/SharedArchiveFile/ArchiveDoesNotExist.java fails with openjdk build
Reviewed-by: dholmes, mseledtsov
2014-09-08 23:49:39 +04:00
Zhengyu Gu
b20fa155a6 Merge 2014-09-04 14:58:58 -04:00
Zhengyu Gu
95216ecffe 8055289: Internal Error: mallocTracker.cpp:146 fatal error: Should not use malloc for big memory block, use virtual memory instead
Return NULL if memory allocation size is bigger than MAX_MALLOC_SIZE when NMT is on

Reviewed-by: coleenp, gtriantafill
2014-09-04 14:50:31 -04:00
Coleen Phillimore
3c70d99eda 8055008: Clean up code that saves the previous versions of redefined classes
Use scratch_class to find EMCP methods for breakpoints if the old methods are still running.

Reviewed-by: dcubed, sspitsyn
2014-09-03 19:13:18 -04:00
Christian Tornqvist
3a78ac3c1b 8041727: [TESTBUG] runtime/jsig/Test8017498.sh fails with Test8017498.sh: 50: [: x/usr/bin/gcc: unexpected operator
Fixed shell script issues

Reviewed-by: dcubed, gtriantafill
2014-08-26 13:07:57 -07:00
Christian Tornqvist
05c6411eed 8055844: [TESTBUG] test/runtime/NMT/VirtualAllocCommitUncommitRecommit.java fails on Solaris Sparc due to incorrect page size being used
Use 128KB chunks for virtual memory operations

Reviewed-by: zgu, gtriantafill
2014-08-22 14:21:41 -07:00
George Triantafillou
3f590aeec4 8055765: Misplaced @key stress prevents MallocSiteHashOverflow.java and MallocStressTest.java tests from running
Reviewed-by: ctornqvi, zgu, hseigel
2014-08-22 06:28:14 -07:00
George Triantafillou
311638a602 8055684: runtime/NMT/CommandLineEmptyArgument.java fails
Reviewed-by: ctornqvi, sla
2014-08-21 14:37:39 -07:00
George Triantafillou
2d90aac381 8055053: [TESTBUG] runtime/NMT/VirtualAllocCommitUncommitRecommit.java fails
Reviewed-by: ctornqvi, zgu
2014-08-22 07:38:42 -07:00
George Triantafillou
663ff7ad59 8055052: [TESTBUG] runtime/NMT/JcmdDetailDiff.java fails on Windows when there are no debug symbols available
Reviewed-by: ctornqvi, hseigel
2014-08-22 06:46:29 -07:00
Christian Tornqvist
bf8c47fafe 8055814: [TESTBUG] runtime/NMT/NMTWithCDS.java fails with product builds due to missing UnlockDiagnosticVMOptions
Passing -XX:+UnlockDiagnosticVMOptions to ProcessBuilder

Reviewed-by: zgu, gtriantafill
2014-08-22 09:30:57 -07:00
Christian Tornqvist
655556a4bf 8055164: [TESTBUG] runtime/CompressedOops/CompressedClassPointers.java fails with OpenJDK build
Removed explicit check for HotSpot in output

Reviewed-by: sla, coleenp, hseigel
2014-08-20 14:59:08 -07:00
Zhengyu Gu
4ef9e6c2bc Merge 2014-08-19 10:04:29 -04:00
George Triantafillou
1a1ce4534e 8055051: runtime/NMT/CommandLineEmptyArgument.java fails
Disable failing test

Reviewed-by: ctornqvi, zgu
2014-08-19 06:47:28 -07:00
George Triantafillou
8fe87f3da7 8054711: [TESTBUG] Enable NMT2 tests after NMT2 is integrated
Enable tests for NMT2

Reviewed-by: ctornqvi, zgu
2014-08-18 11:56:12 -07:00
Zhengyu Gu
7bce315059 8055061: assert at share/vm/services/virtualMemoryTracker.cpp:332 Error: ShouldNotReachHere() when running NMT tests
Handled CDS mapping region and added test for the scenario

Reviewed-by: coleenp, ctornqvi
2014-08-19 09:05:55 -04:00
Serguei Spitsyn
bc23c9949e Merge 2014-08-15 11:25:55 -07:00
Christian Tornqvist
2d98294837 8032999: [TESTBUG] JT-Reg Runtime tests to be run as part of JPRT submit job
JPRT will now run most of the tests in /runtime

Reviewed-by: dcubed, mseledtsov, zgu, mikael
2014-08-14 18:14:07 -07:00
Jon Masamitsu
5a22518210 Merge 2014-08-14 18:42:08 +00:00
Christian Tornqvist
69c1d825ff 8054713: [TESTBUG] runtime/jsig/Test8017498.sh: Execution failed: exit code 1
Changed output directory of gcc to avoid permission problems

Reviewed-by: coleenp, minqi
2014-08-12 17:29:47 -07:00
Christian Tornqvist
0604ebb2bf Merge 2014-08-12 21:18:14 +00:00
George Triantafillou
89c5882d2e 8054952: [TESTBUG] Add missing NMT2 tests
The new NMT2 tests got lost on the way into jdk9 yesterday, this change adds them.

Reviewed-by: coleenp, zgu, ctornqvi
2014-08-12 14:06:41 -07:00
George Triantafillou
69e7c05210 8044140: Create NMT (Native Memory Tracking) tests for NMT2
Create new/modify existing tests for NMT2, which is an internal redesign to address scalability issues in the first implementation.

Reviewed-by: ctornqvi, zgu
2014-08-11 07:30:46 -07:00
Andrey Zakharov
dd95f0a0c2 8011397: JTREG needs to copy additional WhiteBox class file to JTwork/scratch/sun/hotspot
Reviewed-by: kvn, iignatyev, mgerdin
2014-08-11 17:12:41 +04:00
Vladimir Kozlov
648272884a Merge 2014-08-08 10:35:05 -07:00
Harold Seigel
1c5ed7ab4c 8046233: VerifyError on backward branch
Remove check that causes the VerifyError

Reviewed-by: dholmes, coleenp, acorn
2014-08-05 09:11:35 -04:00
Christian Tornqvist
71d23aa793 8053956: [TESTBUG] Remove @ignore tag from fixed runtime issues
Removed ignore tags from already fixed tests

Reviewed-by: gtriantafill, dcubed
2014-07-31 11:56:59 -07:00
Igor Ignatyev
ebcdde4222 8051896: jtreg tests don't use $TESTJAVAOPTS
Reviewed-by: kvn, ctornqvi
2014-08-03 12:04:17 +04:00
Igor Ignatyev
726b299ae0 Merge 2014-07-19 13:43:02 +04:00
Igor Ignatyev
e6b1dd586f 8032449: Get rid of JMX in test/compiler
Reviewed-by: kvn
2014-07-19 00:34:20 +04:00
Coleen Phillimore
06cea98803 8048933: -XX:+TraceExceptions output should include the message
Add the exception detail message to the tracing output

Reviewed-by: minqi, dholmes
2014-07-09 22:37:48 -04:00
Joe Darcy
4f7e4160a0 8048620: Remove unneeded/obsolete -source/-target options in hotspot tests
Reviewed-by: dholmes, hseigel
2014-07-07 12:08:07 -04:00
Harold Seigel
08e90ebfcb 8026894: Improve VerifyError message about overriding a final method
Add full class name to error message.

Reviewed-by: fparain, zgu, lfoltan
2014-07-03 10:25:42 -04:00
Christian Tornqvist
30b9c7d9cb 8048076: [TESTBUG] runtime/Unsafe/RangeCheck.java fails with -Xcomp
Compiler intrinsics doesn't have this assert, disabled the intrinsics to make sure we go through the VM

Reviewed-by: lfoltan, coleenp
2014-06-25 13:03:29 -07:00
Christian Tornqvist
33a0064f97 8047939: [TESTBUG] Rewrite test/runtime/8001071/Test8001071.sh
Rewrote the test in Java, limited the heap size to avoid time out issues on machines with a lot of memory

Reviewed-by: minqi, rdurbin, dcubed
2014-06-24 07:10:06 -07:00
Jesper Wilhelmsson
3e005941e7 Merge 2014-09-15 13:32:30 +00:00
Erik Helin
1d4a5e9412 8049536: os::commit_memory on Solaris uses aligment_hint as page size
Reviewed-by: stefank, tschatzl
2014-09-15 10:57:22 +02:00
Christian Tornqvist
5cfb709349 8047878: [TESTBUG] runtime/memory/ReadFromNoaccessArea.java and runtime/memory/ReserveMemory.java time out on Solaris
Limited heap size to reduce size of core file generated

Reviewed-by: sla, coleenp, dcubed
2014-06-23 14:51:10 -07:00
Pavel Chistyakov
d9a2dbc73b 8044818: [TESTBUG] runtime/CDSCompressedKPtrs/XShareAuto.java fails with RuntimeException 'sharing' found in stderr
Reviewed-by: hseigel, lfoltan, coleenp, dholmes
2014-06-22 21:23:32 -04:00
George Triantafillou
32cd848b56 8038074: [TESTBUG] Add test for anewarray instruction with more than 255 dimensions
Reviewed-by: lfoltan, coleenp
2014-06-20 10:12:02 -07:00
Daniel D. Daugherty
833620662c 8046287: [TESTBUG] runtime/Thread/TestThreadDumpMonitorContention.java failed error_cnt=12
Added a new header waiting pattern to catch the case where the target thread waiting on a condition (like a VM op); several other test improvements

Reviewed-by: sspitsyn, dholmes
2014-06-12 15:57:16 -07:00
Harold Seigel
70c76ec8c4 8044738: Check attribute_length of EnclosingMethod attribute
Add check that attribute_length == 4.

Reviewed-by: fparain, coleenp, lfoltan
2014-06-10 14:04:37 -04:00
Mikhailo Seledtsov
36d332413d 8038587: [TESTBUG] Create CDS tests to exercise region sizes and base address
Added new tests to cover missing CDS basic funtions

Reviewed-by: coleenp, ctornqvi
2014-06-02 21:36:59 -04:00
Christian Tornqvist
fd282f6e9a 8044364: runtime/RedefineFinalizer test fails on windows
Rewrote the test in pure Java, added RedefineClassHelper utility class

Reviewed-by: coleenp, allwin, gtriantafill, dsamersoff
2014-06-02 19:08:18 +02:00
Coleen Phillimore
3656168efc Merge 2014-06-01 11:56:15 -04:00
Christian Thalinger
8f1c6dfff7 Merge 2014-05-30 09:49:53 -07:00
Daniel D. Daugherty
ad6d8d6abd 8036823: Stack trace sometimes shows 'locked' instead of 'waiting to lock'
Add a !owner check for 'waiting to lock' to catch current_pending_monitor corner cases.

Co-authored-by: Krystal Mok <rednaxelafx@gmail.com>
Co-authored-by: Zhengyu Gu <zhengyu.gu@oracle.com>
Reviewed-by: dholmes, sspitsyn, kmo, zgu
2014-05-30 07:20:51 -07:00
Christian Tornqvist
436e1ecdf2 8043786: [TESTBUG] runtime/CommandLine/TestHexArguments.java test fails in nightly
Changed test to not pass on external flags to child processes

Reviewed-by: coleenp, hseigel
2014-05-28 22:59:29 +02:00
Dmitry Samersoff
c291efb1df 6904403: assert(f == k-&gt;has_finalizer(),&quot;inconsistent has_finalizer&quot;) with debug VM
Don't assert if one of classes in hierarhy was redefined

Reviewed-by: coleenp, sspitsyn
2014-05-28 07:36:32 -07:00
Kirill Shirokov
20674a667a 8032970: Add stack size check methods to WhiteBox API
Reviewed-by: twisti, kvn, iignatyev
2014-05-24 00:04:21 +04:00
Dmitry Samersoff
e70b7ac623 8042155: [TESTBUG] Tests for stack guard pages have to be cleaned up
Tests for 6929067 and 8009062 should be composed to single test that provide better testing for stack guard pages behaviour

Reviewed-by: coleenp, dcubed, dsimms
2014-05-22 13:22:09 -07:00
Yumin Qi
ec3e742de1 8042885: java does not take hexadecimal number as vm option
Java does not take number with hexadecimal format as options, fix enable hexadecimal format number can be used as vm option.

Reviewed-by: coleenp, lfoltan, ctornqvi, hseigel, mseledtsov
2014-05-15 20:16:14 -07:00
Lois Foltan
ca501f6b00 8041918: BootstrapMethods attribute cannot be empty
Allow a BootstrapMethods attribute that contains an empty bootstrap_methods table where num_bootstrap_methods is equal to zero.

Reviewed-by: coleenp, hseigel
2014-05-15 09:25:27 -04:00
Christian Tornqvist
d8ec75da34 8042595: [TESTBUG] runtime/7110720/Test7110720.sh rarely fails with message "explicit compiler command file not read"
Removed the shell test and moved the testcases into the already existing Java based tests

Reviewed-by: coleenp, lfoltan
2014-05-14 18:18:58 +02:00
Mikhailo Seledtsov
6e58e65cf7 8041938: [TESTBUG] runtime/SharedArchiveFile/CdsWriteError.java failed in RT_Baseline with 'Unable to create shared archive file' missing from stdout/stderr
His test is unstable in automated testing system, team agreed to remove it

Reviewed-by: coleenp, gtriantafill
2014-05-14 10:38:40 -04:00
Harold Seigel
976e7c8aa7 8040292: Annotation attributes must not appear more than once
Add checks for duplicate attributes.

Reviewed-by: coleenp, lfoltan
2014-05-12 13:12:30 -04:00
Coleen Phillimore
7e2463ea72 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Cache detail message when we cache exception for constant pool resolution.

Reviewed-by: acorn, twisti, jrose
2014-05-05 19:53:00 -04:00
Harold Seigel
cfa7d828d9 8040018: Remove bad assert in ClassFileParser.cpp
Remove assert that prevent throwing valid exception

Reviewed-by: coleenp, lfoltan
2014-04-18 08:51:34 -04:00
Christian Tornqvist
db9dcbd63b 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java
Removed test/runtime/6925573/SortMethodsTest.java

Reviewed-by: coleenp, rdurbin
2014-04-18 00:19:24 +02:00
Christian Tornqvist
961a489536 6959423: [TESTBUG] runtime/6925573/SortMethodsTest.java times out
Decreased maximum number methods in generated classes and decreased ratio to make it reproduce more often

Reviewed-by: coleenp, lfoltan
2014-04-17 00:03:58 +02:00
Christian Tornqvist
ff48970954 8035173: [TESTBUG] runtime/threads/CancellableThreadTest fails with OOM on windows-i586
Test ported to jtreg, thread pairs decreased from 1024 to 128 to avoid OOM on 32 bit Windows

Reviewed-by: sla, dsimms
2014-04-15 19:03:51 +02:00
Lois Foltan
5ca274e0ce 8038076: constraint on multianewarray instruction is not checked since class version 50
No VerifiyError generated if multianewarray bytecode's array type descriptor was 1 dimension smaller than dimensions specified.

Reviewed-by: hseigel, ctornqvi, coleenp, kamg
2014-04-14 10:13:03 -04:00
Dmitry Samersoff
b1295fc704 Merge 2014-04-09 15:01:24 +00:00
Dmitry Samersoff
f359b1fb2c 8029139: [TESTBUG] runtime/InitialThreadOverflow/testme.sh fails with exit code 127
The test launcher compiles against TESTJAVA but LD_LIBRARY_PATH set to COMPILE java.

Reviewed-by: sla, sspitsyn
2014-04-09 07:08:08 -07:00
Dmitry Samersoff
0301b791ef 8037279: runtime/6929067/Test6929067.sh crashes on 32bit linux
The test compile launcher with TESTJAVA but attempt to load vm from COMPILEJAVA

Reviewed-by: sla, sspitsyn
2014-04-09 06:09:43 -07:00
Christian Tornqvist
3c7ebc1745 8028733: [TESTBUG] Remove test exclusion for runtime/6626217/Test6626217.sh
Removed @ignore tag from Test6626217.sh, the fix for 7015395 had already solved the issue but left the @ignore tag

Reviewed-by: sla, lfoltan, gtriantafill
2014-04-02 14:15:39 +02:00
Christian Tornqvist
c3c7dcd507 7049895: [TESTBUG] vmerrors.sh should suppress windows .mdmp files
Added -XX:-CreateMinidumpOnCrash to vmerror.sh to suppress creation of dumps on Windows

Reviewed-by: coleenp, allwin, zgu
2014-04-01 22:39:09 +02:00
Christian Tornqvist
0b0fdb97ce 8007890: [TESTBUG] JcmdWithNMTDisabled.java fails when invoked with NMT explicitly turned on
Wrapped the test in another layer process creation to avoid NMT being turned on.

Reviewed-by: coleenp, dcubed
2014-03-27 22:36:08 +01:00
Mikhailo Seledtsov
3c58faecfe 8032222: [TESTBUG] runtime/SharedArchiveFile/CdsWriteError.java fails on Mac OS with java.lang.RuntimeException
Excluded the test from running on Mac OS

Reviewed-by: coleenp, ctornqvi
2014-03-25 09:26:18 -04:00
Mikhailo Seledtsov
ce25911489 8026154: [TESTBUG] runtime/CDSCompressedKPtrs/XShareAuto.java failed due to exception
Added statements in the tests to handle failures in sharing

Reviewed-by: zgu, ctornqvi
2014-03-10 14:50:20 -04:00
Coleen Phillimore
e8d4b7aee3 8036547: test/runtime/CompressedOops/CompressedClassPointers.java fails with product build since -XX:+PrintMiscellaneous is a debug only flag
Use PrintCompressedOopsMode and these other flags that match printing compressed oop information

Reviewed-by: ctornqvi, sla
2014-03-04 09:57:16 -05:00
Staffan Larsen
1d81fd35d6 8036010: hs: Some jtreg tests use hard coded ports
Bind to an ephemeral port

Reviewed-by: jbachorik, sla
2014-02-28 14:30:25 +04:00
Calvin Cheung
bfbc3a0d51 8025519: [TESTBUG] runtime/7107135/Test7107135.sh need to use COMPILEJAVA for javac task
Modified some tests to use COMPILEJAVA instead of TESTJAVA for javac and include path

Reviewed-by: dholmes, mseledtsov
2014-02-24 21:54:22 -08:00
George Triantafillou
70c77b3470 8034898: [TESTBUG]: Zero failure project - tag all Runtime JTReg bugs that fail nightly
Use @ignore to exclude failing tests

Reviewed-by: coleenp, ctornqvi, mseledtsov
2014-02-20 16:38:45 -05:00
Coleen Phillimore
a9868648e6 7014526: "java -version" crash on sparc with some values of HeapBaseMinAddress
Make default HeapBaseMinAddress the minimum that can be specified.

Reviewed-by: minqi, kvn, tschatzl, dholmes
2014-02-19 02:58:13 +00:00