Commit Graph

226 Commits

Author SHA1 Message Date
Rahul Yadav
c5a7490809 8240921: Minor correction to HttpResponse.BodySubscribers example
The fix updates the incorrect example of the usage of the class java.net.http.HttpResponse.BodySubscribers.

Reviewed-by: chegar, dfuchs, jboes, pconcannon
2020-03-20 20:16:34 +00:00
Daniel Fuchs
58337b12f8 8059309: network tests fail with "java.net.SocketException: Couldn't obtain phys addr" when run as "root"
The solaris specific code is changed to use the fallback mechanism if the DLPI interface returns an error indicating that the operation is unsupported. In addition, NetworkInterface::getHardwareAddress is changed to always return null for the loopback interface.

Reviewed-by: alanb
2020-03-12 18:31:49 +00:00
Patrick Concannon
0ed44d0aee 8239355: (dc) Initial value of SO_SNDBUF should allow sending large datagrams (macOS)
Updates DatagramChannel so that the SO_SNDBUF is set to a minimum value of 65527 for IPv6 sockets and 65507 for IPv4 sockets on macOS.

Reviewed-by: alanb, dfuchs
2020-03-12 17:08:09 +00:00
John Jiang
edaf548beb 8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify a TLS protocol
Reviewed-by: dfuchs
2020-03-10 21:43:46 +08:00
Daniel Fuchs
5c8f935641 8240754: Instrument FlowTest.java to provide more debug traces
Reviewed-by: chegar
2020-03-09 17:48:40 +00:00
Ravi Reddy
b2f1f73e75 8183369: RFC unconformity of HttpURLConnection with proxy
HttpURLConnection retried with proxy if the connection fails on first attempt as per RFC

Reviewed-by: chegar, dfuchs, vtewari
2020-03-05 03:27:17 -05:00
Daniel Fuchs
f7c819a72d 8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java failed with BufferUnderflowException against TLSv1.3
The test assumed that ByteBuffer would be split at long boundaries. This is obviously not always the case. A carry has been added to support reading a long split over several buffers.

Reviewed-by: chegar
2020-02-24 17:19:32 +00:00
Daniel Fuchs
f40220f578 8238990: java/net/httpclient/HandshakeFailureTest.java failed against TLSv1.3 on Windows
The SSLTube and SSLFlowDelegate are improved to wrap any non-SSL exception that occur during the handshake in an SSLHandshakeException.

Reviewed-by: chegar
2020-02-20 20:04:15 +00:00
John Jiang
446f59a26c 8234718: java/net/httpclient tests should cover TLSv1.3
Reviewed-by: dfuchs
2020-02-13 21:42:31 +08:00
John Jiang
fbca3fa710 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version
Reviewed-by: dfuchs
2020-02-11 08:36:02 +08:00
Patrick Concannon
00c40ae1e3 7021373: DatagramPacket exception conditions are not clear
Specification is clarified by adding or clarifying @throws clauses where required

Reviewed-by: alanb, chegar, darcy, dfuchs
2020-02-07 11:10:41 +00:00
Daniel Fuchs
b069da31e0 8238231: Custom DatagramSocketImpl's create method not called when with protected constructor
Allow the socket to be lazily created if not created by the constructor.

Reviewed-by: alanb
2020-02-04 18:35:37 +00:00
Mikael Vidstedt
3318314c7c 8237589: Fix copyright header formatting
Reviewed-by: jjg, serb, iris, jwilhelm
2020-01-21 14:23:01 -08:00
Patrick Concannon
d2cd7a5096 8237571: java/net/DatagramSocket/SendCheck.java is failing on Solaris
Commented out failing testcase as this is being tracked by JDK-8236852

Reviewed-by: dfuchs
2020-01-21 18:38:46 +00:00
Patrick Concannon
2f76772fa9 8236105: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent
DatagramSocket and MulticastSocket changed to throw IllegalArgumentException if not connected and passed a packet containing a port out of range

Reviewed-by: chegar, dfuchs
2020-01-20 16:24:05 +00:00
Daniel Fuchs
c6da6681d4 8236859: WebSocket over authenticating proxy fails with NPE
This change fixes several issues with WebSocket and proxy authentication. The AuthenticationFilter is changed to support an authenticating server accessed through an authenticating proxy. MultiExchange is fixed to close the previous connection if a new connection is necessary to establish the websocket (websocket connections are not cached and must be closed in that case). WebSocket OpeningHandshake is fixed to close the connection (without creating the RawChannel) if the opening handshake doesn't result in 101 upgrade protocol.

Reviewed-by: prappo, chegar
2020-01-17 17:55:06 +00:00
Jesper Wilhelmsson
257a1bb854 Merge 2020-01-08 16:03:32 +01:00
Chris Hegarty
417672bc9d 8236441: Bound MulticastSocket fails when setting outbound interface on Windows
Reviewed-by: alanb
2019-12-23 09:17:00 +00:00
Kiran Sidhartha Ravikumar
a1b2e1042c 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences
Reviewed-by: chegar, dfuchs
2019-12-17 16:06:27 +00:00
Daniel Fuchs
e16d4a45b0 8235925: java/net/Socket/HttpProxy.java fails on IPv4 only hosts and other small cleanups
HttpProxy test is fixed to take into account the possibility that the host may be configured with IPv4 only

Reviewed-by: chegar
2019-12-17 16:11:16 +01:00
Daniel Fuchs
7135b5dd9c 8235141: Specify the required standard socket options for the socket types in the java.net package
Reviewed-by: alanb, chegar
2019-12-10 13:22:52 +00:00
Patrick Concannon
22e26b2a81 8234148: DatagramSocket.setOption/getOption/supportedOption should support multicast options
Fix adds multicast socket options to DatagramSocket

Reviewed-by: alanb, dfuchs, vtewari
2019-12-09 14:25:37 +00:00
Julia Boes
07fc539a85 8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException
Increase the number of bind retries and test repeats, best effort only

Reviewed-by: msheppar, dfuchs, vtewari
2019-12-09 12:46:12 +00:00
Michael McMahon
a2fad13ce2 8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10
Reviewed-by: alanb
2019-12-03 11:55:47 +00:00
Patrick Concannon
55da7d34c9 8233307: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set
The MulticastSocket method getOption has been changed to conform to the behavior described in StandardSocketOptions.IP_MULTICAST_IF.

Reviewed-by: chegar, dfuchs
2019-11-28 16:49:52 +00:00
Patrick Concannon
b9c7a608d2 8233018: Add a new test to verify that DatagramSocket is not interruptible
Test added to check the interruptability of DatagramSocket, MulticastSocket and DatagramSocketAdaptor.

Reviewed-by: chegar, dfuchs
2019-11-27 16:01:34 +00:00
Daniel Fuchs
8333ea85fa 8233296: MulticastSocket getOption/setOption inverts the value of IP_MULTICAST_LOOP
MulticastSocket.getOption(StandardSocketOption.IP_MULTICAST_LOOP) now returns true if loopback mode is enabled, and MulticastSocket.setOption(StandardSocketOption.IP_MULTICAST_LOOP, true) enables loopback mode. No other behavioral changes.

Reviewed-by: alanb, chegar
2019-11-22 11:52:48 +00:00
Patrick Concannon
6a7f775347 8234083: DatagramSocket should report SO_BROADCAST as a supported option
DatagramSocket had a setBroadcast and getBroadcast setter/getter pair but curiously didn't report SO_BROADCAST as a supported option. Note: the source code changes were accidentally pushed with 8234103 so this changeset only has the test changes. The reviewers listed below had already reviewed the full (source+test) changes.

Reviewed-by: alanb, vtewari, chegar
2019-11-21 16:33:00 +00:00
Chris Hegarty
262d5f1790 8232101: (sctp) Add minimal sanity tests for SCTP
Reviewed-by: alanb
2019-11-21 12:14:26 +00:00
Daniel Fuchs
be18a54cb1 8233141: DatagramSocket.send doesn't specify exception thrown when no target address
DatagramSocket and MulticastSocket send methods are changed to throw IllegalArgumentException if no target address can be determined.

Reviewed-by: alanb
2019-11-18 16:48:05 +00:00
Patrick Concannon
78accb5602 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java
This fix adds an IPv4 version of test SetLoopbackMode.java that calls SetLoopbackMode in IPv4 only mode, and runs only if IPv4 is enabled.

Reviewed-by: dfuchs
2019-11-14 11:04:57 +00:00
Patrick Concannon
11433529aa 8233860: AfterClose.java test incorrectly handles IP_MULTICAST_IF
Correction to invalid value used to ensure test fails as expected.

Reviewed-by: alanb, dfuchs, vtewari
2019-11-14 10:49:20 +00:00
Julia Boes
d948bfd584 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException
Change implementation to use iterator instead of plain LinkedList

Reviewed-by: dfuchs, vtewari
2019-11-08 11:15:16 +00:00
Ivan Gerasimov
43368f8f9f 8233886: TEST_BUG jdk/java/net/CookieHandler/B6791927.java hit hardcoded expiration date
Reviewed-by: chegar, vtewari
2019-11-11 05:09:31 -08:00
Daniel Fuchs
eaba9fe23b 8233403: Improve verbosity of some httpclient tests
Improve the verbosity of some httpclient tests to help diagnosis of intermittent failures. Also fixes ShortRequestBody test.

Reviewed-by: chegar
2019-11-07 16:18:02 +00:00
Chris Hegarty
9f6af13f9d 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3
Reviewed-by: dfuchs
2019-11-04 10:06:59 +00:00
Julia Boes
012dffcd27 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact
Modified method description to disambiguate when false is returned and altered implementation

Reviewed-by: dfuchs, chegar, vtewari
2019-11-01 12:57:01 +00:00
Daniel Fuchs
b3477399d0 8232625: HttpClient redirect policy should be more conservative
When enabled, HttpClient redirect is fixed to drop the body when the request method is changed, and to relay any redirection code it does not understand to the caller.

Reviewed-by: chegar
2019-10-23 15:54:39 +01:00
Julia Boes
f8440c33d2 8225499: InetSocketAddress::toString not friendly to IPv6 literal addresses
Enclose IPv6 literal in brackets and adjust string format for unresolved addresses

Reviewed-by: dfuchs, chegar
2019-10-17 08:56:06 +01:00
Ivan Gerasimov
31afddccae 8230407: SocketPermission and FilePermission action list allows leading comma
Co-authored-by: Chris Hegarty <chris.hegarty@oracle.com>
Reviewed-by: chegar
2019-10-16 14:32:17 -07:00
Daniel Fuchs
ecde34ee35 8231449: HttpClient’s client ssl certificate authentication seems to be broken
SSLFlowDelegate.Reader and SubscriberWrapper are changed to better cooperate on when more demand should be requested from upstream. The issue encountered in this scenario was triggered by a large certificate which caused the SSLFlowDelegate to stop requesting data from upstream during the handshake although the engine handshake status was NEED_UNWRAP.

Reviewed-by: chegar
2019-10-16 14:50:53 +01:00
Patrick Concannon
dcceed10b6 8222829: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative
Clarifies behaviour of setSoTimeout() method when given negative timeout value.

Reviewed-by: alanb, chegar, dfuchs
2019-10-08 15:03:20 +01:00
Daniel Fuchs
8e98ce54bf 8231506: Fix some instabilities in a few networking tests
Reviewed-by: alanb, chegar, msheppar
2019-10-01 12:10:33 +01:00
Daniel Fuchs
8578ab1c23 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed
The test is updated to verify whether reverse lookup is altogether possible.

Reviewed-by: chegar
2019-09-27 14:43:35 +01:00
Chris Hegarty
0b881387f2 8231504: Update networking tests to avoid implicit dependency on the system proxies
Reviewed-by: dfuchs
2019-09-27 09:55:35 +01:00
Patrick Concannon
11d43732bc 8217825: Verify @AfterTest is used correctly in WebSocket tests
Remove @AfterTest tags; added in explicit closing of resources e.g. httpServer, webSocket, etc

Reviewed-by: dfuchs, prappo
2019-09-23 16:53:16 +01:00
Daniel Fuchs
e9eaba3d53 8230858: Replace wildcard address with loopback or local host in tests - part 23
Add new traces for better diagnosis, refrain binding to the wildcard address when possible.

Reviewed-by: chegar, xuelei
2019-09-12 15:46:11 +01:00
Daniel Fuchs
10e4fd4b95 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient
Fixed the PlainProxyConnection lookup key.

Reviewed-by: chegar
2019-09-09 18:23:39 +01:00
Patrick Concannon
1f87cb017f 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface
The test is updated to skip Teredo pseudo interfaces on windows.

Reviewed-by: michaelm, vtewari, aefimov
2019-09-09 16:13:43 +01:00
Daniel Fuchs
f71db3074c 8230435: Replace wildcard address with loopback or local host in tests - part 22
Fixes tests to use the loopback address whenever possible. It also fixes some safe publishing issues, or add diagnostics in some of the tests.

Reviewed-by: michaelm
2019-09-04 18:10:07 +01:00