Commit Graph

870 Commits

Author SHA1 Message Date
Maurizio Cimadamore
a4e10d2aad 8009459: Wrong behavior of diamond finder with source level 7
Diamond finder doesn't take into account different inference behaviors

Reviewed-by: jjg
2013-03-06 15:33:17 +00:00
Maurizio Cimadamore
c9bae7b335 8009299: Javac crashes when compiling method reference to static interface method
Assertion in Check.checMethod is too strict

Reviewed-by: jjg
2013-03-06 15:29:30 +00:00
Maurizio Cimadamore
e788a0e536 8009129: Illegal access error when calling method reference
Javac generates method handle referencing non public type

Reviewed-by: jjg, rfield
2013-03-05 14:19:49 +00:00
Maurizio Cimadamore
7a28d6291d 8009154: Missing cast in method reference bridge leads to NoSuchMethodError
Missing cast in generated method reference bridge

Reviewed-by: rfield, jjg
2013-03-05 14:16:07 +00:00
Maurizio Cimadamore
3cbe22f256 8009227: Certain diagnostics should not be deferred
Add new diagnostic flag to mark non deferrable diagnostics

Reviewed-by: jjg
2013-03-05 14:12:07 +00:00
Maurizio Cimadamore
d0a0df54ed 8004962: Code generation crash with lambda and local classes
Translation info should be propagated from LambdaToMethod to Lower

Reviewed-by: jjg, rfield
2013-03-05 14:04:57 +00:00
Jonathan Gibbons
6c39105c60 8008949: javadoc stopped copying doc-files
Reviewed-by: bpatel
2013-03-01 10:47:39 -08:00
Maurizio Cimadamore
f932d844c1 8008537: Missing method reference lookup error when unbound search finds a static method
Static-ness check should be applied after member reference resolution

Reviewed-by: jjg
2013-02-28 14:05:52 +00:00
Maurizio Cimadamore
85067f7869 8008813: Structural most specific fails when method reference is passed to overloaded method
Bad logic for checking most specific method reference type

Reviewed-by: jjg
2013-02-28 14:05:44 +00:00
Maurizio Cimadamore
9c01455eb6 8008723: Graph Inference: bad graph calculation leads to assertion error
Dependencies are not propagated correctly through merged nodes during inference graph initialization

Reviewed-by: jjg
2013-02-28 14:00:52 +00:00
Vicente Romero
9f2721bfb1 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
Reviewed-by: jjg, mcimadamore
2013-02-26 09:04:19 +00:00
Jan Valenta
63fe735683 7112427: The doclet needs to be able to generate JavaFX documentation
Reviewed-by: jjg
2013-02-24 11:36:58 -08:00
Maurizio Cimadamore
7776fdebe7 8008708: Regression: separate compilation causes crash in wildcards inference logic
Invalid use of WildcardType.bound in Types.removeWildcards

Reviewed-by: jjg
2013-02-22 18:19:51 +00:00
Sonali Goel
96495bc664 8008337: Write test to check for compiler error when static method in interface is called via super()
Reviewed-by: mcimadamore
2013-02-22 13:31:35 +00:00
Lana Steuck
3c22954800 Merge 2013-02-21 17:49:56 -08:00
Eric Mccorkle
e84b39e459 8008658: Four new method param jtreg tests fail in nightly tests
Reviewed-by: jjg, ksrini, mcimadamore
2013-02-21 12:23:27 -08:00
Robert Field
bcaa703a49 8008405: Now that metafactory is in place, add javac lambda serialization tests
Tests part of original langtools serialization review.

Reviewed-by: mcimadamore
2013-02-21 14:43:51 -08:00
Maurizio Cimadamore
73b1aee3f4 8008444: Inherited generic functional descriptors are merged incorrectly
Missing call to Types.createMethodWithThrownTypes

Reviewed-by: jjg
2013-02-21 15:27:05 +00:00
Maurizio Cimadamore
6fd868a306 8007461: Regression: bad overload resolution when inner class and outer class have method with same name
Fix regression in varargs method resolution introduced by bad refactoring

Reviewed-by: jjg
2013-02-21 15:26:46 +00:00
Maurizio Cimadamore
8c1621ee38 8008293: Declared bounds not considered when functional interface containing unbound wildcards is instantiated
Wildcards inference should re-use some of the bounds info generated during capture conversion

Reviewed-by: jjg
2013-02-21 15:25:03 +00:00
Maurizio Cimadamore
5bbf5f39fc 8005183: Missing accessor for constructor reference pointing to private inner class ctor
Compiler should add bridges when translating private constructor reference

Reviewed-by: jjg
2013-02-21 15:23:48 +00:00
Maurizio Cimadamore
937b7d2fba 8008276: assertion error in com.sun.tools.javac.comp.TransTypes.visitApply
DiagnosticFilter used during speculative attribution is too broad

Reviewed-by: jjg
2013-02-21 15:21:38 +00:00
Maurizio Cimadamore
eb68b33185 8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler
Disentangle cyclic dependency between static-ness of synthetic lambda method and static-ness of classes nested within lambdas

Reviewed-by: jjg
2013-02-21 15:19:29 +00:00
Peter Jensen
556f6dfebb 8006582: Test for parameter names feature
Reviewed-by: jjg, darcy, emc
2013-02-20 15:47:14 -08:00
Vicente Romero
68a3295c8b 8006212: javac, convert jtreg tests from shell script to java
Reviewed-by: jjg
2013-02-19 17:53:16 +00:00
Jonathan Gibbons
971f247b1b 8008339: Test TargetAnnoCombo.java is broken
Reviewed-by: jjh
2013-02-18 14:29:40 -08:00
Vicente Romero
e6b61ae08a 6563143: javac should issue a warning for overriding equals without hashCode
Reviewed-by: jjg, mcimadamore
2013-02-18 14:33:25 +00:00
David Holmes
e57875e8ab Merge 2013-02-17 16:44:55 -05:00
Robert Field
b2a3c762ff 8004969: Generate $deserializeLambda$ method
8006763: super in method reference used in anonymous class - ClassFormatError is produced
8005632: Inner classes within lambdas cause build failures
8005653: Lambdas containing inner classes referencing external type variables do not correctly parameterize the inner classes

Reviewed-by: mcimadamore
2013-02-15 18:40:38 -08:00
Jonathan Gibbons
ff25ecbcbb 8008313: 8007052 breaks test/tools/javap/MethodParameters.java
Reviewed-by: darcy
2013-02-15 11:26:11 -08:00
Maurizio Cimadamore
fd17a4290b 8008309: TargetType60 fails because of bad golden file
Bad golden file

Reviewed-by: jjg
2013-02-15 18:13:00 +00:00
Maurizio Cimadamore
b9a88adb02 Merge 2013-02-15 16:37:19 +00:00
Sonali Goel
30058417e1 8007427: Annotation element as '_' gives compiler error instead of a warning
8007401: Write test to check for generation of warnings when '_' is used as an identifier

Extended identifier production not used in annotation values

Reviewed-by: jjg
2013-02-15 16:31:19 +00:00
Maurizio Cimadamore
f5df2a2562 8007535: Compiler crashes on @FunctionalInterface used on interface with two inherited methods with same signatures
Bad check in Types.interfaceCandidates

Reviewed-by: jjg
2013-02-15 16:30:31 +00:00
Maurizio Cimadamore
b496912ee1 8007462: Fix provisional applicability for method references
Add speculative arity-based check to rule out potential candidates when stuck reference is passed to method

Reviewed-by: jjg
2013-02-15 16:29:58 +00:00
Maurizio Cimadamore
e88e06a5e0 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
Missing abstractness check on super rmethod references

Reviewed-by: jjg
2013-02-15 16:28:57 +00:00
Jonathan Gibbons
a695bef890 8007052: javap should include the descriptor for a method in verbose mode
Reviewed-by: mcimadamore
2013-02-15 08:28:42 -08:00
Maurizio Cimadamore
f8f9896cc7 8006749: compiler does not allow Object protected methods to be used in lambda
Check.checkFunctionalInterface should take into account 'fake' override

Reviewed-by: jjg
2013-02-15 16:28:07 +00:00
Mandy Chung
ee65d32c20 8006225: tools/jdeps/Basic.java failes with AssertionError
Reviewed-by: alanb
2013-02-14 09:43:00 -08:00
Sonali Goel
2fb38081d5 8001457: New tests needed for library-side changes for repeating annotations
Reviewed-by: darcy
2013-02-13 23:05:17 -08:00
Joel Borggrén-Franck
14c0c8eed8 8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class)
Reviewed-by: darcy, abuckley
2013-02-13 10:33:13 +01:00
Werner Dietl
464abcb4fa 8008077: update reference impl for type-annotations
Reviewed-by: jjg
2013-02-12 17:15:29 -08:00
Maurizio Cimadamore
1ec5dfafe0 8007464: Add graph inference support
Add support for more aggressive type-inference scheme

Reviewed-by: jjg
2013-02-12 19:25:09 +00:00
Vicente Romero
9bdfca5e56 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null
Reviewed-by: jjg
2013-02-12 13:36:56 +00:00
Matherey Nunez
024075fabb 8004822: RFE to write language model API tests for repeating annotations based on the spec updates
Reviewed-by: jjg, abuckley
2013-02-12 11:28:45 +01:00
Joe Darcy
44e3518c32 8007574: Provide isFunctionalInterface in javax.lang.model
Reviewed-by: jjg
2013-02-11 13:37:41 -08:00
Jonathan Gibbons
b30e5c6313 8007610: javadoc doclint does not work with -private
Reviewed-by: darcy
2013-02-08 17:35:16 -08:00
Vicente Romero
59318f1b2e 7167125: Two variables after the same operation in a inner class return different results
Reviewed-by: jjg, mcimadamore
2013-02-08 09:21:19 +00:00
Vicente Romero
561631ea44 8005931: javac doesn't set ACC_STRICT for classes with package access
Reviewed-by: mcimadamore
2013-02-08 09:15:27 +00:00
Vicente Romero
bba9417038 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
Reviewed-by: mcimadamore
2013-02-08 09:12:37 +00:00
Sonali Goel
f1442d8261 7195131: Update 2 compiler combo tests for repeating annotations to include package and default use cases
Reviewed-by: darcy
2013-02-07 20:47:06 -08:00
Jim Holmlund
c88c3bb683 8007698: jtreg test T6306137.java won't compile with ASCII encoding
Reviewed-by: ksrini
2013-02-06 23:10:35 +00:00
Jonathan Gibbons
305cf1f98b 8007566: DocLint too aggressive with not allowed here: <p>
Reviewed-by: mcimadamore
2013-02-06 07:49:31 -08:00
Maurizio Cimadamore
0336a57511 8007463: Cleanup inference related classes
Make Infer.InferenceContext an inner class; adjust bound replacement logic in Type.UndetVar

Reviewed-by: jjg
2013-02-06 14:03:39 +00:00
Jonathan Gibbons
23ca241597 8007485: test creates .class files in the test/ directory
Reviewed-by: mcimadamore
2013-02-05 21:55:41 -08:00
Jim Holmlund
8985a7c2ac 8007504: Remove @ignore from tests that no longer need it
Reviewed-by: mcimadamore
2013-02-05 18:55:13 +00:00
Jonathan Gibbons
4d8014cefa 8007490: NPE from DocumentationTool.run
Reviewed-by: darcy
2013-02-04 15:30:10 -08:00
David Holmes
581f36e1cc Merge 2013-02-04 18:08:53 -05:00
Vicente Romero
a4a897ce52 7199823: javac generates inner class that can't be verified
Reviewed-by: jjg, mcimadamore
2013-02-03 02:31:30 +00:00
Jonathan Gibbons
8f90cd0025 8007344: javac may not make tree end positions and/or doc comments available to processors and listeners
Reviewed-by: darcy
2013-02-01 12:01:03 -08:00
Jonathan Gibbons
7ee6242d0c 8007305: DPrinter: provide better usage message
Reviewed-by: mcimadamore
2013-02-01 08:36:15 -08:00
Jonathan Gibbons
81e9d881ca 8007306: DPrinter: improve display of impl-class, internal tag/kind, and external tag/kind
Reviewed-by: mcimadamore
2013-02-01 08:33:48 -08:00
Joe Darcy
71b457cb97 8007351: Malformed copyright statements in typeAnnotations test directory
Reviewed-by: jjg
2013-01-31 18:58:17 -08:00
Joe Darcy
4484857b50 8007313: Remove use of {ContainerFor/ContainedBy} from langtools
Reviewed-by: jjg
2013-01-31 12:16:03 -08:00
Jonathan Gibbons
c3cd43825b 8007034: debug printer for javac internals
Reviewed-by: mcimadamore
2013-01-30 09:47:12 -08:00
Jonathan Gibbons
ebc0ebf54d 8007096: DocLint parsing problems with some comments
Reviewed-by: mcimadamore
2013-01-30 09:40:54 -08:00
Vicente Romero
b5148d30e2 8006944: javac, combo tests should print out the number of threads used
Reviewed-by: mcimadamore
2013-01-27 19:38:44 +00:00
Michael Ernst
659a96edf9 8006775: JSR 308: Compiler changes in JDK8
Co-authored-by: Werner Dietl <wmdietl@cs.washington.edu>
Co-authored-by: Matt Papi <mpapi@csail.mit.edu>
Co-authored-by: Mahmood Ali <mahmood@notnoop.com>
Reviewed-by: jjg
2013-01-23 13:27:24 -08:00
Maurizio Cimadamore
5b1a78dc92 8006694: temporarily workaround combo tests are causing time out in several platforms
Reviewed-by: jjg
2013-01-23 20:57:40 +00:00
Maurizio Cimadamore
eb646f3c09 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile
Missing boxing cause spurious inference failure

Reviewed-by: jjg
2013-01-23 15:08:03 +00:00
Jonathan Gibbons
ef9719425e Merge 2013-01-22 19:07:20 -08:00
Jonathan Gibbons
cac8147988 8006728: temporarily workaround jtreg problems for doclint tests in othervm
Reviewed-by: jjh
2013-01-22 19:06:05 -08:00
Jonathan Gibbons
7bdddc8471 8006723: sjavac test fails to compile on clean build
Reviewed-by: ksrini
2013-01-22 18:43:22 -08:00
Maurizio Cimadamore
1f8b2abf80 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack
Lambda desugaring generates spurious references to 'this' in static contexts

Reviewed-by: jjg
2013-01-22 16:39:51 +00:00
Maurizio Cimadamore
948888218b 8006673: TargetType52 fails because of bad golden file
Fix golden file in negative test

Reviewed-by: jjg
2013-01-22 16:23:35 +00:00
Maurizio Cimadamore
3054ea5580 8005166: Add support for static interface methods
Support public static interface methods

Reviewed-by: jjg
2013-01-21 20:19:53 +00:00
Maurizio Cimadamore
a6fc182d40 8005851: Remove support for synchronized interface methods
Synchronized default methods are no longer supported

Reviewed-by: jjg
2013-01-21 20:15:16 +00:00
Maurizio Cimadamore
422c8bd914 8006566: Remove transient lambda-related guards from JavacParser
Remove transitional internal flag for allowing intersection types in cast

Reviewed-by: jjg
2013-01-21 20:14:39 +00:00
Maurizio Cimadamore
442154dcf9 8005244: Implement overload resolution as per latest spec EDR
Add support for stuck expressions and provisional applicability

Reviewed-by: jjg
2013-01-21 20:13:56 +00:00
Jonathan Gibbons
f251cc24ca 8006251: doclint: incorrect position for diagnostic for illegal text in tags
Reviewed-by: mcimadamore
2013-01-21 10:07:37 -08:00
Peter Jensen
7967c92db0 8006263: Supplementary test cases needed for doclint
Reviewed-by: mcimadamore
2013-01-21 10:00:46 -08:00
Jonathan Gibbons
caf667de05 8004182: Add support for profiles in javac
Reviewed-by: mcimadamore
2013-01-21 01:27:42 -05:00
Bhavesh Patel
bd4ebc07d8 8006124: javadoc/doclet should be updated to support profiles
Reviewed-by: jjg
2013-01-21 00:45:35 -05:00
Maurizio Cimadamore
00ae27b2cf 8006561: Langtools test failure: missing diags/examples
Forgot to hg add tests

Reviewed-by: jjg
2013-01-18 15:38:14 +00:00
Fredrik Öhrström
3d5f55b851 8004658: Add internal smart javac wrapper to solve JEP 139
Reviewed-by: jjg
2013-01-18 00:16:21 +01:00
Maurizio Cimadamore
0a95b1d28c 8005852: Treatment of '_' as identifier
Warn when '_' is found in an identifier position

Reviewed-by: jjg
2013-01-17 18:15:20 +00:00
Jonathan Gibbons
7b493a180e 8006228: Doclint doesn't detect <code> {@code nested inline} </code>
Reviewed-by: darcy
2013-01-16 20:41:14 -08:00
Jonathan Gibbons
17ebfc350d 8006236: doclint: structural issue hidden
Reviewed-by: darcy
2013-01-16 10:29:52 -08:00
Maurizio Cimadamore
3b3feb3853 8005299: Add FunctionalInterface checking to javac
Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces

Reviewed-by: jjg
2013-01-16 16:30:11 +00:00
Maurizio Cimadamore
d19bc80ca1 8005854: Add support for array constructor references
Support constructor references of the kind int[]::new

Reviewed-by: jjg
2013-01-16 16:27:01 +00:00
Jonathan Gibbons
f8b61f9b0c 8006224: Doclint NPE for attribute with no value
Reviewed-by: darcy
2013-01-15 13:03:11 -08:00
Jonathan Gibbons
f92bbd3311 8006241: Test DocRootSlash.java fails
Reviewed-by: darcy
2013-01-14 14:17:25 -08:00
Jonathan Gibbons
a2f594bf74 8006119: update javac to follow latest spec for repeatable annotations
Reviewed-by: darcy
2013-01-14 13:50:01 -08:00
Jonathan Gibbons
7518dede81 8004834: Add doclint support into javadoc
Reviewed-by: darcy
2013-01-10 19:38:57 -08:00
Jonathan Gibbons
80a7fb0bb4 8006033: bug in Pretty.toSimpleString
Reviewed-by: darcy
2013-01-10 15:48:46 -08:00
Jonathan Gibbons
ca5da47efc 8006037: extra space in javac -help for -J and @ options
Reviewed-by: darcy
2013-01-10 14:09:33 -08:00
Jonathan Gibbons
4779676ac1 8005644: set default max errs and max warns
Reviewed-by: darcy
2013-01-09 10:26:58 -08:00
Vicente Romero
9d4f6a0ebe 8005167: execution time of combo tests in javac should be improved
Reviewed-by: jjg, jjh
2013-01-08 13:47:57 +00:00
Maurizio Cimadamore
c932023b04 8005179: Cleanup Resolve.AmbiguityError
Linearize nested ambiguity errors

Reviewed-by: jjg
2013-01-08 10:16:26 +01:00
Jim Holmlund
259f5d7cc8 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows
Fix javap to not output \r\r\n

Reviewed-by: jjg
2013-01-07 17:51:05 +00:00